@allbluecn/web-app 0.18.2 → 0.19.0

package/src/components/bug/__tests__/use-paged-bug-groups.test.tsx

@@ -63,6 +63,7 @@ const makeBug = (over: Partial<BugListItem> & { id: string }): BugListItem => ({
   assignee: null,
   createdBy: { id: "u1", username: "u", email: "e", avatarConfig: null, bgShape: null, bgColor: null },
   labels: [],
+  boardOrder: 0,
   createdAt: "2026-01-01",
   updatedAt: "2026-01-01",
   ...over,
@@ -251,6 +252,63 @@ describe("usePagedBugGroups", () => {
       expect(result.current.groups[0].items.map((b) => b.id)).toEqual(["a", "b"]); // a 的 updatedAt 变最新
     });
   });
+
+  // 任务 33 审查修复回归：返回回调须引用稳定（看板 memo 契约）——core 回调经
+  // ref 读最新实现恒定，包装层 useCallback 固定；内联箭头会让消费方直传的
+  // patchBug / handleLoadMoreColumn 依赖失效 → BugBoardView config useMemo
+  // 每渲染重建（搜索每键全板卡片重渲染）。
+  it("groupBy=none × subGroupBy=severity：父组 total 回写子组聚合（防假空态），消费面 reduce 非 0", async () => {
+    // 双层枚举子组 keys（groupBy=none 时 parentGroupBy=none，父过滤跳过 → 全量子维度桶）
+    h.listBugGroupsFn.mockResolvedValue({
+      groups: [
+        { key: "critical", total: 2 },
+        { key: "low", total: 1 },
+      ],
+    });
+    h.listBugsInGroupFn
+      .mockResolvedValueOnce({
+        items: [makeBug({ id: "a", severity: "critical" }), makeBug({ id: "b", severity: "critical" })],
+        total: 2,
+        hasMore: false,
+      })
+      .mockResolvedValueOnce({
+        items: [makeBug({ id: "c", severity: "low" })],
+        total: 1,
+        hasMore: false,
+      });
+
+    const { result } = renderHook(() =>
+      usePagedBugGroups(makeArgs({ display: { ...DEFAULT_BUG_DISPLAY_OPTIONS, groupBy: "none", subGroupBy: "severity" } })),
+    );
+    await waitFor(() => expect(result.current.isLoading).toBe(false));
+
+    // 父组「全部」脚手架 total 固定 0（非 undefined）：必须被子组聚合回写，
+    // 否则消费面 bug-list-view `total = Σ(g.total ?? g.items.length)` 恒 0 →
+    // total===0 && !isLoading 渲染整页「还没有 BUG」假空态
+    expect(result.current.groups[0].key).toBe("all");
+    expect(result.current.groups[0].subGroups?.map((sg) => sg.key)).toEqual(["critical", "low"]);
+    expect(result.current.groups[0].totalCount).toBe(3);
+    expect(result.current.groups[0].total).toBe(3);
+    // 与 bug-list-view 消费面同一表达式：非 0 不出空态
+    const listViewTotal = result.current.groups.reduce((sum, g) => sum + (g.total ?? g.items.length), 0);
+    expect(listViewTotal).toBe(3);
+  });
+
+  it("引用稳定：重渲染后 loadMore/patchBug/refresh 引用不变（看板 config memo 契约）", async () => {
+    h.listBugGroupsFn.mockResolvedValue({ groups: [{ key: "open", total: 0 }] });
+    h.listAllGroupsItemsFn.mockResolvedValue({ grouped: {} });
+
+    const args = makeArgs();
+    const { result, rerender } = renderHook(() => usePagedBugGroups(args));
+    await waitFor(() => expect(result.current.isLoading).toBe(false));
+
+    const first = { loadMore: result.current.loadMore, patchBug: result.current.patchBug, refresh: result.current.refresh };
+    // 同 props 重渲染（数据 state.groups 换新对象，回调引用不得变）
+    rerender();
+    expect(result.current.loadMore).toBe(first.loadMore);
+    expect(result.current.patchBug).toBe(first.patchBug);
+    expect(result.current.refresh).toBe(first.refresh);
+  });
 });
 
 describe("InlineBugCreator", () => {

package/src/components/bug/__tests__/view-type.test.tsx

@@ -0,0 +1,247 @@
+// SPDX-License-Identifier: AGPL-3.0-or-later
+// AllBlue - 理想之海
+// Copyright (C) 2026 AllBlue Contributors
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+// BUG 视图定版 list|board（UI 对齐三期 PR-10 任务 34，移除表格视图）：
+// ① BugView 收缩后 localStorage 旧值回退——守卫 isBugView 与类型同出口收敛在
+//    view-types.ts（testcase 任务 27 normalizeViewType 同位物），bug-list-view
+//    挂载恢复链消费；旧值（"table" 及更早臆测值 "grid"）一律回落 list（组件
+//    渲染级验证，task 31「默认值渲染+挂载后恢复」时序口径）。
+// ② 行/看板卡片 identifier 由 displayOptions.properties.includes("id") 门控
+//    （"id" 纳入 BUG_DISPLAY_PROPERTIES 域 + 默认集；peek 面包屑为详情页身份
+//    上下文不参与门控）。
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { cleanup, render, screen, waitFor } from "@testing-library/react";
+import { TooltipProvider } from "@/components/ui/tooltip";
+
+// 部分 mock：模块加载链（subscription-provider → billing serverFn）需要真实
+// createServerFn；仅透传 useServerFn 让行/卡片内联编辑器直调被 mock 的 serverFn
+vi.mock("@tanstack/react-start", async (importOriginal) => {
+  const actual = await importOriginal<typeof import("@tanstack/react-start")>();
+  return { ...actual, useServerFn: (fn: unknown) => fn };
+});
+
+const h = vi.hoisted(() => ({
+  listBugGroupsFn: vi.fn(),
+  listBugsInGroupFn: vi.fn(),
+  listAllGroupsItemsFn: vi.fn(),
+  getBugDisplayOptionsFn: vi.fn(),
+  updateBugDisplayOptionsFn: vi.fn(),
+  listBugViewsFn: vi.fn(),
+  createBugViewFn: vi.fn(),
+  updateBugViewFn: vi.fn(),
+  deleteBugViewFn: vi.fn(),
+  createBugFn: vi.fn(),
+  bulkArchiveBugsFn: vi.fn(),
+  bulkDeleteBugsFn: vi.fn(),
+  bulkUpdateBugsFn: vi.fn(),
+  updateBugFn: vi.fn(),
+  reorderBugsFn: vi.fn(),
+}));
+
+vi.mock("@/server/serverFns/bug", () => h);
+vi.mock("@/server/serverFns/story", () => ({
+  listUsersBriefFn: vi.fn(() => Promise.resolve([])),
+}));
+vi.mock("@/server/serverFns/project", () => ({
+  listProjectsBriefFn: vi.fn(() => Promise.resolve([])),
+  ensureBuiltinProjectFn: vi.fn(() => Promise.resolve(null)),
+}));
+vi.mock("@tanstack/react-router", () => ({
+  useNavigate: () => vi.fn(),
+}));
+vi.mock("@/lib/collab/use-presence-list-refresh", () => ({
+  usePresenceListRefresh: vi.fn(),
+}));
+vi.mock("@/components/ui/toast", () => ({
+  toast: { success: vi.fn(), error: vi.fn(), info: vi.fn(), warning: vi.fn(), loading: vi.fn(), message: vi.fn(), dismiss: vi.fn(), promise: vi.fn() },
+  toastError: vi.fn(),
+}));
+vi.mock("@/components/project/create-project-dialog", () => ({
+  CreateProjectDialog: () => null,
+}));
+vi.mock("../create-bug-dialog", () => ({ CreateBugDialog: () => null }));
+vi.mock("../peek-panel", () => ({ BugPeekPanel: () => null }));
+vi.mock("../views/create-view-dialog", () => ({ CreateViewDialog: () => null }));
+
+import { BugListView } from "../bug-list-view";
+import { isBugView } from "../views/view-types";
+import { BugListRow } from "../views/bug-list/row";
+import { BugBoardView } from "../views/board-view";
+import type { BugListItem } from "../types";
+import type { ReorderEntry } from "@/components/shared-kit/list-kit/kanban/drop-commit";
+
+afterEach(() => {
+  cleanup();
+  vi.clearAllMocks();
+});
+
+/* ------------------------------------------------------------------ */
+/* ① BugView 收缩守卫（localStorage 旧值回退的判定面）                        */
+/* ------------------------------------------------------------------ */
+
+describe("isBugView 守卫（任务 34 BugView 收缩 list|board）", () => {
+  it("新值域 list/board 为合法值", () => {
+    expect(isBugView("list")).toBe(true);
+    expect(isBugView("board")).toBe(true);
+  });
+
+  it("存量旧值 table/grid 与非法值/null 一律 false（调用侧回落 list 缺省）", () => {
+    expect(isBugView("table")).toBe(false);
+    expect(isBugView("grid")).toBe(false);
+    expect(isBugView(null)).toBe(false);
+    expect(isBugView("nope")).toBe(false);
+  });
+});
+
+describe("localStorage bug.view 旧值回退（BugListView 渲染级）", () => {
+  beforeEach(() => {
+    window.localStorage.clear();
+    h.listBugGroupsFn.mockResolvedValue({ groups: [{ key: "open", total: 0 }] });
+    h.listAllGroupsItemsFn.mockResolvedValue({ grouped: { open: [] } });
+    h.listBugsInGroupFn.mockResolvedValue({ items: [], total: 0, hasMore: false });
+    h.getBugDisplayOptionsFn.mockResolvedValue(null);
+    h.updateBugDisplayOptionsFn.mockResolvedValue(null);
+    h.listBugViewsFn.mockResolvedValue([]);
+    h.reorderBugsFn.mockResolvedValue(null);
+  });
+
+  function renderView() {
+    return render(
+      <TooltipProvider>
+        <BugListView users={[]} projects={[]} labels={[]} />
+      </TooltipProvider>,
+    );
+  }
+
+  it("bug.view=table（移除档）→ 恢复为 list，表格按钮不复存在", async () => {
+    window.localStorage.setItem("bug.view", "table");
+    renderView();
+    const listBtn = await screen.findByRole("button", { name: "列表" });
+    await waitFor(() => {
+      expect(listBtn.getAttribute("aria-pressed")).toBe("true");
+    });
+    expect(screen.queryByRole("button", { name: "表格" })).toBeNull();
+  });
+
+  it("bug.view=grid（更早臆测残留）→ 同样回落 list", async () => {
+    window.localStorage.setItem("bug.view", "grid");
+    renderView();
+    const listBtn = await screen.findByRole("button", { name: "列表" });
+    await waitFor(() => {
+      expect(listBtn.getAttribute("aria-pressed")).toBe("true");
+    });
+  });
+
+  it("bug.view=board（新值域内）→ 恢复 board 不受影响", async () => {
+    window.localStorage.setItem("bug.view", "board");
+    renderView();
+    const boardBtn = await screen.findByRole("button", { name: "看板" });
+    await waitFor(() => {
+      expect(boardBtn.getAttribute("aria-pressed")).toBe("true");
+    });
+  });
+});
+
+/* ------------------------------------------------------------------ */
+/* ② identifier 随 properties 显隐                                          */
+/* ------------------------------------------------------------------ */
+
+function makeBug(overrides: Partial<BugListItem> & { id: string; identifier: string; title: string }): BugListItem {
+  return {
+    description: null,
+    state: "open",
+    severity: "medium",
+    source: "manual",
+    env: null,
+    url: null,
+    totalCount: 1,
+    firstOccurAt: "2026-01-01T00:00:00.000Z",
+    lastOccurAt: "2026-01-01T00:00:00.000Z",
+    archived: false,
+    projectId: "p1",
+    storyId: null,
+    story: null,
+    assignee: null,
+    createdBy: { id: "u1", username: "alice", email: "a@x.com", avatarConfig: null, bgShape: null, bgColor: null },
+    labels: [],
+    boardOrder: 0,
+    createdAt: "2026-01-01T00:00:00.000Z",
+    updatedAt: "2026-01-01T00:00:00.000Z",
+    ...overrides,
+  };
+}
+
+const ROW_PROPS = {
+  group: "open",
+  users: [],
+  labels: [],
+  onOpenBug: vi.fn(),
+  onPatchBug: vi.fn(),
+  selected: false,
+  onToggle: vi.fn(),
+};
+
+describe("行 identifier 随 properties 显隐（任务 34）", () => {
+  it("properties 含 id → 行首 identifier 显示", () => {
+    const bug = makeBug({ id: "b1", identifier: "PRJ-B1", title: "缺陷标题 1" });
+    render(
+      <TooltipProvider>
+        <BugListRow bug={bug} properties={["id", "state", "severity"]} {...ROW_PROPS} />
+      </TooltipProvider>,
+    );
+    expect(screen.getByText("PRJ-B1")).toBeInTheDocument();
+  });
+
+  it("properties 不含 id → identifier 隐藏（标题仍显示）", () => {
+    const bug = makeBug({ id: "b2", identifier: "PRJ-B2", title: "缺陷标题 2" });
+    render(
+      <TooltipProvider>
+        <BugListRow bug={bug} properties={["state", "severity"]} {...ROW_PROPS} />
+      </TooltipProvider>,
+    );
+    expect(screen.queryByText("PRJ-B2")).toBeNull();
+    expect(screen.getByText("缺陷标题 2")).toBeInTheDocument();
+  });
+});
+
+describe("看板卡片 identifier 随 properties 显隐（任务 34）", () => {
+  function buildProps(properties: string[]) {
+    return {
+      columns: { open: [makeBug({ id: "b3", identifier: "PRJ-B3", title: "缺陷标题 3" })] },
+      groupBy: "state" as const,
+      properties: properties as never[],
+      users: [],
+      onOpenBug: vi.fn(),
+      onLoadMoreColumn: vi.fn(),
+      onPatchBug: vi.fn(),
+      onReorder: vi.fn<(orders: ReorderEntry[]) => Promise<void>>().mockResolvedValue(undefined),
+      onAutoSwitchManual: vi.fn<() => Promise<void>>().mockResolvedValue(undefined),
+      onRefresh: vi.fn(),
+    };
+  }
+
+  it("properties 含 id → 卡片 identifier 显示", () => {
+    render(<BugBoardView {...buildProps(["id", "state", "severity", "assignee"])} />);
+    expect(screen.getByText("PRJ-B3")).toBeInTheDocument();
+  });
+
+  it("properties 不含 id → 卡片 identifier 隐藏（标题仍显示）", () => {
+    render(<BugBoardView {...buildProps(["state", "severity", "assignee"])} />);
+    expect(screen.queryByText("PRJ-B3")).toBeNull();
+    expect(screen.getByText("缺陷标题 3")).toBeInTheDocument();
+  });
+});