@allbluecn/web-app 0.10.2 → 0.11.0

package/src/server/serverFns/__tests__/story-links.test.ts

@@ -0,0 +1,262 @@
+// SPDX-License-Identifier: AGPL-3.0-or-later
+// AllBlue - 理想之海
+// Copyright (C) 2026 AllBlue Contributors
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+
+// story-links 域覆盖补全：addLinkFn / updateLinkFn / removeLinkFn / getLinksFn。
+// 关键断言：非法 URL 拒绝且不写入 storyLink/storyActivity（双重零触达）；链接去重与
+// 排序断言。mock 骨架同 workspace-kb-idor.test.ts 样板。
+import { beforeEach, describe, expect, it, vi } from "vitest";
+
+vi.mock("@tanstack/react-start", () => ({
+  createServerFn: (_config: unknown) => {
+    const api: any = {
+      _validator: undefined,
+      validator(schema: any) {
+        this._validator = schema;
+        return this;
+      },
+      handler(fn: Function) {
+        return async (args: any) => {
+          let data = args?.data;
+          if (this._validator && data !== undefined) {
+            data = this._validator.parse(data);
+          }
+          return fn({ data });
+        };
+      },
+    };
+    return api;
+  },
+}));
+vi.mock("@tanstack/react-start/server", () => ({ getRequest: () => ({}) }));
+
+const M = vi.hoisted(() => {
+  const f = () => vi.fn();
+  return {
+    requireAuth: f(),
+    storyLink: { create: f(), update: f(), findUnique: f(), findMany: f(), delete: f() },
+    storyActivity: { create: f() },
+  };
+});
+
+vi.mock("@allbluecn/database", () => ({
+  prisma: {
+    storyLink: M.storyLink,
+    storyActivity: M.storyActivity,
+  },
+  Prisma: {},
+}));
+vi.mock("@/server/auth-helpers", () => ({ requireAuth: M.requireAuth }));
+
+import {
+  addLinkFn,
+  getLinksFn,
+  removeLinkFn,
+  updateLinkFn,
+} from "../story/story-links";
+
+const USER = "u-current";
+const STORY_ID = "st-1";
+const LINK_ID = "lk-1";
+const URL_1 = "https://docs.example.com/spec";
+const T1 = new Date("2026-01-01T00:00:00Z");
+
+const userRow = {
+  id: USER,
+  username: "alice",
+  email: "alice@example.com",
+  avatarConfig: null,
+  bgShape: null,
+  bgColor: null,
+};
+const activityRow = (over: Record<string, unknown> = {}) => ({
+  id: "act-1",
+  action: "link_added",
+  field: null,
+  oldValue: null,
+  newValue: null,
+  isAI: false,
+  createdAt: T1,
+  user: userRow,
+  ...over,
+});
+const linkRow = (over: Record<string, unknown> = {}) => ({
+  id: LINK_ID,
+  storyId: STORY_ID,
+  url: URL_1,
+  title: null,
+  description: null,
+  ...over,
+});
+
+beforeEach(() => {
+  vi.clearAllMocks();
+  M.requireAuth.mockResolvedValue({ user: { id: USER } });
+  M.storyActivity.create.mockResolvedValue(activityRow());
+});
+
+describe("addLinkFn", () => {
+  it("写入链接并附带 link_added 活动记录", async () => {
+    M.storyLink.create.mockResolvedValue(linkRow({ title: "规范文档" }));
+    M.storyActivity.create.mockResolvedValue(activityRow({ action: "link_added", newValue: "规范文档" }));
+
+    const res = await addLinkFn({
+      data: { storyId: STORY_ID, url: URL_1, title: "规范文档", description: "外链说明" },
+    });
+
+    expect(M.storyLink.create).toHaveBeenCalledWith({
+      data: { storyId: STORY_ID, url: URL_1, title: "规范文档", description: "外链说明" },
+    });
+    expect(M.storyActivity.create).toHaveBeenCalledWith({
+      data: { storyId: STORY_ID, userId: USER, action: "link_added", newValue: "规范文档" },
+      select: expect.any(Object),
+    });
+    expect(res.id).toBe(LINK_ID);
+    expect(res.activity).toMatchObject({
+      id: "act-1",
+      action: "link_added",
+      createdAt: T1.toISOString(),
+      user: expect.objectContaining({ id: USER, username: "alice" }),
+    });
+  });
+
+  it("无标题时活动记录回退使用 URL", async () => {
+    M.storyLink.create.mockResolvedValue(linkRow({ title: null }));
+    await addLinkFn({ data: { storyId: STORY_ID, url: URL_1 } });
+    expect(M.storyActivity.create).toHaveBeenCalledWith(
+      expect.objectContaining({ data: expect.objectContaining({ newValue: URL_1 }) }),
+    );
+  });
+
+  it("非合法 URL 被 validator 拒绝且不写库", async () => {
+    await expect(addLinkFn({ data: { storyId: STORY_ID, url: "not-a-url" } })).rejects.toThrow();
+    expect(M.storyLink.create).not.toHaveBeenCalled();
+    expect(M.storyActivity.create).not.toHaveBeenCalled();
+  });
+
+  it("未登录拒绝且不写库", async () => {
+    M.requireAuth.mockRejectedValue(new Error("UNAUTHORIZED"));
+    await expect(addLinkFn({ data: { storyId: STORY_ID, url: URL_1 } })).rejects.toThrow("UNAUTHORIZED");
+    expect(M.storyLink.create).not.toHaveBeenCalled();
+    expect(M.storyActivity.create).not.toHaveBeenCalled();
+  });
+});
+
+describe("updateLinkFn", () => {
+  it("仅写入实际传入的字段", async () => {
+    M.storyLink.update.mockResolvedValue(linkRow({ title: "新标题" }));
+    await updateLinkFn({ data: { linkId: LINK_ID, title: "新标题" } });
+    expect(M.storyLink.update).toHaveBeenCalledWith({
+      where: { id: LINK_ID },
+      data: { title: "新标题" },
+    });
+  });
+
+  it("未传任何可变字段时 data 为空对象（不做无意义写入）", async () => {
+    M.storyLink.update.mockResolvedValue(linkRow());
+    await updateLinkFn({ data: { linkId: LINK_ID } });
+    expect(M.storyLink.update).toHaveBeenCalledWith({ where: { id: LINK_ID }, data: {} });
+  });
+
+  it("活动记录归属链接所属需求", async () => {
+    M.storyLink.update.mockResolvedValue(linkRow({ title: "T" }));
+    await updateLinkFn({ data: { linkId: LINK_ID, url: URL_1 } });
+    expect(M.storyActivity.create).toHaveBeenCalledWith(
+      expect.objectContaining({
+        data: expect.objectContaining({ storyId: STORY_ID, action: "link_updated", newValue: "T" }),
+      }),
+    );
+  });
+
+  it("非合法 URL 被 validator 拒绝且不更新", async () => {
+    await expect(updateLinkFn({ data: { linkId: LINK_ID, url: "bad" } })).rejects.toThrow();
+    expect(M.storyLink.update).not.toHaveBeenCalled();
+  });
+
+  it("未登录拒绝且不更新", async () => {
+    M.requireAuth.mockRejectedValue(new Error("UNAUTHORIZED"));
+    await expect(updateLinkFn({ data: { linkId: LINK_ID } })).rejects.toThrow("UNAUTHORIZED");
+    expect(M.storyLink.update).not.toHaveBeenCalled();
+  });
+});
+
+describe("removeLinkFn", () => {
+  it("链接存在时删除并记录 link_removed 活动", async () => {
+    M.storyLink.findUnique.mockResolvedValue(linkRow({ title: "规范文档" }));
+    M.storyLink.delete.mockResolvedValue(linkRow());
+    M.storyActivity.create.mockResolvedValue(activityRow({ action: "link_removed", newValue: "规范文档" }));
+
+    const res = await removeLinkFn({ data: { linkId: LINK_ID } });
+
+    expect(M.storyLink.delete).toHaveBeenCalledWith({ where: { id: LINK_ID } });
+    expect(M.storyActivity.create).toHaveBeenCalledWith(
+      expect.objectContaining({
+        data: expect.objectContaining({ storyId: STORY_ID, action: "link_removed", newValue: "规范文档" }),
+      }),
+    );
+    expect(res.activity).toMatchObject({ action: "link_removed" });
+  });
+
+  it("链接已不存在时仍执行删除但活动为 null", async () => {
+    M.storyLink.findUnique.mockResolvedValue(null);
+    M.storyLink.delete.mockResolvedValue(linkRow());
+
+    const res = await removeLinkFn({ data: { linkId: LINK_ID } });
+
+    expect(M.storyLink.delete).toHaveBeenCalledWith({ where: { id: LINK_ID } });
+    expect(M.storyActivity.create).not.toHaveBeenCalled();
+    expect(res).toEqual({ activity: null });
+  });
+
+  it("未登录拒绝且不查询不删除", async () => {
+    M.requireAuth.mockRejectedValue(new Error("UNAUTHORIZED"));
+    await expect(removeLinkFn({ data: { linkId: LINK_ID } })).rejects.toThrow("UNAUTHORIZED");
+    expect(M.storyLink.findUnique).not.toHaveBeenCalled();
+    expect(M.storyLink.delete).not.toHaveBeenCalled();
+  });
+});
+
+describe("getLinksFn", () => {
+  it("按 createdAt 倒序返回精简链接字段", async () => {
+    M.storyLink.findMany.mockResolvedValue([
+      { id: "lk-2", storyId: STORY_ID, url: URL_1, title: "B", description: "d2" },
+      { id: "lk-1", storyId: STORY_ID, url: URL_1, title: null, description: null },
+    ]);
+
+    const res = await getLinksFn({ data: { storyId: STORY_ID } });
+
+    expect(M.storyLink.findMany).toHaveBeenCalledWith({
+      where: { storyId: STORY_ID },
+      orderBy: { createdAt: "desc" },
+    });
+    expect(res).toEqual([
+      { id: "lk-2", url: URL_1, title: "B", description: "d2" },
+      { id: "lk-1", url: URL_1, title: null, description: null },
+    ]);
+  });
+
+  it("无链接时返回空数组", async () => {
+    M.storyLink.findMany.mockResolvedValue([]);
+    await expect(getLinksFn({ data: { storyId: STORY_ID } })).resolves.toEqual([]);
+  });
+
+  it("未登录拒绝且不查询", async () => {
+    M.requireAuth.mockRejectedValue(new Error("UNAUTHORIZED"));
+    await expect(getLinksFn({ data: { storyId: STORY_ID } })).rejects.toThrow("UNAUTHORIZED");
+    expect(M.storyLink.findMany).not.toHaveBeenCalled();
+  });
+});

package/src/server/serverFns/__tests__/story-list-query.test.ts

@@ -0,0 +1,259 @@
+// SPDX-License-Identifier: AGPL-3.0-or-later
+// AllBlue - 理想之海
+// Copyright (C) 2026 AllBlue Contributors
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+
+// story 列表查询纯函数覆盖补全：buildListWhere / buildGroupFilter。
+// 纯函数无 serverFn，仅 mock @allbluecn/database 的 Prisma（json 路径构造）。
+// 关键断言：JSON 条件 path/operator 枚举映射、空条件短路、分组过滤的 AND/OR 组合形状。
+import { describe, expect, it, vi } from "vitest";
+
+vi.mock("@allbluecn/database", () => ({ Prisma: {} }));
+
+import { buildListWhere, buildGroupFilter } from "../story/story-list-query";
+
+/** 单值/多值字段构造过滤器 JSON */
+const fc = (property: string, operator: string, value: string) =>
+  JSON.stringify([{ property, operator, value }]);
+
+describe("buildListWhere 基础过滤", () => {
+  it("仅 archived 恒为过滤项", () => {
+    expect(buildListWhere({ archived: true })).toEqual({ archived: true });
+  });
+
+  it("state/priority 支持单值与逗号多值", () => {
+    expect(buildListWhere({ archived: false, state: "todo" })).toEqual({ archived: false, state: "todo" });
+    expect(
+      buildListWhere({ archived: false, state: "todo,backlog", priority: "high" }),
+    ).toEqual({ archived: false, state: { in: ["todo", "backlog"] }, priority: "high" });
+    expect(
+      buildListWhere({ archived: false, priority: "high,low" }),
+    ).toEqual({ archived: false, priority: { in: ["high", "low"] } });
+  });
+
+  it("assigneeId 支持指定成员、__none__ 占位符与多值", () => {
+    expect(buildListWhere({ archived: false, assigneeId: "u-1" })).toEqual({
+      archived: false,
+      assigneeId: "u-1",
+    });
+    expect(buildListWhere({ archived: false, assigneeId: "__none__" })).toEqual({
+      archived: false,
+      assigneeId: null,
+    });
+    expect(buildListWhere({ archived: false, assigneeId: "u-1,u-2" })).toEqual({
+      archived: false,
+      assigneeId: { in: ["u-1", "u-2"] },
+    });
+  });
+
+  it("labelId 单值/多值映射为 labels.some", () => {
+    expect(buildListWhere({ archived: false, labelId: "lb-1" })).toEqual({
+      archived: false,
+      labels: { some: { labelId: "lb-1" } },
+    });
+    expect(buildListWhere({ archived: false, labelId: "lb-1,lb-2" })).toEqual({
+      archived: false,
+      labels: { some: { labelId: { in: ["lb-1", "lb-2"] } } },
+    });
+  });
+
+  it("projectId 原样透传", () => {
+    expect(buildListWhere({ archived: false, projectId: "pr-9" })).toEqual({
+      archived: false,
+      projectId: "pr-9",
+    });
+  });
+
+  it("search 对 name 与 identifier 做不区分大小写包含匹配", () => {
+    expect(buildListWhere({ archived: false, search: "登录" })).toEqual({
+      archived: false,
+      OR: [
+        { name: { contains: "登录", mode: "insensitive" } },
+        { identifier: { contains: "登录", mode: "insensitive" } },
+      ],
+    });
+  });
+});
+
+describe("buildListWhere filters（JSON 条件）", () => {
+  it("state/priority 支持 is 与 is_not_any_of", () => {
+    expect(buildListWhere({ archived: false, filters: fc("state", "is_not_any_of", "done") })).toEqual({
+      archived: false,
+      AND: [{ state: { notIn: ["done"] } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("priority", "is", "high,urgent") })).toEqual({
+      archived: false,
+      AND: [{ priority: { in: ["high", "urgent"] } }],
+    });
+  });
+
+  it("assigneeId 支持 is_empty / is_not_empty 与指定值", () => {
+    expect(buildListWhere({ archived: false, filters: fc("assigneeId", "is_empty", "") })).toEqual({
+      archived: false,
+      AND: [{ assigneeId: null }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("assigneeId", "is_not_empty", "") })).toEqual({
+      archived: false,
+      AND: [{ assigneeId: { not: null } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("assigneeId", "is", "u-7") })).toEqual({
+      archived: false,
+      AND: [{ assigneeId: "u-7" }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("assigneeId", "is_not", "u-7") })).toEqual({
+      archived: false,
+      AND: [{ assigneeId: { not: "u-7" } }],
+    });
+  });
+
+  it("labelId 支持 some / none 与有无标签判断", () => {
+    expect(buildListWhere({ archived: false, filters: fc("labelId", "is", "lb-1,lb-2") })).toEqual({
+      archived: false,
+      AND: [{ labels: { some: { labelId: { in: ["lb-1", "lb-2"] } } } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("labelId", "is_not_any_of", "lb-1") })).toEqual({
+      archived: false,
+      AND: [{ labels: { none: { labelId: { in: ["lb-1"] } } } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("labelId", "is_empty", "") })).toEqual({
+      archived: false,
+      AND: [{ labels: { none: {} } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("labelId", "is_not_empty", "") })).toEqual({
+      archived: false,
+      AND: [{ labels: { some: {} } }],
+    });
+  });
+
+  it("createdDate 支持 before/after/on_or_after/on_or_before/is/is_not/between", () => {
+    const d = "2026-03-05";
+    const day = new Date(d);
+    const next = new Date(d);
+    next.setDate(next.getDate() + 1);
+
+    expect(buildListWhere({ archived: false, filters: fc("createdDate", "before", d) })).toEqual({
+      archived: false,
+      AND: [{ createdAt: { lt: day } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("createdDate", "after", d) })).toEqual({
+      archived: false,
+      AND: [{ createdAt: { gte: day } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("createdDate", "on_or_before", d) })).toEqual({
+      archived: false,
+      AND: [{ createdAt: { lte: day } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("createdDate", "is", d) })).toEqual({
+      archived: false,
+      AND: [{ createdAt: { gte: day, lt: next } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("createdDate", "is_not", d) })).toEqual({
+      archived: false,
+      AND: [{ createdAt: { lt: day, gte: next } }],
+    });
+    expect(
+      buildListWhere({ archived: false, filters: JSON.stringify([{ property: "createdDate", operator: "between", value: "2026-03-01,2026-03-05" }]) }),
+    ).toEqual({
+      archived: false,
+      AND: [{ createdAt: { gte: new Date("2026-03-01") } }, { createdAt: { lte: day } }],
+    });
+  });
+
+  it("targetDate 的日期条件与 createdDate 同构", () => {
+    const d = "2026-04-01";
+    const day = new Date(d);
+    expect(buildListWhere({ archived: false, filters: fc("targetDate", "before", d) })).toEqual({
+      archived: false,
+      AND: [{ targetDate: { lt: day } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("targetDate", "after", d) })).toEqual({
+      archived: false,
+      AND: [{ targetDate: { gte: day } }],
+    });
+    expect(
+      buildListWhere({ archived: false, filters: JSON.stringify([{ property: "targetDate", operator: "between", value: "2026-04-01,2026-04-10" }]) }),
+    ).toEqual({
+      archived: false,
+      AND: [{ targetDate: { gte: day } }, { targetDate: { lte: new Date("2026-04-10") } }],
+    });
+  });
+
+  it("title 支持 is_empty / is_not_empty / 包含 / not_contains", () => {
+    expect(buildListWhere({ archived: false, filters: fc("title", "is_empty", "") })).toEqual({
+      archived: false,
+      AND: [{ name: { equals: "" } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("title", "is_not_empty", "") })).toEqual({
+      archived: false,
+      AND: [{ name: { not: "" } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("title", "contains", "  登录  ") })).toEqual({
+      archived: false,
+      AND: [{ name: { contains: "登录", mode: "insensitive" } }],
+    });
+    expect(buildListWhere({ archived: false, filters: fc("title", "not_contains", "bug") })).toEqual({
+      archived: false,
+      AND: [{ name: { not: { contains: "bug" }, mode: "insensitive" } }],
+    });
+  });
+
+  it("非法 JSON 与非法日期静默忽略，不影响其他条件", () => {
+    expect(buildListWhere({ archived: false, filters: "{not-json" })).toEqual({ archived: false });
+    expect(
+      buildListWhere({
+        archived: false,
+        filters: JSON.stringify([
+          { property: "createdDate", operator: "before", value: "不是日期" },
+          { property: "state", operator: "is", value: "todo" },
+        ]),
+      }),
+    ).toEqual({ archived: false, AND: [{ state: "todo" }] });
+  });
+
+  it("多条条件按序聚合到 AND 数组", () => {
+    expect(
+      buildListWhere({
+        archived: false,
+        filters: JSON.stringify([
+          { property: "state", operator: "is", value: "todo" },
+          { property: "assigneeId", operator: "is_empty", value: "" },
+          { property: "labelId", operator: "is_not_empty", value: "" },
+        ]),
+      }),
+    ).toEqual({
+      archived: false,
+      AND: [{ state: "todo" }, { assigneeId: null }, { labels: { some: {} } }],
+    });
+  });
+});
+
+describe("buildGroupFilter", () => {
+  it("groupBy 为 none 时返回空过滤", () => {
+    expect(buildGroupFilter("none", "todo")).toEqual({});
+  });
+
+  it("各分组维度映射为对应查询条件", () => {
+    expect(buildGroupFilter("state", "todo")).toEqual({ state: "todo" });
+    expect(buildGroupFilter("priority", "high")).toEqual({ priority: "high" });
+    expect(buildGroupFilter("assignee", "u-1")).toEqual({ assigneeId: "u-1" });
+    expect(buildGroupFilter("assignee", "unassigned")).toEqual({ assigneeId: null });
+    expect(buildGroupFilter("createdBy", "u-1")).toEqual({ createdById: "u-1" });
+    expect(buildGroupFilter("labels", "lb-1")).toEqual({ labels: { some: { labelId: "lb-1" } } });
+    expect(buildGroupFilter("labels", "no-labels")).toEqual({ labels: { none: {} } });
+    expect(buildGroupFilter("project", "pr-1")).toEqual({ projectId: "pr-1" });
+    expect(buildGroupFilter("project", "no-project")).toEqual({ projectId: null });
+  });
+});