@alizarin/napi 2.0.0-alpha.97 → 2.0.0-alpha.99

package/__test__/index.mjs

@@ -4,7 +4,7 @@ import path from 'node:path';
 import fs from 'node:fs';
 import { fileURLToPath } from 'node:url';
 
-import { NapiStaticGraph, NapiStaticResourceRegistry, NapiResourceModelWrapper, NapiResourceInstanceWrapper } from '../index.js';
+import { NapiStaticGraph, NapiStaticResourceRegistry, NapiResourceModelWrapper, NapiResourceInstanceWrapper, NapiNodeConfigManager } from '../index.js';
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const TEST_DATA = path.resolve(__dirname, '..', '..', '..', 'tests');
@@ -522,3 +522,83 @@ describe('NapiResourceInstanceWrapper methods', () => {
     assert.equal(tiles.length, 0, 'should be empty');
   });
 });
+
+// =============================================================================
+// NapiNodeConfigManager + NapiStaticGraph integration
+// Regression: loadFromGraph used JSON.stringify on a NapiStaticGraph, which
+// produced {} because NAPI class getters are not enumerable own properties.
+// The fix uses buildFromGraph (direct struct reference) instead.
+// =============================================================================
+
+describe('NapiNodeConfigManager', () => {
+  const personJson = fs.readFileSync(
+    path.join(TEST_DATA, 'data', 'models', 'Person.json'),
+    'utf-8'
+  );
+
+  it('buildFromGraph accepts a NapiStaticGraph without error', () => {
+    const graph = NapiStaticGraph.fromJsonString(personJson);
+    const ncm = new NapiNodeConfigManager();
+    // This is the path that failed when using JSON.stringify(napiGraph)
+    ncm.buildFromGraph(graph);
+  });
+
+  it('buildFromGraphJson fails on JSON.stringify of a NapiStaticGraph', () => {
+    const graph = NapiStaticGraph.fromJsonString(personJson);
+    const ncm = new NapiNodeConfigManager();
+    // Demonstrates the bug: NAPI objects don't stringify their getters
+    const stringified = JSON.stringify(graph);
+    assert.throws(
+      () => ncm.buildFromGraphJson(stringified),
+      /Failed to parse graph/i,
+      'JSON.stringify of NapiStaticGraph should produce invalid graph JSON'
+    );
+  });
+
+  it('buildFromGraphJson works with raw graph JSON', () => {
+    const parsed = JSON.parse(personJson);
+    const graphObj = parsed.graph ? parsed.graph[0] : parsed;
+    const ncm = new NapiNodeConfigManager();
+    // Raw JS object stringifies correctly
+    ncm.buildFromGraphJson(JSON.stringify(graphObj));
+  });
+});
+
+// =============================================================================
+// NapiStaticGraph serialization guard
+// Regression: JSON.stringify(NapiStaticGraph) produces {} because NAPI class
+// getters are not enumerable own properties. Any code path that does
+// JSON.stringify(graph) where graph could be a NapiStaticGraph will break.
+// =============================================================================
+
+describe('NapiStaticGraph serialization', () => {
+  const groupJson = fs.readFileSync(
+    path.join(TEST_DATA, 'data', 'models', 'Group.json'),
+    'utf-8'
+  );
+
+  it('JSON.stringify of NapiStaticGraph produces empty object', () => {
+    const graph = NapiStaticGraph.fromJsonString(groupJson);
+    const stringified = JSON.stringify(graph);
+    // This documents the fundamental limitation: NAPI class instances
+    // do not serialize via JSON.stringify
+    assert.equal(stringified, '{}', 'NapiStaticGraph should stringify to {}');
+  });
+
+  it('NapiResourceModelWrapper.fromGraph accepts NapiStaticGraph directly', () => {
+    const graph = NapiStaticGraph.fromJsonString(groupJson);
+    // This is the correct NAPI path — no JSON.stringify needed
+    const wrapper = NapiResourceModelWrapper.fromGraph(graph, true);
+    assert.equal(wrapper.getGraphId(), '07883c9e-b25c-11e9-975a-a4d18cec433a');
+  });
+
+  it('NapiResourceModelWrapper constructor fails with JSON.stringify of NapiStaticGraph', () => {
+    const graph = NapiStaticGraph.fromJsonString(groupJson);
+    // Demonstrates the bug this regression test guards against
+    assert.throws(
+      () => new NapiResourceModelWrapper(JSON.stringify(graph), true),
+      /Invalid graph JSON/i,
+      'JSON.stringify of NapiStaticGraph should produce invalid input for constructor'
+    );
+  });
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@alizarin/napi",
-  "version": "2.0.0-alpha.97",
+  "version": "2.0.0-alpha.99",
   "license": "AGPL-3.0-or-later",
   "repository": {
     "type": "git",
@@ -30,8 +30,8 @@
     "@napi-rs/cli": "^2.18.0"
   },
   "optionalDependencies": {
-    "@alizarin/napi-win32-x64-msvc": "2.0.0-alpha.97",
-    "@alizarin/napi-darwin-x64": "2.0.0-alpha.97",
-    "@alizarin/napi-linux-x64-gnu": "2.0.0-alpha.97"
+    "@alizarin/napi-win32-x64-msvc": "2.0.0-alpha.99",
+    "@alizarin/napi-darwin-x64": "2.0.0-alpha.99",
+    "@alizarin/napi-linux-x64-gnu": "2.0.0-alpha.99"
   }
 }