@aliou/pi-processes 0.10.5 → 0.10.6

package/extensions/processes/config/index.ts

@@ -1,7 +1,6 @@
 export { DEFAULT_CONFIG } from "./defaults";
 export {
   configLoader,
-  createSettingsConfigStore,
   drainImportMessages,
   loadProcessConfig,
 } from "./loader";

package/extensions/processes/config/loader.ts

@@ -1,8 +1,4 @@
-import {
-  ConfigLoader,
-  type ConfigStore,
-  type Scope,
-} from "@aliou/pi-utils-settings";
+import { ConfigLoader } from "@aliou/pi-utils-settings";
 import { DEFAULT_CONFIG } from "./defaults";
 import { importLegacyProcessConfig, migrations } from "./migrations";
 import { PROCESS_CONFIG_SCHEMA_URL } from "./schema";
@@ -41,22 +37,3 @@ export const configLoader = new ConfigLoader<
   migrations,
   schemaUrl: PROCESS_CONFIG_SCHEMA_URL,
 });
-
-export function createSettingsConfigStore(): ConfigStore<
-  ProcessConfig,
-  ProcessProtocolConfig
-> {
-  return {
-    save: (scope, config) => configLoader.save(scope, config),
-    getConfig: () => configLoader.getConfig(),
-    getRawConfig: (scope) => configLoader.getRawConfig(scope),
-    hasScope: (scope) => configLoader.hasScope(scope),
-    hasConfig: (scope) => configLoader.hasConfig(scope),
-    getEnabledScopes: () => {
-      const enabled = new Set(configLoader.getEnabledScopes());
-      return (["global", "local", "memory"] as Scope[]).filter((scope) =>
-        enabled.has(scope),
-      );
-    },
-  };
-}

package/extensions/processes/config/migrations/001-v0-9-4-to-v0-10-0-config.ts

@@ -95,9 +95,31 @@ function migrateDockDefaultState(
   return undefined;
 }
 
+/** Config version this migration brings the config to. */
+export const CONFIG_VERSION_V0100 = "0.10.0";
+
+function compareSemver(a: string, b: string): number {
+  const left = a.split(".");
+  const right = b.split(".");
+
+  for (let i = 0; i < 3; i++) {
+    const diff = (Number(left[i]) || 0) - (Number(right[i]) || 0);
+    if (diff !== 0) return diff;
+  }
+
+  return 0;
+}
+
 export function needsConfigV094ToV0100Migration(
   config: ProcessConfig,
+  fromVersion: number | string = "0.0.0",
 ): boolean {
+  // Gate on content and version: the v0.9.4 projection drops keys added
+  // after v0.10.0, so it must never touch an already-stamped config.
+  if (compareSemver(String(fromVersion), CONFIG_VERSION_V0100) >= 0) {
+    return false;
+  }
+
   const root = config as Record<string, unknown>;
   const widget = isRecord(root.widget) ? root.widget : undefined;
 
@@ -177,7 +199,9 @@ function setNonEmpty<K extends keyof ConfigV0100>(
 
 export const configV094ToV0100Migration: Migration<ProcessConfig> = {
   name: "001-v0-9-4-to-v0-10-0-config",
-  shouldRun: (config) => needsConfigV094ToV0100Migration(config),
+  version: CONFIG_VERSION_V0100,
+  shouldRun: (config, ctx) =>
+    needsConfigV094ToV0100Migration(config, ctx.fromVersion),
   run: (config) => migrateConfigV094ToV0100(config as ConfigV094),
   message:
     "Migrated pi-processes settings to the current schema. Mapped the dock hidden state to closed.",

package/extensions/processes/config/migrations/002-stamp-config-version.ts

@@ -0,0 +1,24 @@
+import type { Migration } from "@aliou/pi-utils-settings";
+
+import type { ProcessConfig } from "../types";
+
+/**
+ * Current config version stamped on every settings file.
+ *
+ * Keep this in sync with the `--version` flag of the `gen:schema` and
+ * `check:schema` scripts in package.json.
+ */
+export const PROCESS_CONFIG_VERSION = "0.10.6";
+
+/**
+ * Terminal migration: converge every config on the current version.
+ *
+ * The config is left untouched; the loader stamps `version` after the run.
+ * Configs stamped by earlier migrations (or already current) are skipped by
+ * the default version comparison.
+ */
+export const configVersionStampMigration: Migration<ProcessConfig> = {
+  name: "002-stamp-config-version",
+  version: PROCESS_CONFIG_VERSION,
+  run: (config) => config,
+};

package/extensions/processes/config/migrations/index.ts

@@ -2,7 +2,7 @@ import type { Migration } from "@aliou/pi-utils-settings";
 
 import type { ProcessConfig } from "../types";
 import { configV094ToV0100Migration } from "./001-v0-9-4-to-v0-10-0-config";
-import { configVersionStampMigration } from "./002-stamp-v0-10-0-config-version";
+import { configVersionStampMigration } from "./002-stamp-config-version";
 
 export { importLegacyProcessConfig } from "./000-import-legacy-process-config";
 export {
@@ -14,10 +14,8 @@ export {
 } from "./001-v0-9-4-to-v0-10-0-config";
 export {
   configVersionStampMigration,
-  needsConfigVersionStamp,
   PROCESS_CONFIG_VERSION,
-  stampConfigVersion,
-} from "./002-stamp-v0-10-0-config-version";
+} from "./002-stamp-config-version";
 
 export const migrations: Migration<ProcessConfig>[] = [
   configV094ToV0100Migration,

package/extensions/processes/config/types.ts

@@ -49,12 +49,13 @@ export interface WidgetConfig {
   dockHeight?: number;
 }
 
-/** User-facing pi-processes settings stored on disk. */
+/**
+ * User-facing pi-processes settings stored on disk.
+ *
+ * The reserved `$schema` and `version` keys are owned by the config loader
+ * and injected into schema.json by `pi-settings-schema`.
+ */
 export interface ProcessConfig {
-  /** JSON Schema URL used by editors for validation and autocomplete. */
-  $schema?: string;
-  /** Config migration marker written after v0.10.0 settings migration. */
-  version?: string;
   /** Process execution settings. */
   execution?: ExecutionConfig;
   /** Shell-command interception settings. */

package/extensions/processes/settings/index.ts

@@ -6,18 +6,21 @@
  */
 
 import {
+  createConfigStore,
   registerSettingsCommand,
   type SettingsSection,
 } from "@aliou/pi-utils-settings";
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 
 import type { ProcessConfig, ProcessProtocolConfig } from "../config";
-import { createSettingsConfigStore } from "../config";
+import { configLoader } from "../config";
 import { applySettingChange } from "./apply-setting-change";
 import { buildSections } from "./build-sections";
 
 export function registerProcessSettings(pi: ExtensionAPI): void {
-  const configStore = createSettingsConfigStore();
+  const configStore = createConfigStore(configLoader, {
+    scopes: ["global", "local", "memory"],
+  });
 
   registerSettingsCommand<ProcessConfig, ProcessProtocolConfig>(pi, {
     commandName: "ps:settings",

package/extensions/processes/tools/index.ts

@@ -3,7 +3,8 @@ import {
   defineTool,
   type ExtensionAPI,
   type ExtensionContext,
-  type Theme,
+  Theme,
+  type ToolDefinition,
 } from "@earendil-works/pi-coding-agent";
 import { type Component, Container, Text } from "@earendil-works/pi-tui";
 
@@ -105,11 +106,32 @@ async function execute(
   }
 }
 
+/** pi's declared renderCall signature, per its public ToolDefinition type. */
+type RenderCallFn = NonNullable<ToolDefinition["renderCall"]>;
+/** pi's third renderCall argument (ToolRenderContext — not root-exported). */
+type RenderCallFnContext = Parameters<RenderCallFn>[2];
+
+/**
+ * pi invokes renderCall as (args, theme, context) where theme is pi's Theme
+ * class instance. Detecting that exact class distinguishes pi's argument
+ * order from OMP's (args, options, theme), where the second argument is a
+ * plain options object.
+ */
+function isPiTheme(value: unknown): value is Theme {
+  return value instanceof Theme;
+}
+
 function renderProcessCall(
   args: ProcessesParamsType,
-  theme: Theme,
-  context?: { expanded?: boolean },
+  second: Theme | RenderCallFnContext,
+  third?: RenderCallFnContext | Theme,
 ): Component {
+  const usesPiOrder = isPiTheme(second);
+  const theme = usesPiOrder ? second : (third as Theme);
+  const context = (usesPiOrder ? third : second) as
+    | RenderCallFnContext
+    | undefined;
+
   switch (args.action) {
     case "start":
       return new ToolLayout().setHeader(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aliou/pi-processes",
-  "version": "0.10.5",
+  "version": "0.10.6",
   "license": "MIT",
   "type": "module",
   "private": false,
@@ -43,7 +43,7 @@
     "CONTRIBUTING.md"
   ],
   "dependencies": {
-    "@aliou/pi-utils-settings": "^0.18.0",
+    "@aliou/pi-utils-settings": "^0.19.1",
     "@aliou/pi-utils-ui": "^0.5.0",
     "@aliou/sh": "^0.1.0"
   },
@@ -75,8 +75,8 @@
     "typecheck:evals": "tsc --noEmit -p tests/evals/tsconfig.json",
     "lint": "biome check",
     "format": "biome check --write",
-    "gen:schema": "ts-json-schema-generator --path extensions/processes/config/types.ts --type ProcessConfig --no-type-check -o schema.json",
-    "check:schema": "ts-json-schema-generator --path extensions/processes/config/types.ts --type ProcessConfig --no-type-check -o /tmp/pi-processes-schema-check.json && diff -q schema.json /tmp/pi-processes-schema-check.json",
+    "gen:schema": "pi-settings-schema -p extensions/processes/config/types.ts -t ProcessConfig -o schema.json --version 0.10.6",
+    "check:schema": "pi-settings-schema -p extensions/processes/config/types.ts -t ProcessConfig -o schema.json --version 0.10.6 --check",
     "check:changesets": "node scripts/check-changesets.ts",
     "check:lockfile": "pnpm install --frozen-lockfile --ignore-scripts",
     "prepare": "[ -d .git ] && husky || true",

package/schema.json

@@ -1,134 +1,142 @@
 {
-  "$ref": "#/definitions/ProcessConfig",
   "$schema": "http://json-schema.org/draft-07/schema#",
+  "$ref": "#/definitions/ProcessConfig",
   "definitions": {
-    "ExecutionConfig": {
-      "additionalProperties": false,
+    "ProcessConfig": {
+      "type": "object",
       "properties": {
-        "shellPath": {
-          "description": "Absolute shell executable used to run process commands.",
+        "execution": {
+          "$ref": "#/definitions/ExecutionConfig",
+          "description": "Process execution settings."
+        },
+        "interception": {
+          "$ref": "#/definitions/InterceptionConfig",
+          "description": "Shell-command interception settings."
+        },
+        "processList": {
+          "$ref": "#/definitions/ProcessListConfig",
+          "description": "Process overview and log viewport settings."
+        },
+        "output": {
+          "$ref": "#/definitions/OutputConfig",
+          "description": "Process output retention settings."
+        },
+        "follow": {
+          "$ref": "#/definitions/FollowConfig",
+          "description": "Live log follow behavior."
+        },
+        "widget": {
+          "$ref": "#/definitions/WidgetConfig",
+          "description": "Dock and status widget settings."
+        },
+        "$schema": {
           "type": "string"
+        },
+        "version": {
+          "anyOf": [
+            {
+              "type": "integer",
+              "minimum": 0
+            },
+            {
+              "type": "string",
+              "pattern": "^\\d{1,15}(\\.\\d{1,15})?(\\.\\d{1,15})?$"
+            }
+          ],
+          "description": "Config schema version, stamped by migrations. Current version: 0.10.6."
         }
       },
-      "type": "object"
-    },
-    "FollowConfig": {
       "additionalProperties": false,
+      "description": "User-facing pi-processes settings stored on disk.\n\nThe reserved `$schema` and `version` keys are owned by the config loader and injected into schema.json by `pi-settings-schema`."
+    },
+    "ExecutionConfig": {
+      "type": "object",
       "properties": {
-        "autoHideOnFinish": {
-          "description": "Hide process log interfaces when all managed processes finish.",
-          "type": "boolean"
-        },
-        "enabledByDefault": {
-          "description": "Open process log interfaces in follow mode by default.",
-          "type": "boolean"
+        "shellPath": {
+          "type": "string",
+          "description": "Absolute shell executable used to run process commands."
         }
       },
-      "type": "object"
+      "additionalProperties": false
     },
     "InterceptionConfig": {
-      "additionalProperties": false,
+      "type": "object",
       "properties": {
         "blockBackgroundCommands": {
-          "description": "Block shell background patterns and redirect the agent to the process tool.",
-          "type": "boolean"
+          "type": "boolean",
+          "description": "Block shell background patterns and redirect the agent to the process tool."
         }
       },
-      "type": "object"
+      "additionalProperties": false
     },
-    "OutputConfig": {
-      "additionalProperties": false,
+    "ProcessListConfig": {
+      "type": "object",
       "properties": {
-        "defaultTailLines": {
-          "description": "Default number of recent lines returned by the process output action.",
-          "type": "number"
-        },
-        "maxOutputBytes": {
-          "description": "Maximum bytes retained by each process log interface.",
-          "type": "number"
+        "maxPreviewLines": {
+          "type": "number",
+          "description": "Maximum log rows displayed in the overview preview and logs overlay."
         },
-        "maxOutputLines": {
-          "description": "Maximum lines retained by process log interfaces.",
-          "type": "number"
+        "maxVisibleProcesses": {
+          "type": "number",
+          "description": "Maximum process rows displayed in the overview before scrolling."
         }
       },
-      "type": "object"
+      "additionalProperties": false
     },
-    "ProcessConfig": {
-      "additionalProperties": false,
-      "description": "User-facing pi-processes settings stored on disk.",
+    "OutputConfig": {
+      "type": "object",
       "properties": {
-        "$schema": {
-          "description": "JSON Schema URL used by editors for validation and autocomplete.",
-          "type": "string"
-        },
-        "execution": {
-          "$ref": "#/definitions/ExecutionConfig",
-          "description": "Process execution settings."
-        },
-        "follow": {
-          "$ref": "#/definitions/FollowConfig",
-          "description": "Live log follow behavior."
-        },
-        "interception": {
-          "$ref": "#/definitions/InterceptionConfig",
-          "description": "Shell-command interception settings."
-        },
-        "output": {
-          "$ref": "#/definitions/OutputConfig",
-          "description": "Process output retention settings."
-        },
-        "processList": {
-          "$ref": "#/definitions/ProcessListConfig",
-          "description": "Process overview and log viewport settings."
+        "defaultTailLines": {
+          "type": "number",
+          "description": "Default number of recent lines returned by the process output action."
         },
-        "version": {
-          "description": "Config migration marker written after v0.10.0 settings migration.",
-          "type": "string"
+        "maxOutputLines": {
+          "type": "number",
+          "description": "Maximum lines retained by process log interfaces."
         },
-        "widget": {
-          "$ref": "#/definitions/WidgetConfig",
-          "description": "Dock and status widget settings."
+        "maxOutputBytes": {
+          "type": "number",
+          "description": "Maximum bytes retained by each process log interface."
         }
       },
-      "type": "object"
+      "additionalProperties": false
     },
-    "ProcessListConfig": {
-      "additionalProperties": false,
+    "FollowConfig": {
+      "type": "object",
       "properties": {
-        "maxPreviewLines": {
-          "description": "Maximum log rows displayed in the overview preview and logs overlay.",
-          "type": "number"
+        "enabledByDefault": {
+          "type": "boolean",
+          "description": "Open process log interfaces in follow mode by default."
         },
-        "maxVisibleProcesses": {
-          "description": "Maximum process rows displayed in the overview before scrolling.",
-          "type": "number"
+        "autoHideOnFinish": {
+          "type": "boolean",
+          "description": "Hide process log interfaces when all managed processes finish."
         }
       },
-      "type": "object"
+      "additionalProperties": false
     },
     "WidgetConfig": {
-      "additionalProperties": false,
+      "type": "object",
       "properties": {
+        "showStatusWidget": {
+          "type": "boolean",
+          "description": "Show a one-line process summary below the editor."
+        },
         "dockDefaultState": {
-          "description": "Initial visibility of the process dock.",
+          "type": "string",
           "enum": [
             "closed",
             "collapsed",
             "expanded"
           ],
-          "type": "string"
+          "description": "Initial visibility of the process dock."
         },
         "dockHeight": {
-          "description": "Number of log rows displayed in the expanded process dock.",
-          "type": "number"
-        },
-        "showStatusWidget": {
-          "description": "Show a one-line process summary below the editor.",
-          "type": "boolean"
+          "type": "number",
+          "description": "Number of log rows displayed in the expanded process dock."
         }
       },
-      "type": "object"
+      "additionalProperties": false
     }
   }
-}
+}

package/extensions/processes/config/migrations/002-stamp-v0-10-0-config-version.ts

@@ -1,21 +0,0 @@
-import type { Migration } from "@aliou/pi-utils-settings";
-
-import type { ProcessConfig } from "../types";
-
-export const PROCESS_CONFIG_VERSION = "0.10.0";
-
-export function needsConfigVersionStamp(config: ProcessConfig): boolean {
-  return (config.version ?? "") < PROCESS_CONFIG_VERSION;
-}
-
-export function stampConfigVersion(config: ProcessConfig): ProcessConfig {
-  return { ...config, version: PROCESS_CONFIG_VERSION };
-}
-
-export const configVersionStampMigration: Migration<ProcessConfig> = {
-  name: "002-stamp-v0-10-0-config-version",
-  shouldRun: needsConfigVersionStamp,
-  run: (config) => stampConfigVersion(config),
-  message:
-    "Updated pi-processes settings for v0.10.0. This release rewrites the package into separate process, logs, and dock extensions while preserving your existing settings. Release notes are available at https://github.com/aliou/pi-processes/releases/tag/v0.10.0.",
-};