@alint-js/plugin-js 0.7.2 → 0.7.3

package/README.md

@@ -9,6 +9,7 @@ The package default export is the plugin definition. Individual rule definitions
 The bundled `recommended` config enables these rules under the `js` plugin name:
 
 - `js/inline-miniature-normalizer` reports clusters of local helpers that form a private reader or narrowing toolkit.
+- `js/no-config-file-tests` reports standalone tests that restate repository configuration instead of verifying behavior. It skips non-test files before calling the model, but the `files:` glob must include tests and ignored files remain excluded.
 - `js/no-mixed-layers-without-abstraction` reports consuming features that own independently reusable external-integration responsibilities without a stable interface.
 - `js/no-private-schema-toolkit` reports clusters of local helpers that form an ad hoc schema or payload-normalization toolkit.
 - `js/no-redundant-binding` reports local bindings that only rename an unchanged value or reference without adding a useful boundary.
@@ -30,6 +31,8 @@ Five repository-aware rules are registered but intentionally not enabled by `rec
 
 The five opt-in rules require both a configured model and an agent adapter capable of tool calls. They reuse the standard `@alint-js/tools-fs` list, search, and read tools, and ask the agent to include repository evidence with each finding.
 
+`js/no-config-file-tests` is not repository-aware and needs no agent adapter: it judges the test file it is handed, so a configured model is enough.
+
 ## How to use
 
 Use the default export with the `js` plugin name because the bundled preset refers to `js/*` rule IDs.
@@ -88,6 +91,7 @@ export default defineConfig([
 
 - Do not use model-backed rules as a deterministic replacement for syntax-aware lint.
 - Do not enable repository-aware rules with a generation-only model or without an agent adapter.
+- Do not use `js/no-config-file-tests` when the configuration module owns logic the repository must verify, such as a custom lint rule, a custom bundler plugin, or a merge or normalization helper. Move that logic into its own module and test the module instead.
 - Do not use `js/no-duplicated-knowledge` for coincidental literals or clones that do not encode one shared decision.
 - Do not use `js/no-overlapping-entrypoints` for documented compatibility aliases or conditional/type-only exports.
 - Do not use `js/no-redundant-catch` when the outer catch changes cleanup, observability, error metadata, cause, identity, or cancellation behavior.

package/dist/index.d.mts

@@ -2605,6 +2605,9 @@ declare function createReportFindingsToolParameters(): JsonSchema;
 //#region src/rules/inline-miniature-normalizer/rule.d.ts
 declare const inlineMiniatureNormalizerRule: RuleDefinition<[]>;
 //#endregion
+//#region src/rules/no-config-file-tests/rule.d.ts
+declare const configFileTestsRule: RuleDefinition<[]>;
+//#endregion
 //#region src/rules/no-duplicated-knowledge/rule.d.ts
 declare const duplicatedKnowledgeRule: RuleDefinition<[]>;
 //#endregion
@@ -2641,6 +2644,7 @@ declare const vacuousFunctionRule: RuleDefinition<[]>;
 //#region src/index.d.ts
 declare const _default: PluginDefinition<{
   readonly 'inline-miniature-normalizer': RuleDefinition<[]>;
+  readonly 'no-config-file-tests': RuleDefinition<[]>;
   readonly 'no-duplicated-knowledge': RuleDefinition<[]>;
   readonly 'no-mixed-layers-without-abstraction': RuleDefinition<[]>;
   readonly 'no-overlapping-entrypoints': RuleDefinition<[]>;
@@ -2654,4 +2658,4 @@ declare const _default: PluginDefinition<{
   readonly 'no-vacuous-function': RuleDefinition<[]>;
 }>;
 //#endregion
-export { createJudgeMessages, createReportFindingsToolParameters, _default as default, duplicatedKnowledgeRule, inlineMiniatureNormalizerRule, judgeFindingSchema, judgeResponseSchema, mixedLayersWithoutAbstractionRule, overlappingEntrypointsRule, privateSchemaToolkitRule, redundantBindingRule, redundantCatchRule, redundantJsdocRule, singleUseMaterializationRule, testOnlyProductionWrapperRule, trivialWrapperStackRule, vacuousFunctionRule };
+export { configFileTestsRule, createJudgeMessages, createReportFindingsToolParameters, _default as default, duplicatedKnowledgeRule, inlineMiniatureNormalizerRule, judgeFindingSchema, judgeResponseSchema, mixedLayersWithoutAbstractionRule, overlappingEntrypointsRule, privateSchemaToolkitRule, redundantBindingRule, redundantCatchRule, redundantJsdocRule, singleUseMaterializationRule, testOnlyProductionWrapperRule, trivialWrapperStackRule, vacuousFunctionRule };

package/dist/index.mjs

@@ -2048,6 +2048,102 @@ async onTargetFile(target) {
 	} })
 });
 //#endregion
+//#region src/rules/no-config-file-tests/prompt.ts
+const configFileTestsPrompt = `
+You are reviewing one JavaScript or TypeScript test file.
+
+Task:
+Warn about a standalone test file whose subject is repository configuration rather than production behavior.
+
+This is a warning-level design smell, not a correctness error.
+
+The issue:
+Configuration is declarative, so a test that restates it keeps a second copy of values the configuration already states. Every intentional configuration change then fails the test without proving any behavior, and the same decision has to be updated in two places. A failing copy is also easy to misread: it looks like evidence that the configuration change is wrong.
+
+Report test files whose subject is configuration, such as:
+- importing a configuration module like eslint.config.ts, vite.config.ts, vitest.config.ts, tsdown.config.ts, or alint.config.ts and asserting its exported object, arrays, globs, plugin lists, or rule severities
+- reading a configuration file as text or structured data, like tsconfig.json, package.json, or cspell.config.yaml, and asserting its keys, values, ordering, or a snapshot of it
+- asserting that a configuration entry contains an expected string, path, dependency, or file name, where the expectation is the configuration itself
+
+Do not report:
+- tests for logic the repository owns: custom lint rule implementations, custom bundler or transformer plugins, configuration helper, merge, or normalization functions, schema validation, or environment-dependent branch selection
+- tests that run the configured tool over a fixture and assert the behavior or diagnostics it produces
+- tests that verify a generator produces configuration, when the generator is the unit under test
+- configuration that owns policy the repository must verify, such as permission or access lists, ignore lists that must stay in sync with another file, or a cross-file invariant the test proves
+- fixtures, snapshots, or helpers rather than tests that run
+- test files whose subject also includes production behavior
+- files that are not test files
+
+Use an aggressive but fair standard:
+- if the assertions repeat values the configuration already declares, report it
+- if the test can only fail when a value it copied changes, report it
+- if deleting the test would lose no verified behavior, report it
+- if the subject is production code, or the configuration carries behavior that needs coverage, return no finding
+
+Report the line that shows the configuration under test, usually the import of the configuration module or the assertion that restates it. Report each test file once, name the configuration under test or the values being restated, and keep the message short.
+
+Suggest deleting the standalone test and covering the configuration through the behavior it produces. When the configuration carries logic that needs coverage, suggest moving that logic into its own module and testing the module instead.
+
+Return warnings only.
+`.trim();
+//#endregion
+//#region src/rules/no-config-file-tests/rule.ts
+const TEST_FILE_SUFFIX = /\.(?:test|spec)\.[cm]?[jt]sx?$/;
+const TEST_DIRECTORY = /(?:^|\/)(?:__tests__|__test__)\//;
+const configFileTestsRule = defineRule({
+	cacheKey: configFileTestsPrompt,
+	create: (ctx) => ({ 
+	/**
+	* Reviews one test file target for a standalone test of configuration content.
+	*
+	* Triggering workflow:
+	*
+	* {@link defineRule}
+	*   -> `PlannedSourceTarget.kind === "file"`
+	*     -> `onTargetFile`
+	*       -> {@link judgeSource}
+	*
+	* Upstream:
+	* - {@link defineRule}
+	*
+	* Downstream:
+	* - {@link judgeSource}
+	* - `ctx.report`
+	*/
+async onTargetFile(target) {
+		if (!isTestFile(target.file.path)) return;
+		const model = await ctx.model();
+		const file = await ctx.src.readFile(target.file);
+		const findings = await judgeSource({
+			logger: ctx.logger,
+			metering: ctx.metering,
+			model,
+			operation: "config-file-tests-judge",
+			outputLanguage: ctx.outputLanguage,
+			prompt: configFileTestsPrompt,
+			signal: ctx.signal,
+			source: file.text
+		});
+		for (const finding of findings) ctx.report({
+			evidence: {
+				confidence: finding.confidence,
+				suggestion: finding.suggestion
+			},
+			filePath: target.file.path,
+			loc: { start: {
+				column: 0,
+				line: finding.line
+			} },
+			message: finding.message
+		});
+	} }),
+	languages: ["javascript", "typescript"]
+});
+function isTestFile(filePath) {
+	const normalized = filePath.replace(/\\/g, "/");
+	return TEST_FILE_SUFFIX.test(normalized) || TEST_DIRECTORY.test(normalized);
+}
+//#endregion
 //#region src/rules/no-duplicated-knowledge/prompt.ts
 const duplicatedKnowledgeInstructions = `
 Investigate whether the target independently maintains knowledge that the repository already owns elsewhere.
@@ -6232,6 +6328,7 @@ async onTargetFile(target) {
 var src_default = definePlugin({
 	configs: { recommended: [{ rules: {
 		"js/inline-miniature-normalizer": "warn",
+		"js/no-config-file-tests": "warn",
 		"js/no-mixed-layers-without-abstraction": "warn",
 		"js/no-private-schema-toolkit": "warn",
 		"js/no-redundant-binding": "warn",
@@ -6241,6 +6338,7 @@ var src_default = definePlugin({
 	} }] },
 	rules: {
 		"inline-miniature-normalizer": inlineMiniatureNormalizerRule,
+		"no-config-file-tests": configFileTestsRule,
 		"no-duplicated-knowledge": duplicatedKnowledgeRule,
 		"no-mixed-layers-without-abstraction": mixedLayersWithoutAbstractionRule,
 		"no-overlapping-entrypoints": overlappingEntrypointsRule,
@@ -6255,4 +6353,4 @@ var src_default = definePlugin({
 	}
 });
 //#endregion
-export { createJudgeMessages, createReportFindingsToolParameters, src_default as default, duplicatedKnowledgeRule, inlineMiniatureNormalizerRule, judgeFindingSchema, judgeResponseSchema, mixedLayersWithoutAbstractionRule, overlappingEntrypointsRule, privateSchemaToolkitRule, redundantBindingRule, redundantCatchRule, redundantJsdocRule, singleUseMaterializationRule, dist_exports as t, testOnlyProductionWrapperRule, trivialWrapperStackRule, vacuousFunctionRule };
+export { configFileTestsRule, createJudgeMessages, createReportFindingsToolParameters, src_default as default, duplicatedKnowledgeRule, inlineMiniatureNormalizerRule, judgeFindingSchema, judgeResponseSchema, mixedLayersWithoutAbstractionRule, overlappingEntrypointsRule, privateSchemaToolkitRule, redundantBindingRule, redundantCatchRule, redundantJsdocRule, singleUseMaterializationRule, dist_exports as t, testOnlyProductionWrapperRule, trivialWrapperStackRule, vacuousFunctionRule };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@alint-js/plugin-js",
   "type": "module",
-  "version": "0.7.2",
+  "version": "0.7.3",
   "description": "Model-backed JavaScript and TypeScript review rules for alint",
   "license": "MIT",
   "repository": {
@@ -32,9 +32,9 @@
     "@valibot/to-json-schema": "^1.7.1",
     "apeira": "^0.0.7",
     "valibot": "^1.4.2",
-    "@alint-js/plugin": "0.7.2",
-    "@alint-js/tools-fs": "0.7.2",
-    "@alint-js/core": "0.7.2"
+    "@alint-js/core": "0.7.3",
+    "@alint-js/plugin": "0.7.3",
+    "@alint-js/tools-fs": "0.7.3"
   },
   "scripts": {
     "build": "tsdown",