@alia.onl/sdk 22.1.0 → 22.1.2

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @alia.onl/sdk
 
+## 22.1.2
+
+- **Every entry type-checks under `noUncheckedIndexedAccess`.** The SDK ships source, so a
+  consumer compiling with `"noUncheckedIndexedAccess": true` (Astro) type-checked the SDK under
+  it too and got errors from indexed reads in the runtime, thread, citation and catalogue-tool
+  modules (27 from `@alia.onl/sdk/runtime` alone). Each read is now narrowed where the index is
+  known to be in range, with a loop over the values where that is simpler. Behaviour is unchanged.
+- `check:entry-types` compiles every entry with `noUncheckedIndexedAccess` on, so CI keeps it so.
+
+## 22.1.1
+
+- A delayed Stop acknowledgement cannot idle a newer turn, replace its sidebar
+  preview, or notify a different conversation. Thread/account changes and unmounts
+  invalidate old completion callbacks while the original acknowledgement drains.
+- Keep repeated Stop requests deduplicated during that drain; errors from an old
+  Stop cannot appear in a replacement thread. Public APIs and peer ranges are unchanged.
+
 ## 22.1.0
 
 - Stop explicitly cancels the authenticated foreground turn across API replicas;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@alia.onl/sdk",
-  "version": "22.1.0",
+  "version": "22.1.2",
   "description": "Alia AI chat SDK — the conversation runtime, chat UI, voice calls and dictation for Oxy apps",
   "main": "src/index.ts",
   "react-native": "src/index.ts",

package/src/components/AmbientField.tsx

@@ -554,7 +554,7 @@ export const AmbientField = memo(function AmbientField({
                   key={config.w}
                   config={config}
                   index={index}
-                  color={palette[index]}
+                  color={palette[index] as string}
                   vw={vw}
                   vh={vh}
                   vmax={vmax}

package/src/components/ReplyMarkdown.tsx

@@ -121,7 +121,7 @@ function parseBlockData(type: string, match: RegExpExecArray): any {
     switch (type) {
       case 'COMPACTLIST': {
         const title = match[1];
-        const itemsText = match[2];
+        const itemsText = match[2] ?? '';
         const items = itemsText
           .split('\n')
           .filter((line) => line.trim().startsWith('-'))
@@ -140,26 +140,26 @@ function parseBlockData(type: string, match: RegExpExecArray): any {
         return {
           type: match[1],
           title: match[2],
-          content: match[3].trim(),
+          content: (match[3] ?? '').trim(),
         };
       }
       case 'COMPARISON': {
         const title = match[1];
-        const content = match[2];
+        const content = match[2] ?? '';
         const leftMatch = content.match(/LEFT:\s*({.*?})/s);
         const rightMatch = content.match(/RIGHT:\s*({.*?})/s);
         const conclusionMatch = content.match(/CONCLUSION:\s*(.*?)$/s);
 
         return {
           title,
-          left: leftMatch ? JSON.parse(leftMatch[1]) : {},
-          right: rightMatch ? JSON.parse(rightMatch[1]) : {},
-          conclusion: conclusionMatch ? conclusionMatch[1].trim() : undefined,
+          left: leftMatch ? JSON.parse(leftMatch[1] ?? '') : {},
+          right: rightMatch ? JSON.parse(rightMatch[1] ?? '') : {},
+          conclusion: conclusionMatch ? (conclusionMatch[1] ?? '').trim() : undefined,
         };
       }
       case 'TIMELINE': {
         const title = match[1];
-        const itemsText = match[2];
+        const itemsText = match[2] ?? '';
         const items = itemsText
           .split('\n')
           .filter((line) => line.trim().startsWith('-'))
@@ -183,7 +183,7 @@ function parseBlockData(type: string, match: RegExpExecArray): any {
       }
       case 'CREDIBILITY': {
         return {
-          level: parseInt(match[1], 10),
+          level: parseInt(match[1] ?? '', 10),
           source: match[2],
         };
       }

package/src/components/canvas/ChartRenderer.tsx

@@ -30,7 +30,7 @@ export function ChartRenderer({ data, title }: ChartRendererProps) {
     labels.map((label, i) => ({ label, value: values[i] || 0 }));
 
   if (chartType === 'line' && datasets.length === 1) {
-    const series = datasets[0];
+    const series = datasets[0] as (typeof datasets)[number];
     return (
       <LineChartCard
         title={series.label || title}

package/src/components/thought/ThoughtPanel.tsx

@@ -129,7 +129,7 @@ function StepsTab({ steps, lifecycle }: { steps: ThoughtStep[]; lifecycle: TurnL
     return <EmptyState variant="compact" description={t('thought.noSteps')} />;
   }
 
-  const last = steps[steps.length - 1];
+  const last = steps[steps.length - 1] as (typeof steps)[number];
   const tail = live && (last.type === 'thinking' || last.type === 'writing') ? last : null;
   const rows = tail === null ? steps : steps.slice(0, -1);
 

package/src/components/thread/AliaThread.tsx

@@ -213,7 +213,7 @@ export const AliaThread = memo(function AliaThread({
     if (index !== lastReplyIndex || index !== rows.length - 1) return false;
     if (index < history.length || failedTurn?.anchorMessageId === message.id) return false;
     for (let i = index - 1; i >= history.length; i--) {
-      if (rows[i].role === 'user') return true;
+      if (rows[i]?.role === 'user') return true;
     }
     return false;
   };
@@ -223,7 +223,7 @@ export const AliaThread = memo(function AliaThread({
    * an old message belongs to the stretch that ended, not to the one on screen.
    */
   const conversationOf = (index: number): string | undefined =>
-    index < history.length ? history[index].conversationId : conversationId;
+    index < history.length ? history[index]?.conversationId : conversationId;
 
   // ── Which rows are mounted, and the scroll that goes with them ──
   /** The row a cursor jump was aimed at, as an index into what is shown, or -1. */

package/src/hooks/useTimelineWindow.ts

@@ -169,7 +169,7 @@ export function useTimelineWindow({
         anchor: kept,
         offset: lastOffset.current ?? 0,
         atBottom: atBottom.current,
-        probeId: rows[first],
+        probeId: rows[first] as string,
       });
     };
   }, [scrollKey]);

package/src/lib/audio-level.ts

@@ -71,8 +71,8 @@ export function levelFromFrames(frames: readonly number[]): number {
   if (frames.length === 0) return 0;
 
   let sumSquares = 0;
-  for (let index = 0; index < frames.length; index += 1) {
-    sumSquares += frames[index] * frames[index];
+  for (const frame of frames) {
+    sumSquares += frame * frame;
   }
   const rms = Math.sqrt(sumSquares / frames.length);
 

package/src/lib/catalogue-tool.ts

@@ -12,7 +12,7 @@ const CANONICAL_TOOL = /^(?:oxy|self)_([a-z][a-z0-9-]{0,63})__([A-Za-z0-9_-]+)$/
 /** The app and tool of a canonical catalogue tool name, or `null` for any other name. */
 export function parseCatalogueTool(toolName: string): { app: string; tool: string } | null {
   const match = CANONICAL_TOOL.exec(toolName);
-  return match ? { app: match[1], tool: match[2] } : null;
+  return match ? { app: match[1] ?? '', tool: match[2] ?? '' } : null;
 }
 
 /** The renderer key of a tool name (`<app>:<tool>`), or `null` when it is not a catalogue tool. */

package/src/lib/citations.ts

@@ -180,7 +180,7 @@ export function splitReferences(
     const m = REFERENCE_LINE_RE.exec(line);
     if (m) {
       flush();
-      current = { id: Number(m[1]), rest: m[2] };
+      current = { id: Number(m[1]), rest: m[2] ?? '' };
     } else if (current && line.trim().length > 0) {
       // A legacy entry's URL sits on the indented line after the title.
       current.rest += ` ${line.trim()}`;

package/src/runtime/conversations.ts

@@ -275,13 +275,14 @@ function upsertOnTop(
   if (moveExisting) {
     // Remove the conversation from its current position (if it is in any page)
     for (let i = 0; i < pages.length; i++) {
-      const existingIndex = pages[i].conversations.findIndex((c) => c.id === row.id);
+      const page = pages[i] as ConversationsPage;
+      const existingIndex = page.conversations.findIndex((c) => c.id === row.id);
       if (existingIndex >= 0) {
         pages[i] = {
-          ...pages[i],
+          ...page,
           conversations: [
-            ...pages[i].conversations.slice(0, existingIndex),
-            ...pages[i].conversations.slice(existingIndex + 1),
+            ...page.conversations.slice(0, existingIndex),
+            ...page.conversations.slice(existingIndex + 1),
           ],
         };
         break;
@@ -347,7 +348,10 @@ export function useSaveConversation() {
             id,
             title: offlineTitle,
             lastMessage,
-            createdAt: existingIndex >= 0 ? conversations[existingIndex].createdAt : new Date(),
+            createdAt:
+              existingIndex >= 0
+                ? (conversations[existingIndex] as Conversation).createdAt
+                : new Date(),
             updatedAt: new Date(),
             messages,
           };

package/src/runtime/message-history.ts

@@ -102,7 +102,7 @@ export function normalizeConversationMessages(messages: readonly Message[]): Mes
   messages = messages.filter((message) => message.role !== 'system');
 
   for (let index = 0; index < messages.length; index += 1) {
-    const current = messages[index];
+    const current = messages[index] as Message;
     const placeholder = messages[index + 1];
     const duplicate = messages[index + 2];
 

package/src/runtime/thread/thought-utils.ts

@@ -718,8 +718,9 @@ export function turnTiming(
   const index = messages.findIndex((m) => m.id === message.id);
   let sendStamp: number | null = null;
   for (let i = index - 1; i >= 0; i -= 1) {
-    if (messages[i].role === 'user') {
-      sendStamp = stampToMs(messages[i].createdAt);
+    const earlier = messages[i];
+    if (earlier?.role === 'user') {
+      sendStamp = stampToMs(earlier.createdAt);
       break;
     }
   }

package/src/runtime/thread/thread-history.ts

@@ -95,7 +95,7 @@ export function threadHistory(
 ): ThreadMessage[] {
   const history: ThreadMessage[] = [];
   for (let page = pages.length - 1; page >= 0; page -= 1) {
-    for (const message of pages[page].messages) {
+    for (const message of pages[page]?.messages ?? []) {
       if (message.conversationId === activeConversationId) continue;
       history.push({ ...message, id: message.id ?? message.cursor });
     }

package/src/runtime/thread/timeline.ts

@@ -76,7 +76,7 @@ function tailStart(count: number): number {
 /** The anchor that keeps exactly the rows mounted now, from the row at `start`. */
 export function pinAnchor(ids: readonly string[], start: number): TimelineAnchor {
   if (start <= 0 || ids.length === 0) return TOP;
-  return { kind: 'row', id: ids[start] };
+  return { kind: 'row', id: ids[start] as string };
 }
 
 /**
@@ -124,7 +124,7 @@ export function sameTimelineShape(previous: readonly Shape[], next: readonly Sha
   if (previous === next) return true;
   if (previous.length !== next.length) return false;
   for (let i = 0; i < next.length; i += 1) {
-    if (!sameShape(previous[i], next[i])) return false;
+    if (!sameShape(previous[i] as Shape, next[i] as Shape)) return false;
   }
   return true;
 }

package/src/runtime/thread/tool-cards.ts

@@ -125,8 +125,8 @@ function toPoints(series: readonly PricePoint[], intraday: boolean, locale: stri
 
 /** First-to-last change as a ratio, or none for a run that started at nothing. */
 function runDelta(series: readonly PricePoint[]): number | undefined {
-  const first = series[0][1];
-  const last = series[series.length - 1][1];
+  const first = (series[0] as PricePoint)[1];
+  const last = (series[series.length - 1] as PricePoint)[1];
   return first === 0 ? undefined : (last - first) / first;
 }
 
@@ -189,7 +189,7 @@ export function marketChart(data: MarketCardData, t: Translate, locale: string):
       id,
       label: t(`market.range.${id}`),
       data: toPoints(run, id === '1D', locale),
-      headline: quoted(data.price) ? data.price : run[run.length - 1][1],
+      headline: quoted(data.price) ? data.price : (run[run.length - 1] as PricePoint)[1],
       delta: id === '1D' && quoted(data.changePct) ? data.changePct / 100 : runDelta(run),
     });
   }
@@ -205,7 +205,7 @@ export function marketChart(data: MarketCardData, t: Translate, locale: string):
   if (intraday.length >= 2) {
     notes.push(
       [
-        `${t('market.open')} ${format(intraday[0])}`,
+        `${t('market.open')} ${format(intraday[0] as number)}`,
         `${t('market.dayHigh')} ${format(Math.max(...intraday))}`,
         `${t('market.dayLow')} ${format(Math.min(...intraday))}`,
       ].join(' · '),
@@ -220,7 +220,9 @@ export function marketChart(data: MarketCardData, t: Translate, locale: string):
   return {
     title: `${data.name} · ${data.symbol}`,
     ranges,
-    defaultRange: ranges.some((r) => r.id === '1D') ? '1D' : ranges[0].id,
+    defaultRange: ranges.some((r) => r.id === '1D')
+      ? '1D'
+      : (ranges[0] as (typeof ranges)[number]).id,
     format,
     formatAxisValue: (value) => formatAxis(value, locale),
     notes,
@@ -275,7 +277,7 @@ export function faircoinChart(
       id,
       label: t(`faircoin.range.${id}`),
       data: toPoints(run, id === '24h', locale),
-      headline: quoted(data.price) ? data.price : run[run.length - 1][1],
+      headline: quoted(data.price) ? data.price : (run[run.length - 1] as PricePoint)[1],
       delta: id === '24h' && quoted(data.changePct) ? data.changePct / 100 : runDelta(run),
     });
   }
@@ -331,7 +333,9 @@ export function faircoinChart(
     chart: {
       title: `${t('faircoin.name')} · ${t('faircoin.symbol')}`,
       ranges,
-      defaultRange: ranges.some((r) => r.id === '24h') ? '24h' : ranges[0].id,
+      defaultRange: ranges.some((r) => r.id === '24h')
+        ? '24h'
+        : (ranges[0] as (typeof ranges)[number]).id,
       format,
       formatAxisValue: (value) => formatAxis(value, locale),
       notes: [],

package/src/runtime/use-conversation-stream.ts

@@ -216,6 +216,8 @@ export function useConversationStream({
   const queryClient = useQueryClient();
   const abortControllerRef = useRef<AbortController | null>(null);
   const turnControlRef = useRef<ReturnType<typeof createChatTurnControl> | null>(null);
+  // A Stop acknowledgement can outlive its stream, thread, or the next send.
+  const turnGenerationRef = useRef(0);
 
   // Batching refs: accumulate streaming text and flush at ~20fps instead of per-chunk
   const pendingContentRef = useRef('');
@@ -279,6 +281,8 @@ export function useConversationStream({
     mountedRef.current = true;
     return () => {
       mountedRef.current = false;
+      turnGenerationRef.current++;
+      turnControlRef.current = null;
       flushPendingUpdates();
       if (flushTimerRef.current) {
         clearTimeout(flushTimerRef.current);
@@ -324,6 +328,8 @@ export function useConversationStream({
     const was = conversationRef.current;
     conversationRef.current = conversationId;
     if (was !== undefined && was !== conversationId) {
+      turnGenerationRef.current++;
+      turnControlRef.current = null;
       hostOutcomesRef.current.clear();
       // The reply still streaming belongs to the thread that was left: cut it, drop what it had
       // batched (it would land on this thread's last message) and let the screen be idle.
@@ -350,6 +356,8 @@ export function useConversationStream({
     const was = accountRef.current;
     accountRef.current = accountId;
     if (was === null || was === accountId) return;
+    turnGenerationRef.current++;
+    turnControlRef.current = null;
     abortControllerRef.current?.abort();
     abortControllerRef.current = null;
     dropPendingUpdates();
@@ -367,6 +375,7 @@ export function useConversationStream({
 
   const append = useCallback(
     async (message: Omit<Message, 'id'>, options?: SendOptions): Promise<SendOutcome> => {
+      const turnGeneration = ++turnGenerationRef.current;
       setIsLoading(true);
       setError(null);
       // A new send answers the old failure, whether it is the retry or a fresh
@@ -888,7 +897,7 @@ export function useConversationStream({
                           const idx = invocations.findIndex((t) => t.toolCallId === tool_call_id);
                           if (idx >= 0) {
                             invocations[idx] = {
-                              ...invocations[idx],
+                              ...(invocations[idx] as ToolInvocation),
                               state: 'result',
                               result: output,
                             };
@@ -1245,7 +1254,11 @@ export function useConversationStream({
                       const idx = invocations.findIndex((t) => t.toolCallId === tool_call_id);
 
                       if (idx >= 0) {
-                        invocations[idx] = { ...invocations[idx], state: 'result', result: output };
+                        invocations[idx] = {
+                          ...(invocations[idx] as ToolInvocation),
+                          state: 'result',
+                          result: output,
+                        };
                       } else {
                         invocations.push({
                           toolCallId: tool_call_id,
@@ -1376,33 +1389,31 @@ export function useConversationStream({
         setError(finalError);
         return keepFailedTurn(true, finalError.message);
       } finally {
-        // Flush any remaining batched content
-        flushPendingUpdates();
-        if (flushTimerRef.current) {
-          clearTimeout(flushTimerRef.current);
-          flushTimerRef.current = null;
+        // Batches belong to the current turn. An older finally must not flush or clear
+        // the next turn's shared timer, even when its controller ref has been cleared.
+        if (turnGenerationRef.current === turnGeneration) {
+          flushPendingUpdates();
+          if (flushTimerRef.current) {
+            clearTimeout(flushTimerRef.current);
+            flushTimerRef.current = null;
+          }
         }
-        // Only the turn that still owns the ref clears it and the loading flag: after Stop and a new
-        // send, this `finally` belongs to the old turn and must not idle the new one.
-        const ownsTurn =
-          abortControllerRef.current === null || abortControllerRef.current === controller;
-        if (abortControllerRef.current === controller) abortControllerRef.current = null;
-        if (turnControlRef.current === turnControl) turnControlRef.current = null;
+        // Settle only this turn's message ids, including when a new send has already
+        // started in the same conversation. Error paths may have settled them first.
+        settleAssistant(controller?.signal.aborted === true ? 'cancelled' : 'completed');
+        // Retain this control while its ACK drains so repeated Stop remains deduplicated.
+        // Local transport cleanup is required even after the thread has been replaced.
         if (turnControl) await turnControl.finish();
         else linked?.dispose();
-        // A turn that is still streaming here ended without an error path
-        // settling it: on its own, or because `stop()` aborted the controller.
-        // (The error paths abort it too, but they have settled it first.)
-        settleAssistant(controller?.signal.aborted === true ? 'cancelled' : 'completed');
-        if (ownsTurn) setIsLoading(false);
-        /*
-         * The answer replaces your own line in the sidebar — once per turn rather
-         * than once per token. Read from what this turn received, not from the
-         * rendered messages, which have not caught up with the last batched flush.
-         */
-        if (replyText !== '') host.onTurnPreview?.(agentId, replyText);
-        // Every way a turn stops streaming — finished, stopped, failed — passes here once.
-        if (mountedRef.current) host.onTurnEnd?.();
+        if (abortControllerRef.current === controller) abortControllerRef.current = null;
+        if (turnControlRef.current === turnControl) turnControlRef.current = null;
+        // Recheck after the await: another turn, thread, account or mount may now own UI.
+        if (mountedRef.current && turnGenerationRef.current === turnGeneration) {
+          setIsLoading(false);
+          // The sidebar preview and completion notification belong to this visible turn.
+          if (replyText !== '') host.onTurnPreview?.(agentId, replyText);
+          host.onTurnEnd?.();
+        }
       }
     },
     [
@@ -1434,9 +1445,14 @@ export function useConversationStream({
 
   const stop = useCallback(() => {
     const turn = turnControlRef.current;
+    const turnGeneration = turnGenerationRef.current;
     if (!turn) return;
     void turn.stop().catch((error: unknown) => {
-      if (turnControlRef.current === turn && mountedRef.current) {
+      if (
+        turnControlRef.current === turn &&
+        turnGenerationRef.current === turnGeneration &&
+        mountedRef.current
+      ) {
         setError(error instanceof Error ? error : new Error('Generation could not be stopped.'));
       }
     });

package/src/runtime/use-conversation-thread.ts

@@ -435,7 +435,8 @@ export function useConversationThread({
     (assistantMessageId: string): Message | undefined => {
       const idx = messages.findIndex((msg) => msg.id === assistantMessageId);
       for (let i = idx - 1; i >= 0; i--) {
-        if (messages[i].role === 'user') return messages[i];
+        const earlier = messages[i];
+        if (earlier?.role === 'user') return earlier;
       }
       return undefined;
     },