@algorandfoundation/algokit-utils 8.0.0 → 8.0.1-beta.1

package/types/app-client.js

@@ -471,9 +471,7 @@ class AppClient {
             }
             e = new types_logicError.LogicError(errorDetails, buffer.Buffer.from(isClearStateProgram ? appSpec.source.clear : appSpec.source.approval, 'base64')
                 .toString()
-                .split('\n'), 
-            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-            getLineForPc);
+                .split('\n'), getLineForPc);
         }
         if (errorMessage) {
             const appId = JSON.stringify(e).match(/(?<=app=)\d+/)?.[0] || '';
@@ -824,10 +822,10 @@ class AppClient {
         return typeof sender === 'string' ? algosdk.Address.fromString(sender) : (sender ?? this._defaultSender);
     }
     /** Returns the signer for a call, using the provided signer or the `defaultSigner`
-     * if no signer was provided and the call will use default sender
+     * if no signer was provided and the sender resolves to the default sender, the call will use default signer
      * or `undefined` otherwise (so the signer is resolved from `AlgorandClient`) */
     getSigner(sender, signer) {
-        return signer ?? (!sender ? this._defaultSigner : undefined);
+        return signer ?? (!sender || sender === this._defaultSender ? this._defaultSigner : undefined);
     }
     getBareParams(params, onComplete) {
         return {
@@ -1114,7 +1112,6 @@ class ApplicationClient {
         if (!sender) {
             throw new Error('No sender provided, unable to deploy app');
         }
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         const from = sender ?? this.sender;
         if (!this._creator) {
             throw new Error("Attempt to `deploy` a contract without specifying `resolveBy: 'creatorAndName'` in the constructor");
@@ -1215,7 +1212,6 @@ class ApplicationClient {
                 ...(sendParams ?? {}),
             }, this.algod);
             if (result.confirmation) {
-                // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
                 this._appId = result.confirmation.applicationIndex;
                 this._appAddress = getApplicationAddress(this._appId).toString();
             }
@@ -1275,7 +1271,6 @@ class ApplicationClient {
             // There isn't an ATC passed in
             !call.sendParams?.atc &&
             // The method is readonly
-            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             this.appSpec.hints[this.getABIMethodSignature(this.getABIMethod(call.method))].read_only) {
             const atc = new AtomicTransactionComposer();
             await this.callOfType({ ...call, sendParams: { ...call.sendParams, atc } }, 'no_op');
@@ -1356,7 +1351,6 @@ class ApplicationClient {
             return await app.callApp({
                 appId: appMetadata.appId,
                 callType: callType,
-                // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
                 from: sender,
                 args: await this.getCallArgs(args, sender),
                 note: note,
@@ -1574,7 +1568,6 @@ class ApplicationClient {
      */
     async getAppReference() {
         if (!this.existingDeployments && this._creator) {
-            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             this.existingDeployments = await appDeploy.getCreatorAppsByName(this._creator, this.indexer);
         }
         if (this.existingDeployments && this._appId === 0) {
@@ -1607,9 +1600,7 @@ class ApplicationClient {
         if (errorDetails !== undefined)
             return new types_logicError.LogicError(errorDetails, buffer.Buffer.from(isClear ? this.appSpec.source.clear : this.appSpec.source.approval, 'base64')
                 .toString()
-                .split('\n'), 
-            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-            (pc) => (isClear ? this._clearSourceMap : this._approvalSourceMap)?.getLocationForPc(pc)?.line);
+                .split('\n'), (pc) => (isClear ? this._clearSourceMap : this._approvalSourceMap)?.getLocationForPc(pc)?.line);
         else
             return e;
     }