@algolia/wizard 0.103.0-rc.217.762 → 0.103.0-rc.217.764

package/dist/main.js

@@ -2467,7 +2467,7 @@ async function ensureApplication(resumeAppId) {
 // package.json
 var package_default = {
   name: "@algolia/wizard",
-  version: "0.103.0-rc.217.762",
+  version: "0.103.0-rc.217.764",
   description: "Magically implement Algolia functionality in your codebase",
   type: "module",
   engines: {
@@ -3909,82 +3909,87 @@ function writeCredentialsTool(ctx) {
       if (!targetIndex) {
         return "Error: no target index is set for this run, so a scoped write key cannot be provisioned.";
       }
-      let existing = "";
-      let present;
-      try {
-        const targetError = await validateSafeWriteTarget(ctx, resolved2.target);
-        if (targetError) return targetError;
+      return withFileLock(resolved2.target, async () => {
+        let existing = "";
+        let present;
         try {
-          existing = await readFile7(resolved2.target, "utf8");
+          const targetError = await validateSafeWriteTarget(
+            ctx,
+            resolved2.target
+          );
+          if (targetError) return targetError;
+          try {
+            existing = await readFile7(resolved2.target, "utf8");
+          } catch (err) {
+            if (err.code !== "ENOENT") throw err;
+          }
+          present = [APP_ID_VAR, API_KEY_VAR].filter(
+            (name) => readEnv(existing, name) !== null
+          );
         } catch (err) {
-          if (err.code !== "ENOENT") throw err;
+          return `Error writing credentials to ${filePath}: ${err.message}`;
         }
-        present = [APP_ID_VAR, API_KEY_VAR].filter(
-          (name) => readEnv(existing, name) !== null
-        );
-      } catch (err) {
-        return `Error writing credentials to ${filePath}: ${err.message}`;
-      }
-      const credentials = [];
-      const notes = [];
-      const fileAppId = readEnv(existing, APP_ID_VAR);
-      const fileKey = readEnv(existing, API_KEY_VAR);
-      const fileIndex = readEnv(existing, INDEX_NAME_VAR);
-      if (fileAppId === null || fileKey === null) {
-        try {
-          const selected = (await requireApplication(ctx.appId)).id;
-          if (fileAppId === null) credentials.push([APP_ID_VAR, selected]);
-          if (fileKey === null) {
-            if (fileAppId !== null && fileAppId !== selected) {
+        const credentials = [];
+        const notes = [];
+        const fileAppId = readEnv(existing, APP_ID_VAR);
+        const fileKey = readEnv(existing, API_KEY_VAR);
+        const fileIndex = readEnv(existing, INDEX_NAME_VAR);
+        if (fileAppId === null || fileKey === null) {
+          try {
+            const selected = (await requireApplication(ctx.appId)).id;
+            if (fileAppId === null) credentials.push([APP_ID_VAR, selected]);
+            if (fileKey === null) {
+              if (fileAppId !== null && fileAppId !== selected) {
+                notes.push(
+                  `No ${API_KEY_VAR} was provisioned: ${filePath} names application ${fileAppId}, but ${selected} is selected. Tell the user to remove ${APP_ID_VAR} from ${filePath} and re-run so a matching pair can be written, or to fill in a ${API_KEY_VAR} for ${fileAppId} by hand.`
+                );
+              } else {
+                credentials.push([
+                  API_KEY_VAR,
+                  (await resolveWriteKey(targetIndex, selected)).key
+                ]);
+              }
+            } else {
               notes.push(
-                `No ${API_KEY_VAR} was provisioned: ${filePath} names application ${fileAppId}, but ${selected} is selected. Tell the user to remove ${APP_ID_VAR} from ${filePath} and re-run so a matching pair can be written, or to fill in a ${API_KEY_VAR} for ${fileAppId} by hand.`
+                `The existing ${API_KEY_VAR} must belong to application ${selected} or writes will fail.`
               );
-            } else {
-              credentials.push([
-                API_KEY_VAR,
-                (await resolveWriteKey(targetIndex, selected)).key
-              ]);
             }
-          } else {
-            notes.push(
-              `The existing ${API_KEY_VAR} must belong to application ${selected} or writes will fail.`
-            );
+          } catch (err) {
+            return `Error: could not resolve Algolia credentials (${err.message})`;
           }
-        } catch (err) {
-          return `Error: could not resolve Algolia credentials (${err.message})`;
         }
-      }
-      let wrote;
-      try {
-        const updated = [
-          ...credentials,
-          // Unconditional, unlike the credentials: the write key is scoped to
-          // the run's index, so a stale name left in the file earns a 403.
-          [INDEX_NAME_VAR, targetIndex]
-        ].reduce(
-          (content, [name, value]) => upsertEnv(content, name, value),
-          existing
-        );
-        const writeError = await safeWriteFile(ctx, resolved2.target, updated);
-        if (writeError) return writeError;
-        const sentences = [
-          `Wrote ${[...credentials.map(([name]) => name), INDEX_NAME_VAR].join(", ")} to ${filePath}.`
-        ];
-        if (fileIndex !== null && fileIndex !== targetIndex) {
-          sentences.push(
-            `That replaced the ${INDEX_NAME_VAR} already there ("${fileIndex}"), which this run does not target.`
-          );
-        }
-        if (present.length > 0) {
-          sentences.push(
-            `Skipped ${present.join(" and ")}: already defined there.`
+        let wrote;
+        try {
+          const updated = [
+            ...credentials,
+            // Unconditional, unlike the credentials: the write key is scoped to
+            // the run's index, so a stale name left in the file earns a 403.
+            [INDEX_NAME_VAR, targetIndex]
+          ].reduce(
+            (content, [name, value]) => upsertEnv(content, name, value),
+            existing
           );
+          const writeError = await safeWriteFile(ctx, resolved2.target, updated);
+          if (writeError) return writeError;
+          const sentences = [
+            `Wrote ${[...credentials.map(([name]) => name), INDEX_NAME_VAR].join(", ")} to ${filePath}.`
+          ];
+          if (fileIndex !== null && fileIndex !== targetIndex) {
+            sentences.push(
+              `That replaced the ${INDEX_NAME_VAR} already there ("${fileIndex}"), which this run does not target.`
+            );
+          }
+          if (present.length > 0) {
+            sentences.push(
+              `Skipped ${present.join(" and ")}: already defined there.`
+            );
+          }
+          wrote = [...sentences, ...notes].join(" ");
+        } catch (err) {
+          return `Error writing credentials to ${filePath}: ${err.message}`;
         }
-        wrote = [...sentences, ...notes].join(" ");
-      } catch (err) {
-        return `Error writing credentials to ${filePath}: ${err.message}`;
-      }
-      return wrote + await gitIgnoreOutcome(ctx, resolved2.target);
+        return wrote + await gitIgnoreOutcome(ctx, resolved2.target);
+      });
     }
   });
 }
@@ -5044,7 +5049,6 @@ async function classifyCommandSafety(createModel, command, cwd, explanation, app
     const { output, usage } = await generateText({
       model: anthropic(profile.model),
       maxOutputTokens: CLASSIFIER_MAX_OUTPUT_TOKENS,
-      temperature: 0,
       providerOptions: {
         anthropic: {
           thinking: modelOptions.thinking,
@@ -5739,7 +5743,7 @@ async function runAgentAttempt(req, attempt, retryReason, continuation) {
     continuation: continuation?.number ?? 0,
     durationMs: end - start,
     usage,
-    stepCount: totalSteps,
+    stepCount,
     hitStepLimit,
     finishReason
   });
@@ -5751,7 +5755,8 @@ async function runAgentAttempt(req, attempt, retryReason, continuation) {
       profile: profileName,
       model: profile.model,
       usage,
-      stepCount: totalSteps,
+      stepCount,
+      totalSteps,
       maxSteps,
       hitStepLimit,
       finishReason
@@ -6869,14 +6874,14 @@ function validationInstructions(input) {
     `The confirmed placement candidate was "${input.searchLocation ?? "unknown"}", but verify the actual mount rather than assuming the candidate was used.`,
     "Inspect the generated search component, its actual mount file, that file's parent layout and sibling controls, and the relevant content UI. Do not rely only on type checks or tests.",
     "Confirm that the application renders exactly one search bar. Check for an old search bar and duplicate mounts.",
-    "If the project sets a Content-Security-Policy, confirm that connect-src allows https://*.algolia.net, https://*.algolianet.com, and https://insights.algolia.io, and that search-insights is loaded from npm (not a CDN). If a CSP exists and fails either check, set sufficient=false. If the project has no CSP, skip both checks: do not set sufficient=false, and do not ask to add a CSP.",
+    "If the project sets a Content-Security-Policy, confirm that connect-src allows https://*.algolia.net, https://*.algolianet.com, and https://insights.algolia.io, and that search-insights is loaded from npm (not a CDN). If a CSP exists and fails either check, set sufficient=false. If the project has no CSP, skip both checks: do not set sufficient=false, and do not ask to add a CSP. Without a CSP, insights={true} (or insights: true) with no search-insights package is correct, because the widget loads search-insights from its CDN: do not report a missing search-insights package.",
     "Confirm content-specific search is placed with the corresponding content or task controls. Shared navigation is valid only for genuinely app-wide search that fits the visual hierarchy and responsive layout without crowding primary actions.",
     "Confirm the input has a persistent accessible name; widget-provided combobox, popup, and item relationships and keyboard behavior are preserved; and loading, empty, and error status text is perceivable to assistive technology.",
     "Inspect the CSS that actually applies to the generated DOM. Confirm the results panel and the element drawing the input frame have non-transparent surfaces, the input frame is distinguishable from its surrounding background in every supported theme, text meets 4.5:1 contrast, meaningful boundaries and focus indicators meet 3:1, and no state relies on color alone.",
     "Confirm the search experience reflows without horizontal page scrolling at 320 CSS pixels, keeps its panel on-screen, preserves visible focus, and respects reduced-motion preferences for any added animation.",
     "If the project imports an InstantSearch theme, confirm that the project sets the theme palette to the app colors in each theme that the app supports: --ais-primary-color-rgb to the app accent color, and --ais-background-color-rgb, --ais-text-color-rgb, and --ais-border-color-rgb to the app surface, text, and border colors. If the project keeps the theme defaults, set sufficient=false, because the search icon, focus ring, and active item then show the theme blue, and the panel shows the theme surface instead of the app surface. A match between the light and dark themes of the widget and the page is not enough. The theme colors .ais-Highlight-highlighted and .ais-Snippet-highlighted with a fixed blue that the palette does not change: if the results show either class and the project does not restyle it, set sufficient=false.",
     "Then confirm that the palette overrides (--ais-*-rgb) win over the theme: they must use a higher specificity than the theme, for example `:root:root`, and for a dark mode `:root:root.dark` or `:root:root[data-theme=dark]`, because the theme sets its own blue in `:root` and in `:root[data-theme=dark], .dark`. `:root:root` alone ties with `:root[data-theme=dark]`. If an override can lose to the theme, set sufficient=false, because the search icon and focus ring then show the theme blue instead of the app accent color.",
-    "Find how the app selects each theme it supports (a class or attribute on an ancestor, a prefers-color-scheme media query, or a theme that exists only in code). Confirm that the search input and results panel take their colors from the active app theme through that same switch. A search widget whose colors do not match the page theme, for example a light panel on a dark page, is a failure: set sufficient=false.",
+    "Find how the app selects each theme it supports (a class or attribute on an ancestor, a prefers-color-scheme media query, or a theme that exists only in code). A theme is supported only when the app can select it at runtime: a mounted theme switch, or a stored or system preference that the app applies. A theme file or theme option that the app never selects, for example because the app forces one mode, does not count. Confirm that the search input and results panel take their colors from the active app theme through that same switch. A search widget whose colors do not match the page theme, for example a light panel on a dark page, is a failure: set sufficient=false.",
     "When the project has a package.json, confirm that the theme CSS of the search widget (for InstantSearch, a theme from instantsearch.css) is imported once from a legal global-CSS entry for that framework (Next.js Pages Router: pages/_app; Next.js App Router: root layout; otherwise the app global stylesheet or a component module when allowed). If it is installed but not imported, or imported from a Next.js component file, set sufficient=false.",
     "Confirm that the search component is reachable from and fits the corresponding content task at every supported breakpoint; require app-wide reachability only when the search scope is genuinely app-wide.",
     "For an InstantSearch Autocomplete, confirm that the item component (the React itemComponent, or the item template in indices[].templates) calls the onSelect that it receives when the user clicks the result, for example onClick={onSelect} on its root element. The widget goes to the getURL route only through onSelect: the click on its <li> only sends the Insights event. If the item ignores onSelect, set sufficient=false, because a click on a result then does nothing.",
@@ -7199,6 +7204,13 @@ function validationRunInstructions(plan, attempt) {
     "Do not use an autofix option during validation."
   ];
 }
+function previousFindingsInstructions(findings) {
+  if (!findings) return [];
+  return [
+    `The previous validation pass reported these findings: ${findings}`,
+    "Check those findings first. Keep the conclusions of that pass that the changes did not affect, for example which themes the app supports. Report a new finding only when it breaks the search (the search bar does not render, search returns no results, or a click on a result does not open it), fails an accessibility requirement, or comes from a change made after the previous pass. Do not set sufficient=false for any other new issue: name it briefly in the summary."
+  ];
+}
 function retryTypeCheckInstructions(plan) {
   if (!plan.run) return [];
   return [
@@ -7642,6 +7654,7 @@ ${detail}` : ""}`
     );
     let extraInstructions = [];
     let buildCheckPlan;
+    let previousFindings;
     const confirmedFrameworks = language.frameworks ?? [];
     const detectedFrameworks = scan.frameworks ?? [];
     const framework = confirmedFrameworks[0]?.name ?? "unknown";
@@ -7687,9 +7700,10 @@ ${detail}` : ""}`
         searchConfigFile = searchResult.searchConfigFile;
       }
       buildCheckPlan ??= await resolveBuildCheckPlan(ctx, repoRoot, input);
-      const validation = await runValidationUseCase(
-        validationRunInstructions(buildCheckPlan, attempt)
-      );
+      const validation = await runValidationUseCase([
+        ...validationRunInstructions(buildCheckPlan, attempt),
+        ...previousFindingsInstructions(previousFindings)
+      ]);
       summaries.push(formatSummary("validation", validation.summary));
       const finalAttempt = attempt === MAX_IMPLEMENT_VALIDATION_ATTEMPTS;
       let investigateUnrelated = false;
@@ -7740,6 +7754,7 @@ ${detail}` : ""}`
           `Unable to validate the implementation after ${MAX_IMPLEMENT_VALIDATION_ATTEMPTS} attempts (details in wizard.log): ${briefSummary(validation.summary)}`
         );
       }
+      previousFindings = validation.sufficient ? void 0 : validation.additionalInstructions ?? validation.summary;
       extraInstructions = validation.sufficient ? [] : validationRetryInstructions(validation);
       if (validation.unrelatedFailure && investigateUnrelated) {
         extraInstructions.push(
@@ -10165,7 +10180,7 @@ async function resetProjectState() {
 // package.json with { type: 'json' }
 var package_default2 = {
   name: "@algolia/wizard",
-  version: "0.103.0-rc.217.762",
+  version: "0.103.0-rc.217.764",
   description: "Magically implement Algolia functionality in your codebase",
   type: "module",
   engines: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@algolia/wizard",
-  "version": "0.103.0-rc.217.762",
+  "version": "0.103.0-rc.217.764",
   "description": "Magically implement Algolia functionality in your codebase",
   "type": "module",
   "engines": {