@alfe.ai/ctrader-mcp 0.2.0 → 0.2.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@alfe.ai/ctrader-mcp",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "cTrader MCP server — full trading (place/modify/close orders + read) over the cTrader Open API (protobuf/TLS)",
   "type": "module",
   "main": "./dist/server.js",

package/proto/ctrader.proto

@@ -119,11 +119,16 @@ message ProtoOACtidTraderAccount {
   optional string brokerTitleShort    = 6;
 }
 
+// Canonical: permissionScope=3 (an enum upstream; we don't read it, kept as a
+// scalar), ctidTraderAccount=4. This response is declared for completeness but
+// is NOT on the live path — accounts come from AgentApiClient.getCTraderAccounts(),
+// not this socket call. Field numbers corrected to match canonical anyway so a
+// future decode of this message reads the account list at the right field.
 message ProtoOAGetAccountListByAccessTokenRes {
   optional uint32 payloadType                       = 1;
   required string accessToken                       = 2;
-  repeated ProtoOACtidTraderAccount ctidTraderAccount = 3;
-  optional bool   permissionScope                   = 4;
+  optional uint32 permissionScope                   = 3;
+  repeated ProtoOACtidTraderAccount ctidTraderAccount = 4;
 }
 
 // ── Trader (balance / account details) ──────────────────────────────────
@@ -194,30 +199,33 @@ message ProtoOAPosition {
   optional bool             trailingStopLoss = 16;
 }
 
+// NOTE: canonical ProtoOAOrder has NO field 5 — it jumps orderStatus=4 → expirationTimestamp=6.
+// Field numbers below are transcribed verbatim from Spotware's ProtoOAOrder
+// (relativeStopLoss/relativeTakeProfit are int64, not double, upstream).
 message ProtoOAOrder {
   required int64            orderId       = 1;
   required ProtoOATradeData tradeData     = 2;
   required ProtoOAOrderType orderType     = 3;
   required uint32           orderStatus   = 4;
-  optional int64            expirationTimestamp = 5;
-  optional double           executionPrice = 6;
-  optional int64            executedVolume = 7;
-  optional int64            utcLastUpdateTimestamp = 8;
-  optional double           baseSlippagePrice = 9;
-  optional int64            slippageInPoints = 10;
-  optional bool             closingOrder  = 11;
-  optional double           limitPrice    = 12;
-  optional double           stopPrice     = 13;
-  optional double           stopLoss      = 14;
-  optional double           takeProfit    = 15;
-  optional string           clientOrderId = 16;
-  optional uint32           timeInForce   = 17;
-  optional int64            positionId    = 18;
-  optional double           relativeStopLoss = 19;
-  optional double           relativeTakeProfit = 20;
-  optional bool             isStopOut     = 21;
-  optional bool             trailingStopLoss = 22;
-  optional uint32           stopTriggerMethod = 23;
+  optional int64            expirationTimestamp = 6;
+  optional double           executionPrice = 7;
+  optional int64            executedVolume = 8;
+  optional int64            utcLastUpdateTimestamp = 9;
+  optional double           baseSlippagePrice = 10;
+  optional int64            slippageInPoints = 11;
+  optional bool             closingOrder  = 12;
+  optional double           limitPrice    = 13;
+  optional double           stopPrice     = 14;
+  optional double           stopLoss      = 15;
+  optional double           takeProfit    = 16;
+  optional string           clientOrderId = 17;
+  optional uint32           timeInForce   = 18;
+  optional int64            positionId    = 19;
+  optional int64            relativeStopLoss = 20;
+  optional int64            relativeTakeProfit = 21;
+  optional bool             isStopOut     = 22;
+  optional bool             trailingStopLoss = 23;
+  optional uint32           stopTriggerMethod = 24;
 }
 
 message ProtoOAReconcileReq {
@@ -278,7 +286,10 @@ message ProtoOASymbol {
   optional int64  minVolume          = 10;
   optional int64  stepVolume         = 11;
   optional int64  maxExposure        = 12;
-  optional int64  lotSize            = 21;
+  // lotSize is canonical field 30 (NOT 21 — field 21 is the deprecated
+  // minCommission). Reading it at 21 yields 0 for XAUUSD → SYMBOL_NO_LOTSIZE
+  // and mis-sizes volume for any symbol where field 21 is non-zero.
+  optional int64  lotSize            = 30;
 }
 
 message ProtoOASymbolByIdReq {
@@ -421,14 +432,18 @@ message ProtoOACancelOrderReq {
   required int64  orderId             = 3;
 }
 
+// errorCode is canonical field 9 and isServerEvent field 10 (fields 6/7/8 are
+// deal / bonusDepositWithdraw / depositWithdraw upstream, which we don't decode).
+// An order-op rejection can ride here with errorCode set, so the field number
+// is on the money path — reading errorCode at 8 misses the reject entirely.
 message ProtoOAExecutionEvent {
   optional uint32          payloadType         = 1;
   required int64           ctidTraderAccountId = 2;
   required uint32          executionType       = 3;
   optional ProtoOAPosition position            = 4;
   optional ProtoOAOrder    order               = 5;
-  optional string          errorCode           = 8;
-  optional bool            isServerEvent       = 9;
+  optional string          errorCode           = 9;
+  optional bool            isServerEvent       = 10;
 }
 
 // ── Order-error event (payloadType 2132) ────────────────────────────────
@@ -437,11 +452,15 @@ message ProtoOAExecutionEvent {
 // hours, insufficient margin, etc.). Field numbers/types transcribed from
 // Spotware's ProtoOAOrderErrorEvent (OpenApiMessages.proto). This is a REJECT
 // on a money path — it MUST map to a CTraderError, never resolve as success.
+// Canonical field numbers are NOT sequential: errorCode=2, orderId=3,
+// ctidTraderAccountId=5, positionId=6, description=7. Getting these wrong
+// means the reject decodes to an empty errorCode and fails to map to a
+// CTraderError — reintroducing the 2132 phantom-success bug.
 message ProtoOAOrderErrorEvent {
   optional uint32 payloadType         = 1;
-  required int64  ctidTraderAccountId = 2;
-  required string errorCode           = 3;
-  optional int64  orderId             = 4;
-  optional int64  positionId          = 5;
-  optional string description         = 6;
+  required string errorCode           = 2;
+  optional int64  orderId             = 3;
+  required int64  ctidTraderAccountId = 5;
+  optional int64  positionId          = 6;
+  optional string description         = 7;
 }