@alexleekt/pi-ask-user-glimpse 0.3.1 → 0.4.1

package/tool/ask-user.ts

@@ -5,299 +5,13 @@ import { fileURLToPath } from "node:url";
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { prompt } from "glimpseui";
 import { terminalPrompt } from "../fallback/terminal-prompt.js";
-import type { AskUserPayload, Question } from "../shared/ask-user.js";
+import type { AnimationLevel, AskUserPayload, Question, ThemeMode } from "../shared/ask-user.js";
 import { formatResponse } from "./response-formatter.js";
 
 const _require = createRequire(import.meta.url);
 const __dirname = dirname(fileURLToPath(import.meta.url));
 
-/** ~100 common English stopwords for title extraction. */
-const STOPWORDS = new Set([
-    "a",
-    "an",
-    "the",
-    "is",
-    "are",
-    "was",
-    "were",
-    "be",
-    "been",
-    "being",
-    "have",
-    "has",
-    "had",
-    "do",
-    "does",
-    "did",
-    "will",
-    "would",
-    "could",
-    "should",
-    "may",
-    "might",
-    "must",
-    "shall",
-    "can",
-    "need",
-    "ought",
-    "used",
-    "to",
-    "of",
-    "in",
-    "for",
-    "on",
-    "with",
-    "at",
-    "by",
-    "from",
-    "as",
-    "into",
-    "through",
-    "during",
-    "before",
-    "after",
-    "above",
-    "below",
-    "between",
-    "under",
-    "again",
-    "further",
-    "then",
-    "once",
-    "here",
-    "there",
-    "when",
-    "where",
-    "why",
-    "how",
-    "all",
-    "each",
-    "few",
-    "more",
-    "most",
-    "other",
-    "some",
-    "such",
-    "no",
-    "nor",
-    "not",
-    "only",
-    "own",
-    "same",
-    "so",
-    "than",
-    "too",
-    "very",
-    "just",
-    "and",
-    "but",
-    "if",
-    "or",
-    "because",
-    "until",
-    "while",
-    "which",
-    "what",
-    "who",
-    "whom",
-    "this",
-    "that",
-    "these",
-    "those",
-    "am",
-    "it",
-    "its",
-    "we",
-    "our",
-    "you",
-    "your",
-    "they",
-    "their",
-    "them",
-    "he",
-    "him",
-    "his",
-    "she",
-    "her",
-    "i",
-    "me",
-    "my",
-    "mine",
-    "us",
-    "any",
-    "both",
-    "either",
-    "neither",
-    "one",
-    "two",
-    "first",
-    "last",
-    "another",
-    "every",
-    "many",
-    "much",
-    "several",
-    "let",
-    "new",
-    "use",
-    "using",
-    "make",
-    "made",
-    "get",
-    "got",
-    "go",
-    "going",
-    "want",
-    "wanted",
-    "like",
-    "liked",
-    "know",
-    "knew",
-    "known",
-    "think",
-    "thought",
-    "see",
-    "saw",
-    "seen",
-    "come",
-    "came",
-    "give",
-    "gave",
-    "given",
-    "take",
-    "took",
-    "taken",
-    "find",
-    "found",
-    "say",
-    "said",
-    "tell",
-    "told",
-    "ask",
-    "asked",
-    "work",
-    "worked",
-    "seem",
-    "seemed",
-    "feel",
-    "felt",
-    "try",
-    "tried",
-    "leave",
-    "left",
-    "call",
-    "called",
-    "good",
-    "well",
-    "better",
-    "best",
-    "bad",
-    "worse",
-    "worst",
-    "old",
-    "long",
-    "great",
-    "little",
-    "right",
-    "left",
-    "big",
-    "high",
-    "different",
-    "important",
-    "same",
-    "able",
-    "next",
-    "early",
-    "young",
-    "public",
-    "free",
-    "real",
-    "easy",
-    "clear",
-    "recent",
-    "local",
-    "social",
-    "full",
-    "small",
-    "large",
-    "possible",
-    "particular",
-    "available",
-    "special",
-    "certain",
-    "personal",
-    "open",
-    "general",
-    "enough",
-    "probably",
-    "actually",
-    "especially",
-    "finally",
-    "usually",
-    "perhaps",
-    "almost",
-    "simply",
-    "quickly",
-    "recently",
-    "already",
-    "eventually",
-    "suddenly",
-    "certainly",
-    "definitely",
-    "absolutely",
-    "completely",
-    "totally",
-    "entirely",
-    "exactly",
-    "specifically",
-    "particularly",
-    "especially",
-    "mainly",
-    "mostly",
-    "partly",
-    "fully",
-    "nearly",
-    "quite",
-    "rather",
-    "pretty",
-    "fairly",
-    "really",
-    "even",
-    "still",
-    "yet",
-    "ever",
-    "never",
-    "always",
-    "sometimes",
-    "often",
-    "usually",
-    "frequently",
-    "rarely",
-    "generally",
-    "typically",
-    "normally",
-    "largely",
-    "potentially",
-    "theoretically",
-    "practically",
-    "basically",
-    "essentially",
-    "fundamentally",
-    "primarily",
-    "chiefly",
-    "principally",
-    "partially",
-    "half",
-    "quarter",
-    "double",
-    "single",
-    "multiple",
-    "various",
-    "hundred",
-    "thousand",
-    "million",
-    "billion",
-]);
+import { STOPWORDS } from "../constants/stopwords.js";
 
 /** Extract a short title from a question by removing stopwords.
  *  Falls back to first 5 words if nothing meaningful remains.
@@ -356,12 +70,20 @@ export interface AskUserParams {
     allowSkip?: boolean;
     displayMode?: string;
     followCursor?: boolean;
+    theme?: ThemeMode;
+    animationLevel?: AnimationLevel;
+}
+
+export interface AskUserMetadata {
+    theme?: string;
+    animationLevel?: string;
 }
 
 export async function askUserHandler(
     params: AskUserParams,
     signal: AbortSignal | undefined,
     ctx: ExtensionContext,
+    onMetadata?: (metadata: AskUserMetadata) => void,
 ) {
     if (signal?.aborted) {
         return {
@@ -397,16 +119,31 @@ export async function askUserHandler(
         payloadType = "single-select";
     }
 
+    // If the question is long and no separate context was provided, auto-split
+    // the first sentence into the question and the rest into context.
+    let question = params.question;
+    let context = params.context;
+    if (!context && params.question.length > 120) {
+        const match = params.question.match(/^(.+?[.?!])(\s+|$)/);
+        if (match && match[0].length < params.question.length) {
+            question = match[1].trim();
+            context = params.question.slice(match[0].length).trim();
+        }
+    }
+
     const payload: AskUserPayload = {
         type: payloadType,
-        question: params.question,
-        context: params.context,
+        question,
+        context,
         options: normalizedOptions,
         questions: params.questions,
         allowMultiple,
         allowFreeform,
         allowComment,
         allowSkip: params.allowSkip,
+        sessionName: ctx.sessionManager.getSessionName(),
+        theme: params.theme,
+        animationLevel: params.animationLevel,
     };
 
     let result: Record<string, unknown> | null = null;
@@ -423,10 +160,16 @@ export async function askUserHandler(
                 .replace(/&/g, "\\u0026"),
         );
 
+        const sessionName = ctx.sessionManager.getSessionName();
+        const questionTitle = summarizeTitle(params.question);
+        const title = sessionName
+            ? `Pi · ${sessionName} · ${questionTitle}`
+            : `Pi · ${questionTitle}`;
+
         const options: Record<string, unknown> = {
             width: 1200,
             height: 900,
-            title: summarizeTitle(params.question),
+            title: title.length > 60 ? `${title.slice(0, 57)}…` : title,
         };
 
         if (params.followCursor) {
@@ -440,6 +183,11 @@ export async function askUserHandler(
         if (result === null || result?.__cancelled === true) {
             cancelled = true;
             result = null;
+        } else if (result && onMetadata) {
+            onMetadata({
+                theme: result.__theme as string | undefined,
+                animationLevel: result.__animationLevel as string | undefined,
+            });
         }
     } catch (err) {
         // Glimpse unavailable — fall back to terminal prompt

package/tool/response-formatter.ts

@@ -11,6 +11,7 @@ export interface AskResponse {
         kind: "selection" | "freeform";
         comment?: string;
     }[];
+    additionalComments?: string;
 }
 
 export interface AskToolDetails {
@@ -22,6 +23,10 @@ export interface AskToolDetails {
     error?: string;
 }
 
+function pickString(raw: unknown): string | undefined {
+    return raw ? String(raw) : undefined;
+}
+
 function normalizeKind(raw: unknown): AskResponse["kind"] {
     if (raw === "freeform" || raw === "questionnaire") return raw;
     return "selection";
@@ -51,9 +56,7 @@ function buildResponse(
                               entry.kind === "freeform"
                                   ? "freeform"
                                   : "selection",
-                          comment: entry.comment
-                              ? String(entry.comment)
-                              : undefined,
+                          comment: pickString(entry.comment),
                       };
                   })
                 : [],
@@ -69,7 +72,8 @@ function buildResponse(
     return {
         kind,
         selections,
-        comment: result.comment ? String(result.comment) : undefined,
+        comment: pickString(result.comment),
+        additionalComments: pickString(result.additionalComments),
     };
 }
 
@@ -77,12 +81,12 @@ function responseToText(response: AskResponse): string {
     if (response.kind === "freeform") {
         return response.text ?? "";
     }
+    const lines: string[] = [];
     const selections = response.selections ?? [];
-    let text = selections.join(", ");
-    if (response.comment) {
-        text += `\n\nComment: ${response.comment}`;
-    }
-    return text;
+    if (selections.length > 0) lines.push(selections.join(", "));
+    if (response.comment) lines.push(`Comment: ${response.comment}`);
+    if (response.additionalComments) lines.push(`Additional Comments: ${response.additionalComments}`);
+    return lines.join("\n\n");
 }
 
 export function formatResponse(