@alexgorbatchev/pi-skill-library 1.0.1 → 1.0.3

package/README.md

@@ -75,7 +75,7 @@ Invoke a library skill directly:
 
 Discovered library skills are registered as real extension slash commands at startup and reload, so they show up in slash-command autocomplete like other commands.
 
-On startup, the extension prints a library-discovery message into the transcript listing each discovered library root and its skills. Home-directory paths are rendered with the `~/` convention.
+On startup, the extension prints a library-discovery message into the transcript listing each discovered library root and its skills.
 
 Use the package info command to print the same report again:
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@alexgorbatchev/pi-skill-library",
-  "version": "1.0.1",
+  "version": "1.0.3",
   "description": "Pi extension that exposes skills-library roots through /library:<skill-name> commands.",
   "type": "module",
   "author": "Alex Gorbatchev",
@@ -46,7 +46,8 @@
     "typescript": "6.0.2"
   },
   "scripts": {
-    "check": "bun --bun oxfmt --write . && bun --bun oxlint . && tsgo --noEmit",
+    "fix": "bun --bun oxfmt --write .",
+    "check": "bun --bun oxfmt --check . && bun --bun oxlint . && tsgo --noEmit",
     "test": "PI_OFFLINE=1 bun x pi --no-extensions -e ./src/index.ts --list-models > /dev/null 2>&1",
     "test:local": "bun x pi -e ./src/index.ts"
   }

package/src/createLibraryReport.ts

@@ -1,16 +1,9 @@
 import { groupLibrarySummariesByScope } from "./groupLibrarySummariesByScope.js";
 import { replaceHomeDirectoryWithTilde } from "./replaceHomeDirectoryWithTilde.js";
-import type { ILibraryReportDetails, ILibrarySkillDiscovery, ILibrarySummary } from "./types.js";
+import type { ILibraryReportDetails, ILibrarySummary } from "./types.js";
 
-export function createLibraryReport(librarySkillDiscovery: ILibrarySkillDiscovery): string {
-  return createLibraryReportFromDetails({
-    diagnostics: librarySkillDiscovery.diagnostics,
-    librarySummaries: librarySkillDiscovery.librarySummaries,
-  });
-}
-
-export function createLibraryReportFromDetails(details: ILibraryReportDetails): string {
-  const lines = ["[Skills Library]"];
+export function createLibraryReport(details: ILibraryReportDetails): string {
+  const lines = ["[@alexgorbatchev/pi-skill-library]"];
   if (details.librarySummaries.length === 0) {
     lines.push("  No library skills were discovered.");
     return lines.join("\n");

package/src/groupLibrarySummariesByScope.ts

@@ -9,7 +9,7 @@ export function groupLibrarySummariesByScope(librarySummaries: ILibrarySummary[]
     librarySummariesByScope.set(displayScope, existingSummaries);
   }
 
-  const orderedScopes = ["project", "user", "path"];
+  const orderedScopes = ["project settings", "global settings", "path"];
   const orderedLibrarySummariesByScope = new Map<string, ILibrarySummary[]>();
   for (const orderedScope of orderedScopes) {
     const scopedSummaries = librarySummariesByScope.get(orderedScope);
@@ -29,9 +29,12 @@ export function groupLibrarySummariesByScope(librarySummaries: ILibrarySummary[]
 }
 
 function toDisplayScope(scope: ILibrarySummary["scope"]): string {
-  if (scope === "temporary") {
-    return "path";
+  switch (scope) {
+    case "project":
+      return "project settings";
+    case "user":
+      return "global settings";
+    case "temporary":
+      return "path";
   }
-
-  return scope;
 }

package/src/piSkillLibraryExtension.ts

@@ -1,4 +1,5 @@
-import type { ExtensionAPI, ExtensionContext, InputEventResult } from "@mariozechner/pi-coding-agent";
+import type { ImageContent, TextContent } from "@mariozechner/pi-ai";
+import type { ExtensionAPI, ExtensionContext, InputEventResult, Theme } from "@mariozechner/pi-coding-agent";
 import { Box, Text } from "@mariozechner/pi-tui";
 import { dirname } from "node:path";
 import { fileURLToPath } from "node:url";
@@ -7,17 +8,53 @@ import { discoverLibrarySkills } from "./discoverLibrarySkills.js";
 import { expandLibrarySkill } from "./expandLibrarySkill.js";
 import { parseLibraryCommand } from "./parseLibraryCommand.js";
 import { renderLibraryReport } from "./renderLibraryReport.js";
-import type { ILibraryReportDetails, ILibrarySkillDiscovery, MessageContent } from "./types.js";
+import type { ILibraryReportDetails, ILibrarySkillDiscovery } from "./types.js";
 
 const INFO_COMMAND_NAME = "pi-skill-library";
-const STARTUP_REPORT_MESSAGE_TYPE = "pi-skill-library.startup-report";
+const LIBRARY_MESSAGE_TYPE = "pi-skill-library.message";
 const extensionPackageRoot = dirname(dirname(fileURLToPath(import.meta.url)));
 const handledInputEventResult: InputEventResult = { action: "handled" };
 
+type LibraryMessageContent = string | (TextContent | ImageContent)[];
+type LibraryMessageLevel = "info" | "error";
+
+interface ILibraryMessageDetails {
+  level: LibraryMessageLevel;
+  reportDetails?: ILibraryReportDetails;
+}
+
 export default function piSkillLibraryExtension(pi: ExtensionAPI): void {
   let cachedLibrarySkillDiscovery: ILibrarySkillDiscovery | null = null;
   let cachedCwd = "";
 
+  pi.registerMessageRenderer<ILibraryMessageDetails>(LIBRARY_MESSAGE_TYPE, (message, _options, theme) => {
+    const details = message.details;
+    const content = getMessageTextContent(message.content);
+    const text =
+      details?.reportDetails === undefined
+        ? renderLibraryMessage(theme, content, details?.level ?? "info")
+        : renderLibraryReport(theme, details.reportDetails);
+    const box = new Box(0, 0);
+    box.addChild(new Text(text, 0, 0));
+    return box;
+  });
+
+  const sendLibraryMessage = (content: string, details: ILibraryMessageDetails): void => {
+    pi.sendMessage<ILibraryMessageDetails>({
+      customType: LIBRARY_MESSAGE_TYPE,
+      content,
+      display: true,
+      details,
+    });
+  };
+
+  const sendLibraryReport = (reportDetails: ILibraryReportDetails): void => {
+    sendLibraryMessage(createLibraryReport(reportDetails), {
+      level: "info",
+      reportDetails,
+    });
+  };
+
   const ensureLibrarySkillCommandsRegistered = (librarySkillDiscovery: ILibrarySkillDiscovery): void => {
     for (const librarySkill of librarySkillDiscovery.skills) {
       const commandName = createLibraryCommandName(librarySkill.name);
@@ -28,9 +65,9 @@ export default function piSkillLibraryExtension(pi: ExtensionAPI): void {
           const requestedSkill = refreshedLibrarySkillDiscovery.skillByName.get(librarySkill.name);
           if (requestedSkill === undefined) {
             if (ctx.hasUI) {
-              ctx.ui.notify(
+              sendLibraryMessage(
                 `Library skill is no longer available: ${librarySkill.name}. Run /reload if discovery changed.`,
-                "error",
+                { level: "error" },
               );
             }
             return;
@@ -69,24 +106,13 @@ export default function piSkillLibraryExtension(pi: ExtensionAPI): void {
     await refreshLibrarySkillDiscovery(ctx.cwd);
   };
 
-  pi.registerMessageRenderer(STARTUP_REPORT_MESSAGE_TYPE, (message, _options, theme) => {
-    const reportDetails = readLibraryReportDetails(message.details);
-    const reportText =
-      reportDetails === null ? getMessageTextContent(message.content) : renderLibraryReport(theme, reportDetails);
-    const box = new Box(0, 0);
-    box.addChild(new Text(reportText, 0, 0));
-    return box;
-  });
-
   pi.on("session_start", async (_event, ctx) => {
     invalidateLibrarySkillDiscovery();
     const librarySkillDiscovery = await refreshLibrarySkillDiscovery(ctx.cwd);
-    pi.sendMessage({
-      customType: STARTUP_REPORT_MESSAGE_TYPE,
-      content: createLibraryReport(librarySkillDiscovery),
-      display: true,
-      details: createLibraryReportDetails(librarySkillDiscovery),
-    });
+
+    if (ctx.hasUI) {
+      sendLibraryReport(createLibraryReportDetails(librarySkillDiscovery));
+    }
   });
   pi.on("session_before_switch", onSessionChanged);
   pi.on("session_before_fork", onSessionChanged);
@@ -96,24 +122,12 @@ export default function piSkillLibraryExtension(pi: ExtensionAPI): void {
     description: "Print the discovered skills-library roots and skills",
     handler: async (_args, ctx) => {
       const librarySkillDiscovery = await refreshLibrarySkillDiscovery(ctx.cwd);
-      pi.sendMessage({
-        customType: STARTUP_REPORT_MESSAGE_TYPE,
-        content: createLibraryReport(librarySkillDiscovery),
-        display: true,
-        details: createLibraryReportDetails(librarySkillDiscovery),
-      });
+      if (ctx.hasUI) {
+        sendLibraryReport(createLibraryReportDetails(librarySkillDiscovery));
+      }
     },
   });
 
-  pi.on("context", async (event) => {
-    return {
-      messages: event.messages.filter((message) => {
-        const messageCustomType = "customType" in message ? message.customType : undefined;
-        return messageCustomType !== STARTUP_REPORT_MESSAGE_TYPE;
-      }),
-    };
-  });
-
   pi.on("input", async (event, ctx): Promise<InputEventResult | undefined> => {
     const libraryCommand = parseLibraryCommand(event.text);
     if (libraryCommand === null) {
@@ -130,7 +144,9 @@ export default function piSkillLibraryExtension(pi: ExtensionAPI): void {
           : `Available library skills: ${availableSkillNames.join(", ")}`;
 
       if (ctx.hasUI) {
-        ctx.ui.notify(`Unknown library skill: ${libraryCommand.skillName}. ${availableSkillSummary}`, "error");
+        sendLibraryMessage(`Unknown library skill: ${libraryCommand.skillName}. ${availableSkillSummary}`, {
+          level: "error",
+        });
       }
 
       return handledInputEventResult;
@@ -148,50 +164,15 @@ function createLibraryReportDetails(librarySkillDiscovery: ILibrarySkillDiscover
   };
 }
 
-function readLibraryReportDetails(details: unknown): ILibraryReportDetails | null {
-  if (!isLibraryReportDetails(details)) {
-    return null;
-  }
-
-  return details;
-}
-
-function isLibraryReportDetails(value: unknown): value is ILibraryReportDetails {
-  if (typeof value !== "object" || value === null) {
-    return false;
+function renderLibraryMessage(theme: Theme, content: string, level: LibraryMessageLevel): string {
+  if (level === "error") {
+    return theme.fg("error", content);
   }
 
-  const diagnostics = Reflect.get(value, "diagnostics");
-  const librarySummaries = Reflect.get(value, "librarySummaries");
-  return (
-    Array.isArray(diagnostics) &&
-    diagnostics.every((diagnostic) => typeof diagnostic === "string") &&
-    Array.isArray(librarySummaries) &&
-    librarySummaries.every(isLibrarySummary)
-  );
-}
-
-function isLibrarySummary(value: unknown): value is ILibraryReportDetails["librarySummaries"][number] {
-  if (typeof value !== "object" || value === null) {
-    return false;
-  }
-
-  const libraryPath = Reflect.get(value, "libraryPath");
-  const scope = Reflect.get(value, "scope");
-  const skillNames = Reflect.get(value, "skillNames");
-  return (
-    typeof libraryPath === "string" &&
-    isLibrarySummaryScope(scope) &&
-    Array.isArray(skillNames) &&
-    skillNames.every((skillName) => typeof skillName === "string")
-  );
-}
-
-function isLibrarySummaryScope(value: unknown): value is ILibraryReportDetails["librarySummaries"][number]["scope"] {
-  return value === "project" || value === "user" || value === "temporary";
+  return content;
 }
 
-function getMessageTextContent(content: MessageContent): string {
+function getMessageTextContent(content: LibraryMessageContent): string {
   if (typeof content === "string") {
     return content;
   }

package/src/renderLibraryReport.ts

@@ -4,7 +4,7 @@ import { replaceHomeDirectoryWithTilde } from "./replaceHomeDirectoryWithTilde.j
 import type { ILibraryReportDetails } from "./types.js";
 
 export function renderLibraryReport(theme: Theme, details: ILibraryReportDetails): string {
-  const lines: string[] = [theme.fg("mdHeading", "[Skills Library]")];
+  const lines: string[] = [theme.fg("mdHeading", "[@alexgorbatchev/pi-skill-library]")];
   if (details.librarySummaries.length === 0) {
     lines.push(theme.fg("dim", "  No library skills were discovered."));
     return lines.join("\n");

package/src/types.ts

@@ -23,10 +23,3 @@ export interface ILibrarySkillDiscovery {
   libraryPaths: string[];
   librarySummaries: ILibrarySummary[];
 }
-
-export interface IMessageContentPart {
-  type: string;
-  text?: string;
-}
-
-export type MessageContent = string | IMessageContentPart[];