@alecsibilia/luca 14.0.0-alpha.20 → 14.0.0-alpha.21

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # @alecsibilia/luca
 
+## 14.0.0-alpha.21
+
+No changes in this release.
+
 ## 14.0.0-alpha.20
 
 No changes in this release.

package/board/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@luca/board",
-    "version": "14.0.0-alpha.20",
+    "version": "14.0.0-alpha.21",
     "private": true,
     "type": "module"
 }

package/board/server/luca-version.ts

@@ -1,2 +1,2 @@
 /** The Luca version of this board, stamped when the package was packed. */
-export const LUCA_VERSION: string = "14.0.0-alpha.20"
+export const LUCA_VERSION: string = "14.0.0-alpha.21"

package/engine/agents/common-instructions.ts

@@ -70,6 +70,9 @@ export const COMMON = `## Rules for every agent
 - Work only inside your worktree (your current folder).
 - Anything you change that your role may not change is undone after your turn, and your try counts as failed.
 - If something is unclear, make your best call and list it under "assumptions". Don't stop to ask.
+  - An assumption is a call you made that the owner might disagree with, such as a behaviour, a wording, or a limit the ticket didn't settle.
+  - These are not assumptions: following your instructions (such as relying on the engine's gates or reviewing only the new changes), the names you picked for internal code, and how you wrote a test.
+  - On a later turn, such as a fix round, list only new assumptions, not ones you already listed in an earlier turn.
 - "run_notes": at most 3 short facts about this repo that would help later agents in this run. Can be empty.
 - Finish by giving your structured result. A turn without one counts as failed.`
 
@@ -77,7 +80,7 @@ export const COMMON = `## Rules for every agent
 export const SANDBOX = `## Your sandbox
 - The engine runs the gates (tests, types, lint) outside your sandbox and gives you their results.
 - The sandbox blocks the network and local ports, writes outside your worktree, git internals, \`node_modules\`, lockfiles, test setup files, test files for roles that may not edit them, and secret files.
-- A command that fails only inside your sandbox isn't yours to fix or work around. Rely on the engine's gate results, and say so.`
+- A command that fails only inside your sandbox isn't yours to fix or work around. Rely on the engine's gate results.`
 
 /**
  * The writers' list of the repo's rule files (#646), named, not pasted in,

package/engine/intake/criteria-checks.ts

@@ -7,6 +7,10 @@ export const PIN_TEXT = 'pin the exact text'
 export const UNTESTABLE_TEXT =
     'no agent can check this; move it out of the acceptance criteria'
 
+/** The fix intake asks for when a criterion describes what stays as it is. */
+export const UNCHANGED_TEXT =
+    "describes behaviour that doesn't change, so no test can fail first; move it out of the acceptance criteria (for example into the ticket's notes)"
+
 /**
  * Text that leaves an agent to guess, caught anywhere in a criterion, inside
  * quotes and code spans too (#541).
@@ -28,6 +32,16 @@ const UNTESTABLE_ASKS: RegExp[] = [
     /\bADR[\s#-]*\d+/g,
 ]
 
+/**
+ * Phrases for behaviour that doesn't change, caught outside code spans only
+ * (#653): no test can fail first on them.
+ */
+const UNCHANGED_PHRASES: RegExp[] = [
+    /\bunchanged\b/gi,
+    /\bstays? the same\b/gi,
+    /\bas (?:today|before)\b/gi,
+]
+
 /** Inline code spans: a run of backticks up to the same run. */
 const CODE_SPAN = /(`+)[\s\S]*?\1/g
 
@@ -59,8 +73,10 @@ const asCode = (text: string): string => {
 
 /**
  * Intake's problems with one ticket's acceptance criteria: a placeholder
- * anywhere in a criterion, or an untestable ask (a screenshot, a changeset,
- * an ADR number) outside its code spans. Each problem names the ticket,
+ * anywhere in a criterion, an untestable ask (a screenshot, a changeset,
+ * an ADR number) outside its code spans, or, outside its code spans, words
+ * for behaviour that doesn't change ("unchanged", "stays the same", "as
+ * today", "as before"), once per criterion. Each problem names the ticket,
  * quotes the criterion, and says what to do. Pure. Empty when all are clean.
  *
  * @example
@@ -78,10 +94,10 @@ export const criteriaProblems = ({
         const named = `Acceptance criterion ${id} of #${ticket}`
         const quoted = `It reads: ${asCode(text)}`
         const placeholders = found({ text, patterns: PLACEHOLDERS })
-        const asks = found({
-            text: text.replace(CODE_SPAN, ' '),
-            patterns: UNTESTABLE_ASKS,
-        })
+        const prose = text.replace(CODE_SPAN, ' ')
+        const asks = found({ text: prose, patterns: UNTESTABLE_ASKS })
+        const unchanged =
+            found({ text: prose, patterns: UNCHANGED_PHRASES }).length > 0
         return [
             ...(placeholders.length === 0
                 ? []
@@ -93,5 +109,6 @@ export const criteriaProblems = ({
                 : [
                       `${named} asks for ${asks.map(asCode).join(', ')}: ${UNTESTABLE_TEXT}. ${quoted}`,
                   ]),
+            ...(unchanged ? [`${named} ${UNCHANGED_TEXT}. ${quoted}`] : []),
         ]
     })

package/engine/intake/intake-checks.ts

@@ -279,8 +279,9 @@ export const configProblems = ({
  * too, but still checked, so a later run can build it. The run builds the
  * rest. A ticket with neither ready label is still refused.
  *
- * Each open agent ticket's acceptance criteria must hold no placeholders and
- * no untestable asks (#541, `criteriaProblems`); the spec's text isn't checked.
+ * Each open agent ticket's acceptance criteria must hold no placeholders, no
+ * untestable asks (#541), and nothing about behaviour that doesn't change
+ * (#653), per `criteriaProblems`; the spec's text isn't checked.
  */
 export const checkIntake = ({
     config,

package/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@alecsibilia/luca",
     "description": "Luca: turns a spec on GitHub Issues into a reviewed pull request, run from Paseo with Claude Code",
-    "version": "14.0.0-alpha.20",
+    "version": "14.0.0-alpha.21",
     "license": "Apache-2.0",
     "author": "Alec Sibilia <sibilia.alec@gmail.com>",
     "homepage": "https://github.com/asibilia/luca-framework#readme",