@alcorexchange/alcor-swap-sdk 1.1.4 → 1.1.5

package/build/entities/trade.js

@@ -440,8 +440,14 @@ let Trade = exports.Trade = /*#__PURE__*/function () {
     value: function bestTradeExactIn(routes, currencyAmountIn, maxNumResults = 1) {
       (0, _tinyInvariant.default)(routes.length > 0, 'ROUTES');
 
-      // Pre-filter: remove routes with zero-liquidity pools
-      const validRoutes = routes.filter(route => route.pools.every(pool => pool.active && pool.liquidity > _internalConstants.ZERO));
+      // Pre-filter: drop routes touching empty pools (no positions at all).
+      // Use ticks presence, NOT current in-range liquidity: a pool can have
+      // liquidity === 0 at the current tick while all positions are out of range,
+      // yet still be tradeable (the swap crosses the gap into a position).
+      const validRoutes = routes.filter(route => route.pools.every(pool => {
+        var _ticks$length, _pool$tickDataProvide;
+        return pool.active && ((_ticks$length = (_pool$tickDataProvide = pool.tickDataProvider) === null || _pool$tickDataProvide === void 0 || (_pool$tickDataProvide = _pool$tickDataProvide.ticks) === null || _pool$tickDataProvide === void 0 ? void 0 : _pool$tickDataProvide.length) !== null && _ticks$length !== void 0 ? _ticks$length : 0) > 0;
+      }));
 
       // Helper: compute min liquidity (no overflow)
       const getMinLiquidity = route => {
@@ -493,8 +499,14 @@ let Trade = exports.Trade = /*#__PURE__*/function () {
     value: function bestTradeExactOut(routes, currencyAmountOut, maxNumResults = 1) {
       (0, _tinyInvariant.default)(routes.length > 0, 'ROUTES');
 
-      // Pre-filter: remove routes with zero-liquidity pools
-      const validRoutes = routes.filter(route => route.pools.every(pool => pool.active && pool.liquidity > _internalConstants.ZERO));
+      // Pre-filter: drop routes touching empty pools (no positions at all).
+      // Use ticks presence, NOT current in-range liquidity: a pool can have
+      // liquidity === 0 at the current tick while all positions are out of range,
+      // yet still be tradeable (the swap crosses the gap into a position).
+      const validRoutes = routes.filter(route => route.pools.every(pool => {
+        var _ticks$length2, _pool$tickDataProvide2;
+        return pool.active && ((_ticks$length2 = (_pool$tickDataProvide2 = pool.tickDataProvider) === null || _pool$tickDataProvide2 === void 0 || (_pool$tickDataProvide2 = _pool$tickDataProvide2.ticks) === null || _pool$tickDataProvide2 === void 0 ? void 0 : _pool$tickDataProvide2.length) !== null && _ticks$length2 !== void 0 ? _ticks$length2 : 0) > 0;
+      }));
 
       // Helper: compute min liquidity (no overflow)
       const getMinLiquidity = route => {
@@ -570,8 +582,14 @@ let Trade = exports.Trade = /*#__PURE__*/function () {
       (0, _tinyInvariant.default)(_routes.length > 0, 'ROUTES');
       (0, _tinyInvariant.default)(percents.length > 0, 'PERCENTS');
 
-      // Pre-filter: remove routes with zero-liquidity or inactive pools
-      const validRoutes = _routes.filter(route => route.pools.every(pool => pool.active && pool.liquidity > _internalConstants.ZERO));
+      // Pre-filter: drop routes touching empty pools (no positions at all).
+      // Use ticks presence, NOT current in-range liquidity: a pool can have
+      // liquidity === 0 at the current tick while all positions are out of range,
+      // yet still be tradeable (the swap crosses the gap into a position).
+      const validRoutes = _routes.filter(route => route.pools.every(pool => {
+        var _ticks$length3, _pool$tickDataProvide3;
+        return pool.active && ((_ticks$length3 = (_pool$tickDataProvide3 = pool.tickDataProvider) === null || _pool$tickDataProvide3 === void 0 || (_pool$tickDataProvide3 = _pool$tickDataProvide3.ticks) === null || _pool$tickDataProvide3 === void 0 ? void 0 : _pool$tickDataProvide3.length) !== null && _ticks$length3 !== void 0 ? _ticks$length3 : 0) > 0;
+      }));
 
       // Helper: compute min liquidity for a route (no overflow)
       const getMinLiquidity = route => {

package/build/esm/entities/trade.js

@@ -431,8 +431,14 @@ export let Trade = /*#__PURE__*/function () {
     value: function bestTradeExactIn(routes, currencyAmountIn, maxNumResults = 1) {
       invariant(routes.length > 0, 'ROUTES');
 
-      // Pre-filter: remove routes with zero-liquidity pools
-      const validRoutes = routes.filter(route => route.pools.every(pool => pool.active && pool.liquidity > ZERO));
+      // Pre-filter: drop routes touching empty pools (no positions at all).
+      // Use ticks presence, NOT current in-range liquidity: a pool can have
+      // liquidity === 0 at the current tick while all positions are out of range,
+      // yet still be tradeable (the swap crosses the gap into a position).
+      const validRoutes = routes.filter(route => route.pools.every(pool => {
+        var _ticks$length, _pool$tickDataProvide;
+        return pool.active && ((_ticks$length = (_pool$tickDataProvide = pool.tickDataProvider) === null || _pool$tickDataProvide === void 0 || (_pool$tickDataProvide = _pool$tickDataProvide.ticks) === null || _pool$tickDataProvide === void 0 ? void 0 : _pool$tickDataProvide.length) !== null && _ticks$length !== void 0 ? _ticks$length : 0) > 0;
+      }));
 
       // Helper: compute min liquidity (no overflow)
       const getMinLiquidity = route => {
@@ -484,8 +490,14 @@ export let Trade = /*#__PURE__*/function () {
     value: function bestTradeExactOut(routes, currencyAmountOut, maxNumResults = 1) {
       invariant(routes.length > 0, 'ROUTES');
 
-      // Pre-filter: remove routes with zero-liquidity pools
-      const validRoutes = routes.filter(route => route.pools.every(pool => pool.active && pool.liquidity > ZERO));
+      // Pre-filter: drop routes touching empty pools (no positions at all).
+      // Use ticks presence, NOT current in-range liquidity: a pool can have
+      // liquidity === 0 at the current tick while all positions are out of range,
+      // yet still be tradeable (the swap crosses the gap into a position).
+      const validRoutes = routes.filter(route => route.pools.every(pool => {
+        var _ticks$length2, _pool$tickDataProvide2;
+        return pool.active && ((_ticks$length2 = (_pool$tickDataProvide2 = pool.tickDataProvider) === null || _pool$tickDataProvide2 === void 0 || (_pool$tickDataProvide2 = _pool$tickDataProvide2.ticks) === null || _pool$tickDataProvide2 === void 0 ? void 0 : _pool$tickDataProvide2.length) !== null && _ticks$length2 !== void 0 ? _ticks$length2 : 0) > 0;
+      }));
 
       // Helper: compute min liquidity (no overflow)
       const getMinLiquidity = route => {
@@ -561,8 +573,14 @@ export let Trade = /*#__PURE__*/function () {
       invariant(_routes.length > 0, 'ROUTES');
       invariant(percents.length > 0, 'PERCENTS');
 
-      // Pre-filter: remove routes with zero-liquidity or inactive pools
-      const validRoutes = _routes.filter(route => route.pools.every(pool => pool.active && pool.liquidity > ZERO));
+      // Pre-filter: drop routes touching empty pools (no positions at all).
+      // Use ticks presence, NOT current in-range liquidity: a pool can have
+      // liquidity === 0 at the current tick while all positions are out of range,
+      // yet still be tradeable (the swap crosses the gap into a position).
+      const validRoutes = _routes.filter(route => route.pools.every(pool => {
+        var _ticks$length3, _pool$tickDataProvide3;
+        return pool.active && ((_ticks$length3 = (_pool$tickDataProvide3 = pool.tickDataProvider) === null || _pool$tickDataProvide3 === void 0 || (_pool$tickDataProvide3 = _pool$tickDataProvide3.ticks) === null || _pool$tickDataProvide3 === void 0 ? void 0 : _pool$tickDataProvide3.length) !== null && _ticks$length3 !== void 0 ? _ticks$length3 : 0) > 0;
+      }));
 
       // Helper: compute min liquidity for a route (no overflow)
       const getMinLiquidity = route => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@alcorexchange/alcor-swap-sdk",
-  "version": "1.1.4",
+  "version": "1.1.5",
   "description": "",
   "main": "build/index.js",
   "module": "build/esm/index.js",