@alanwang-merit/meritdata-platform-skill-package 1.0.9 → 1.0.11

package/skills/meritdata-platform-cloud-dev/references/scenario-contract.md

@@ -1,75 +0,0 @@
-# 场景契约
-
-> 本文件定义 `meritdata-platform-cloud-dev` 处理的 7 类动作及其路由契约。
-> 来源：研发版 `meritdata-cloud-dev/references/scenario-contract.md` v3.1.0，本文件做了**精简**（移除内部模块细节，保留动作骨架）。
-
----
-
-## 1. 动作路由（7 类）
-
-| 动作 | 典型输入 | 主要输出 | 内部模块 | 当前整合包对应 skill |
-|------|---------|---------|---------|-------------------|
-| **能力查询** | 平台有什么人员/流程/缓存/附件能力 | 能力路径 + 证据 + 版本 + 边界 | `merit-cloud-platform` | `meritdata-platform-playbook`（L1 路由）+ 本 skill |
-| **集成查询** | 如何接 Feign / 认证 / 流程 / 消息 / 业务审计 | 契约候选 + 依赖 + GAP + 联调清单 | `merit-cloud-feign-api` / `meritdata-platform-bpm` / `merit-cloud-msg-job` / `merit-cloud-logging` | `meritdata-platform-data-access` / `meritdata-platform-bpm` / `meritdata-platform-job` / `meritdata-platform-operation-log` |
-| **方案设计** | 新系统 / 模块关系 / 数据边界 / 接口方案 | 服务 + 数据模型 + 接口 + 验证方案 | `merit-cloud-domain-model` / `merit-cloud-data-boundary` / `meritdata-platform-frontend` | `meritdata-platform-domain-model` / `meritdata-platform-data-boundary` |
-| **新工程** | scaffold + 模块 manifest | 完整前后端工程 + SQL + 文档 + 验证 | `merit-cloud-gen` + `merit-code-spec` + 相关平台模块 | `meritdata-bootstrap-2nd-dev`（L4 工具）+ `meritdata-platform-2nd-dev-check` |
-| **存量新增模块** | project_context + create_module | 模块补丁 + SQL migration + 接入清单 | `merit-cloud-gen` + `merit-cloud-domain-model` + `merit-code-spec` | `meritdata-platform-domain-model` + `meritdata-platform-code-spec` |
-| **已有模块扩展** | 真实源码 + 字段/API/页面/流程需求 | 符号级最小修改 + 迁移 + 回归结果 | `merit-cloud-gen` + `merit-code-spec` + 命中的专项模块 | 各 L2/L3 skill + `meritdata-platform-code-review` |
-| **项目验证** | manifest / 源码目录 / 工程 ZIP | 强制违规 + 建议 + 哈希 + 编译边界 | `merit-code-spec` + `merit-cloud-data-boundary` + 治理工具 | `meritdata-platform-2nd-dev-check`（L4）+ `tools/skill-vetter` + `tools/skill-stocktake` |
-
----
-
-## 2. 平台版本
-
-- **默认版本**：`6.13.2`
-- **不得静默使用**：必须显式声明用户项目使用的版本
-- **存量项目**：优先从 POM 和真实依赖读取版本
-- **路径/签名/返回包装/依赖**：不可跨版本照搬
-
----
-
-## 3. 输出状态（5 档）
-
-| 状态 | 含义 | 处置 |
-|------|------|------|
-| `PASS` | 适用门禁通过且无声明缺口 | 可交付 |
-| `PASS_WITH_SERVICE_REQUIREMENTS` | 平台语义存在，远程契约尚未接入 | 需联调 |
-| `PASS_WITH_DECLARED_GAPS` | 结构可用，但存在明确待联调或待取证能力 | 需补 GAP |
-| `NOT_RUN_REQUIRES_MERGE` | 存量模块补丁必须合入原项目后构建 | 不宣称编译通过 |
-| `FAIL` | 触发规范 / 数据边界 / manifest / 构建强制规则 | 阻断 |
-
----
-
-## 4. 强契约（与 playbook 的关键差异）
-
-| 维度 | playbook | 本 skill |
-|------|---------|---------|
-| 主入口 | 单 skill 路由 | **一个请求只能有一个主入口** |
-| 复合需求 | 多 skill 串联（flows.md）| **主入口 + 补充 modules 内部加载**，不让用户逐个选择 |
-| 模块来源 | references/intent-routing.md | `references/modules-mapping.md`（22 modules）|
-| 角色 | 路由器 | 执行引擎 |
-
----
-
-## 5. 决策约束（与 rules/code-dev-rules.md §八 联动）
-
-- 二开业务库**不得**连接或映射 cloud 平台表（`PF_` 前缀）
-- 平台 Entity 与 Q 类**只在同 JVM 且已验证依赖时使用**；独立二开服务**必须**转 Feign/API
-- 平台接口、Swagger/HTTP、Feign、本地 Bean、DTO、版本差异等**只使用随 Skill 发布的离线知识库与已登记证据**；**不得**在生成代码时要求用户提供平台源码、解压/反编译 Jar、访问维护人员本机目录或重新取证
-- 人员、部门、角色、字典、附件、富文本和流程字段**自动联动**对应公共能力（org-user-api / lookup-api / permission / file / bpm）
-- 业务表默认小写蛇形且**不使用** `PF_`；实体使用大驼峰
-- Git/SVN 状态和差异**只读**，提交**始终**由用户手动完成
-- 不生成 AI 开发 Journal；`merit-cloud-logging` 只处理生成后业务系统的运行审计（不处理 AI 自身）
-
----
-
-## 6. 相关资源
-
-| 资源 | 路径 |
-|------|------|
-| 22 modules 映射 | [modules-mapping.md](modules-mapping.md) |
-| skill 元数据 + 路由场景 | [skill-suite.json](skill-suite.json) |
-| schema | [skill-suite.schema.json](skill-suite.schema.json) |
-| 铁律前置约束 | `meritdata-platform-suite/rules/code-dev-rules.md §八` |
-| 顶层路由器 | `meritdata-platform-suite/skills/meritdata-platform-playbook/SKILL.md` |
-| 研发版源文件 | `研发skills/skills/meritdata-cloud-dev/references/scenario-contract.md` |

package/skills/meritdata-platform-cloud-dev/references/skill-suite.json

@@ -1,52 +0,0 @@
-{
-  "$schema": "./skill-suite.schema.json",
-  "schema_version": "1.0.0",
-  "suite_version": "1.0.0",
-  "platform_profiles_ref": "../references/modules-mapping.md",
-  "policies": {
-    "unknown_skill": "fail",
-    "unknown_platform_version": "fail",
-    "incubating_implicit_route": false,
-    "one_primary_per_route": true
-  },
-  "skills": [
-    {"id":"meritdata-platform-bpm","path":"meritdata-platform-bpm","lifecycle":"stable","kind":"integration","owner":"workflow","primary_capabilities":["workflow.runtime"],"excludes":["file.lifecycle","message.delivery"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-bpm"]},
-    {"id":"merit-cloud-config","path":"merit-cloud-config","lifecycle":"stable","kind":"knowledge","owner":"platform-config","primary_capabilities":["config.runtime","security.policy"],"excludes":["auth.code-generation"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-nacos-config","meritdata-platform-platform-config"]},
-    {"id":"merit-cloud-domain-model","path":"merit-cloud-domain-model","lifecycle":"stable","kind":"design","owner":"architecture","primary_capabilities":["domain.relationship-modeling"],"excludes":["code.rendering"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-domain-model"]},
-    {"id":"merit-cloud-data-boundary","path":"merit-cloud-data-boundary","lifecycle":"stable","kind":"governance","owner":"data-architecture","primary_capabilities":["data.platform-business-isolation"],"excludes":["datasource.metadata","integration.masterdata-sync"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-data-boundary"]},
-    {"id":"merit-cloud-feign-api","path":"merit-cloud-feign-api","lifecycle":"stable","kind":"integration","owner":"service-contract","primary_capabilities":["service.internal-feign"],"excludes":["integration.external-publishing"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-data-access"]},
-    {"id":"merit-cloud-gen","path":"merit-cloud-gen","lifecycle":"stable","kind":"generator","owner":"code-generation","primary_capabilities":["code.rendering","auth.code-generation"],"excludes":["service.fact-ownership"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-bootstrap-2nd-dev","meritdata-platform-2nd-dev-check"]},
-    {"id":"meritdata-platform-impexp","path":"meritdata-platform-impexp","lifecycle":"stable","kind":"integration","owner":"data-exchange","primary_capabilities":["data.excel-import-export"],"excludes":["file.lifecycle"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-impexp"]},
-    {"id":"merit-cloud-logging","path":"merit-cloud-logging","lifecycle":"stable","kind":"integration","owner":"audit","primary_capabilities":["audit.business-operation"],"excludes":[],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-operation-log"]},
-    {"id":"merit-cloud-msg-job","path":"merit-cloud-msg-job","lifecycle":"stable","kind":"integration","owner":"message-schedule","primary_capabilities":["message.delivery","schedule.job"],"excludes":["cache.pubsub"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-job","meritdata-platform-message-center"]},
-    {"id":"merit-cloud-platform","path":"merit-cloud-platform","lifecycle":"stable","kind":"router","owner":"platform-architecture","primary_capabilities":["knowledge.capability-graph"],"excludes":["domain.implementation"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-cloud-dev"]},
-    {"id":"meritdata-platform-org-user-api","path":"meritdata-platform-org-user-api","lifecycle":"stable","kind":"integration","owner":"platform-services","primary_capabilities":["service.organization-directory","service.authorization"],"excludes":["service.internal-feign","integration.masterdata-sync"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-org-user-api","meritdata-platform-lookup-api","meritdata-platform-permission"]},
-    {"id":"meritdata-platform-data-access","path":"meritdata-platform-data-access","lifecycle":"beta","kind":"knowledge","owner":"platform-entity-contract","primary_capabilities":["entity.platform-querydsl-index"],"excludes":["data.platform-business-isolation","service.internal-feign"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-data-access"]},
-    {"id":"meritdata-platform-frontend","path":"meritdata-platform-frontend","lifecycle":"stable","kind":"integration","owner":"frontend-platform","primary_capabilities":["ui.platform-components"],"excludes":["http.transport","code.rendering"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-frontend","meritdata-platform-ui-components"]},
-    {"id":"merit-cloud-utils","path":"merit-cloud-utils","lifecycle":"stable","kind":"knowledge","owner":"backend-runtime","primary_capabilities":["runtime.utility-session","runtime.date-id-crypto"],"excludes":["config.runtime"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-session","meritdata-platform-sm-crypto"]},
-    {"id":"merit-code-spec","path":"merit-code-spec","lifecycle":"stable","kind":"governance","owner":"quality","primary_capabilities":["quality.code-policy"],"excludes":["code.rendering"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-code-spec","meritdata-platform-code-review"]},
-    {"id":"merit-skill-governance","path":"merit-skill-governance","lifecycle":"stable","kind":"governance","owner":"skill-governance","primary_capabilities":["governance.skill-suite"],"excludes":["domain.implementation"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["tools/skill-vetter","tools/skill-stocktake","tools/skill-authoring-workflow"]},
-    {"id":"merit-cloud-cache","path":"merit-cloud-cache","lifecycle":"stable","kind":"integration","owner":"platform-runtime","primary_capabilities":["cache.kv","cache.hash","cache.queue","cache.counter","cache.pubsub"],"excludes":["message.delivery","lock.reliable-distributed"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified"},"maps_to":["meritdata-platform-cache"]},
-    {"id":"merit-cloud-file","path":"merit-cloud-file","lifecycle":"beta","kind":"integration","owner":"file-lifecycle","primary_capabilities":["file.lifecycle","file.security"],"excludes":["data.excel-import-export","workflow.runtime"],"supported_profiles":{"6.12.1":"compatible","6.13.2":"verified"},"maps_to":[],"gap":"待补：附件上传/下载/孤儿清理独立 references"},
-    {"id":"merit-cloud-datasource","path":"merit-cloud-datasource","lifecycle":"beta","kind":"integration","owner":"data-platform","primary_capabilities":["datasource.metadata","datasource.dynamic-pool","datasource.safe-sql"],"excludes":["domain.repository","data.etl"],"supported_profiles":{"6.10.1":"compatible","6.12.1":"verified","6.13.2":"verified-distribution"},"maps_to":[],"gap":"待补：数据源元数据 + 动态连接池 references"},
-    {"id":"merit-cloud-webapi","path":"merit-cloud-webapi","lifecycle":"beta","kind":"integration","owner":"external-api","primary_capabilities":["webapi.catalog","webapi.app-auth"],"excludes":["service.internal-feign","integration.masterdata-sync"],"supported_profiles":{"6.12.1":"compatible","6.13.2":"verified"},"maps_to":[],"gap":"待补：对外 WebAPI（App-Key/Token）references"},
-    {"id":"merit-cloud-masterdata-sync","path":"merit-cloud-masterdata-sync","lifecycle":"beta","kind":"integration","owner":"masterdata-integration","primary_capabilities":["integration.masterdata-sync"],"excludes":["service.organization-directory","data.etl"],"supported_profiles":{"6.12.1":"compatible","6.13.2":"verified"},"maps_to":[],"gap":"待补：HR/组织人员同步（增量同步 + 失败重放）references"},
-    {"id":"merit-cloud-http-client","path":"merit-cloud-http-client","lifecycle":"beta","kind":"integration","owner":"frontend-transport","primary_capabilities":["http.transport","http.service-registry"],"excludes":["ui.platform-components","service.internal-feign","webapi.app-auth"],"supported_profiles":{"6.12.1":"compatible","6.13.2":"verified"},"maps_to":[],"gap":"待补：前端 HTTP 客户端 + 服务注册 references"}
-  ],
-  "route_scenarios": [
-    {"id":"route.existing-add-module","prompt":"在现有项目新增采购申请模块，保留原工程配置","expected_primary":"merit-cloud-gen","allowed_supplemental":["merit-cloud-domain-model","merit-code-spec","meritdata-platform-impexp"]},
-    {"id":"route.existing-add-workflow","prompt":"给现有报销模块增加审批流程、人员选择和消息通知","expected_primary":"merit-cloud-gen","allowed_supplemental":["meritdata-platform-bpm","meritdata-platform-org-user-api","merit-cloud-msg-job","merit-code-spec"]},
-    {"id":"route.person-selector","prompt":"业务表单选择人员并回填名称","expected_primary":"meritdata-platform-org-user-api","allowed_supplemental":["meritdata-platform-frontend","merit-cloud-gen"]},
-    {"id":"route.workflow-attachment","prompt":"审批表上传附件并随流程归档","expected_primary":"meritdata-platform-bpm","allowed_supplemental":["merit-cloud-file"]},
-    {"id":"route.excel-import","prompt":"批量导入 Excel 并导出错误明细","expected_primary":"meritdata-platform-impexp","allowed_supplemental":["merit-cloud-logging"]},
-    {"id":"route.cache-ttl","prompt":"用平台 Redis 做租户隔离的 TTL 缓存和原子计数","expected_primary":"merit-cloud-cache","allowed_supplemental":["merit-cloud-config","merit-code-spec"]},
-    {"id":"route.business-file","prompt":"普通业务附件上传、回显、下载、删除和孤儿清理","expected_primary":"merit-cloud-file","allowed_supplemental":["meritdata-platform-frontend","merit-cloud-config"],"gap":"需先补 merit-cloud-file references"},
-    {"id":"route.datasource-metadata","prompt":"检查数据源连通性并读取 schema table column 元数据","expected_primary":"merit-cloud-datasource","allowed_supplemental":["merit-cloud-config"],"gap":"需先补 merit-cloud-datasource references"},
-    {"id":"route.cloud-data-boundary","prompt":"二开项目查询 cloud 库人员组织数据并设计多表查询","expected_primary":"merit-cloud-data-boundary","allowed_supplemental":["merit-cloud-domain-model","merit-cloud-feign-api","merit-cloud-gen"]},
-    {"id":"route.publish-webapi","prompt":"向外部 ERP 发布一个带 App-Key 和 App-Token 的接口","expected_primary":"merit-cloud-webapi","allowed_supplemental":["merit-cloud-logging"],"gap":"需先补 merit-cloud-webapi references"},
-    {"id":"route.sync-masterdata","prompt":"把外部组织人员角色增量同步到平台并支持失败重放","expected_primary":"merit-cloud-masterdata-sync","allowed_supplemental":["merit-cloud-webapi","merit-cloud-logging"],"gap":"需先补 merit-cloud-masterdata-sync references"},
-    {"id":"route.frontend-multi-service","prompt":"前端同时调用业务、system-manager 和 bpm-engine 并保留平台签名","expected_primary":"merit-cloud-http-client","allowed_supplemental":["meritdata-platform-frontend","merit-cloud-gen"],"gap":"需先补 merit-cloud-http-client references"},
-    {"id":"route.platform-entity-qclass","prompt":"同 JVM 项目核对平台人员实体字段并用 QueryDSL Q 类查询","expected_primary":"meritdata-platform-data-access","allowed_supplemental":["meritdata-platform-org-user-api","merit-cloud-config"]}
-  ],
-  "aliases": []
-}

package/skills/meritdata-platform-cloud-dev/references/skill-suite.schema.json

@@ -1,23 +0,0 @@
-{
-  "$schema": "https://json-schema.org/draft/2020-12/schema",
-  "$id": "https://meritdata.example/schemas/skill-suite.schema.json",
-  "type": "object",
-  "required": ["schema_version", "suite_version", "platform_profiles_ref", "policies", "skills", "route_scenarios", "aliases"],
-  "properties": {
-    "skills": {
-      "type": "array",
-      "items": {
-        "type": "object",
-        "required": ["id", "path", "lifecycle", "kind", "owner", "primary_capabilities", "excludes", "supported_profiles"],
-        "properties": {
-          "id": {"type": "string", "pattern": "^[a-z0-9-]+$"},
-          "path": {"type": "string"},
-          "lifecycle": {"enum": ["incubating", "beta", "stable", "deprecated", "retired"]},
-          "primary_capabilities": {"type": "array", "minItems": 1, "items": {"type": "string"}, "uniqueItems": true},
-          "excludes": {"type": "array", "items": {"type": "string"}, "uniqueItems": true},
-          "supported_profiles": {"type": "object", "minProperties": 1}
-        }
-      }
-    }
-  }
-}

package/skills/meritdata-platform-code-review/SKILL.md

@@ -1,42 +0,0 @@
----
-name: meritdata-platform-code-review
-description: |
-  代码审查。Java 代码审查清单；性能/安全/可维护性维度；code-spec 规则的实施场景。
-  触发场景：二开代码 PR review / Java 编码规范检查 / 性能问题排查 / 安全漏洞扫描。
-  何时不用：数据访问专项 → 用 data-access-review；测试用例 → 用 test-case。
-metadata:
-  version: "1.0.0"
-  author: petroleum+rd
-  source: petroleum+rd
-  date_added: "2026-09-07"
-  last_modified: "2026-09-07"
-  risk: medium
-  layer: L2
-  sub-layer: L2-M
-  stack: methodology
-allowed-tools: Read, Grep, Glob, Bash
----
-
-# 代码审查（code-review）
-
-## 触发
-- 二开 Java 代码 PR review
-- 性能问题代码定位（SQL/N+1/缓存）
-- 安全漏洞代码扫描（注入/越权/敏感）
-- 可维护性评估（命名/复杂度/重复）
-
-## 不触发
-- 数据访问专项（PF_/Feign/Entity）→ 用 `meritdata-platform-data-access-review`
-- 测试用例设计 → 用 `meritdata-platform-test-case`
-- 业务模型设计 → 用 `meritdata-platform-domain-model`
-
-## 前置约束
-- 审查**必须**涵盖 4 维度：正确性 / 性能 / 安全 / 可维护性
-- 严重问题（数据泄露/事务错误）**零容忍**
-- 审查结论**必须**有依据（具体行号 + 反例 + 修复建议）
-
-## 路由
-- 4 维度审查清单 → [references/guide.md](references/guide.md)
-- 性能审查（N+1/缓存/SQL）→ [references/performance.md](references/performance.md)
-- 安全审查（注入/越权/敏感）→ [references/security.md](references/security.md)
-- [SKILL.md](../SKILL.md)

package/skills/meritdata-platform-code-review/references/guide.md

@@ -1,173 +0,0 @@
-# 代码审查基础指南（code-review）
-
-> Java 代码 4 维度审查：正确性 / 性能 / 安全 / 可维护性。
-
----
-
-## 1. 4 维度清单
-
-### 1.1 正确性
-
-- [ ] 业务逻辑正确（边界、空值、状态机）
-- [ ] 异常处理完整（不吞异常 / 不空 catch）
-- [ ] 事务边界正确（@Transactional 范围）
-- [ ] 并发安全（线程安全集合、锁）
-
-### 1.2 性能
-
-- [ ] 无 N+1 查询
-- [ ] 无循环 DB / Feign
-- [ ] SQL 走索引
-- [ ] 缓存合理（key 带用户/租户）
-- [ ] 大对象不序列化
-
-### 1.3 安全
-
-- [ ] 无 SQL 拼接
-- [ ] 无 XSS（HTML 渲染转义）
-- [ ] 无越权（资源 + 数据权限）
-- [ ] 敏感数据脱敏（日志、响应）
-- [ ] 无硬编码密钥
-
-### 1.4 可维护性
-
-- [ ] 命名规范（类/方法/常量）
-- [ ] 方法长度 ≤ 50 行
-- [ ] 无重复代码
-- [ ] 注释解释"为什么"
-- [ ] 测试覆盖核心路径
-
----
-
-## 2. 审查流程
-
-```
-PR 创建
-   ↓
-1. 自动 CI（编译、扫描、测试）
-   ↓
-2. Reviewer 审查
-   ↓ 评审
-3. 评论（必须含：行号 + 问题 + 建议）
-   ↓
-4. 修改 → 重新审查
-   ↓
-5. 批准 → 合并
-```
-
-### 2.1 评审评论模板
-
-```markdown
-**问题**：<具体问题>
-**位置**：<文件:行号>
-**影响**：<严重程度>
-**建议**：<修复方案 + 代码示例>
-**优先级**：🔴 阻断 / 🟠 必须 / 🟢 建议
-```
-
-## 3. 严重度
-
-| 等级 | 处理 | 例子 |
-|------|------|------|
-| 🔴 阻断 | 必须修复才能合并 | 内存泄漏、数据丢失、安全漏洞 |
-| 🟠 必须 | 必须修复（可在 follow-up）| 性能问题、命名错误 |
-| 🟢 建议 | 后续重构 | 重复代码、注释不全 |
-
-## 4. 评审检查清单
-
-### 4.1 Controller 层
-
-- [ ] URL 命名规范（名词、复数、连字符）
-- [ ] HTTP 方法正确（GET/POST/PUT/DELETE）
-- [ ] 响应包装（`Result.success(data)`）
-- [ ] 参数校验（@Valid + JSR-303）
-- [ ] 权限校验（@PreAuthorize）
-- [ ] 异常处理（@ExceptionHandler）
-- [ ] 文档注解（@OpenAPIDefinition）
-
-### 4.2 Service 层
-
-- [ ] 接口和实现分离（IXxxService / XxxServiceImpl）
-- [ ] 事务边界（@Transactional）
-- [ ] 业务校验（前置 + 后置）
-- [ ] 不在循环内调用外部资源
-- [ ] 不吞异常
-- [ ] 不返回 null（用空集合 / Optional）
-
-### 4.3 Repository 层
-
-- [ ] 方法命名（findXxx / listXxx / saveXxx）
-- [ ] 无 SQL 拼接
-- [ ] 无 N+1
-- [ ] 索引走通（EXPLAIN）
-- [ ] 软删除穿透（findXxxIncludingDeleted）
-
-### 4.4 通用
-
-- [ ] 无硬编码常量
-- [ ] 无死代码
-- [ ] 无过度嵌套（≤ 3 层）
-- [ ] 日志规范（INFO/WARN/ERROR 正确）
-
-## 5. ❌ 反模式
-
-### 5.1 ❌ 评审无依据
-
-```markdown
-// ❌ 错
-这段代码有问题。
-```
-
-```markdown
-// ✅ 正确
-**问题**：N+1 查询
-**位置**：OrderService.list():42
-**影响**：1000 订单 → 1000 次 Feign，RT 30s
-**建议**：用 userClient.listByIds 批量装配
-**优先级**：🔴
-```
-
-### 5.2 ❌ 评审不区分严重度
-
-```markdown
-// ❌ 错
-这个变量名不好。这段代码有 SQL 注入。这两个都得改。
-```
-
-✅ 区分 🔴 阻断 / 🟠 必须 / 🟢 建议。
-
-### 5.3 ❌ 评审不写建议
-
-```markdown
-// ❌ 错
-这个方法太长了。
-```
-
-```markdown
-// ✅ 正确
-**问题**：方法 80 行（>50）
-**建议**：拆成 validate + calculate + save 三个方法
-**优先级**：🟢
-```
-
-## 6. 评审效率
-
-### 6.1 时间
-
-- 简单 PR（< 200 行）：15-30 分钟
-- 中等 PR（200-500 行）：30-60 分钟
-- 复杂 PR（> 500 行）：拆分或多次评审
-
-### 6.2 多人评审
-
-大型 PR 可指定 2-3 个 Reviewer 分维度评审：
-
-- Reviewer A：正确性 + 性能
-- Reviewer B：安全 + 可维护性
-
-## 7. 关联阅读
-
-- [performance.md](performance.md) — 性能审查
-- [security.md](security.md) — 安全审查
-- [rules/code-dev-rules.md](../../rules/code-dev-rules.md)
-- [SKILL.md](../SKILL.md)

package/skills/meritdata-platform-code-review/references/performance.md

@@ -1,263 +0,0 @@
-# 性能审查（code-review）
-
-> 性能维度审查清单：SQL / 缓存 / Feign / 循环 / 大对象。
-
----
-
-## 1. SQL 性能
-
-### 1.1 必须走索引
-
-```sql
--- ❌ 错：status 没建索引
-SELECT * FROM t_order WHERE status = 'PAID';
-
--- ✅ 正确：建索引
-CREATE INDEX idx_t_order_status ON t_order(status);
-```
-
-### 1.2 ❌ SELECT *
-
-```java
-// ❌ 错
-@Query("SELECT o FROM Order o WHERE o.id = :id")
-Order findById(@Param("id") String id);
-
-// ✅ 正确：只查需要的字段
-@Query("SELECT new OrderDTO(o.id, o.orderNo, o.amount) FROM Order o WHERE o.id = :id")
-OrderDTO findDTOById(@Param("id") String id);
-```
-
-### 1.3 ❌ 大表全表扫描
-
-```sql
--- ❌ 错：100 万行表，全表扫描
-SELECT * FROM t_order WHERE description LIKE '%关键词%';
-
--- ✅ 正确：全文索引
-ALTER TABLE t_order ADD FULLTEXT INDEX ft_description(description);
-SELECT * FROM t_order WHERE MATCH(description) AGAINST('关键词');
-```
-
-### 1.4 EXPLAIN 验证
-
-```sql
-EXPLAIN SELECT * FROM t_order WHERE user_id = '10001';
-```
-
-关注：
-- `type`：ALL（扫表）→ ref/range（走索引）
-- `key`：实际使用的索引
-- `rows`：扫描行数
-- `Extra`：避免 Using filesort / Using temporary
-
-## 2. N+1 查询
-
-### 2.1 ❌ JPA 关联懒加载
-
-```java
-// ❌ 错：OneToMany 默认懒加载，循环访问触发 N+1
-@Entity
-public class Order {
-    @OneToMany
-    private List<OrderItem> items;
-}
-
-List<Order> orders = orderRepository.findAll();
-for (Order o : orders) {
-    o.getItems().size();  // 每次触发 SQL
-}
-```
-
-### 2.2 ✅ JOIN FETCH
-
-```java
-@Query("SELECT o FROM Order o JOIN FETCH o.items WHERE o.userId = :userId")
-List<Order> findByUserIdWithItems(@Param("userId") String userId);
-```
-
-### 2.3 ✅ @EntityGraph
-
-```java
-@EntityGraph(attributePaths = {"items"})
-List<Order> findByUserId(String userId);
-```
-
-## 3. 循环内外部资源
-
-### 3.1 ❌ 循环内 DB
-
-```java
-// ❌ 错
-for (String id : ids) {
-    userRepository.findById(id);  // 100 次 SQL
-}
-
-// ✅ 正确
-userRepository.findAllById(ids);  // 1 次 SQL
-```
-
-### 3.2 ❌ 循环内 Feign
-
-```java
-// ❌ 错
-for (Order o : orders) {
-    o.setUserName(userClient.getById(o.getUserId()).getRealName());
-}
-
-// ✅ 正确：批量装配
-List<String> ids = orders.stream().map(Order::getUserId).distinct().collect(toList());
-Map<String, UserDTO> userMap = userClient.listByIds(ids).stream()
-    .collect(Collectors.toMap(UserDTO::getUserId, e -> e));
-orders.forEach(o -> o.setUserName(userMap.get(o.getUserId()).getRealName()));
-```
-
-### 3.3 ❌ 循环内 HTTP
-
-```java
-// ❌ 错：循环内发 HTTP
-for (String url : urls) {
-    httpClient.get(url);  // 100 次 HTTP
-}
-
-// ✅ 正确：并行
-List<CompletableFuture<String>> futures = urls.stream()
-    .map(url -> CompletableFuture.supplyAsync(() -> httpClient.get(url)))
-    .collect(toList());
-List<String> results = futures.stream().map(CompletableFuture::join).collect(toList());
-```
-
-## 4. 缓存
-
-### 4.1 ❌ 缓存 key 无隔离
-
-```java
-// ❌ 错：不同租户数据混淆
-@Cacheable(value = "user", key = "#userId")
-public UserDTO getById(String userId) { ... }
-
-// ✅ 正确
-@Cacheable(value = "user", key = "#userId + ':' + #tenantId")
-public UserDTO getById(String userId) { ... }
-```
-
-### 4.2 ❌ 缓存无 TTL
-
-```java
-// ❌ 错
-redisTemplate.opsForValue().set("key", "value");  // 永不过期
-
-// ✅ 正确
-redisTemplate.opsForValue().set("key", "value", Duration.ofMinutes(10));
-```
-
-### 4.3 ❌ 缓存大对象
-
-```java
-// ❌ 错：缓存 10MB 对象
-@Cacheable(value = "report", key = "#reportId")
-public List<Report> getReport(String reportId) {
-    return reportRepository.findAll();  // 10 万行
-}
-
-// ✅ 正确：分页 + 压缩
-@Cacheable(value = "report", key = "#reportId + ':' + #page")
-public Page<Report> getReportPage(String reportId, int page) { ... }
-```
-
-## 5. 大对象
-
-### 5.1 ❌ 序列化大对象到日志
-
-```java
-// ❌ 错
-log.info("订单详情：{}", JSON.toJSONString(order));  // 含 items / payment / log
-
-// ✅ 正确：只记录关键字段
-log.info("订单创建：orderNo={}, amount={}", order.getOrderNo(), order.getAmount());
-```
-
-### 5.2 ❌ 返回大对象
-
-```java
-// ❌ 错：返回全字段
-@GetMapping("/orders/{id}")
-public Order getById(@PathVariable String id) {
-    return orderRepository.findById(id).orElseThrow();
-}
-
-// ✅ 正确：返回 VO
-@GetMapping("/orders/{id}")
-public OrderVO getById(@PathVariable String id) {
-    return orderRepository.findById(id).map(OrderVO::from).orElseThrow();
-}
-```
-
-### 5.3 ❌ 在循环内创建大对象
-
-```java
-// ❌ 错
-for (int i = 0; i < 10000; i++) {
-    StringBuilder sb = new StringBuilder();  // 创建 1 万次
-}
-
-// ✅ 正确
-StringBuilder sb = new StringBuilder();
-for (int i = 0; i < 10000; i++) {
-    sb.append(i);
-}
-```
-
-## 6. 异步
-
-### 6.1 ❌ 同步阻塞
-
-```java
-// ❌ 错：审批后等消息发送
-@PostMapping("/approve")
-public Result approve(@RequestBody ApproveRequest req) {
-    orderService.approve(req);
-    smsClient.send(req.getMobile(), "审批通过");  // 等短信返回
-    emailClient.send(req.getEmail(), "审批通过");  // 等邮件返回
-    return Result.success();
-}
-
-// ✅ 正确
-@PostMapping("/approve")
-public Result approve(@RequestBody ApproveRequest req) {
-    orderService.approve(req);
-    // 异步发送
-    CompletableFuture.allOf(
-        CompletableFuture.runAsync(() -> smsClient.send(...)),
-        CompletableFuture.runAsync(() -> emailClient.send(...))
-    );
-    return Result.success();
-}
-```
-
-## 7. 监控指标
-
-审查后建议监控：
-- P50 / P95 / P99 响应时间
-- QPS / TPS
-- DB 连接池使用率
-- 缓存命中率
-- JVM 堆使用 / GC 暂停
-
-## 8. ❌ 反模式清单
-
-| 反模式 | 影响 |
-|--------|------|
-| N+1 查询 | 性能雪崩 |
-| 循环内 DB | 100x 慢 |
-| 循环内 Feign | 100x 慢 |
-| 缓存 key 无隔离 | 数据泄露 |
-| 缓存无 TTL | 内存泄漏 |
-| 大对象序列化 | GC 抖动 |
-| 同步阻塞 | 响应慢 |
-
-## 9. 关联阅读
-
-- [guide.md](guide.md) — 代码审查基础
-- [security.md](security.md) — 安全审查
-- [SKILL.md](../SKILL.md)