@akterjs/conformance 0.1.1 → 0.1.3

package/README.md

@@ -29,7 +29,7 @@ The computer guarantees are a second suite, `computerConformanceOf({ engine, ski
 - a computer step runs once by its key: sent again, even after the engine restarts, it reads back the outcome it recorded
 - a computer keeps its files across pause, resume, stop and an engine restart
 - a held computer stays paused, or stopped if it was stopped: an ensure, a step, and a resume or pause without its hold are refused until its hold resumes it
-- a computer past the store's limit is refused with ComputerLimitError and makes nothing, and one fits again once another is removed
+- an actor keeps as many computers as it ensures: five all start and are listed, and all five remove
 - a removed computer is gone with its disk: calls to it fail with ComputerNotFoundError, and ensuring it again starts it empty
 
 The fork guarantees are a third suite, `forkConformanceOf({ engine, skip })` from `@akterjs/conformance/fork`, which forks the suite's `acct-1` Ledger into `acct-5`, and its `bench-1` Workbench, with a running and a stopped computer, into `bench-250`, through `ActorHost.fork`. An engine under test serves all four keys, with the Workbench's computers bound both to its jobs and to its fork, and an engine that places an actor by its key puts each fork's key on its parent's shard, because Akter Cloud forks only within a shard (`acct-5` and `bench-250` hash to their parents' shards there). The local engine runs it with `AKTER_LOCAL_COMPUTERS=true` in `tests/engine-conformance.suite.test.ts`.

package/dist/guarantee-titles.pure.d.mts

@@ -17,7 +17,7 @@ declare const guaranteeTitles: {
 declare const computerGuaranteeTitles: {
   readonly computerHeldStaysPaused: "a held computer stays paused, or stopped if it was stopped: an ensure, a step, and a resume or pause without its hold are refused until its hold resumes it";
   readonly computerKeepsFiles: "a computer keeps its files across pause, resume, stop and an engine restart";
-  readonly computerLimitHolds: "a computer past the store's limit is refused with ComputerLimitError and makes nothing, and one fits again once another is removed";
+  readonly computerManyKept: "an actor keeps as many computers as it ensures: five all start and are listed, and all five remove";
   readonly computerRemovedIsGone: "a removed computer is gone with its disk: calls to it fail with ComputerNotFoundError, and ensuring it again starts it empty";
   readonly computerStepJournaled: "a durable computer step journals its start and outcome in the actor, and its steps read back newest first, one with its output";
   readonly computerStepRunsOnce: "a computer step runs once by its key: sent again, even after the engine restarts, it reads back the outcome it recorded";

package/dist/guarantee-titles.pure.mjs

@@ -18,7 +18,7 @@ const guaranteeTitles = {
 const computerGuaranteeTitles = {
 	computerHeldStaysPaused: "a held computer stays paused, or stopped if it was stopped: an ensure, a step, and a resume or pause without its hold are refused until its hold resumes it",
 	computerKeepsFiles: "a computer keeps its files across pause, resume, stop and an engine restart",
-	computerLimitHolds: "a computer past the store's limit is refused with ComputerLimitError and makes nothing, and one fits again once another is removed",
+	computerManyKept: "an actor keeps as many computers as it ensures: five all start and are listed, and all five remove",
 	computerRemovedIsGone: "a removed computer is gone with its disk: calls to it fail with ComputerNotFoundError, and ensuring it again starts it empty",
 	computerStepJournaled: "a durable computer step journals its start and outcome in the actor, and its steps read back newest first, one with its output",
 	computerStepRunsOnce: "a computer step runs once by its key: sent again, even after the engine restarts, it reads back the outcome it recorded",

package/dist/workbench/computer-conformance.suite.mjs

@@ -132,41 +132,18 @@ const heldStaysPaused = (storage) => onBench(storage, (host) => Effect.gen(funct
 	]);
 	yield* stoppedStaysStopped(host);
 }));
-const tried = 8;
-const none = 0;
-const first = 1;
-/** `value` `count` times, for a count from none to `tried`. */
-const times = (value, count) => Array.take(Array.replicate(value, tried), count);
+const many = 5;
 const listed = (names) => `[${Array.join(Array.sort(names, String$1.Order), ",")}]`;
-const limitHolds = (storage) => onBench(storage, (host) => Effect.gen(function* fillThenFree() {
-	const names = Array.makeBy(tried, (index) => `c${String(index)}`);
-	const filled = yield* ran(host, "l-1", [...Array.map(names, ensure), list]);
-	const made = Array.takeWhile(filled, (outcome) => outcome === "up").length;
-	const refused = `ComputerLimitError store ${String(made)}`;
-	const kept = Array.take(names, made);
-	const freed = yield* ran(host, "l-2", [
-		remove("c0"),
-		ensure("again"),
-		ensure("more"),
-		list
-	]);
+const manyKept = (storage) => onBench(storage, (host) => Effect.gen(function* ensureMany() {
+	const names = Array.makeBy(many, (index) => `c${String(index)}`);
+	const kept = yield* ran(host, "m-1", [...Array.map(names, ensure), list]);
+	const removed = yield* ran(host, "m-2", [...Array.map(names, remove), list]);
 	expect({
-		filled,
-		freed,
-		made: made > none && made < tried
+		kept,
+		removed
 	}).toStrictEqual({
-		filled: [
-			...times("up", made),
-			...times(refused, tried - made),
-			listed(kept)
-		],
-		freed: [
-			"removed",
-			"up",
-			refused,
-			listed([...Array.drop(kept, first), "again"])
-		],
-		made: true
+		kept: [...Array.replicate("up", many), listed(names)],
+		removed: [...Array.replicate("removed", many), listed([])]
 	});
 }));
 const removedIsGone = (storage) => onBench(storage, (host) => Effect.gen(function* removeThenEnsure() {
@@ -301,7 +278,7 @@ const stepSurvivesRestart = (storage) => Effect.gen(function* cutThenReplay() {
 const computerGuarantees = {
 	computerHeldStaysPaused: heldStaysPaused,
 	computerKeepsFiles: keepsFiles,
-	computerLimitHolds: limitHolds,
+	computerManyKept: manyKept,
 	computerRemovedIsGone: removedIsGone,
 	computerStepJournaled: stepJournaled,
 	computerStepRunsOnce: stepRunsOnce,

package/dist/workbench/workbench.actor.mjs

@@ -1,5 +1,4 @@
 import { ComputerOp, Workbench } from "./workbench.contract.mjs";
-import { ComputerLimitError } from "@akterjs/effect/contract/errors";
 import { Array, Cause, Effect, Exit, Layer, Option, Predicate, Record, Schema, String as String$1 } from "effect";
 import { Akter } from "@akterjs/effect/contract";
 import { Akter as Akter$1 } from "@akterjs/effect";
@@ -12,6 +11,7 @@ const failures = [
 	"ActorUnavailableError",
 	"CallerNotAllowedError",
 	"ComputerHeldError",
+	"ComputerLimitError",
 	"ComputerLostError",
 	"ComputerNotFoundError",
 	"ComputersUnavailableError",
@@ -19,7 +19,6 @@ const failures = [
 	"SecretUnavailableError",
 	"UnauthenticatedError"
 ];
-const isLimit = Schema.is(ComputerLimitError);
 const isRan = Schema.is(ExecRan);
 const specOf = (computer) => ({
 	egress: [],
@@ -57,11 +56,8 @@ const called = (client, op) => ComputerOp.match(op, {
 	Step: () => Effect.die("a durable step runs in the job, not in an activity"),
 	Stop: ({ computer }) => Effect.map(client.stop(computer), stateOf)
 });
-/** A failure by its tag; a limit with the limit and its maximum, which the suite checks against what was made. */
-const failureOf = (failure) => {
-	if (isLimit(failure)) return `ComputerLimitError ${failure.limit} ${String(failure.maximum)}`;
-	return Option.getOrElse(Array.findFirst(failures, (tag) => Predicate.isTagged(failure, tag)), () => "unexpected failure");
-};
+/** A failure by its tag. */
+const failureOf = (failure) => Option.getOrElse(Array.findFirst(failures, (tag) => Predicate.isTagged(failure, tag)), () => "unexpected failure");
 const attempted = (key, op) => Effect.flatMap(Workbench.computer(key), (client) => called(client, op));
 const answered = (key, op) => Effect.match(attempted(key, op), {
 	onFailure: failureOf,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@akterjs/conformance",
-  "version": "0.1.1",
+  "version": "0.1.3",
   "description": "The test suite every Akter engine must pass: the local engine here and the production engine on Akter Cloud.",
   "license": "Apache-2.0",
   "repository": {
@@ -48,9 +48,9 @@
     "provenance": true
   },
   "devDependencies": {
-    "@akterjs/client": "0.1.1",
-    "@akterjs/effect": "0.1.1",
-    "@akterjs/sdk": "0.1.1",
+    "@akterjs/client": "0.1.3",
+    "@akterjs/effect": "0.1.3",
+    "@akterjs/sdk": "0.1.3",
     "@effect/platform-node": "4.1.2",
     "@effect/vitest": "4.1.2",
     "effect": "4.1.2",
@@ -60,9 +60,9 @@
     "zod": "4.6.7"
   },
   "peerDependencies": {
-    "@akterjs/client": "0.1.1",
-    "@akterjs/effect": "0.1.1",
-    "@akterjs/sdk": "0.1.1",
+    "@akterjs/client": "0.1.3",
+    "@akterjs/effect": "0.1.3",
+    "@akterjs/sdk": "0.1.3",
     "@effect/vitest": "4.1.2",
     "effect": "4.1.2",
     "vitest": "5.1.0",

package/src/guarantee-titles.pure.ts

@@ -27,8 +27,8 @@ const computerGuaranteeTitles = {
   computerHeldStaysPaused:
     "a held computer stays paused, or stopped if it was stopped: an ensure, a step, and a resume or pause without its hold are refused until its hold resumes it",
   computerKeepsFiles: "a computer keeps its files across pause, resume, stop and an engine restart",
-  computerLimitHolds:
-    "a computer past the store's limit is refused with ComputerLimitError and makes nothing, and one fits again once another is removed",
+  computerManyKept:
+    "an actor keeps as many computers as it ensures: five all start and are listed, and all five remove",
   computerRemovedIsGone:
     "a removed computer is gone with its disk: calls to it fail with ComputerNotFoundError, and ensuring it again starts it empty",
   computerStepJournaled:

package/src/workbench/computer-conformance.suite.ts

@@ -161,31 +161,20 @@ const heldStaysPaused = <Failure>(storage: Storage<Failure>): Checked<Failure> =
     }),
   );
 
-const tried = 8;
-
-const none = 0;
-
-const first = 1;
-
-/** `value` `count` times, for a count from none to `tried`. */
-const times = (value: string, count: number): readonly string[] => Arr.take(Arr.replicate(value, tried), count);
+const many = 5;
 
 const listed = (names: readonly string[]): string => `[${Arr.join(Arr.sort(names, Str.Order), ",")}]`;
 
-const limitHolds = <Failure>(storage: Storage<Failure>): Checked<Failure> =>
+const manyKept = <Failure>(storage: Storage<Failure>): Checked<Failure> =>
   onBench(storage, (host) =>
-    Effect.gen(function* fillThenFree() {
-      const names = Arr.makeBy(tried, (index) => `c${String(index)}`);
-      const filled = yield* ran(host, "l-1", [...Arr.map(names, ensure), list]);
-      const made = Arr.takeWhile(filled, (outcome) => outcome === "up").length;
-      const refused = `ComputerLimitError store ${String(made)}`;
-      const kept = Arr.take(names, made);
-      const freed = yield* ran(host, "l-2", [remove("c0"), ensure("again"), ensure("more"), list]);
-
-      expect({ filled, freed, made: made > none && made < tried }).toStrictEqual({
-        filled: [...times("up", made), ...times(refused, tried - made), listed(kept)],
-        freed: ["removed", "up", refused, listed([...Arr.drop(kept, first), "again"])],
-        made: true,
+    Effect.gen(function* ensureMany() {
+      const names = Arr.makeBy(many, (index) => `c${String(index)}`);
+      const kept = yield* ran(host, "m-1", [...Arr.map(names, ensure), list]);
+      const removed = yield* ran(host, "m-2", [...Arr.map(names, remove), list]);
+
+      expect({ kept, removed }).toStrictEqual({
+        kept: [...Arr.replicate("up", many), listed(names)],
+        removed: [...Arr.replicate("removed", many), listed([])],
       });
     }),
   );
@@ -332,7 +321,7 @@ type Guarantee = <Failure>(storage: Storage<Failure>) => Checked<Failure>;
 const computerGuarantees = {
   computerHeldStaysPaused: heldStaysPaused,
   computerKeepsFiles: keepsFiles,
-  computerLimitHolds: limitHolds,
+  computerManyKept: manyKept,
   computerRemovedIsGone: removedIsGone,
   computerStepJournaled: stepJournaled,
   computerStepRunsOnce: stepRunsOnce,

package/src/workbench/workbench.actor.ts

@@ -3,7 +3,6 @@ import { Akter } from "@akterjs/effect/contract";
 import { ComputerName, ExecRan } from "@akterjs/effect/contract/computer";
 import type { Computer, ComputerSpec, ExecResult } from "@akterjs/effect/contract/computer";
 import type { ActorComputerClients } from "@akterjs/effect/contract/computer-clients";
-import { ComputerLimitError } from "@akterjs/effect/contract/errors";
 import {
   Array as Arr,
   Cause,
@@ -36,6 +35,7 @@ const failures = [
   "ActorUnavailableError",
   "CallerNotAllowedError",
   "ComputerHeldError",
+  "ComputerLimitError",
   "ComputerLostError",
   "ComputerNotFoundError",
   "ComputersUnavailableError",
@@ -44,8 +44,6 @@ const failures = [
   "UnauthenticatedError",
 ] as const;
 
-const isLimit = Schema.is(ComputerLimitError);
-
 const isRan = Schema.is(ExecRan);
 
 const specOf = (computer: string): ComputerSpec => ({
@@ -102,17 +100,12 @@ const called = (client: ComputerClient, op: ComputerOp): Effect.Effect<string, C
     Stop: ({ computer }) => Effect.map(client.stop(computer), stateOf),
   });
 
-/** A failure by its tag; a limit with the limit and its maximum, which the suite checks against what was made. */
-const failureOf = (failure: Failed): string => {
-  if (isLimit(failure)) {
-    return `ComputerLimitError ${failure.limit} ${String(failure.maximum)}`;
-  }
-
-  return Option.getOrElse(
+/** A failure by its tag. */
+const failureOf = (failure: Failed): string =>
+  Option.getOrElse(
     Arr.findFirst(failures, (tag) => Predicate.isTagged(failure, tag)),
     () => "unexpected failure",
   );
-};
 
 const attempted = (key: string, op: ComputerOp): Effect.Effect<string, Failed> =>
   Effect.flatMap(Workbench.computer(key), (client) => called(client, op));