@akiojin/gwt 6.30.3 → 9.0.1

package/scripts/test_release_issue_refs.py

@@ -0,0 +1,257 @@
+from __future__ import annotations
+
+import importlib.util
+import json
+import sys
+import unittest
+from pathlib import Path
+from textwrap import dedent
+
+MODULE_PATH = Path(__file__).with_name("release_issue_refs.py")
+MODULE_SPEC = importlib.util.spec_from_file_location("release_issue_refs", MODULE_PATH)
+assert MODULE_SPEC is not None
+assert MODULE_SPEC.loader is not None
+release_issue_refs = importlib.util.module_from_spec(MODULE_SPEC)
+sys.modules[MODULE_SPEC.name] = release_issue_refs
+MODULE_SPEC.loader.exec_module(release_issue_refs)
+
+PR_1585_BODY = dedent(
+    """\
+    ## Summary
+
+    - Refit and refresh the terminal when focus or visibility returns so Windows terminal corruption can recover without manual tab switching.
+
+    ## Closing Issues
+
+    None
+
+    ## Related Issues / Links
+
+    - #1457
+    """
+)
+
+
+class FakeRunner:
+    def __init__(self, outputs: dict[tuple[str, ...], str]) -> None:
+        self.outputs = outputs
+
+    def __call__(self, args: list[str] | tuple[str, ...]) -> str:
+        key = tuple(args)
+        if key not in self.outputs:
+            raise AssertionError(f"Unexpected command: {key!r}")
+        return self.outputs[key]
+
+
+class ReleaseIssueRefsTests(unittest.TestCase):
+    def test_parse_pr_body_collects_keywords_and_closing_section(self) -> None:
+        body = dedent(
+            """\
+            ## Summary
+
+            This change resolves #2000 and keeps release notes aligned.
+
+            ## Closing Issues
+
+            #2001
+            Closes #2002
+
+            ## Related Issues / Links
+
+            - #2003
+            - https://example.com/task
+            """
+        )
+
+        result = release_issue_refs.parse_pr_body_refs(body, pr_number=1234)
+
+        self.assertEqual([2000, 2001, 2002], result.auto_close_issues)
+        self.assertEqual([2003], result.reference_only_issues)
+        self.assertEqual(
+            [
+                "PR #1234 references #2003 only in `Related Issues / Links`; "
+                "they will not auto-close on release."
+            ],
+            result.warnings,
+        )
+
+    def test_parse_pr_body_flags_related_only_refs(self) -> None:
+        result = release_issue_refs.parse_pr_body_refs(PR_1585_BODY, pr_number=1585)
+
+        self.assertEqual([], result.auto_close_issues)
+        self.assertEqual([1457], result.reference_only_issues)
+        self.assertEqual(
+            [
+                "PR #1585 references #1457 only in `Related Issues / Links`; "
+                "they will not auto-close on release."
+            ],
+            result.warnings,
+        )
+
+    def test_collect_release_issue_refs_keeps_reference_only_issues_visible(self) -> None:
+        runner = FakeRunner(
+            {
+                (
+                    "git",
+                    "log",
+                    "--pretty=%s",
+                    "--no-merges",
+                    "v8.6.0..HEAD",
+                ): (
+                    "fix(gui): refresh terminal when focus returns (#1585)\n"
+                    "fix: hook error (#1589)\n"
+                ),
+                ("git", "log", "--merges", "--pretty=%s", "v8.6.0..HEAD"): "",
+                ("gh", "api", "repos/akiojin/gwt/issues/1585"): '{"pull_request":{"url":"https://example.com/pr/1585"}}',
+                (
+                    "gh",
+                    "pr",
+                    "view",
+                    "1585",
+                    "--repo",
+                    "akiojin/gwt",
+                    "--json",
+                    "body",
+                ): json.dumps({"body": PR_1585_BODY}),
+                ("gh", "api", "repos/akiojin/gwt/issues/1589"): "{}",
+            }
+        )
+
+        result = release_issue_refs.collect_release_issue_refs(
+            "v8.6.0..HEAD",
+            repo_slug="akiojin/gwt",
+            runner=runner,
+        )
+
+        self.assertEqual([1589], result.auto_close_issues)
+        self.assertEqual([1457], result.reference_only_issues)
+        self.assertEqual(
+            [
+                "Reference-only issues detected: #1457. Add them to `Closing Issues` if they should auto-close.",
+                "PR #1585 references #1457 only in `Related Issues / Links`; they will not auto-close on release.",
+            ],
+            result.warnings,
+        )
+        self.assertEqual(["pr", "issue"], [ref.kind for ref in result.refs])
+
+    def test_gwt_spec_direct_issue_moved_to_reference_only(self) -> None:
+        """Direct issue ref with gwt-spec label moves to reference_only."""
+        runner = FakeRunner(
+            {
+                (
+                    "git",
+                    "log",
+                    "--pretty=%s",
+                    "--no-merges",
+                    "v8.14.0..HEAD",
+                ): "feat(spec): adopt artifact-first issue workflow (#1700)\n",
+                ("git", "log", "--merges", "--pretty=%s", "v8.14.0..HEAD"): "",
+                ("gh", "api", "repos/akiojin/gwt/issues/1700"): json.dumps(
+                    {"labels": [{"name": "gwt-spec"}, {"name": "enhancement"}]}
+                ),
+            }
+        )
+
+        result = release_issue_refs.collect_release_issue_refs(
+            "v8.14.0..HEAD",
+            repo_slug="akiojin/gwt",
+            runner=runner,
+        )
+
+        self.assertEqual([], result.auto_close_issues)
+        self.assertEqual([1700], result.reference_only_issues)
+        self.assertIn(
+            "gwt-spec issues moved to reference-only: #1700. "
+            "gwt-spec issues are never auto-closed by releases.",
+            result.warnings,
+        )
+
+    def test_gwt_spec_issue_via_pr_closing_moved_to_reference_only(self) -> None:
+        """PR body `Closes #N` where N has gwt-spec label moves N to reference_only."""
+        pr_body = dedent(
+            """\
+            ## Closing Issues
+
+            #1700
+
+            ## Related Issues / Links
+
+            None"""
+        )
+        runner = FakeRunner(
+            {
+                (
+                    "git",
+                    "log",
+                    "--pretty=%s",
+                    "--no-merges",
+                    "v8.14.0..HEAD",
+                ): "fix(spec): harden issue migration retries (#1701)\n",
+                ("git", "log", "--merges", "--pretty=%s", "v8.14.0..HEAD"): "",
+                ("gh", "api", "repos/akiojin/gwt/issues/1701"): json.dumps(
+                    {"pull_request": {"url": "https://example.com/pr/1701"}}
+                ),
+                (
+                    "gh",
+                    "pr",
+                    "view",
+                    "1701",
+                    "--repo",
+                    "akiojin/gwt",
+                    "--json",
+                    "body",
+                ): json.dumps({"body": pr_body}),
+                ("gh", "api", "repos/akiojin/gwt/issues/1700"): json.dumps(
+                    {"labels": [{"name": "gwt-spec"}]}
+                ),
+            }
+        )
+
+        result = release_issue_refs.collect_release_issue_refs(
+            "v8.14.0..HEAD",
+            repo_slug="akiojin/gwt",
+            runner=runner,
+        )
+
+        self.assertEqual([], result.auto_close_issues)
+        self.assertEqual([1700], result.reference_only_issues)
+        self.assertIn(
+            "gwt-spec issues moved to reference-only: #1700. "
+            "gwt-spec issues are never auto-closed by releases.",
+            result.warnings,
+        )
+
+    def test_non_gwt_spec_issue_stays_in_auto_close(self) -> None:
+        """Non-gwt-spec issue stays in auto_close."""
+        runner = FakeRunner(
+            {
+                (
+                    "git",
+                    "log",
+                    "--pretty=%s",
+                    "--no-merges",
+                    "v8.14.0..HEAD",
+                ): "fix: hook error (#1589)\n",
+                ("git", "log", "--merges", "--pretty=%s", "v8.14.0..HEAD"): "",
+                ("gh", "api", "repos/akiojin/gwt/issues/1589"): json.dumps(
+                    {"labels": [{"name": "bug"}]}
+                ),
+            }
+        )
+
+        result = release_issue_refs.collect_release_issue_refs(
+            "v8.14.0..HEAD",
+            repo_slug="akiojin/gwt",
+            runner=runner,
+        )
+
+        self.assertEqual([1589], result.auto_close_issues)
+        self.assertEqual([], result.reference_only_issues)
+        gwt_spec_warnings = [
+            w for w in result.warnings if "gwt-spec" in w
+        ]
+        self.assertEqual([], gwt_spec_warnings)
+
+
+if __name__ == "__main__":
+    unittest.main()

package/scripts/validate-skill-frontmatter.sh

@@ -0,0 +1,108 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+cd "$ROOT_DIR"
+
+TMP_DIR="$(mktemp -d)"
+trap 'rm -rf "$TMP_DIR"' EXIT
+
+MANIFEST="$TMP_DIR/frontmatter-manifest.tsv"
+FAILURES=0
+
+extract_frontmatter() {
+  local input_file="$1"
+  local output_file="$2"
+
+  awk '
+    BEGIN {
+      state = 0
+    }
+    {
+      line = $0
+      sub(/\r$/, "", line)
+
+      if (NR == 1) {
+        if (line != "---") {
+          exit 2
+        }
+        state = 1
+        next
+      }
+
+      if (state == 1 && line == "---") {
+        state = 2
+        exit 0
+      }
+
+      if (state == 1) {
+        print line
+      }
+    }
+    END {
+      if (NR == 0) {
+        exit 2
+      }
+      if (state != 2) {
+        exit 3
+      }
+    }
+  ' "$input_file" > "$output_file"
+}
+
+SKILL_FILES=()
+while IFS= read -r skill_file; do
+  SKILL_FILES+=("$skill_file")
+done < <(git ls-files '*SKILL.md')
+
+for index in "${!SKILL_FILES[@]}"; do
+  relative_path="${SKILL_FILES[$index]}"
+  if [ ! -f "$relative_path" ]; then
+    echo "$relative_path: tracked SKILL.md is missing from working tree" >&2
+    FAILURES=1
+    continue
+  fi
+  frontmatter_file="$TMP_DIR/frontmatter-$index.yaml"
+
+  if extract_frontmatter "$relative_path" "$frontmatter_file"; then
+    printf '%s\t%s\n' "$frontmatter_file" "$relative_path" >> "$MANIFEST"
+    continue
+  fi
+
+  case $? in
+    2)
+      echo "$relative_path: missing YAML frontmatter block" >&2
+      ;;
+    3)
+      echo "$relative_path: missing closing YAML frontmatter delimiter" >&2
+      ;;
+    *)
+      echo "$relative_path: failed to extract YAML frontmatter" >&2
+      ;;
+  esac
+
+  FAILURES=1
+done
+
+if [ -s "$MANIFEST" ]; then
+  if ! MANIFEST="$MANIFEST" pnpm dlx -s --package js-yaml -c '
+    status=0
+    while IFS="$(printf "\t")" read -r yaml_file source_path; do
+      if ! output=$(js-yaml -c "$yaml_file" 2>&1 >/dev/null); then
+        printf "%s: invalid YAML frontmatter: %s\n" "$source_path" "$output" >&2
+        status=1
+      fi
+    done < "$MANIFEST"
+    exit "$status"
+  '; then
+    FAILURES=1
+  fi
+fi
+
+if [ "$FAILURES" -ne 0 ]; then
+  echo "SKILL.md frontmatter validation failed." >&2
+  exit 1
+fi
+
+echo "Validated ${#SKILL_FILES[@]} SKILL.md frontmatter block(s)."

package/scripts/verify-ci-node-toolchain.sh

@@ -0,0 +1,76 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+
+fail() {
+  echo "CI node toolchain verification failed: $1" >&2
+  exit 1
+}
+
+require_file() {
+  if [ ! -f "$1" ]; then
+    fail "Missing file: $1"
+  fi
+}
+
+require_not_file() {
+  if [ -f "$1" ]; then
+    fail "Unexpected file exists: $1"
+  fi
+}
+
+require_contains() {
+  local file="$1"
+  local pattern="$2"
+  if ! grep -Fq "$pattern" "$file"; then
+    fail "Expected pattern not found in $file: $pattern"
+  fi
+}
+
+require_not_contains() {
+  local file="$1"
+  local pattern="$2"
+  if grep -Fq "$pattern" "$file"; then
+    fail "Unexpected pattern found in $file: $pattern"
+  fi
+}
+
+require_file "$ROOT_DIR/pnpm-lock.yaml"
+require_not_file "$ROOT_DIR/package-lock.json"
+require_file "$ROOT_DIR/package.json"
+
+require_contains "$ROOT_DIR/package.json" "\"packageManager\": \"pnpm@10.29.2\""
+
+require_file "$ROOT_DIR/gwt-gui/package.json"
+require_contains "$ROOT_DIR/gwt-gui/package.json" "\"packageManager\": \"pnpm@10.29.2\""
+require_file "$ROOT_DIR/gwt-gui/pnpm-lock.yaml"
+require_not_file "$ROOT_DIR/gwt-gui/package-lock.json"
+require_contains "$ROOT_DIR/.gitignore" "gwt-gui/package-lock.json"
+
+WORKFLOW="$ROOT_DIR/.github/workflows/lint.yml"
+require_file "$WORKFLOW"
+
+require_not_contains "$WORKFLOW" "npm install -g"
+require_contains "$WORKFLOW" "corepack prepare pnpm@10.29.2 --activate"
+require_contains "$WORKFLOW" "pnpm lint:skills"
+require_contains "$WORKFLOW" "pnpm dlx @commitlint/cli@20.4.1"
+
+TEST_WORKFLOW="$ROOT_DIR/.github/workflows/test.yml"
+require_file "$TEST_WORKFLOW"
+
+require_not_contains "$TEST_WORKFLOW" "cd gwt-gui && npm ci"
+require_not_contains "$TEST_WORKFLOW" "cd gwt-gui && npm run check"
+require_not_contains "$TEST_WORKFLOW" "cd gwt-gui && npm run build"
+require_contains "$TEST_WORKFLOW" "cd gwt-gui && pnpm install --frozen-lockfile"
+require_contains "$TEST_WORKFLOW" "cd gwt-gui && pnpm run check"
+require_contains "$TEST_WORKFLOW" "cd gwt-gui && pnpm run build"
+
+RELEASE_WORKFLOW="$ROOT_DIR/.github/workflows/release.yml"
+require_file "$RELEASE_WORKFLOW"
+
+require_not_contains "$RELEASE_WORKFLOW" "cd gwt-gui && npm ci"
+require_contains "$RELEASE_WORKFLOW" "cd gwt-gui && pnpm install --frozen-lockfile"
+
+echo "CI node toolchain verification passed."

package/scripts/verify-husky-hooks.sh

@@ -37,17 +37,23 @@ require_not_contains() {
 
 require_file "$PACKAGE_JSON"
 require_contains "$PACKAGE_JSON" '"prepare": "test -n \"$CI\" || bunx husky install"'
+require_contains "$PACKAGE_JSON" "\"lint:skills\": \"bash scripts/validate-skill-frontmatter.sh\""
 require_contains "$PACKAGE_JSON" "\"lint:husky\": \"bash scripts/verify-husky-hooks.sh\""
 
 require_file "$PRE_PUSH"
 require_contains "$PRE_PUSH" "cargo clippy --all-targets --all-features -- -D warnings"
 require_contains "$PRE_PUSH" "cargo fmt --all -- --check"
 require_contains "$PRE_PUSH" "bunx --bun markdownlint-cli . --config .markdownlint.json --ignore target --ignore CHANGELOG.md"
+require_contains "$PRE_PUSH" "pnpm lint:skills"
 
 require_file "$COMMIT_MSG"
 require_contains "$COMMIT_MSG" 'bunx --package @commitlint/cli commitlint --edit "$1"'
 
 if [ -f "$PRE_COMMIT" ]; then
+  require_contains "$PRE_COMMIT" "pnpm lint:skills"
+  require_contains "$PRE_COMMIT" "bash scripts/run-local-backend-tests-on-commit.sh"
+  require_contains "$PRE_COMMIT" "bash scripts/run-local-e2e-on-commit.sh"
+  require_contains "$PRE_COMMIT" "bash scripts/run-local-e2e-coverage-on-commit.sh"
   require_not_contains "$PRE_COMMIT" "cargo clippy --all-targets --all-features -- -D warnings"
   require_not_contains "$PRE_COMMIT" "cargo fmt --all -- --check"
   require_not_contains "$PRE_COMMIT" "markdownlint-cli"

package/scripts/voice-eval.sh

@@ -0,0 +1,48 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+MANIFEST_PATH="${GWT_VOICE_EVAL_MANIFEST:-$ROOT_DIR/tests/voice_eval/manifest.json}"
+OUTPUT_PATH="${GWT_VOICE_EVAL_OUTPUT:-$ROOT_DIR/tests/voice_eval/latest-report.json}"
+BASELINE_PATH="${GWT_VOICE_EVAL_BASELINE:-$ROOT_DIR/tests/voice_eval/baseline.json}"
+QUALITIES="${GWT_VOICE_EVAL_QUALITIES:-fast,balanced,accurate}"
+MODELS="${GWT_VOICE_EVAL_MODELS:-}"
+
+if [[ ! -f "$MANIFEST_PATH" ]]; then
+  echo "voice-eval: manifest not found: $MANIFEST_PATH" >&2
+  echo "Create one from: $ROOT_DIR/tests/voice_eval/manifest.template.json" >&2
+  exit 1
+fi
+
+EXTRA_ARGS=()
+if [[ -f "$BASELINE_PATH" ]]; then
+  EXTRA_ARGS+=(--baseline "$BASELINE_PATH")
+fi
+
+echo "[voice-eval] manifest: $MANIFEST_PATH"
+echo "[voice-eval] output:   $OUTPUT_PATH"
+echo "[voice-eval] qualities: $QUALITIES"
+if [[ -n "$MODELS" ]]; then
+  echo "[voice-eval] models:   $MODELS"
+fi
+
+CMD=(
+  cargo run -p gwt-tauri --bin voice_eval --
+  --manifest "$MANIFEST_PATH"
+  --output "$OUTPUT_PATH"
+)
+
+if [[ -n "$QUALITIES" ]]; then
+  CMD+=(--qualities "$QUALITIES")
+fi
+if [[ -n "$MODELS" ]]; then
+  CMD+=(--models "$MODELS")
+fi
+if [[ ${#EXTRA_ARGS[@]} -gt 0 ]]; then
+  CMD+=("${EXTRA_ARGS[@]}")
+fi
+if [[ $# -gt 0 ]]; then
+  CMD+=("$@")
+fi
+
+"${CMD[@]}"

package/tests/voice_eval/README.md

@@ -0,0 +1,53 @@
+# Voice Evaluation Dataset
+
+This directory contains local assets for offline voice accuracy checks.
+
+## Files
+
+- `script-ja.txt`: Japanese recording script for consistent test utterances.
+- `manifest.template.json`: template for your local `manifest.json`.
+- `samples/`: place your recorded WAV files here.
+
+## Quick Start
+
+1. Copy template:
+```bash
+cp tests/voice_eval/manifest.template.json tests/voice_eval/manifest.json
+```
+
+1. Record your voice using `tests/voice_eval/script-ja.txt` and place WAV files under:
+- `tests/voice_eval/samples/001.wav`
+- `tests/voice_eval/samples/002.wav`
+- ...
+
+1. Run evaluation:
+```bash
+scripts/voice-eval.sh
+```
+
+1. Run additional popular models:
+```bash
+scripts/voice-eval.sh --models popular-lite
+```
+
+1. Run full-size popular models (large downloads):
+```bash
+scripts/voice-eval.sh --models popular
+```
+
+1. Optional baseline update (after you approve current quality):
+```bash
+cp tests/voice_eval/latest-report.json tests/voice_eval/baseline.json
+```
+
+## WAV Requirements
+
+- PCM WAV
+- mono or stereo (stereo will be downmixed)
+- recommended sample rate: 16kHz or 48kHz
+
+## Notes
+
+- `manifest.json`, `baseline.json`, `latest-report.json`, and `samples/*.wav` are ignored by git.
+- The evaluator computes WER/CER and compares against baseline when available.
+- A versioned summary snapshot is tracked at `docs/voice-eval-benchmarks.md`.

package/tests/voice_eval/manifest.template.json

@@ -0,0 +1,55 @@
+{
+  "default_language": "ja",
+  "samples": [
+    {
+      "id": "ja-001",
+      "audio_path": "samples/001.wav",
+      "reference": "おはようございます。今日の進捗を共有します。"
+    },
+    {
+      "id": "ja-002",
+      "audio_path": "samples/002.wav",
+      "reference": "新しいブランチを作成して、テストを先に追加します。"
+    },
+    {
+      "id": "ja-003",
+      "audio_path": "samples/003.wav",
+      "reference": "エラーの再現手順を確認してから修正に入ります。"
+    },
+    {
+      "id": "ja-004",
+      "audio_path": "samples/004.wav",
+      "reference": "ターミナルのログを保存して、原因を切り分けます。"
+    },
+    {
+      "id": "ja-005",
+      "audio_path": "samples/005.wav",
+      "reference": "プルリクエストには変更理由と影響範囲を明記します。"
+    },
+    {
+      "id": "ja-006",
+      "audio_path": "samples/006.wav",
+      "reference": "この仕様は後方互換性を維持しなければなりません。"
+    },
+    {
+      "id": "ja-007",
+      "audio_path": "samples/007.wav",
+      "reference": "ゼロダウンタイムでデプロイできるか検証しましょう。"
+    },
+    {
+      "id": "ja-008",
+      "audio_path": "samples/008.wav",
+      "reference": "明日のミーティングは午前九時に開始します。"
+    },
+    {
+      "id": "ja-009",
+      "audio_path": "samples/009.wav",
+      "reference": "ユーザーが迷わないように文言を短くします。"
+    },
+    {
+      "id": "ja-010",
+      "audio_path": "samples/010.wav",
+      "reference": "機能追加の前に要件とテストを更新してください。"
+    }
+  ]
+}

package/tests/voice_eval/samples/.gitkeep

@@ -0,0 +1 @@
+

package/tests/voice_eval/script-ja.txt

@@ -0,0 +1,10 @@
+1. おはようございます。今日の進捗を共有します。
+2. 新しいブランチを作成して、テストを先に追加します。
+3. エラーの再現手順を確認してから修正に入ります。
+4. ターミナルのログを保存して、原因を切り分けます。
+5. プルリクエストには変更理由と影響範囲を明記します。
+6. この仕様は後方互換性を維持しなければなりません。
+7. ゼロダウンタイムでデプロイできるか検証しましょう。
+8. 明日のミーティングは午前九時に開始します。
+9. ユーザーが迷わないように文言を短くします。
+10. 機能追加の前に要件とテストを更新してください。