@akiojin/gwt 2.14.0 → 3.1.0

package/src/types/profiles.ts

@@ -0,0 +1,64 @@
+/**
+ * 環境変数プロファイル型定義
+ *
+ * プロファイル機能で使用する型を定義します。
+ * @see specs/SPEC-dafff079/spec.md
+ */
+
+/**
+ * 環境変数プロファイル
+ *
+ * 環境変数のセットを表します。
+ */
+export interface EnvironmentProfile {
+  /** プロファイルの表示名 */
+  displayName: string;
+  /** プロファイルの説明（オプション） */
+  description?: string;
+  /** 環境変数のキーバリューペア */
+  env: Record<string, string>;
+}
+
+/**
+ * プロファイル設定
+ *
+ * 全プロファイルを管理する設定です。
+ * ~/.gwt/profiles.yaml に保存されます。
+ */
+export interface ProfilesConfig {
+  /** 設定ファイルのバージョン */
+  version: string;
+  /** 現在アクティブなプロファイル名（nullの場合はプロファイルなし） */
+  activeProfile: string | null;
+  /** プロファイルの辞書（キー: プロファイル名、値: プロファイル設定） */
+  profiles: Record<string, EnvironmentProfile>;
+}
+
+/**
+ * デフォルトのプロファイル設定
+ *
+ * profiles.yamlが存在しない場合に使用されます。
+ * 不変オブジェクトとして扱われるため、変更は禁止されています。
+ */
+export const DEFAULT_PROFILES_CONFIG: Readonly<ProfilesConfig> = Object.freeze({
+  version: "1.0",
+  activeProfile: null,
+  profiles: Object.freeze({}),
+});
+
+/**
+ * プロファイル名のバリデーションパターン
+ *
+ * 小文字英数字とハイフンのみを許可し、先頭と末尾は英数字でなければなりません。
+ */
+export const PROFILE_NAME_PATTERN = /^[a-z0-9](?:[a-z0-9-]*[a-z0-9])?$/;
+
+/**
+ * プロファイル名をバリデート
+ *
+ * @param name - 検証するプロファイル名
+ * @returns バリデーション結果
+ */
+export function isValidProfileName(name: string): boolean {
+  return name.length > 0 && PROFILE_NAME_PATTERN.test(name);
+}

package/src/web/client/src/pages/BranchDetailPage.tsx

@@ -88,6 +88,66 @@ export function BranchDetailPage() {
     };
   }, [isTerminalFullscreen]);
 
+  // Available tools - must be before conditional returns
+  const customTools: CustomAITool[] = config?.tools ?? [];
+  const availableTools: SelectableTool[] = useMemo(
+    () => [
+      { id: "claude-code", label: "Claude Code", target: "claude" },
+      { id: "codex-cli", label: "Codex CLI", target: "codex" },
+      ...customTools.map(
+        (tool): SelectableTool => ({
+          id: tool.id,
+          label: tool.displayName,
+          target: "custom" as const,
+          definition: tool,
+        }),
+      ),
+    ],
+    [customTools],
+  );
+
+  // Ensure selected tool is valid - must be before conditional returns
+  useEffect(() => {
+    if (!availableTools.length) {
+      setSelectedToolId("claude-code");
+      return;
+    }
+    if (!availableTools.find((tool) => tool.id === selectedToolId)) {
+      const first = availableTools[0];
+      if (first) setSelectedToolId(first.id);
+    }
+  }, [availableTools, selectedToolId]);
+
+  // Branch sessions - must be before conditional returns
+  const branchSessions = useMemo(() => {
+    return (sessionsData ?? [])
+      .filter((session) => session.worktreePath === branch?.worktreePath)
+      .sort((a, b) => (b.startedAt ?? "").localeCompare(a.startedAt ?? ""));
+  }, [sessionsData, branch?.worktreePath]);
+
+  // Latest tool usage - must be before conditional returns
+  const latestToolUsage: LastToolUsage | null = useMemo(() => {
+    if (!branch) return null;
+    if (branch.lastToolUsage) return branch.lastToolUsage;
+    const first = branchSessions[0];
+    if (!first) return null;
+    return {
+      branch: branch.name,
+      worktreePath: branch.worktreePath ?? null,
+      toolId:
+        first.toolType === "custom"
+          ? (first.toolName ?? "custom")
+          : (first.toolType as LastToolUsage["toolId"]),
+      toolLabel:
+        first.toolType === "custom"
+          ? (first.toolName ?? "Custom")
+          : toolLabel(first.toolType),
+      mode: first.mode ?? "normal",
+      model: null,
+      timestamp: first.startedAt ? Date.parse(first.startedAt) : Date.now(),
+    };
+  }, [branch, branchSessions]);
+
   // Loading state
   if (isLoading) {
     return (
@@ -162,74 +222,10 @@ export function BranchDetailPage() {
   );
   const isSyncingBranch = syncBranch.isPending;
 
-  // Available tools
-  const customTools: CustomAITool[] = config?.tools ?? [];
-  const availableTools: SelectableTool[] = useMemo(
-    () => [
-      { id: "claude-code", label: "Claude Code", target: "claude" },
-      { id: "codex-cli", label: "Codex CLI", target: "codex" },
-      ...customTools.map(
-        (tool): SelectableTool => ({
-          id: tool.id,
-          label: tool.displayName,
-          target: "custom" as const,
-          definition: tool,
-        }),
-      ),
-    ],
-    [customTools],
-  );
-
-  // Ensure selected tool is valid
-  useEffect(() => {
-    if (!availableTools.length) {
-      setSelectedToolId("claude-code");
-      return;
-    }
-    if (!availableTools.find((tool) => tool.id === selectedToolId)) {
-      const first = availableTools[0];
-      if (first) setSelectedToolId(first.id);
-    }
-  }, [availableTools, selectedToolId]);
-
   const selectedTool = availableTools.find(
     (tool) => tool.id === selectedToolId,
   );
 
-  // Branch sessions
-  const branchSessions = useMemo(() => {
-    return (sessionsData ?? [])
-      .filter((session) => session.worktreePath === branch?.worktreePath)
-      .sort((a, b) => (b.startedAt ?? "").localeCompare(a.startedAt ?? ""));
-  }, [sessionsData, branch?.worktreePath]);
-
-  // Latest tool usage
-  const latestToolUsage: LastToolUsage | null = useMemo(() => {
-    if (branch?.lastToolUsage) return branch.lastToolUsage;
-    const first = branchSessions[0];
-    if (!first) return null;
-    return {
-      branch: branch.name,
-      worktreePath: branch.worktreePath ?? null,
-      toolId:
-        first.toolType === "custom"
-          ? (first.toolName ?? "custom")
-          : (first.toolType as LastToolUsage["toolId"]),
-      toolLabel:
-        first.toolType === "custom"
-          ? (first.toolName ?? "Custom")
-          : toolLabel(first.toolType),
-      mode: first.mode ?? "normal",
-      model: null,
-      timestamp: first.startedAt ? Date.parse(first.startedAt) : Date.now(),
-    };
-  }, [
-    branch?.lastToolUsage,
-    branch?.name,
-    branch?.worktreePath,
-    branchSessions,
-  ]);
-
   // Handlers
   const handleCreateWorktree = async () => {
     try {

package/src/web/server/tray.ts

@@ -11,15 +11,18 @@ const TRAY_ICON_BASE64 =
   "iVBORw0KGgoAAAANSUhEUgAAABAAAAAQBAMAAADt3eJSAAAABGdBTUEAALGPC/xhBQAAACBjSFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEUAAAAAvNQAvNQAvNQAvNQAvNQAvNQAvNQAvNQAvNQAvNQAvNT////J1ubyAAAAC3RSTlMAJYTcgyQJnJ3U3WXfUogAAAABYktHRAyBs1FjAAAAB3RJTUUH6QwMCRccbOpRBQAAAFdJREFUCNdjYEAARuXNriCarXr37t1tQEYmkN69M4GBoRvE2F3AwAqmd29kYIEwNjEwQxibGbghjN0MXDARJpgaqK6tDAzVUHMQJoPtKgPZyuq8S5WBAQBeRj51tvdhawAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyNS0xMi0xMlQwOToyMzoyOCswMDowMBPEA5UAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjUtMTItMTJUMDk6MjM6MjgrMDA6MDBimbspAAAAAElFTkSuQmCC";
 
 let trayInitAttempted = false;
-let trayInstance: { dispose?: () => void } | null = null;
+type TrayHandle = { dispose?: () => void; kill?: () => void };
+let trayInstance: TrayHandle | null = null;
+let trayInitPromise: Promise<TrayHandle> | null = null;
 
-function shouldEnableTray(): boolean {
+function shouldEnableTray(
+  platform: NodeJS.Platform = process.platform,
+): boolean {
+  // NOTE: `trayicon` is a win32-only dependency.
+  if (platform !== "win32") return false;
   if (process.env.GWT_DISABLE_TRAY?.toLowerCase() === "true") return false;
   if (process.env.GWT_DISABLE_TRAY === "1") return false;
   if (process.env.CI) return false;
-  if (process.platform === "linux") {
-    if (!process.env.DISPLAY && !process.env.WAYLAND_DISPLAY) return false;
-  }
   return true;
 }
 
@@ -52,9 +55,9 @@ export async function openUrl(url: string): Promise<void> {
  */
 export async function startSystemTray(
   url: string,
-  opts?: { openUrl?: OpenUrlFn },
+  opts?: { openUrl?: OpenUrlFn; platform?: NodeJS.Platform },
 ): Promise<void> {
-  if (trayInitAttempted || !shouldEnableTray()) return;
+  if (trayInitAttempted || !shouldEnableTray(opts?.platform)) return;
   trayInitAttempted = true;
 
   const logger = createLogger({ category: "tray" });
@@ -71,14 +74,31 @@ export async function startSystemTray(
     const icon = Buffer.from(TRAY_ICON_BASE64, "base64");
     const open = opts?.openUrl ?? openUrl;
 
-    trayInstance = create({
-      icon,
-      title: "gwt Web UI",
-      tooltip: "Double-click to open Web UI",
-      action: async () => {
-        await open(url);
-      },
-    });
+    const initPromise = Promise.resolve(
+      create({
+        icon,
+        title: "gwt Web UI",
+        tooltip: "Double-click to open Web UI",
+        action: async () => {
+          await open(url);
+        },
+      }) as TrayHandle,
+    );
+    trayInitPromise = initPromise;
+
+    void initPromise
+      .then((tray) => {
+        if (trayInitPromise !== initPromise) {
+          tray.dispose?.();
+          tray.kill?.();
+          return;
+        }
+        trayInstance = tray;
+      })
+      .catch((err) => {
+        if (trayInitPromise !== initPromise) return;
+        logger.warn({ err }, "System tray failed to initialize");
+      });
   } catch (err) {
     logger.warn({ err }, "System tray failed to initialize");
   }
@@ -88,6 +108,13 @@ export async function startSystemTray(
  * システムトレイアイコンを破棄
  */
 export function disposeSystemTray(): void {
-  trayInstance?.dispose?.();
+  trayInitPromise = null;
+
+  const instance = trayInstance;
   trayInstance = null;
+
+  instance?.dispose?.();
+  instance?.kill?.();
+
+  trayInitAttempted = false;
 }