@akinon/pz-theme 2.0.86-rc.0 → 2.0.86

package/CHANGELOG.md

@@ -1,38 +1,19 @@
 # @akinon/pz-theme
 
-## 2.0.86-rc.0
-
-### Patch Changes
-
-- Updated dependencies [86187b1c]
-- Updated dependencies [0cf9ea239]
-- Updated dependencies [324f97d55]
-- Updated dependencies [51ea06888]
-- Updated dependencies
-- Updated dependencies [2fea41430]
-- Updated dependencies [b55acb768]
-- Updated dependencies [760258c1c]
-- Updated dependencies [143be2b9d]
-- Updated dependencies [7889b08fe]
-- Updated dependencies [9f8cd3bc5]
-- Updated dependencies [bfafa3f49]
-- Updated dependencies [57d7eb305]
-- Updated dependencies [d99a6a7d5]
-- Updated dependencies [9db81a714]
-- Updated dependencies [591e345e1]
-- Updated dependencies [4de5303c5]
-- Updated dependencies [95b139dc1]
-- Updated dependencies [1d00f2d06]
-- Updated dependencies [4ac7b2a1e]
-- Updated dependencies [e9598c71d]
-- Updated dependencies [4998a9631]
-- Updated dependencies [804d2bd6c]
-- Updated dependencies [3909d3224]
-- Updated dependencies [6a3d8a631]
-- Updated dependencies [e18836b20]
-- Updated dependencies [b1111d7b]
-  - @akinon/next@2.0.86-rc.0
-  - @akinon/theme-contract@2.0.86-rc.0
+## 2.0.86
+
+### Patch Changes
+
+- 323443c8: ZERO-4911: Fix the four type errors pz-theme's own sources raise in a consumer build
+
+  The package ships its sources, so every consumer type-checks them, and four of its own declarations did not compile. A brand build failed on the first one it reached.
+
+  The hand-built favourite block in the slider quick view omitted the four fields `Block` requires. `CommerceEventDetail` carried an index signature, which makes `Omit` collapse every named field into it, so `currency` arrived as `unknown` where a `string` was wanted; the named facts now live in their own interface that the open one extends. The `Window.dataLayer` augmentation disagreed with the one `@akinon/next` declares, and the same block is duplicated in the sibling test, so both moved together. The line-break predicates were typed against `theme-section`'s `Section` while the CSS generator hands them its own structural copy, so they are now typed by shape.
+
+  None of this is a peer-version problem: `Block`, `Section` and `CommerceEventDetail` are pz-theme's own types, and `dataLayer` is declared identically in every published `@akinon/next`. Every fix is types-only and nothing changes at runtime.
+
+  - @akinon/next@2.0.86
+  - @akinon/theme-contract@2.0.86
 
 ## 2.0.85
 

package/package.json

@@ -1,26 +1,26 @@
 {
   "name": "@akinon/pz-theme",
   "description": "Theme package for Project Zero Next — ThemePlaceholder system and theme editor infrastructure",
-  "version": "2.0.86-rc.0",
+  "version": "2.0.86",
   "license": "MIT",
   "main": "src/index.ts",
   "scripts": {
     "test": "jest"
   },
   "peerDependencies": {
-    "@akinon/next": "2.0.86-rc.0",
+    "@akinon/next": "2.0.86",
     "react": "^18.0.0 || ^19.0.0",
     "react-dom": "^18.0.0 || ^19.0.0"
   },
   "dependencies": {
-    "@akinon/theme-contract": "2.0.86-rc.0",
+    "@akinon/theme-contract": "2.0.86",
     "clsx": "2.1.1",
     "lottie-web": "^5.13.0",
     "tailwind-merge": "^2.5.4",
     "zod": "4.4.1"
   },
   "devDependencies": {
-    "@akinon/next": "2.0.86-rc.0",
+    "@akinon/next": "2.0.86",
     "@testing-library/jest-dom": "5.16.4",
     "@testing-library/react": "16.3.2",
     "@testing-library/user-event": "14.1.1",

package/src/sections/slider-quick-view.tsx

@@ -356,7 +356,18 @@ const SliderQuickView = ({
                   block={{
                     id: `quick-view-favorite-${String(row.pk)}`,
                     type: 'favorite-button',
-                    properties: {}
+                    properties: {},
+                    /*
+                     * Synthesised, not authored: this heart is never part of a
+                     * composition, so it has no layer name, no styles of its
+                     * own and no siblings. The section styles it through its
+                     * own part instead. Written out because `Block` requires
+                     * all four, and a consumer type-checks these sources.
+                     */
+                    label: 'Quick view favourite',
+                    styles: {},
+                    order: 0,
+                    hidden: false
                   }}
                   placeholderId=""
                   sectionId=""

package/src/utils/__tests__/analytics.test.ts

@@ -8,10 +8,15 @@ import {
 
 declare global {
   interface Window {
-    dataLayer?: Array<Record<string, unknown>>;
+    // Must match the augmentation in ../analytics, and the core package's.
+    // eslint-disable-next-line @typescript-eslint/ban-types
+    dataLayer?: Object[];
   }
 }
 
+/** `Object[]` hides the element shape, so reads go through one typed view. */
+const layer = () => (window.dataLayer ?? []) as Array<Record<string, unknown>>;
+
 describe('neutral commerce events (ZERO-4869)', () => {
   let received: Array<Record<string, unknown>>;
   let listener: (event: Event) => void;
@@ -170,7 +175,7 @@ describe('default GA4 dataLayer bridge', () => {
       items: [buildCommerceItem({ pk: 1, name: 'A' })]
     });
 
-    expect(window.dataLayer?.map((e) => e.event)).toEqual(['select_item']);
+    expect(layer().map((e) => e.event)).toEqual(['select_item']);
 
     detach();
   });
@@ -223,7 +228,7 @@ describe('default GA4 dataLayer bridge', () => {
     });
     emitCommerceEvent('search', { searchTerm: 'polo' });
 
-    expect(window.dataLayer?.map((e) => e.event)).toEqual(['wishlist_add']);
+    expect(layer().map((e) => e.event)).toEqual(['wishlist_add']);
     expect(window.dataLayer?.[0]).toMatchObject({ wishlist_source: 'pdp' });
 
     detach();

package/src/utils/analytics.ts

@@ -40,7 +40,13 @@ export interface CommerceItem {
   attributes?: Record<string, string>;
 }
 
-export interface CommerceEventDetail {
+/**
+ * The named commerce facts, declared apart from the open index signature
+ * below. A `[key: string]: unknown` member makes `Omit` and `Pick` collapse
+ * every named field into that signature, so `Omit<CommerceEventDetail,
+ * 'action'>` hands back `currency: unknown` rather than `string`.
+ */
+export interface CommerceFacts {
   action: string;
   currency?: string;
   value?: number;
@@ -48,6 +54,10 @@ export interface CommerceEventDetail {
   searchTerm?: string;
   method?: string;
   transactionId?: string;
+}
+
+/** What rides on the event: the named facts, plus whatever else a brand adds. */
+export interface CommerceEventDetail extends CommerceFacts {
   [key: string]: unknown;
 }
 
@@ -168,8 +178,14 @@ export const readItemsCurrency = (
  */
 export const emitCommerceEvent = (
   action: string,
-  detail: Omit<CommerceEventDetail, 'action'> & {
+  detail: Omit<CommerceFacts, 'action' | 'items'> & {
     items?: Array<CommerceItem | null>;
+    /*
+     * Kept open on purpose. Callers pass arbitrary extra facts today and they
+     * still flow through into the event; narrowing here would break them for
+     * a type error that was never theirs.
+     */
+    [key: string]: unknown;
   } = {}
 ): void => {
   if (typeof window === 'undefined') return;
@@ -220,7 +236,13 @@ export const emitCommerceEvent = (
 
 declare global {
   interface Window {
-    dataLayer?: Array<Record<string, unknown>>;
+    /*
+     * The shape @akinon/next declares, matched exactly. Two augmentations of
+     * one global have to agree or TypeScript refuses both, and the core
+     * package has declared it this way on every major line.
+     */
+    // eslint-disable-next-line @typescript-eslint/ban-types
+    dataLayer?: Object[];
   }
 }
 

package/src/utils/line-breaks.ts

@@ -3,8 +3,6 @@ import {
   TABLET_MIN_WIDTH,
   type BreakpointName
 } from './breakpoints';
-import type { Block } from '../theme-block';
-import type { Section } from '../theme-section';
 
 /**
  * Line breaks that exist at one width and not another.
@@ -110,7 +108,25 @@ const stringsIn = (value: unknown): string[] => {
   return [];
 };
 
-const blockUsesScopedLineBreaks = (block: Block): boolean => {
+/*
+ * Typed by SHAPE rather than against `Block` and `Section`, because the CSS
+ * generator keeps its own structural copies of both and the two families are
+ * not assignable to one another - `generateThemeCSS` hands its own `Section[]`
+ * straight to the predicate below. The same reason `hasCustomSectionRenderer`
+ * is shape-typed.
+ *
+ * These are the three fields the walk actually reads and nothing else, so a
+ * scoped break is found in whichever copy it is kept.
+ */
+type LineBreakBlock = {
+  value?: unknown;
+  properties?: unknown;
+  blocks?: LineBreakBlock[];
+};
+
+type LineBreakSection = { blocks?: LineBreakBlock[] };
+
+const blockUsesScopedLineBreaks = (block: LineBreakBlock): boolean => {
   // `value` holds the rich text (a locale map, or a bare string on a
   // single-locale composition); `properties` holds the authored HTML of the
   // blocks that keep their copy there instead.
@@ -135,7 +151,7 @@ const blockUsesScopedLineBreaks = (block: Block): boolean => {
  * composition with no scoped break emits nothing new.
  */
 export const compositionUsesScopedLineBreaks = (
-  sections: Section[]
+  sections: LineBreakSection[]
 ): boolean =>
   sections.some((section) =>
     (section.blocks ?? []).some(blockUsesScopedLineBreaks)