@akinon/pz-theme 2.0.150-beta.0 → 2.0.150

package/CHANGELOG.md

@@ -1,12 +1,15 @@
 # @akinon/pz-theme
 
-## 2.0.150-beta.0
+## 2.0.150
 
 ### Patch Changes
 
-- Updated dependencies [cbbbfd757]
-  - @akinon/next@2.0.150-beta.0
-  - @akinon/theme-contract@2.0.150-beta.0
+- 6532002: ZERO-5207: Correct what pz-theme's notes say each core provides, and pin the collection widget fallback
+
+  The notes in the server loader, the favourite button, the recommendations block and the reset password check described every gap as a v1 gap. On the latest cores only one remains: `getCollectionWidgetData` (added to the v1 line by ZERO-5207). No core, 1.x or 2.x, has a recommendation or a per-product favourite endpoint, and the reset token query has been on the 1.x line since 1.121.0. A new test pins both halves of the collection widget path: through the core when it exports `getCollectionWidgetData`, straight to the endpoint when it does not. No runtime change.
+
+  - @akinon/next@2.0.150
+  - @akinon/theme-contract@2.0.150
 
 ## 2.0.149
 

package/package.json

@@ -1,19 +1,19 @@
 {
   "name": "@akinon/pz-theme",
   "description": "Theme package for Project Zero Next — ThemePlaceholder system and theme editor infrastructure",
-  "version": "2.0.150-beta.0",
+  "version": "2.0.150",
   "license": "MIT",
   "main": "src/index.ts",
   "scripts": {
     "test": "jest"
   },
   "peerDependencies": {
-    "@akinon/next": "2.0.150-beta.0",
+    "@akinon/next": "2.0.150",
     "react": "^18.0.0 || ^19.0.0",
     "react-dom": "^18.0.0 || ^19.0.0"
   },
   "dependencies": {
-    "@akinon/theme-contract": "2.0.150-beta.0",
+    "@akinon/theme-contract": "2.0.150",
     "clsx": "2.1.1",
     "lottie-web": "^5.13.0",
     "react-multi-carousel": "2.8.4",
@@ -21,7 +21,7 @@
     "zod": "4.4.1"
   },
   "devDependencies": {
-    "@akinon/next": "2.0.150-beta.0",
+    "@akinon/next": "2.0.150",
     "@testing-library/jest-dom": "5.16.4",
     "@testing-library/react": "16.3.2",
     "@testing-library/user-event": "14.1.1",

package/src/__tests__/collection-widget-core-path.test.ts

@@ -0,0 +1,167 @@
+/**
+ * Where a collection-backed section's rows come from on the server.
+ *
+ * A section bound to a product collection is saved as a collection widget
+ * (`/product_collection_widgets/<slug>/`), so its regular widget answer is
+ * empty and the loader asks for the collection widget instead. A core that
+ * exports `getCollectionWidgetData` answers through its cache: every 2.x core,
+ * and the 1.x line from ZERO-5207 on. An older 1.x core has no such export, so
+ * the loader calls the same endpoint itself, uncached.
+ *
+ * Both paths must hand the renderer the same rows; only the cache differs.
+ */
+jest.mock('server-only', () => ({}), { virtual: true });
+
+const getWidgetData = jest.fn();
+const getWidgetSchemaData = jest.fn();
+const getCollectionWidgetData = jest.fn();
+const getPreviewSnapshot = jest.fn();
+const appFetch = jest.fn();
+
+/** The core's server data layer, as this test shapes it. */
+const core: Record<string, unknown> = {
+  __esModule: true,
+  getWidgetData: (...args: unknown[]) => getWidgetData(...args),
+  getWidgetSchemaData: (...args: unknown[]) => getWidgetSchemaData(...args),
+  getCollectionWidgetData: (...args: unknown[]) =>
+    getCollectionWidgetData(...args),
+  getPreviewSnapshot: (...args: unknown[]) => getPreviewSnapshot(...args)
+};
+
+jest.mock('@akinon/next/data/server', () => core);
+
+jest.mock(
+  '@akinon/next/utils/app-fetch',
+  () => ({
+    __esModule: true,
+    default: (...args: unknown[]) => appFetch(...args)
+  }),
+  { virtual: true }
+);
+
+jest.mock(
+  '@akinon/next/utils/server-variables',
+  () => ({ ServerVariables: { locale: 'tr', currency: 'try' } }),
+  { virtual: true }
+);
+
+import { loadPlaceholderSections } from '../load-placeholder-sections';
+
+const SLOT = 'homepage';
+const SECTION = 'collection-slider';
+const SOURCE_ID = 'ds-1';
+const COLLECTION_ENDPOINT = `/product_collection_widgets/${SECTION}/`;
+
+const LIVE_ROWS = [
+  { pk: 1, name: 'Live one', absolute_url: '/live-one/', price: '199.99' }
+];
+
+/** The collection widget's answer: the bound collection's live rows. */
+const COLLECTION_WIDGET = {
+  slug: SECTION,
+  attributes: {},
+  products: LIVE_ROWS
+};
+
+const withCollectionExport = (present: boolean) => {
+  core.getCollectionWidgetData = present
+    ? (...args: unknown[]) => getCollectionWidgetData(...args)
+    : undefined;
+};
+
+const loadSection = async () => {
+  getWidgetData.mockImplementation(async ({ slug }: { slug: string }) => {
+    if (slug === SLOT) {
+      return {
+        slug: SLOT,
+        attributes: {
+          theme_editor_placeholder: {
+            value: JSON.stringify([{ section_slug: SECTION, order: 0 }])
+          }
+        }
+      };
+    }
+
+    if (slug === 'theme-config') {
+      return {
+        slug: 'theme-config',
+        attributes: {
+          theme_dataSources: {
+            value: JSON.stringify([
+              {
+                id: SOURCE_ID,
+                name: 'Picked collection',
+                type: 'collection',
+                details: { collection: { id: 'c-1', products: [] } }
+              }
+            ])
+          }
+        }
+      };
+    }
+
+    // The section itself is a collection widget: the regular endpoint has
+    // nothing for it.
+    return null;
+  });
+
+  getWidgetSchemaData.mockResolvedValue({
+    schema: {
+      [SECTION]: {
+        metadata: {
+          name: 'Product slider',
+          dataSourceId: SOURCE_ID,
+          blocks: []
+        }
+      }
+    }
+  });
+
+  const loaded = await loadPlaceholderSections(SLOT);
+  return loaded?.sections[0];
+};
+
+const collectionEndpointCalls = () =>
+  appFetch.mock.calls.filter(([args]) => args?.url === COLLECTION_ENDPOINT);
+
+beforeEach(() => {
+  getWidgetData.mockReset();
+  getWidgetSchemaData.mockReset();
+  getCollectionWidgetData.mockReset().mockResolvedValue(COLLECTION_WIDGET);
+  getPreviewSnapshot.mockReset().mockResolvedValue(null);
+  appFetch.mockReset().mockResolvedValue(COLLECTION_WIDGET);
+});
+
+afterAll(() => {
+  withCollectionExport(true);
+});
+
+describe('a core that exports getCollectionWidgetData', () => {
+  beforeEach(() => withCollectionExport(true));
+
+  it("reads the section's collection widget through the core", async () => {
+    const section = await loadSection();
+
+    expect(getCollectionWidgetData).toHaveBeenCalledWith({ slug: SECTION });
+    expect(collectionEndpointCalls()).toHaveLength(0);
+    expect(section?.dataSource.details.collection.data).toEqual(
+      COLLECTION_WIDGET
+    );
+  });
+});
+
+describe('an older 1.x core without it', () => {
+  beforeEach(() => withCollectionExport(false));
+
+  it('calls the collection widget endpoint itself and renders the same rows', async () => {
+    const section = await loadSection();
+
+    expect(getCollectionWidgetData).not.toHaveBeenCalled();
+    expect(collectionEndpointCalls()).toEqual([
+      [{ url: COLLECTION_ENDPOINT, locale: 'tr', currency: 'try' }]
+    ]);
+    expect(section?.dataSource.details.collection.data).toEqual(
+      COLLECTION_WIDGET
+    );
+  });
+});

package/src/blocks/favorite-button-block.tsx

@@ -111,9 +111,10 @@ const FavoriteButtonBlock = ({
   const productPk = Number(pickProductField(product, 'pk'));
   const hasProduct = Number.isFinite(productPk) && productPk > 0;
 
-  // The v1 core has no "is this product favourited" endpoint, so the current
-  // state is derived from the favourites list. It is skipped for guests (the
-  // endpoint 401s) and in the designer (no shopper session to reflect).
+  // No core, 1.x or 2.x, has an "is this product favourited" endpoint, so the
+  // current state is derived from the favourites list. It is skipped for
+  // guests (the endpoint 401s) and in the designer (no shopper session to
+  // reflect).
   const { data: favorites } = useGetFavoritesQuery(
     { limit: FAVORITES_PAGE_SIZE },
     { skip: !isAuthenticated || !hasProduct || isDesigner }

package/src/blocks/product-recommendations-block.tsx

@@ -219,8 +219,8 @@ interface RecommendationCard {
 /**
  * Functional PDP/campaign block: a related-products slider.
  *
- * v1 core ships no recommendation endpoint, so the data path is the
- * collection/widget one every storefront already uses: the author names a
+ * No core, 1.x or 2.x, ships a recommendation endpoint, so the data path is
+ * the collection/widget one every storefront already uses: the author names a
  * collection and `getWidget` returns its products in merchandiser order. The
  * cards are laid out exactly like the product grid so a recommendation strip
  * and a PLP card stay visually identical.

package/src/blocks/reset-password-token-check.ts

@@ -45,11 +45,12 @@ const useUncheckedResetToken: ValidateResetTokenHook = () => UNCHECKED;
 /**
  * Read off the module object instead of imported by name.
  *
- * `useGetValidatePasswordResetTokenQuery` arrived with @akinon/next 2.x, and
- * most brands are still on the 1.x line. A brand transpiles and type-checks
- * this package from `src`, so a named import of an export its core does not
- * have fails `next build` before the block can ever run — while a bare runtime
- * lookup would leave `undefined` in a hook position and crash the screen.
+ * Every 2.x core has `useGetValidatePasswordResetTokenQuery`, but it reached
+ * the 1.x line only in 1.121.0 (ZERO-4009), and brands on an older 1.x core
+ * still run this package. A brand transpiles and type-checks this package
+ * from `src`, so a named import of an export its core does not have fails
+ * `next build` before the block can ever run — while a bare runtime lookup
+ * would leave `undefined` in a hook position and crash the screen.
  *
  * Both are answered here: the name never appears in an import clause, so the
  * v1 type-checker has nothing to miss, and the fallback above is bound in its

package/src/load-placeholder-sections.ts

@@ -21,14 +21,16 @@ import { carriesProducts } from './utils/live-rows';
 const { getWidgetData } = serverData;
 
 /**
- * v1 cores ship a smaller server data layer: only `getWidgetData` exists,
- * `getWidgetSchemaData` and `getCollectionWidgetData` arrived with v2.
+ * Older 1.x cores ship a smaller server data layer: every 2.x core has
+ * `getWidgetSchemaData` and `getCollectionWidgetData`, but they reached the
+ * 1.x line only with ZERO-5194 and ZERO-5207.
  *
- * The endpoints are identical on both backends — v1 just never wrapped them.
- * Degrading to "no data" would render every published section *without its
- * blocks* (a section's block tree lives in the widget schema, not in the
- * widget), so on v1 we call the REST endpoints directly. This is what keeps
- * composed pages rendering on the brands still running v1.
+ * The endpoints are identical on both backends — those cores just never
+ * wrapped them. Degrading to "no data" would render every published section
+ * *without its blocks* (a section's block tree lives in the widget schema, not
+ * in the widget), so on such a core we call the REST endpoints directly,
+ * without the core's cache. This is what keeps composed pages rendering on the
+ * brands whose core predates them.
  */
 type ServerDataFn = (<T>(args: never) => Promise<T | null>) | undefined;