@akinon/next 1.92.0-rc.33 → 1.92.0-rc.35

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @akinon/next
 
+## 1.92.0-rc.35
+
+### Minor Changes
+
+- 89ce46fc: ZERO-3493: return 404 status code for pz-not-found pages
+
+## 1.92.0-rc.34
+
+### Minor Changes
+
+- 0ad91bbd: ZERO-3489: Improve error handling in data fetching across multiple pages and server functions
+
 ## 1.92.0-rc.33
 
 ## 1.92.0-rc.32

package/data/server/category.ts

@@ -5,7 +5,6 @@ import { category, product } from '../urls';
 import { Cache, CacheKey } from '../../lib/cache';
 import { parse } from 'lossless-json';
 import logger from '../../utils/log';
-import { headers as nHeaders } from 'next/headers';
 import { ServerVariables } from '../../utils/server-variables';
 
 function getCategoryDataHandler(
@@ -18,19 +17,30 @@ function getCategoryDataHandler(
   return async function () {
     const params = generateCommerceSearchParams(searchParams);
 
-    const rawData = await appFetch<string>({
-      url: `${category.getCategoryByPk(pk)}${params ? params : ''}`,
-      locale,
-      currency,
-      init: {
-        headers: {
-          Accept: 'application/json',
-          'Content-Type': 'application/json',
-          ...(headers ?? {})
-        }
-      },
-      responseType: FetchResponseType.TEXT
-    });
+    let rawData: string;
+
+    try {
+      rawData = await appFetch<string>({
+        url: `${category.getCategoryByPk(pk)}${params ? params : ''}`,
+        locale,
+        currency,
+        init: {
+          headers: {
+            Accept: 'application/json',
+            'Content-Type': 'application/json',
+            ...(headers ?? {})
+          }
+        },
+        responseType: FetchResponseType.TEXT
+      });
+    } catch (error) {
+      logger.error('Failed to fetch category data', {
+        handler: 'getCategoryDataHandler',
+        pk,
+        error: error.message
+      });
+      return null;
+    }
 
     let data: GetCategoryResponse;
 
@@ -64,17 +74,27 @@ function getCategoryDataHandler(
       return { data, breadcrumbData: undefined };
     }
 
-    const breadcrumbData = await appFetch<any>({
-      url: product.breadcrumbUrl(menuItemModel),
-      locale,
-      currency,
-      init: {
-        headers: {
-          Accept: 'application/json',
-          'Content-Type': 'application/json'
+    let breadcrumbData: { menu?: unknown } = {};
+
+    try {
+      breadcrumbData = await appFetch<{ menu?: unknown }>({
+        url: product.breadcrumbUrl(menuItemModel),
+        locale,
+        currency,
+        init: {
+          headers: {
+            Accept: 'application/json',
+            'Content-Type': 'application/json'
+          }
         }
-      }
-    });
+      });
+    } catch (error) {
+      logger.warn('Failed to fetch breadcrumb data', {
+        handler: 'getCategoryDataHandler',
+        pk,
+        error: error.message
+      });
+    }
 
     return { data, breadcrumbData: breadcrumbData?.menu };
   };

package/data/server/flatpage.ts

@@ -11,20 +11,24 @@ const getFlatPageDataHandler = (
   headers?: Record<string, string>
 ) => {
   return async function () {
-    const data = await appFetch<FlatPage>({
-      url: flatpage.getFlatPageByPk(pk),
-      locale,
-      currency,
-      init: {
-        headers: {
-          Accept: 'application/json',
-          'Content-Type': 'application/json',
-          ...(headers ?? {})
+    try {
+      const data = await appFetch<FlatPage>({
+        url: flatpage.getFlatPageByPk(pk),
+        locale,
+        currency,
+        init: {
+          headers: {
+            Accept: 'application/json',
+            'Content-Type': 'application/json',
+            ...(headers ?? {})
+          }
         }
-      }
-    });
+      });
 
-    return data;
+      return data;
+    } catch (error) {
+      return null;
+    }
   };
 };
 

package/data/server/landingpage.ts

@@ -11,20 +11,24 @@ const getLandingPageHandler = (
   headers?: Record<string, string>
 ) => {
   return async function () {
-    const data = await appFetch<LandingPage>({
-      url: landingpage.getLandingPageByPk(pk),
-      locale,
-      currency,
-      init: {
-        headers: {
-          Accept: 'application/json',
-          'Content-Type': 'application/json',
-          ...(headers ?? {})
+    try {
+      const data = await appFetch<LandingPage>({
+        url: landingpage.getLandingPageByPk(pk),
+        locale,
+        currency,
+        init: {
+          headers: {
+            Accept: 'application/json',
+            'Content-Type': 'application/json',
+            ...(headers ?? {})
+          }
         }
-      }
-    });
+      });
 
-    return data;
+      return data;
+    } catch (error) {
+      return null;
+    }
   };
 };
 

package/data/server/list.ts

@@ -16,19 +16,29 @@ const getListDataHandler = (
   return async function () {
     const params = generateCommerceSearchParams(searchParams);
 
-    const rawData = await appFetch<string>({
-      url: `${category.list}${params}`,
-      locale,
-      currency,
-      init: {
-        headers: {
-          Accept: 'application/json',
-          'Content-Type': 'application/json',
-          ...(headers ?? {})
-        }
-      },
-      responseType: FetchResponseType.TEXT
-    });
+    let rawData: string;
+
+    try {
+      rawData = await appFetch<string>({
+        url: `${category.list}${params}`,
+        locale,
+        currency,
+        init: {
+          headers: {
+            Accept: 'application/json',
+            'Content-Type': 'application/json',
+            ...(headers ?? {})
+          }
+        },
+        responseType: FetchResponseType.TEXT
+      });
+    } catch (error) {
+      logger.error('Failed to fetch list data', {
+        handler: 'getListDataHandler',
+        error: error.message
+      });
+      return null;
+    }
 
     let data: GetCategoryResponse;
 

package/data/server/product.ts

@@ -35,57 +35,84 @@ const getProductDataHandler = ({
           .join('&');
     }
 
-    const data = await appFetch<ProductResult>({
-      url,
-      locale,
-      currency,
-      init: {
-        headers: {
-          Accept: 'application/json',
-          'Content-Type': 'application/json',
-          ...(headers ?? {})
+    let data: ProductResult;
+
+    try {
+      data = await appFetch<ProductResult>({
+        url,
+        locale,
+        currency,
+        init: {
+          headers: {
+            Accept: 'application/json',
+            'Content-Type': 'application/json',
+            ...(headers ?? {})
+          }
         }
-      }
-    });
+      });
+    } catch (error) {
+      logger.error('Failed to fetch product data', {
+        handler: 'getProductDataHandler',
+        pk,
+        error: error.message,
+        url
+      });
+      return null;
+    }
 
     const categoryUrl = product.categoryUrl(data.product.pk);
 
-    const productCategoryData = await appFetch<ProductCategoryResult>({
-      url: categoryUrl,
-      locale,
-      currency,
-      init: {
-        headers: {
-          Accept: 'application/json',
-          'Content-Type': 'application/json'
+    let productCategoryData: ProductCategoryResult;
+    let breadcrumbData: { menu?: unknown } = {};
+
+    try {
+      productCategoryData = await appFetch<ProductCategoryResult>({
+        url: categoryUrl,
+        locale,
+        currency,
+        init: {
+          headers: {
+            Accept: 'application/json',
+            'Content-Type': 'application/json'
+          }
         }
+      });
+
+      const menuItemModel = productCategoryData?.results[0]?.menuitemmodel;
+
+      if (!menuItemModel) {
+        logger.warn(
+          'menuItemModel is undefined, skipping breadcrumbData fetch',
+          {
+            handler: 'getProductDataHandler',
+            pk
+          }
+        );
+        return { data, breadcrumbData: undefined };
       }
-    });
 
-    const menuItemModel = productCategoryData?.results[0]?.menuitemmodel;
+      const breadcrumbUrl = product.breadcrumbUrl(menuItemModel);
 
-    if (!menuItemModel) {
-      logger.warn('menuItemModel is undefined, skipping breadcrumbData fetch', {
+      breadcrumbData = await appFetch<{ menu?: unknown }>({
+        url: breadcrumbUrl,
+        locale,
+        currency,
+        init: {
+          headers: {
+            Accept: 'application/json',
+            'Content-Type': 'application/json'
+          }
+        }
+      });
+    } catch (error) {
+      logger.warn('Failed to fetch breadcrumb data', {
         handler: 'getProductDataHandler',
-        pk
+        pk,
+        error: error.message
       });
-      return { data, breadcrumbData: undefined };
+      // Continue without breadcrumb data
     }
 
-    const breadcrumbUrl = product.breadcrumbUrl(menuItemModel);
-
-    const breadcrumbData = await appFetch<any>({
-      url: breadcrumbUrl,
-      locale,
-      currency,
-      init: {
-        headers: {
-          Accept: 'application/json',
-          'Content-Type': 'application/json'
-        }
-      }
-    });
-
     return {
       data,
       breadcrumbData: breadcrumbData?.menu

package/data/server/special-page.ts

@@ -15,20 +15,24 @@ const getSpecialPageDataHandler = (
   return async function () {
     const params = generateCommerceSearchParams(searchParams);
 
-    const data: GetCategoryResponse = await appFetch({
-      url: `${category.getSpecialPageByPk(pk)}${params}`,
-      locale,
-      currency,
-      init: {
-        headers: {
-          Accept: 'application/json',
-          'Content-Type': 'application/json',
-          ...(headers ?? {})
+    try {
+      const data: GetCategoryResponse = await appFetch({
+        url: `${category.getSpecialPageByPk(pk)}${params}`,
+        locale,
+        currency,
+        init: {
+          headers: {
+            Accept: 'application/json',
+            'Content-Type': 'application/json',
+            ...(headers ?? {})
+          }
         }
-      }
-    });
+      });
 
-    return data;
+      return data;
+    } catch (error) {
+      return null;
+    }
   };
 };
 

package/middlewares/default.ts

@@ -302,19 +302,6 @@ const withPzDefault =
                                     )}`;
                                 }
 
-                                if (
-                                  !req.middlewareParams.found &&
-                                  Settings.customNotFoundEnabled
-                                ) {
-                                  const pathname = url.pathname
-                                    .replace(/\/+$/, '')
-                                    .split('/');
-                                  url.pathname = url.pathname.replace(
-                                    pathname.pop(),
-                                    'pz-not-found'
-                                  );
-                                }
-
                                 Settings.rewrites.forEach((rewrite) => {
                                   url.pathname = url.pathname.replace(
                                     rewrite.source,
@@ -352,6 +339,24 @@ const withPzDefault =
                                   middlewareResult = NextResponse.rewrite(url);
                                 }
 
+                                if (
+                                  !req.middlewareParams.found &&
+                                  Settings.customNotFoundEnabled
+                                ) {
+                                  const pathSegments = url.pathname
+                                    .replace(/\/+$/, '')
+                                    .split('/');
+                                  if (pathSegments.length >= 3) {
+                                    url.pathname = `/${pathSegments[1]}/${pathSegments[2]}/pz-not-found`;
+                                  } else {
+                                    url.pathname = '/pz-not-found';
+                                  }
+
+                                  middlewareResult = NextResponse.rewrite(url, {
+                                    status: 404
+                                  });
+                                }
+
                                 const { localeUrlStrategy } =
                                   Settings.localization;
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@akinon/next",
   "description": "Core package for Project Zero Next",
-  "version": "1.92.0-rc.33",
+  "version": "1.92.0-rc.35",
   "private": false,
   "license": "MIT",
   "bin": {
@@ -34,7 +34,7 @@
     "set-cookie-parser": "2.6.0"
   },
   "devDependencies": {
-    "@akinon/eslint-plugin-projectzero": "1.92.0-rc.33",
+    "@akinon/eslint-plugin-projectzero": "1.92.0-rc.35",
     "@babel/core": "7.26.10",
     "@babel/preset-env": "7.26.9",
     "@babel/preset-typescript": "7.27.0",

package/utils/app-fetch.ts

@@ -60,6 +60,11 @@ const appFetch = async <T>({
     status = req.status;
     logger.debug(`FETCH END ${url}`, { status: req.status, ip });
 
+    if (!req.ok) {
+      const errorMessage = `HTTP ${req.status}: ${req.statusText}`;
+      throw new Error(errorMessage);
+    }
+
     if (responseType === FetchResponseType.JSON) {
       response = (await req.json()) as T;
     } else {