@akinon/next 1.126.16 → 1.126.17

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @akinon/next
 
+## 1.126.17
+
+### Patch Changes
+
+- 0fe8ab7: ZERO-5209: Close the theme editor's package and CLI gaps on the v1 line
+
+  - `@akinon/pz-list-hover-image` is published on the v1 line, registered in the plugin list and in `PluginModule` (`Component.ListHoverImage`), and offered by `projectzero --plugins`. Until now `pz-install-plugins` asked for `@akinon/pz-list-hover-image@<@akinon/next version>`, which never existed for 1.x, so the plugin could not be installed on a v1 project.
+  - `projectzero codemod --codemod=composable-auth` is available on the v1 CLI. It moves the login page into an `auth/(login)` route group and mounts the theme editor's login slot there. It leaves a project without `@akinon/pz-theme` (or with one older than 2.0.41) untouched instead of writing a layout that cannot build.
+  - `@akinon/pz-theme` and `@akinon/theme-contract` are transpiled by `withPzConfig`, and `pz-postinstall` no longer removes `@akinon/pz-theme` when it is missing from `src/plugins.js`, as on main. Brands that added both packages to `transpilePackages` by hand can drop that override. Keep `'pz-theme'` in `src/plugins.js` unless `tailwind.config.js` lists pz-theme's sources itself: that entry is also what puts them in Tailwind's `content`.
+
 ## 1.126.16
 
 ### Patch Changes

package/__tests__/theme-editor-packages.test.ts

@@ -0,0 +1,81 @@
+import fs from 'fs';
+import os from 'os';
+import path from 'path';
+
+/**
+ * The theme editor packages (@akinon/pz-theme, @akinon/theme-contract) ship
+ * TypeScript sources and are released from main only, so a v1 brand gets them
+ * at a 2.x version next to a 1.x core. These pin what the core does for them,
+ * as on main: transpile both, and keep pz-theme through `pz-postinstall`.
+ */
+describe('withPzConfig transpilePackages', () => {
+  const withPzConfig = require('../with-pz-config.js');
+
+  it.each([
+    '@akinon/next',
+    '@akinon/pz-theme',
+    '@akinon/theme-contract',
+    '@akinon/pz-list-hover-image'
+  ])('transpiles %s', (name) => {
+    expect(withPzConfig({}).transpilePackages).toContain(name);
+  });
+});
+
+describe('pz-install-plugins', () => {
+  let baseDir: string;
+  let execSync: jest.Mock;
+
+  const run = (dependencies: Record<string, string>, plugins: string[]) => {
+    fs.writeFileSync(
+      path.join(baseDir, 'package.json'),
+      JSON.stringify({ name: 'brand', dependencies })
+    );
+    fs.writeFileSync(
+      path.join(baseDir, 'src', 'plugins.js'),
+      `module.exports = ${JSON.stringify(plugins)};`
+    );
+
+    jest.isolateModules(() => {
+      jest.doMock('child_process', () => ({ execSync }));
+      jest.doMock('../utils/find-base-dir', () => () => baseDir);
+      require('../bin/pz-install-plugins.js');
+    });
+
+    return execSync.mock.calls.map(([command]) => command);
+  };
+
+  beforeEach(() => {
+    baseDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pz-install-plugins-'));
+    fs.mkdirSync(path.join(baseDir, 'src'));
+    execSync = jest.fn();
+  });
+
+  afterEach(() => {
+    fs.rmSync(baseDir, { recursive: true, force: true });
+  });
+
+  it('keeps @akinon/pz-theme when src/plugins.js does not list it', () => {
+    const commands = run(
+      {
+        '@akinon/next': '1.126.17',
+        '@akinon/pz-otp': '1.126.17',
+        '@akinon/pz-theme': '2.0.143'
+      },
+      []
+    );
+
+    expect(commands).toEqual(['yarn remove @akinon/pz-otp']);
+  });
+
+  // A plugin is installed at the core's own version, which is why
+  // pz-list-hover-image needs a 1.x release before a v1 brand can add it.
+  it('installs pz-list-hover-image at the core version', () => {
+    const commands = run({ '@akinon/next': '1.126.17' }, [
+      'pz-list-hover-image'
+    ]);
+
+    expect(commands).toEqual([
+      'yarn add @akinon/pz-list-hover-image@1.126.17 --exact --ignore-scripts'
+    ]);
+  });
+});

package/bin/pz-install-plugins.js

@@ -26,7 +26,7 @@ try {
   process.exit(1);
 }
 
-const protectedPackages = ['@akinon/next', 'next'];
+const protectedPackages = ['@akinon/next', '@akinon/pz-theme', 'next'];
 
 const pluginsToRemove = Object.keys(packageJson.dependencies || {}).filter(
   (dep) =>

package/components/plugin-module.tsx

@@ -27,7 +27,8 @@ enum Plugin {
   MasterpassRest = 'pz-masterpass-rest',
   SimilarProducts = 'pz-similar-products',
   Haso = 'pz-haso',
-  GooglePay = 'pz-google-pay'
+  GooglePay = 'pz-google-pay',
+  ListHoverImage = 'pz-list-hover-image'
 }
 
 export enum Component {
@@ -68,7 +69,8 @@ export enum Component {
   ImageSearchButton = 'ImageSearchButton',
   HeaderImageSearchFeature = 'HeaderImageSearchFeature',
   HasoPaymentGateway = 'HasoPaymentGateway',
-  GooglePay = 'GooglePay'
+  GooglePay = 'GooglePay',
+  ListHoverImage = 'ListHoverImage'
 }
 
 const PluginComponents = new Map([
@@ -123,7 +125,8 @@ const PluginComponents = new Map([
   [Plugin.Hepsipay, [Component.Hepsipay]],
   [Plugin.MasterpassRest, [Component.MasterpassRest]],
   [Plugin.Haso, [Component.HasoPaymentGateway]],
-  [Plugin.GooglePay, [Component.GooglePay]]
+  [Plugin.GooglePay, [Component.GooglePay]],
+  [Plugin.ListHoverImage, [Component.ListHoverImage]]
 ]);
 
 const getPlugin = (component: Component) => {
@@ -202,6 +205,8 @@ export default function PluginModule({
               promise = import(`${'@akinon/pz-haso'}`);
             } else if (plugin === Plugin.GooglePay) {
               promise = import(`${'@akinon/pz-google-pay'}`);
+            } else if (plugin === Plugin.ListHoverImage) {
+              promise = import(`${'@akinon/pz-list-hover-image'}`);
             }
           } catch (error) {
             logger.error(error);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@akinon/next",
   "description": "Core package for Project Zero Next",
-  "version": "1.126.16",
+  "version": "1.126.17",
   "private": false,
   "license": "MIT",
   "bin": {
@@ -35,7 +35,7 @@
     "set-cookie-parser": "2.6.0"
   },
   "devDependencies": {
-    "@akinon/eslint-plugin-projectzero": "1.126.16",
+    "@akinon/eslint-plugin-projectzero": "1.126.17",
     "@babel/core": "7.26.10",
     "@babel/preset-env": "7.26.9",
     "@babel/preset-typescript": "7.27.0",

package/plugins.js

@@ -23,5 +23,6 @@ module.exports = [
   'pz-masterpass-rest',
   'pz-similar-products',
   'pz-haso',
-  'pz-google-pay'
+  'pz-google-pay',
+  'pz-list-hover-image'
 ];

package/with-pz-config.js

@@ -5,7 +5,12 @@ const deepMerge = require('./utils/deep-merge');
 const defaultConfig = {
   experimental: { instrumentationHook: true },
   reactStrictMode: true,
-  transpilePackages: ['@akinon/next', ...pzPlugins.map((p) => `@akinon/${p}`)],
+  transpilePackages: [
+    '@akinon/next',
+    '@akinon/pz-theme',
+    '@akinon/theme-contract',
+    ...pzPlugins.map((p) => `@akinon/${p}`)
+  ],
   skipTrailingSlashRedirect: true,
   poweredByHeader: false,
   cacheMaxMemorySize: 0,