@akinon/next 1.126.14-v1-rc.11 → 1.126.14

package/CHANGELOG.md

@@ -1,17 +1,10 @@
 # @akinon/next
 
-## 1.126.14-v1-rc.11
+## 1.126.14
 
 ### Patch Changes
 
-- a34bb1b: ZERO-5168: Post the attribute-based shipping selection to the page name Commerce reports
-
-## 1.126.14-v1-rc.10
-
-### Patch Changes
-
-- d480941: ZERO-4399: add card rewards to pz-masterpass-rest
-- 182a639b: ZERO-4483: Verify v1-rc maintenance pipeline (no-op patch to confirm v1-rc dist-tag flow)
+- fb75f8e: ZERO-5168: Post the attribute-based shipping selection to the page name Commerce reports
 
 ## 1.126.13
 

package/__tests__/attribute-based-shipping-middleware.test.ts

@@ -49,17 +49,21 @@ describe('attributeBasedShippingOptionMiddleware', () => {
     expect(result).toBeNull();
   });
 
-  it('skips a group that came back without any option', () => {
-    const { dispatch } = run({
+  it('posts nothing when only some of the reported groups are selectable', () => {
+    // The backend rejects a selection that does not cover every group it
+    // reported, and that rejection leaves pre_order empty, which re-arms this
+    // middleware. Posting a partial map would loop.
+    const { dispatch, result, action } = run({
       express: group(11),
       None: group()
     });
 
-    expect(mockInitiate).toHaveBeenCalledWith({ express: 11 });
-    expect(dispatch).toHaveBeenCalledTimes(1);
+    expect(mockInitiate).not.toHaveBeenCalled();
+    expect(dispatch).not.toHaveBeenCalled();
+    expect(result).toBe(action);
   });
 
-  it('does not dispatch when no group has a selectable option', () => {
+  it('does not dispatch when no group has a selectable option at all', () => {
     const { dispatch, result, action } = run({ None: group() });
 
     expect(mockInitiate).not.toHaveBeenCalled();
@@ -71,4 +75,11 @@ describe('attributeBasedShippingOptionMiddleware', () => {
     expect(() => run({ None: {} })).not.toThrow();
     expect(mockInitiate).not.toHaveBeenCalled();
   });
+
+  it('still posts when every reported group is selectable', () => {
+    const { dispatch } = run({ express: group(11), standart: group(21, 22) });
+
+    expect(mockInitiate).toHaveBeenCalledWith({ express: 11, standart: 21 });
+    expect(dispatch).toHaveBeenCalledTimes(1);
+  });
 });

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@akinon/next",
   "description": "Core package for Project Zero Next",
-  "version": "1.126.14-v1-rc.11",
+  "version": "1.126.14",
   "private": false,
   "license": "MIT",
   "bin": {
@@ -35,7 +35,7 @@
     "set-cookie-parser": "2.6.0"
   },
   "devDependencies": {
-    "@akinon/eslint-plugin-projectzero": "1.126.14-v1-rc.11",
+    "@akinon/eslint-plugin-projectzero": "1.126.14",
     "@babel/core": "7.26.10",
     "@babel/preset-env": "7.26.9",
     "@babel/preset-typescript": "7.27.0",

package/redux/middlewares/pre-order/attribute-based-shipping-option.ts

@@ -21,10 +21,9 @@ export const attributeBasedShippingOptionMiddleware: Middleware = ({
       Object.keys(attributeBasedShippingOptions).length > 0 &&
       !preOrder.attribute_based_shipping_options
     ) {
-      // A group can come back without any option -- the remote grouping falls
-      // back to a single group when its provider is unreachable, and no rule
-      // ships for it. Skip those instead of indexing into an empty list, which
-      // would throw inside the middleware chain and drop the whole response.
+      // A group can come back without any option: the service logs it and still
+      // reports the group with an empty list, so indexing into it would throw
+      // inside the middleware chain and drop the whole checkout response.
       const initialSelectedOptions: Record<string, number> = {};
 
       Object.entries(attributeBasedShippingOptions).forEach(([key, group]) => {
@@ -35,7 +34,13 @@ export const attributeBasedShippingOptionMiddleware: Middleware = ({
         }
       });
 
-      if (Object.keys(initialSelectedOptions).length === 0) {
+      // The backend rejects a selection that does not cover every group it
+      // reported, and the rejection leaves pre_order empty, which brings us
+      // straight back here. Post nothing rather than start that loop.
+      if (
+        Object.keys(initialSelectedOptions).length !==
+        Object.keys(attributeBasedShippingOptions).length
+      ) {
         return result;
       }