@akanjs/devkit 3.0.0-beta.24 → 3.0.0-beta.25

package/incrementalBuilder/incrementalBuilder.proc.test.ts

@@ -16,7 +16,7 @@ const until = async (proc: Bun.Subprocess, what: string, condition: () => boolea
 };
 
 describe("incremental builder process", () => {
-  test("says why and where a route's client bundle failed, in its answer, its build status and its log", async () => {
+  test("says why and where a route's client bundle failed, in its answer, its build status and its log, at the builder's generation", async () => {
     const { root } = track(await createTempApp("demo"));
     const appDir = path.join(root, "apps/demo");
     // The batch runner looks under the workspace root first: a stand-in for the boot build, which needs a whole app.
@@ -44,6 +44,7 @@ process.send({ type: "build-batch-result", data: { generation, errors: {}, artif
         AKAN_PUBLIC_SERVE_DOMAIN: "localhost",
         AKAN_PUBLIC_ENV: "local",
         AKAN_WATCH: "0",
+        AKAN_BUILDER_INITIAL_GENERATION: "5",
       },
       stdio: ["ignore", "ignore", "pipe"],
       serialization: "advanced",
@@ -64,6 +65,8 @@ process.send({ type: "build-batch-result", data: { generation, errors: {}, artif
       await until(proc, "build-route-res", () => messages.some((message) => message.type === "build-route-res"));
     } finally {
       proc.kill();
+      //? Windows refuses to remove a directory a live process has as its cwd.
+      await proc.exited;
     }
     const log = await new Response(proc.stderr).text();
 
@@ -74,8 +77,132 @@ process.send({ type: "build-batch-result", data: { generation, errors: {}, artif
       error: expect.stringContaining(reason),
     });
     expect(messages.find((message) => message.type === "build-status")).toMatchObject({
-      data: { generation: 3, phase: "route", ok: false, message: expect.stringContaining(reason) },
+      data: { generation: 6, phase: "route", ok: false, message: expect.stringContaining(reason) },
     });
     expect(log).toContain(reason);
   }, 30_000);
+
+  test("a killed boot build is tried again after the crash window, before boot-armed; a route build's check waits likewise", async () => {
+    // Inside the checkout so the route's client bundle resolves the framework from its source.
+    const { root } = track(await createTempApp("demo", path.join(import.meta.dir, "..", "local")));
+    const appDir = path.join(root, "apps/demo");
+    const runs = path.join(root, "ssr-runs.log");
+    // The first two registry builds are killed (the boot build and its retry), the third succeeds.
+    await writeText(
+      path.join(root, "pkgs/@akanjs/devkit/incrementalBuilder/buildBatch.proc.ts"),
+      `import fs from "node:fs";
+const { generation, needs } = JSON.parse(process.argv[2]);
+if (needs.includes("ssr")) {
+  fs.appendFileSync(${JSON.stringify(runs)}, Date.now() + "\\n");
+  if (fs.readFileSync(${JSON.stringify(runs)}, "utf8").trim().split("\\n").length <= 2) process.exit(1);
+}
+process.send({ type: "build-batch-result", data: { generation, errors: {}, artifact: {}, optimizedFonts: { css: "", files: [] } } });
+`,
+    );
+    const page = path.join(appDir, "page/_index.tsx");
+    await writeText(page, 'import { Card } from "../ui/Card";\nexport default Card;\n');
+    await writeText(path.join(appDir, "ui/Card.tsx"), '"use client";\nexport const Card = () => null;\n');
+
+    const messages: BuilderMessage[] = [];
+    const proc = Bun.spawn(["bun", path.join(import.meta.dir, "incrementalBuilder.proc.ts")], {
+      cwd: appDir,
+      env: {
+        ...process.env,
+        AKAN_WORKSPACE_ROOT: root,
+        AKAN_PUBLIC_APP_NAME: "demo",
+        AKAN_PUBLIC_REPO_NAME: "repo",
+        AKAN_PUBLIC_SERVE_DOMAIN: "localhost",
+        AKAN_PUBLIC_ENV: "local",
+        AKAN_WATCH: "0",
+      },
+      stdio: ["ignore", "ignore", "ignore"],
+      serialization: "advanced",
+      ipc: (message: BuilderMessage) => {
+        messages.push(message);
+      },
+    });
+    const ssrRuns = async () =>
+      (await Bun.file(runs).exists()) ? (await Bun.file(runs).text()).trim().split("\n").map(Number) : [];
+    try {
+      await until(proc, "boot-armed", () => messages.some((message) => message.type === "boot-armed"));
+      const [first = 0, second = 0] = await ssrRuns();
+      expect(await ssrRuns()).toHaveLength(2);
+      expect(second - first).toBeGreaterThanOrEqual(9_500);
+      proc.send({
+        type: "build-route",
+        id: 1,
+        routeId: "page:/",
+        seeds: [page],
+        knownEntries: [],
+        generation: 3,
+      } satisfies BuilderReq);
+      await until(proc, "build-route-res", () => messages.some((message) => message.type === "build-route-res"));
+      expect(messages.find((message) => message.type === "build-route-res")).toMatchObject({ ok: true });
+      const deadline = Date.now() + 15_000;
+      while ((await ssrRuns()).length < 3 && Date.now() < deadline) await wait(100);
+      const [, retried = 0, third = 0] = await ssrRuns();
+      expect(third - retried).toBeGreaterThanOrEqual(9_500);
+    } finally {
+      proc.kill();
+      await proc.exited;
+    }
+  }, 60_000);
+
+  test("a route build's registry check that has nothing to add reports no ssr status, so it cannot hide a failure", async () => {
+    const { root } = track(await createTempApp("demo", path.join(import.meta.dir, "..", "local")));
+    const appDir = path.join(root, "apps/demo");
+    // The registry's own build is the real worker's; the rest is stood in for, as a boot build needs a whole app.
+    await writeText(
+      path.join(root, "pkgs/@akanjs/devkit/incrementalBuilder/buildBatch.proc.ts"),
+      `const { generation, needs } = JSON.parse(process.argv[2]);
+if (needs.includes("ssr")) await import(${JSON.stringify(path.join(import.meta.dir, "buildBatch.proc.ts"))});
+else process.send({ type: "build-batch-result", data: { generation, errors: {}, artifact: {}, optimizedFonts: { css: "", files: [] } } });
+`,
+    );
+    await writeText(path.join(appDir, "env/env.client.ts"), "export const env = {} as const;\n");
+    const page = path.join(appDir, "page/_index.tsx");
+    await writeText(page, 'import { Card } from "../ui/Card";\nexport default Card;\n');
+    await writeText(path.join(appDir, "ui/Card.tsx"), '"use client";\nexport const Card = () => null;\n');
+
+    const messages: BuilderMessage[] = [];
+    const proc = Bun.spawn(["bun", path.join(import.meta.dir, "incrementalBuilder.proc.ts")], {
+      cwd: appDir,
+      env: {
+        ...process.env,
+        AKAN_WORKSPACE_ROOT: root,
+        AKAN_PUBLIC_APP_NAME: "demo",
+        AKAN_PUBLIC_REPO_NAME: "repo",
+        AKAN_PUBLIC_SERVE_DOMAIN: "localhost",
+        AKAN_PUBLIC_ENV: "local",
+        AKAN_WATCH: "0",
+      },
+      stdio: ["ignore", "ignore", "ignore"],
+      serialization: "advanced",
+      ipc: (message: BuilderMessage) => {
+        messages.push(message);
+      },
+    });
+    const ssrStatuses = () =>
+      messages.filter((message) => message.type === "build-status" && message.data.phase === "ssr");
+    try {
+      await until(proc, "boot-armed", () => messages.some((message) => message.type === "boot-armed"));
+      expect(messages.some((message) => message.type === "ssr-updated")).toBe(true);
+      const before = ssrStatuses().length;
+      proc.send({
+        type: "build-route",
+        id: 1,
+        routeId: "page:/",
+        seeds: [page],
+        knownEntries: [],
+        generation: 3,
+      } satisfies BuilderReq);
+      await until(proc, "build-route-res", () => messages.some((message) => message.type === "build-route-res"));
+      expect(messages.find((message) => message.type === "build-route-res")).toMatchObject({ ok: true });
+      await wait(200);
+      expect(ssrStatuses().length).toBe(before);
+    } finally {
+      proc.kill();
+      await proc.exited;
+    }
+  }, 60_000);
 });