@akanjs/devkit 3.0.0-beta.2 → 3.0.0-beta.20

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (265) hide show
  1. package/README.md +1 -0
  2. package/abstractDoc.test.ts +6 -15
  3. package/abstractDoc.ts +6 -8
  4. package/agentsIndex.test.ts +4 -7
  5. package/agentsIndex.ts +6 -22
  6. package/akanApp/BackendImportGraph.test.ts +8 -22
  7. package/akanApp/BackendImportGraph.ts +1 -20
  8. package/akanApp/akanApp.host.test.ts +1 -3
  9. package/akanApp/akanApp.host.ts +82 -254
  10. package/akanApp/devHostPolicy.test.ts +10 -34
  11. package/akanApp/devHostPolicy.ts +12 -98
  12. package/akanConfig/akanConfig.test.ts +85 -69
  13. package/akanConfig/akanConfig.ts +69 -153
  14. package/akanConfig/types.ts +1 -0
  15. package/akanContext.ts +106 -159
  16. package/akanMcpContract.ts +28 -73
  17. package/appSelectionMemory.ts +1 -4
  18. package/applicationBuildReporter.ts +37 -5
  19. package/applicationBuildRunner.test.ts +5 -3
  20. package/applicationBuildRunner.ts +54 -61
  21. package/applicationReleasePackager.ts +24 -44
  22. package/applicationTestPreload.ts +3 -12
  23. package/artifact/implicitRootLayout.test.ts +9 -30
  24. package/artifact/implicitRootLayout.ts +34 -106
  25. package/artifact/routeSeedIndex.test.ts +7 -6
  26. package/artifact/routeSeedIndex.ts +11 -44
  27. package/biome.base.json +6 -1
  28. package/biomeBase.ts +2 -5
  29. package/capacitorApp.test.ts +32 -16
  30. package/capacitorApp.ts +110 -238
  31. package/cloud/cloudApi.test.ts +202 -0
  32. package/cloud/cloudApi.ts +77 -39
  33. package/cloud/configLock.test.ts +64 -0
  34. package/cloud/configLock.ts +96 -0
  35. package/cloud/constants.ts +26 -5
  36. package/cloud/globalConfig.ts +70 -32
  37. package/codeAgent/agent/AkanCodeServices.ts +97 -0
  38. package/codeAgent/agent/AkanContextFiles.ts +94 -0
  39. package/codeAgent/agent/CodeAgent.ts +551 -0
  40. package/codeAgent/agent/CodeAgentAsks.ts +66 -0
  41. package/codeAgent/agent/CodeAgentEventMapper.ts +225 -0
  42. package/codeAgent/agent/CodeAgentGate.ts +93 -0
  43. package/codeAgent/agent/CodeAgentProxy.ts +82 -0
  44. package/codeAgent/agent/CodeAgentRpcHost.ts +103 -0
  45. package/codeAgent/agent/CodeAgentRpcListener.ts +109 -0
  46. package/codeAgent/agent/CodeAgentStreamPrinter.ts +86 -0
  47. package/codeAgent/agent/CodeAgentSuspended.ts +85 -0
  48. package/codeAgent/agent/CodeAgentUi.ts +47 -0
  49. package/codeAgent/agent/CodeMailbox.ts +148 -0
  50. package/codeAgent/agent/CodeSessionFork.ts +56 -0
  51. package/codeAgent/agent/CodeSessionIndex.ts +78 -0
  52. package/codeAgent/agent/SubagentPool.ts +214 -0
  53. package/codeAgent/agent/akanCodeModel.ts +47 -0
  54. package/codeAgent/agent/akanCodePaths.ts +31 -0
  55. package/codeAgent/agent/akanContextFiles.test.ts +114 -0
  56. package/codeAgent/agent/akanSystemPrompt.ts +46 -0
  57. package/codeAgent/agent/codeAgent.test.ts +178 -0
  58. package/codeAgent/agent/codeAgentContract.test.ts +523 -0
  59. package/codeAgent/agent/codeAgentProxy.test.ts +74 -0
  60. package/codeAgent/agent/codeAgentRpcListener.test.ts +113 -0
  61. package/codeAgent/agent/codeAgentSuspended.test.ts +47 -0
  62. package/codeAgent/agent/codeMailbox.test.ts +76 -0
  63. package/codeAgent/agent/codeSessionFork.test.ts +58 -0
  64. package/codeAgent/agent/codeSessionIndex.test.ts +77 -0
  65. package/codeAgent/agent/consoleToStderr.ts +8 -0
  66. package/codeAgent/agent/jsonLines.ts +29 -0
  67. package/codeAgent/agent/stringArg.ts +5 -0
  68. package/codeAgent/feedback/DevLogFeedback.ts +82 -0
  69. package/codeAgent/feedback/PreviewChrome.ts +82 -0
  70. package/codeAgent/feedback/PreviewFeedback.ts +46 -0
  71. package/codeAgent/feedback/PreviewView.ts +95 -0
  72. package/codeAgent/feedback/TurnFeedback.ts +98 -0
  73. package/codeAgent/feedback/VerifyFeedback.ts +40 -0
  74. package/codeAgent/feedback/previewChrome.test.ts +73 -0
  75. package/codeAgent/index.ts +34 -0
  76. package/codeAgent/skills/akan-code/SKILL.md +130 -0
  77. package/codeAgent/skills/akan-debug/SKILL.md +42 -0
  78. package/codeAgent/skills/akan-deps/SKILL.md +50 -0
  79. package/codeAgent/skills/akan-err/SKILL.md +39 -0
  80. package/codeAgent/skills/akan-module/SKILL.md +45 -0
  81. package/codeAgent/skills/akan-scaffold/SKILL.md +76 -0
  82. package/codeAgent/skills/akan-scalar/SKILL.md +52 -0
  83. package/codeAgent/skills/akan-service/SKILL.md +34 -0
  84. package/codeAgent/skills/akan-store/SKILL.md +67 -0
  85. package/codeAgent/skills/akan-ui/SKILL.md +63 -0
  86. package/codeAgent/skills/akan-validate/SKILL.md +44 -0
  87. package/codeAgent/tools/AkanCli.ts +50 -0
  88. package/codeAgent/tools/AkanCodePlugins.ts +136 -0
  89. package/codeAgent/tools/AkanEditScope.ts +48 -0
  90. package/codeAgent/tools/AkanEnvKeys.ts +50 -0
  91. package/codeAgent/tools/AkanToolPack.ts +92 -0
  92. package/codeAgent/tools/AkanVerifier.ts +48 -0
  93. package/codeAgent/tools/AskToolPack.ts +99 -0
  94. package/codeAgent/tools/MailToolPack.ts +76 -0
  95. package/codeAgent/tools/McpClient.ts +187 -0
  96. package/codeAgent/tools/McpOAuth.ts +233 -0
  97. package/codeAgent/tools/McpOAuthLoopback.ts +64 -0
  98. package/codeAgent/tools/McpServerConfig.ts +129 -0
  99. package/codeAgent/tools/McpSignIn.ts +158 -0
  100. package/codeAgent/tools/McpTokenStore.ts +81 -0
  101. package/codeAgent/tools/McpToolPack.ts +199 -0
  102. package/codeAgent/tools/SessionToolPack.ts +91 -0
  103. package/codeAgent/tools/WebToolPack.ts +147 -0
  104. package/codeAgent/tools/akanCodePlugins.test.ts +677 -0
  105. package/codeAgent/tools/askToolPack.test.ts +116 -0
  106. package/codeAgent/tools/mcpOAuth.test.ts +612 -0
  107. package/codeAgent/tools/mcpServerConfig.test.ts +212 -0
  108. package/codegenLock.test.ts +4 -13
  109. package/codegenLock.ts +3 -17
  110. package/commandDecorators/argMeta.ts +1 -5
  111. package/commandDecorators/camelToKebabCase.ts +1 -0
  112. package/commandDecorators/command.ts +46 -102
  113. package/commandDecorators/commandBuilder.ts +30 -61
  114. package/commandDecorators/commandDecorators.test.ts +2 -10
  115. package/commandDecorators/dependencyBuilder.ts +10 -1
  116. package/commandDecorators/helpFormatter.ts +68 -145
  117. package/commandDecorators/index.ts +0 -2
  118. package/commandDecorators/targetMeta.ts +9 -7
  119. package/createTunnel.ts +7 -14
  120. package/dependencyScanner.test.ts +4 -16
  121. package/dependencyScanner.ts +31 -80
  122. package/devkitUtils.test.ts +48 -20
  123. package/executors.linkFallback.test.ts +103 -0
  124. package/executors.test.ts +132 -106
  125. package/executors.ts +194 -484
  126. package/fileEditor.ts +9 -37
  127. package/{getDirname.test.ts → fileSys.test.ts} +5 -3
  128. package/fileSys.ts +6 -8
  129. package/formSetterScanner.ts +3 -16
  130. package/frontendBuild/allRoutesBuilder.ts +7 -21
  131. package/frontendBuild/autoImportSync.test.ts +27 -38
  132. package/frontendBuild/autoImportSync.ts +31 -65
  133. package/frontendBuild/buildRouteClient.test.ts +62 -37
  134. package/frontendBuild/bundleDefine.ts +12 -0
  135. package/frontendBuild/clientBuildTypes.ts +5 -36
  136. package/frontendBuild/clientEntriesBundler.ts +9 -40
  137. package/frontendBuild/clientEntryDiscovery.ts +6 -41
  138. package/frontendBuild/csrArtifactBuilder.ts +6 -25
  139. package/frontendBuild/cssCandidateCache.test.ts +0 -6
  140. package/frontendBuild/cssCandidateCache.ts +6 -41
  141. package/frontendBuild/cssCompiler.ts +29 -78
  142. package/frontendBuild/cssImportResolver.ts +6 -19
  143. package/frontendBuild/devChangePlanner.ts +7 -10
  144. package/frontendBuild/devGeneratedIndexSync.test.ts +12 -27
  145. package/frontendBuild/devGeneratedIndexSync.ts +1 -4
  146. package/frontendBuild/fontOptimizer.test.ts +6 -14
  147. package/frontendBuild/fontOptimizer.ts +15 -72
  148. package/frontendBuild/fontPruner.test.ts +5 -10
  149. package/frontendBuild/fontPruner.ts +5 -20
  150. package/frontendBuild/frontendBuild.test.ts +46 -69
  151. package/frontendBuild/hmrChangeClassifier.ts +2 -2
  152. package/frontendBuild/hmrWatcher.test.ts +8 -32
  153. package/frontendBuild/hmrWatcher.ts +14 -71
  154. package/frontendBuild/pagesBundleBuilder.ts +4 -29
  155. package/frontendBuild/precompressArtifacts.ts +5 -18
  156. package/frontendBuild/routeClientBuilder.ts +23 -46
  157. package/frontendBuild/routesManifestArtifactSerializer.ts +5 -36
  158. package/frontendBuild/sourceMtimeIndex.test.ts +41 -97
  159. package/frontendBuild/sourceMtimeIndex.ts +19 -130
  160. package/frontendBuild/ssrBaseArtifactBuilder.ts +2 -8
  161. package/frontendBuild/styleContract.ts +1 -8
  162. package/frontendBuild/themeValidator.ts +4 -26
  163. package/frontendBuild/watchRootResolver.test.ts +23 -42
  164. package/frontendBuild/watchRootResolver.ts +5 -27
  165. package/getRelatedCnsts.ts +12 -92
  166. package/incrementalBuilder/buildBatch.proc.ts +22 -57
  167. package/incrementalBuilder/buildBatchProtocol.ts +8 -36
  168. package/incrementalBuilder/buildBatchRunner.test.ts +34 -0
  169. package/incrementalBuilder/buildBatchRunner.ts +10 -31
  170. package/incrementalBuilder/builderChannel.test.ts +24 -49
  171. package/incrementalBuilder/builderChannel.ts +6 -37
  172. package/incrementalBuilder/builderRequestRouter.test.ts +0 -8
  173. package/incrementalBuilder/builderRequestRouter.ts +5 -24
  174. package/incrementalBuilder/devWatchBatch.test.ts +21 -24
  175. package/incrementalBuilder/incrementalBuilder.host.test.ts +18 -55
  176. package/incrementalBuilder/incrementalBuilder.host.ts +18 -76
  177. package/incrementalBuilder/incrementalBuilder.proc.test.ts +81 -0
  178. package/incrementalBuilder/incrementalBuilder.proc.ts +49 -161
  179. package/index.ts +5 -17
  180. package/integration/devResourceProbe.ts +50 -56
  181. package/integration/devStability.integration.test.ts +47 -194
  182. package/integration/devStabilityHarness.test.ts +13 -28
  183. package/integration/devStabilityHarness.ts +65 -330
  184. package/integration/ssrMemoryProbe.ts +41 -167
  185. package/libSource.test.ts +4 -15
  186. package/libSource.ts +19 -31
  187. package/lint/gritRules.test.ts +8 -24
  188. package/lint/no-deep-internal-import.grit +2 -2
  189. package/lint/no-redeclare-predefined-endpoint.grit +2 -1
  190. package/linter.test.ts +1 -2
  191. package/linter.ts +26 -116
  192. package/mobile/mobileTarget.ts +14 -13
  193. package/package.json +10 -5
  194. package/packageExports.test.ts +3 -18
  195. package/packageExportsMap.ts +3 -19
  196. package/piDependencyPins.test.ts +46 -0
  197. package/platformTest/BunTestReport.test.ts +60 -0
  198. package/platformTest/BunTestReport.ts +65 -0
  199. package/platformTest/IdleWatchedProcess.test.ts +56 -0
  200. package/platformTest/IdleWatchedProcess.ts +73 -0
  201. package/platformTest/LinuxDockerTarget.ts +105 -0
  202. package/platformTest/PlatformTestRun.test.ts +64 -0
  203. package/platformTest/PlatformTestRun.ts +141 -0
  204. package/platformTest/PlatformTestTarget.ts +142 -0
  205. package/platformTest/TestSnapshot.test.ts +72 -0
  206. package/platformTest/TestSnapshot.ts +103 -0
  207. package/platformTest/WindowsSshTarget.ts +151 -0
  208. package/prompter.ts +3 -13
  209. package/qualityScanner.test.ts +9 -26
  210. package/qualityScanner.ts +197 -285
  211. package/recipeScanner.test.ts +7 -12
  212. package/recipeScanner.ts +9 -38
  213. package/repoIdentity.ts +2 -9
  214. package/routeSourceValidator.test.ts +0 -1
  215. package/routeSourceValidator.ts +7 -42
  216. package/scanInfo.ts +87 -216
  217. package/selectModel.ts +1 -2
  218. package/semver.ts +3 -5
  219. package/slicePlanner.test.ts +6 -24
  220. package/slicePlanner.ts +11 -32
  221. package/spinner.test.ts +3 -8
  222. package/spinner.ts +4 -16
  223. package/sshTunnel.ts +1 -6
  224. package/ssrScanner.test.ts +1 -6
  225. package/ssrScanner.ts +103 -113
  226. package/stripAnsi.ts +3 -0
  227. package/subspace.test.ts +30 -25
  228. package/subspace.ts +81 -115
  229. package/subspaceConfig.ts +11 -9
  230. package/testHelpers.ts +194 -0
  231. package/transforms/asyncDefaultExportDetector.ts +3 -11
  232. package/transforms/barrelAnalyzer.ts +43 -135
  233. package/transforms/barrelImportsPlugin.ts +38 -175
  234. package/transforms/externalizeFrameworkPlugin.test.ts +39 -118
  235. package/transforms/externalizeFrameworkPlugin.ts +13 -87
  236. package/transforms/moduleSyntax.ts +32 -0
  237. package/transforms/rscUseClientTransform.ts +35 -20
  238. package/transforms/transforms.test.ts +153 -44
  239. package/transforms/tsconfigPackageResolver.test.ts +6 -24
  240. package/transforms/useClientBundlePlugin.ts +2 -22
  241. package/typeChecker.ts +7 -63
  242. package/types.ts +1 -0
  243. package/uploadRelease.ts +10 -25
  244. package/workflow/artifacts.ts +18 -0
  245. package/workflow/executor.test.ts +1 -12
  246. package/workflow/executor.ts +101 -110
  247. package/workflow/index.ts +0 -1
  248. package/workflow/moduleIndex.test.ts +4 -15
  249. package/workflow/moduleIndex.ts +9 -49
  250. package/workflow/plan.ts +18 -25
  251. package/workflow/render.ts +80 -96
  252. package/workflow/rolloutGate.test.ts +1 -1
  253. package/workflow/source.ts +52 -69
  254. package/workflow/sourceAst.ts +50 -0
  255. package/workspaceLayout.ts +4 -19
  256. package/abstractCompactor.ts +0 -112
  257. package/aiEditor.test.ts +0 -60
  258. package/aiEditor.ts +0 -387
  259. package/commandDecorators/commandMeta.ts +0 -7
  260. package/commandDecorators/types.ts +0 -10
  261. package/getDirname.ts +0 -4
  262. package/guideline.ts +0 -19
  263. package/local/optimize-resource/ipcprobe/child.ts +0 -1
  264. package/local/optimize-resource/ipcprobe/parent.ts +0 -11
  265. package/workflow/primitive.ts +0 -59
package/typeChecker.ts CHANGED
@@ -38,31 +38,15 @@ export class TypeChecker {
38
38
  }
39
39
  this.config = parsedConfig;
40
40
  }
41
- /**
42
- * Find tsconfig.json by walking up the directory tree
43
- */
44
41
  #findConfigFile(searchPath: string): string | undefined {
45
42
  return ts.findConfigFile(searchPath, (fileName) => ts.sys.fileExists(fileName), "tsconfig.json");
46
43
  }
47
44
 
48
- /**
49
- * Type-check a single TypeScript file
50
- * @param filePath - Path to the TypeScript file to check
51
- * @returns Array of diagnostic messages
52
- */
53
- check(filePath: string): {
54
- diagnostics: ts.Diagnostic[];
55
- errors: ts.Diagnostic[];
56
- warnings: ts.Diagnostic[];
57
- fileDiagnostics: ts.Diagnostic[];
58
- fileErrors: ts.Diagnostic[];
59
- fileWarnings: ts.Diagnostic[];
60
- } {
45
+ check(filePath: string) {
61
46
  const program = ts.createProgram([filePath], this.config.options);
62
47
  const diagnostics = [
63
48
  ...program.getSemanticDiagnostics(),
64
49
  ...program.getSyntacticDiagnostics(),
65
- // Only check declaration diagnostics when declaration emit is enabled
66
50
  ...(this.config.options.declaration ? program.getDeclarationDiagnostics() : []),
67
51
  ];
68
52
  const errors = diagnostics.filter((diagnostic) => diagnostic.category === ts.DiagnosticCategory.Error);
@@ -73,11 +57,6 @@ export class TypeChecker {
73
57
  return { diagnostics, errors, warnings, fileDiagnostics, fileErrors, fileWarnings };
74
58
  }
75
59
 
76
- /**
77
- * Format diagnostics for console output
78
- * @param diagnostics - Array of TypeScript diagnostics
79
- * @returns Formatted string
80
- */
81
60
  formatDiagnostics(diagnostics: ts.Diagnostic[]): string {
82
61
  if (diagnostics.length === 0) return chalk.bold("✅ No type errors found");
83
62
 
@@ -86,48 +65,24 @@ export class TypeChecker {
86
65
  let warningCount = 0;
87
66
  let suggestionCount = 0;
88
67
 
89
- // Group diagnostics by file
90
68
  const diagnosticsByFile = new Map<string, ts.Diagnostic[]>();
91
69
  diagnostics.forEach((diagnostic) => {
92
70
  if (diagnostic.category === ts.DiagnosticCategory.Error) errorCount++;
93
71
  else if (diagnostic.category === ts.DiagnosticCategory.Warning) warningCount++;
94
72
  else if (diagnostic.category === ts.DiagnosticCategory.Suggestion) suggestionCount++;
95
-
96
- if (diagnostic.file) {
97
- const fileName = diagnostic.file.fileName;
98
- if (!diagnosticsByFile.has(fileName)) diagnosticsByFile.set(fileName, []);
99
- const fileDiagnostics = diagnosticsByFile.get(fileName);
100
- if (fileDiagnostics) fileDiagnostics.push(diagnostic);
101
- } else {
102
- if (!diagnosticsByFile.has("")) diagnosticsByFile.set("", []);
103
- const fileDiagnostics = diagnosticsByFile.get("");
104
- if (fileDiagnostics) fileDiagnostics.push(diagnostic);
105
- }
73
+ diagnosticsByFile.getOrInsert(diagnostic.file?.fileName ?? "", []).push(diagnostic);
106
74
  });
107
75
 
108
- // Format diagnostics by file
109
76
  diagnosticsByFile.forEach((fileDiagnostics, fileName) => {
110
77
  if (fileName) output.push(`\n${chalk.cyan(fileName)}`);
111
78
 
112
79
  fileDiagnostics.forEach((diagnostic) => {
113
- const categoryText =
114
- diagnostic.category === ts.DiagnosticCategory.Error
115
- ? "error"
116
- : diagnostic.category === ts.DiagnosticCategory.Warning
117
- ? "warning"
118
- : "suggestion";
119
- const categoryColor =
120
- diagnostic.category === ts.DiagnosticCategory.Error
121
- ? chalk.red
122
- : diagnostic.category === ts.DiagnosticCategory.Warning
123
- ? chalk.yellow
124
- : chalk.blue;
125
- const icon =
80
+ const [categoryText, categoryColor, icon] =
126
81
  diagnostic.category === ts.DiagnosticCategory.Error
127
- ? "❌"
82
+ ? (["error", chalk.red, "❌"] as const)
128
83
  : diagnostic.category === ts.DiagnosticCategory.Warning
129
- ? "⚠️"
130
- : "💡";
84
+ ? (["warning", chalk.yellow, "⚠️"] as const)
85
+ : (["suggestion", chalk.blue, "💡"] as const);
131
86
  const message = ts.flattenDiagnosticMessageText(diagnostic.messageText, "\n");
132
87
  const tsCode = chalk.dim(`(TS${diagnostic.code})`);
133
88
 
@@ -137,7 +92,6 @@ export class TypeChecker {
137
92
  output.push(`\n ${icon} ${categoryColor(categoryText)}: ${message} ${tsCode}`);
138
93
  output.push(` ${chalk.gray("at")} ${fileName}:${chalk.bold(`${line + 1}:${character + 1}`)}`);
139
94
 
140
- // Show source line with underline
141
95
  const sourceLines = diagnostic.file.text.split("\n");
142
96
  if (line < sourceLines.length) {
143
97
  const sourceLine = sourceLines[line];
@@ -145,7 +99,6 @@ export class TypeChecker {
145
99
 
146
100
  output.push(`\n${chalk.dim(`${lineNumber} |`)} ${sourceLine}`);
147
101
 
148
- // Create underline with squiggly for TypeScript
149
102
  const underlinePrefix = " ".repeat(character);
150
103
  const length = diagnostic.length ?? 1;
151
104
  const underline = "~".repeat(Math.max(1, length));
@@ -166,11 +119,6 @@ export class TypeChecker {
166
119
  return `\n${summary.join(", ")} found${output.join("\n")}`;
167
120
  }
168
121
 
169
- /**
170
- * Get detailed diagnostic information with code snippet
171
- * @param filePath - Path to the TypeScript file to check
172
- * @returns Object containing diagnostics and detailed information
173
- */
174
122
  getDetailedDiagnostics(filePath: string): {
175
123
  diagnostics: ts.Diagnostic[];
176
124
  details: { line: number; column: number; message: string; code: number; codeSnippet?: string }[];
@@ -199,11 +147,7 @@ export class TypeChecker {
199
147
  return { diagnostics, details };
200
148
  }
201
149
 
202
- /**
203
- * Check if a file has type errors
204
- * @param filePath - Path to the TypeScript file to check
205
- * @returns true if there are no type errors, false otherwise
206
- */
150
+ /** Also false when the check itself throws. */
207
151
  hasNoTypeErrors(filePath: string): boolean {
208
152
  try {
209
153
  const { diagnostics } = this.check(filePath);
package/types.ts CHANGED
@@ -10,6 +10,7 @@ export interface PackageJson {
10
10
  peerDependencies?: Record<string, string>;
11
11
  peerDependenciesMeta?: Record<string, { optional?: boolean }>;
12
12
  optionalDependencies?: Record<string, string>;
13
+ overrides?: Record<string, string>;
13
14
  engines?: Record<string, string>;
14
15
  exports?: Record<string, string | Record<string, string>>;
15
16
  bun?: {
package/uploadRelease.ts CHANGED
@@ -2,10 +2,8 @@ import { Logger, RestClient } from "akanjs/common";
2
2
 
3
3
  import { Spinner } from "./spinner";
4
4
 
5
- const spinning = (message: string) => {
6
- const spinner = new Spinner(message, { prefix: message, enableSpin: true }).start();
7
- return spinner;
8
- };
5
+ const spinning = (message: string) => new Spinner(message, { prefix: message, enableSpin: true }).start();
6
+
9
7
  export const uploadRelease = async (
10
8
  appName: string,
11
9
  {
@@ -27,33 +25,20 @@ export const uploadRelease = async (
27
25
  const logger = new Logger("uploadRelease");
28
26
  const basePath = local ? "http://localhost:8282/backend" : "https://cloud.akanjs.com/backend";
29
27
  const httpClient = new RestClient(basePath);
30
- const buildPath = `${workspaceRoot}/releases/builds/${appName}-release.tar.gz`;
31
- const appBuildPath = `${workspaceRoot}/releases/builds/${appName}-appBuild.zip`;
32
- const sourcePath = `${workspaceRoot}/releases/sources/${appName}-source.tar.gz`;
33
-
34
28
  const readingFilesSpinner = spinning("Reading files...");
35
29
  try {
36
- const buildFile = Bun.file(buildPath);
37
- const sourceFile = Bun.file(sourcePath);
38
- const appBuildFile = Bun.file(appBuildPath);
39
- const buildStat = { mtime: new Date(buildFile.lastModified), size: buildFile.size };
40
- const sourceStat = { mtime: new Date(sourceFile.lastModified), size: sourceFile.size };
41
- const appBuildStat = { mtime: new Date(appBuildFile.lastModified), size: appBuildFile.size };
30
+ const uploads = [
31
+ [`builds/${appName}-release.tar.gz`, `${appName}-release.tar.gz`],
32
+ [`sources/${appName}-source.tar.gz`, `${appName}-source.tar.gz`],
33
+ [`builds/${appName}-appBuild.zip`, `${appName}-appBuild.zip`],
34
+ ].map(([relativePath, name]) => ({ file: Bun.file(`${workspaceRoot}/releases/${relativePath}`), name }));
35
+ const metas = uploads.map(({ file }) => ({ lastModifiedAt: new Date(file.lastModified), size: file.size }));
42
36
  readingFilesSpinner.succeed("Reading files... done");
43
37
 
44
38
  const preparingFormSpinner = spinning("Preparing form data...");
45
39
  const formData = new FormData();
46
- formData.append("files", buildFile, `${appName}-release.tar.gz`);
47
- formData.append("files", sourceFile, `${appName}-source.tar.gz`);
48
- formData.append("files", appBuildFile, `${appName}-appBuild.zip`);
49
- formData.append(
50
- "metas",
51
- JSON.stringify([
52
- { lastModifiedAt: buildStat.mtime, size: buildStat.size },
53
- { lastModifiedAt: sourceStat.mtime, size: sourceStat.size },
54
- { lastModifiedAt: appBuildStat.mtime, size: appBuildStat.size },
55
- ]),
56
- );
40
+ for (const { file, name } of uploads) formData.append("files", file, name);
41
+ formData.append("metas", JSON.stringify(metas));
57
42
  formData.append("type", "release");
58
43
  preparingFormSpinner.succeed("Preparing form data... done");
59
44
 
@@ -1,3 +1,4 @@
1
+ import { capitalize } from "akanjs/common";
1
2
  import type { Workspace } from "../commandDecorators";
2
3
  import type {
3
4
  GeneratedSyncState,
@@ -146,6 +147,23 @@ export const workflowCommandsForPlan = (plan: WorkflowPlan) =>
146
147
  kind: validation.kind,
147
148
  })) satisfies WorkflowApplyCommand[];
148
149
 
150
+ const planInputString = (plan: WorkflowPlan, key: string) => {
151
+ const value = plan.inputs[key];
152
+ return typeof value === "string" ? value : "";
153
+ };
154
+
155
+ export const workflowPathsForPlan = (plan: WorkflowPlan) => {
156
+ const app = planInputString(plan, "app");
157
+ const module = planInputString(plan, "module");
158
+ const moduleClass = module ? capitalize(module) : "<Module>";
159
+ return plan.predictedChanges.map((change) =>
160
+ change.target
161
+ .replace(/^\*\//, app ? `apps/${app}/` : "")
162
+ .replaceAll("<module>", module || "<module>")
163
+ .replaceAll("<Module>", moduleClass),
164
+ );
165
+ };
166
+
149
167
  export const workflowRunsDir = ".akan/workflows/runs";
150
168
 
151
169
  export const createWorkflowRunId = (prefix = "run") =>
@@ -9,11 +9,6 @@ import type {
9
9
  WorkflowStepResult,
10
10
  } from "./types";
11
11
 
12
- /**
13
- * `WorkflowExecutor` takes its registry by constructor injection and its plan as data, so `apply` runs with
14
- * no filesystem and no workspace — the `workspace` argument is what gates every post-apply check. These
15
- * cover the ordering rules that `cli/workflow/workflow.test.ts` can only reach through a real scaffold.
16
- */
17
12
  const step = (id: string, tool = `tool:${id}`): WorkflowStep => ({
18
13
  id,
19
14
  tool,
@@ -21,8 +16,7 @@ const step = (id: string, tool = `tool:${id}`): WorkflowStep => ({
21
16
  description: id,
22
17
  });
23
18
 
24
- // Every field spelled out rather than cast through `unknown`: `apply` reads `validation` before the first
25
- // step runs, so a partial literal fails at runtime instead of at the type level.
19
+ // Not a cast partial: `apply` reads `validation` before the first step, so a missing field fails only at runtime.
26
20
  const planOf = (steps: WorkflowStep[], diagnostics: WorkflowDiagnostic[] = []): WorkflowPlan => ({
27
21
  schemaVersion: 1,
28
22
  workflow: "add-field",
@@ -37,10 +31,6 @@ const planOf = (steps: WorkflowStep[], diagnostics: WorkflowDiagnostic[] = []):
37
31
  requiresApproval: true,
38
32
  });
39
33
 
40
- /**
41
- * A registry that records **which key** each call resolved through, not just that a step ran — the
42
- * resolution order is the thing under test, and every candidate key would otherwise record the same step id.
43
- */
44
34
  const changed = (path: string): PrimitiveChangedFile => ({ path, action: "modify", reason: "test" });
45
35
 
46
36
  const recordingRegistry = (results: Record<string, WorkflowStepResult | undefined> = {}) => {
@@ -79,7 +69,6 @@ describe("WorkflowExecutor.apply", () => {
79
69
 
80
70
  test("resolves a runner by workflow-scoped key first, then tool, then bare step id", async () => {
81
71
  const { calls, registry, on } = recordingRegistry();
82
- // All three keys are registered for the same step, so only the winner records a call.
83
72
  on(workflowStepKey("add-field", "scoped"));
84
73
  on("tool:scoped");
85
74
  on("scoped");
@@ -1,3 +1,4 @@
1
+ import { capitalize } from "akanjs/common";
1
2
  import ts from "typescript";
2
3
  import type { AkanModuleContext } from "../akanContext";
3
4
  import type { Sys, Workspace } from "../commandDecorators";
@@ -47,16 +48,13 @@ const workflowStringListInput = (value: WorkflowInputValue | undefined) =>
47
48
  const workflowStringArrayInput = (value: WorkflowInputValue | undefined) => (Array.isArray(value) ? value : null);
48
49
  const workflowBooleanInput = (value: WorkflowInputValue | undefined) => (typeof value === "boolean" ? value : null);
49
50
 
50
- const postApplyDiagnostic = (code: string, message: string, target: string): WorkflowDiagnostic => ({
51
- severity: "error",
52
- code,
53
- message,
54
- failureScope: "source-change",
55
- context: { target },
56
- });
57
-
58
- const postApplyWarning = (code: string, message: string, target: string): WorkflowDiagnostic => ({
59
- severity: "warning",
51
+ const postApplyDiagnostic = (
52
+ code: string,
53
+ message: string,
54
+ target: string,
55
+ severity: WorkflowDiagnostic["severity"] = "error",
56
+ ): WorkflowDiagnostic => ({
57
+ severity,
60
58
  code,
61
59
  message,
62
60
  failureScope: "source-change",
@@ -113,27 +111,23 @@ const checkTypeScriptSyntax = async (workspace: Workspace, filePath: string) =>
113
111
 
114
112
  const checkChangedFile = async (workspace: Workspace, file: PrimitiveChangedFile): Promise<WorkflowStepResult> => {
115
113
  if (file.action === "remove") return { postApplyChecks: [] };
116
- const diagnostics: WorkflowDiagnostic[] = [];
117
- const checks: WorkflowPostApplyCheck[] = [];
118
- const pathIssue = await checkPathCasing(workspace, file.path);
119
- if (pathIssue) {
120
- diagnostics.push(postApplyDiagnostic(pathIssue.code, pathIssue.message, file.path));
121
- checks.push({ ...pathIssue, target: file.path, status: "failed" });
122
- return { diagnostics, postApplyChecks: checks };
114
+ const issue = (await checkPathCasing(workspace, file.path)) ?? (await checkTypeScriptSyntax(workspace, file.path));
115
+ if (issue) {
116
+ return {
117
+ diagnostics: [postApplyDiagnostic(issue.code, issue.message, file.path)],
118
+ postApplyChecks: [{ ...issue, target: file.path, status: "failed" }],
119
+ };
123
120
  }
124
- const syntaxIssue = await checkTypeScriptSyntax(workspace, file.path);
125
- if (syntaxIssue) {
126
- diagnostics.push(postApplyDiagnostic(syntaxIssue.code, syntaxIssue.message, file.path));
127
- checks.push({ ...syntaxIssue, target: file.path, status: "failed" });
128
- return { diagnostics, postApplyChecks: checks };
129
- }
130
- checks.push({
131
- code: "workflow-post-apply-file-valid",
132
- target: file.path,
133
- status: "passed",
134
- message: "Changed file exists with exact casing and parses as source when applicable.",
135
- });
136
- return { postApplyChecks: checks };
121
+ return {
122
+ postApplyChecks: [
123
+ {
124
+ code: "workflow-post-apply-file-valid",
125
+ target: file.path,
126
+ status: "passed",
127
+ message: "Changed file exists with exact casing and parses as source when applicable.",
128
+ },
129
+ ],
130
+ };
137
131
  };
138
132
 
139
133
  const checkRecommendationPath = async (
@@ -198,18 +192,6 @@ const workflowModuleContext = async (workspace: Workspace, plan: WorkflowPlan):
198
192
  };
199
193
  };
200
194
 
201
- const structureCheck = (
202
- code: string,
203
- target: string,
204
- status: WorkflowPostApplyCheck["status"],
205
- message: string,
206
- ): WorkflowPostApplyCheck => ({
207
- code,
208
- target,
209
- status,
210
- message,
211
- });
212
-
213
195
  const checkAddFieldStructure = async (workspace: Workspace, plan: WorkflowPlan): Promise<WorkflowStepResult> => {
214
196
  if (plan.workflow !== "add-field" && plan.workflow !== "add-enum-field") return {};
215
197
  const app = workflowStringInput(plan.inputs.app);
@@ -259,16 +241,14 @@ const checkAddFieldStructure = async (workspace: Workspace, plan: WorkflowPlan):
259
241
  .map((diagnostic) => diagnostic.message),
260
242
  ].filter((failure): failure is string => failure !== null);
261
243
  const constantValid = constantFailures.length === 0;
262
- postApplyChecks.push(
263
- structureCheck(
264
- constantValid ? "workflow-post-apply-constant-shape-valid" : "workflow-post-apply-structure-invalid",
265
- constantPath,
266
- constantValid ? "passed" : "failed",
267
- constantValid
268
- ? `${inputClassName} keeps via structure, builder usage, imports, and requested field presence.`
269
- : constantFailures.join(" "),
270
- ),
271
- );
244
+ postApplyChecks.push({
245
+ code: constantValid ? "workflow-post-apply-constant-shape-valid" : "workflow-post-apply-structure-invalid",
246
+ target: constantPath,
247
+ status: constantValid ? "passed" : "failed",
248
+ message: constantValid
249
+ ? `${inputClassName} keeps via structure, builder usage, imports, and requested field presence.`
250
+ : constantFailures.join(" "),
251
+ });
272
252
  if (!constantValid) {
273
253
  diagnostics.push(
274
254
  postApplyDiagnostic("workflow-post-apply-structure-invalid", constantFailures.join(" "), constantPath),
@@ -293,16 +273,14 @@ const checkAddFieldStructure = async (workspace: Workspace, plan: WorkflowPlan):
293
273
  .map((diagnostic) => diagnostic.message),
294
274
  ].filter((failure): failure is string => failure !== null);
295
275
  const dictionaryValid = dictionaryFailures.length === 0;
296
- postApplyChecks.push(
297
- structureCheck(
298
- dictionaryValid ? "workflow-post-apply-dictionary-shape-valid" : "workflow-post-apply-structure-invalid",
299
- dictionaryPath,
300
- dictionaryValid ? "passed" : "failed",
301
- dictionaryValid
302
- ? `.model<${moduleClassName}> keeps the requested field inside the model object and preserves dictionary chain order.`
303
- : dictionaryFailures.join(" "),
304
- ),
305
- );
276
+ postApplyChecks.push({
277
+ code: dictionaryValid ? "workflow-post-apply-dictionary-shape-valid" : "workflow-post-apply-structure-invalid",
278
+ target: dictionaryPath,
279
+ status: dictionaryValid ? "passed" : "failed",
280
+ message: dictionaryValid
281
+ ? `.model<${moduleClassName}> keeps the requested field inside the model object and preserves dictionary chain order.`
282
+ : dictionaryFailures.join(" "),
283
+ });
306
284
  if (!dictionaryValid) {
307
285
  diagnostics.push(
308
286
  postApplyDiagnostic("workflow-post-apply-structure-invalid", dictionaryFailures.join(" "), dictionaryPath),
@@ -312,22 +290,21 @@ const checkAddFieldStructure = async (workspace: Workspace, plan: WorkflowPlan):
312
290
  const constantOrderValid = fieldOrderValid(constantNames, fieldName);
313
291
  const dictionaryOrderValid = fieldOrderValid(dictionaryStructure.fields, fieldName);
314
292
  const orderValid = constantOrderValid && dictionaryOrderValid;
315
- postApplyChecks.push(
316
- structureCheck(
317
- "workflow-post-apply-field-order-valid",
318
- `${constantPath}, ${dictionaryPath}`,
319
- orderValid ? "passed" : "failed",
320
- orderValid
321
- ? `Field "${fieldName}" follows the shared priority ordering policy.`
322
- : `Field "${fieldName}" is present but does not match the shared priority ordering policy.`,
323
- ),
324
- );
293
+ postApplyChecks.push({
294
+ code: "workflow-post-apply-field-order-valid",
295
+ target: `${constantPath}, ${dictionaryPath}`,
296
+ status: orderValid ? "passed" : "failed",
297
+ message: orderValid
298
+ ? `Field "${fieldName}" follows the shared priority ordering policy.`
299
+ : `Field "${fieldName}" is present but does not match the shared priority ordering policy.`,
300
+ });
325
301
  if (!orderValid) {
326
302
  diagnostics.push(
327
- postApplyWarning(
303
+ postApplyDiagnostic(
328
304
  "workflow-post-apply-field-order-mismatch",
329
305
  `Field "${fieldName}" is present but does not match the shared priority ordering policy.`,
330
306
  `${constantPath}, ${dictionaryPath}`,
307
+ "warning",
331
308
  ),
332
309
  );
333
310
  }
@@ -364,6 +341,14 @@ const unsupportedInput = (input: string, message: string): WorkflowDiagnostic =>
364
341
  message,
365
342
  });
366
343
 
344
+ const surfaceReview = (
345
+ plan: WorkflowPlan,
346
+ { code, target, action, message, reason }: Record<"code" | "target" | "action" | "message" | "reason", string>,
347
+ ): WorkflowStepResult => ({
348
+ recommendations: [{ code, kind: "manual-action", target, action, confidence: "medium", message }],
349
+ nextActions: [{ command: `akan workflow explain ${plan.workflow}`, reason }],
350
+ });
351
+
367
352
  const addFieldUiSurfaceInspection = (plan: WorkflowPlan): WorkflowStepResult => {
368
353
  const app = workflowStringInput(plan.inputs.app);
369
354
  const module = workflowStringInput(plan.inputs.module) ?? "<module>";
@@ -373,27 +358,41 @@ const addFieldUiSurfaceInspection = (plan: WorkflowPlan): WorkflowStepResult =>
373
358
  const surfaces = workflowStringArrayInput(plan.inputs.surfaces);
374
359
  const templateRequested = surfaces?.includes("template") ?? false;
375
360
  const moduleClassName = moduleComponentName(module);
376
- const target = `${app ? `apps/${app}` : "*"}/${moduleSourcePaths(module).template}`;
377
- return {
378
- recommendations: [
379
- {
380
- code: "add-field-ui-surface-review",
381
- kind: "manual-action",
382
- target,
383
- action: templateRequested
384
- ? `Template was requested for ${field}. If no Template file changed, users will not see the field in the form yet because the file was missing, the generated ${module}Form/Layout.Template pattern was not found, or ${policy.component} needs option binding. Add it inside Layout.Template near existing Field components.`
385
- : `Template was not selected, so users will not see ${field} in the form from this apply. If list/card display is needed, include ${field} in Light${moduleClassName} projection data and place it in the local Unit/View card layout.`,
386
- confidence: "medium",
387
- message: `Review user-visible UI for ${module}.${field}; recommended component is ${policy.component}.`,
388
- },
389
- ],
390
- nextActions: [
391
- {
392
- command: `akan workflow explain ${plan.workflow}`,
393
- reason: "Review UI surface guidance before manually editing ambiguous UI files.",
394
- },
395
- ],
396
- };
361
+ return surfaceReview(plan, {
362
+ code: "add-field-ui-surface-review",
363
+ target: `${app ? `apps/${app}` : "*"}/${moduleSourcePaths(module).template}`,
364
+ action: templateRequested
365
+ ? `Template was requested for ${field}. If no Template file changed, users will not see the field in the form yet because the file was missing, the generated ${module}Form/Layout.Template pattern was not found, or ${policy.component} needs option binding. Add it inside Layout.Template near existing Field components.`
366
+ : `Template was not selected, so users will not see ${field} in the form from this apply. If list/card display is needed, include ${field} in Light${moduleClassName} projection data and place it in the local Unit/View card layout.`,
367
+ message: `Review user-visible UI for ${module}.${field}; recommended component is ${policy.component}.`,
368
+ reason: "Review UI surface guidance before manually editing ambiguous UI files.",
369
+ });
370
+ };
371
+
372
+ const addMutationActionSurfaceInspection = (plan: WorkflowPlan): WorkflowStepResult => {
373
+ const module = workflowStringInput(plan.inputs.module) ?? "<module>";
374
+ const mutation = workflowStringInput(plan.inputs.mutation) ?? "<mutation>";
375
+ const moduleClassName = moduleComponentName(module);
376
+ return surfaceReview(plan, {
377
+ code: "add-mutation-action-surface-review",
378
+ target: `*/${moduleSourcePaths(module).store}`,
379
+ action: `Name the endpoint's guards and add its dictionary .endpoint() entry with a .desc(). After sync, fetch.${mutation} exists; write a store action only for a toast, an optimistic update, or a multi-field write, and put the control that calls it in ${moduleClassName}.Util.tsx.`,
380
+ message: `Workflow apply does not write store or UI code for ${module}.${mutation}; review whether a screen should call it.`,
381
+ reason: "Review action surface guidance before manually editing store or UI files.",
382
+ });
383
+ };
384
+
385
+ const addSliceViewSurfaceInspection = (plan: WorkflowPlan): WorkflowStepResult => {
386
+ const module = workflowStringInput(plan.inputs.module) ?? "<module>";
387
+ const slice = workflowStringInput(plan.inputs.slice) ?? "<slice>";
388
+ const moduleClassName = moduleComponentName(module);
389
+ return surfaceReview(plan, {
390
+ code: "add-slice-view-surface-review",
391
+ target: `*/${moduleSourcePaths(module).zone}`,
392
+ action: `Fill in the service query stub and add the dictionary .slice() entry. After sync, load fetch.init${moduleClassName}${capitalize(slice)}() in the page and pass the result to a ${moduleClassName}.Zone as an init prop.`,
393
+ message: `Workflow apply does not write page or Zone code for ${module}.${slice}; review where the list should render.`,
394
+ reason: "Review view surface guidance before manually editing Zone or page files.",
395
+ });
397
396
  };
398
397
 
399
398
  export const createWorkflowStepRegistry = ({
@@ -494,6 +493,8 @@ export const createWorkflowStepRegistry = ({
494
493
  }),
495
494
  ),
496
495
  [workflowStepKey("add-mutation", "update-signal")]: inspect,
496
+ [workflowStepKey("add-mutation", "update-action-surfaces")]: async (_step, plan) =>
497
+ addMutationActionSurfaceInspection(plan),
497
498
  [workflowStepKey("add-slice", "update-service-query")]: async (_step, plan) =>
498
499
  primitiveReportToWorkflowStepResult(
499
500
  await addSlice({
@@ -503,6 +504,7 @@ export const createWorkflowStepRegistry = ({
503
504
  }),
504
505
  ),
505
506
  [workflowStepKey("add-slice", "update-signal-slice")]: inspect,
507
+ [workflowStepKey("add-slice", "connect-view-surfaces")]: async (_step, plan) => addSliceViewSurfaceInspection(plan),
506
508
  };
507
509
  };
508
510
 
@@ -529,9 +531,8 @@ export class WorkflowExecutor {
529
531
  const postApplyChecks: WorkflowPostApplyCheck[] = [];
530
532
  const recommendations = [...plan.recommendations];
531
533
  const nextActions: PrimitiveNextAction[] = [];
532
-
533
- if (diagnostics.some((diagnostic) => diagnostic.severity === "error")) {
534
- return createWorkflowApplyReport({
534
+ const report = () =>
535
+ createWorkflowApplyReport({
535
536
  workflow: plan.workflow,
536
537
  mode: "apply",
537
538
  changedFiles,
@@ -543,7 +544,8 @@ export class WorkflowExecutor {
543
544
  nextActions,
544
545
  plan,
545
546
  });
546
- }
547
+
548
+ if (diagnostics.some((diagnostic) => diagnostic.severity === "error")) return report();
547
549
 
548
550
  recommendedValidationCommands.push(...workflowCommandsForPlan(plan));
549
551
  nextActions.push(...workflowCommandsForPlan(plan));
@@ -594,17 +596,6 @@ export class WorkflowExecutor {
594
596
  );
595
597
  }
596
598
 
597
- return createWorkflowApplyReport({
598
- workflow: plan.workflow,
599
- mode: "apply",
600
- changedFiles,
601
- generatedFiles,
602
- recommendedValidationCommands,
603
- diagnostics,
604
- postApplyChecks,
605
- recommendations,
606
- nextActions,
607
- plan,
608
- });
599
+ return report();
609
600
  }
610
601
  }
package/workflow/index.ts CHANGED
@@ -2,7 +2,6 @@ export * from "./artifacts";
2
2
  export * from "./executor";
3
3
  export * from "./moduleIndex";
4
4
  export * from "./plan";
5
- export * from "./primitive";
6
5
  export * from "./render";
7
6
  export * from "./rolloutGate";
8
7
  export * from "./source";
@@ -1,31 +1,20 @@
1
- import { afterEach, describe, expect, test } from "bun:test";
2
- import { mkdir, mkdtemp, rm, writeFile } from "node:fs/promises";
3
- import os from "node:os";
1
+ import { describe, expect, test } from "bun:test";
4
2
  import path from "node:path";
5
3
  import type { AkanModuleContext } from "../akanContext";
6
4
  import type { Workspace } from "../commandDecorators";
5
+ import { tempDirs, writeText } from "../testHelpers";
7
6
  import { buildAkanModuleContextIndex } from "./moduleIndex";
8
7
 
9
- const tempRoots: string[] = [];
10
-
11
- afterEach(async () => {
12
- await Promise.all(tempRoots.splice(0).map((root) => rm(root, { recursive: true, force: true })));
13
- });
8
+ const tempRoot = tempDirs("akan-module-index-");
14
9
 
15
10
  const makeWorkspace = async () => {
16
- const root = await mkdtemp(path.join(os.tmpdir(), "akan-module-index-"));
17
- tempRoots.push(root);
11
+ const root = await tempRoot();
18
12
  return {
19
13
  root,
20
14
  workspace: { workspaceRoot: root } as Workspace,
21
15
  };
22
16
  };
23
17
 
24
- const writeText = async (filePath: string, content: string) => {
25
- await mkdir(path.dirname(filePath), { recursive: true });
26
- await writeFile(filePath, content);
27
- };
28
-
29
18
  const moduleContext = (files: string[], name = "post"): AkanModuleContext => ({
30
19
  kind: "domain",
31
20
  name,