@akanjs/devkit 3.0.0-beta.19 → 3.0.0-beta.20

package/integration/devStabilityHarness.test.ts

@@ -1,23 +1,14 @@
 import { afterEach, describe, expect, test } from "bun:test";
-import { mkdir, mkdtemp, readdir, rm, writeFile } from "node:fs/promises";
-import { tmpdir } from "node:os";
+import { mkdir, readdir, writeFile } from "node:fs/promises";
 import path from "node:path";
+import { tempDirs } from "../testHelpers";
 import { DevStabilityHarness } from "./devStabilityHarness";
 
-/**
- * Port allocation and orphan sweeping, asserted directly rather than through the integration suite.
- *
- * Both used to be probabilistic: the offset was drawn at random, and the port was re-derived from the
- * live `apps/` listing on every call. Neither failure shows up in a sequential run on a quiet machine —
- * five consecutive runs of the integration file passed 16/16 with the old code — so the properties have
- * to be asserted here, where a collision can be constructed instead of waited for.
- */
-const roots: string[] = [];
 const servers: Bun.Server<undefined>[] = [];
+const makeRoot = tempDirs("akan-harness-port-");
 
 const createRoot = async (): Promise<string> => {
-  const root = await mkdtemp(path.join(tmpdir(), "akan-harness-port-"));
-  roots.push(root);
+  const root = await makeRoot();
   await mkdir(path.join(root, "apps"), { recursive: true });
   return root;
 };
@@ -28,23 +19,18 @@ const occupy = (port: number): Bun.Server<undefined> => {
   return server;
 };
 
-afterEach(async () => {
+afterEach(() => {
   for (const server of servers.splice(0)) server.stop(true);
-  await Promise.all(roots.splice(0).map((root) => rm(root, { recursive: true, force: true })));
 });
 
 describe("dev stability harness port allocation", () => {
   test("hands every harness in a process a distinct port", async () => {
     const workspaceRoot = await createRoot();
     const ports: number[] = [];
-    // Sequentially, the way the suite creates them — one harness per test.
     for (let i = 0; i < 12; i++) ports.push(await new DevStabilityHarness({ workspaceRoot }).resolvePort());
 
     expect(new Set(ports).size).toBe(ports.length);
-    // Forward-only, so a harness cannot be handed a port a previous host in this process may still be
-    // holding while it shuts down — which is the collision the random offset kept producing. The cursor starts
-    // at a pid-seeded slot and wraps at the end of the band, so forward is measured around the band, and a step
-    // back would read as most of a lap.
+    // The cursor wraps at the end of the band, so forward is measured around it; a step back reads as most of a lap.
     const band = DevStabilityHarness.portOffsetMax - DevStabilityHarness.portOffsetMin;
     const steps = ports.slice(1).map((port, idx) => (port - ports[idx] + band) % band);
     expect(steps.every((step) => step > 0 && step % DevStabilityHarness.portOffsetStride === 0)).toBe(true);
@@ -56,8 +42,7 @@ describe("dev stability harness port allocation", () => {
     const harness = new DevStabilityHarness({ workspaceRoot });
     const first = await harness.resolvePort();
 
-    // A rival fixture appearing shifts this app's index among locale-sorted apps, which is exactly what
-    // a parallel run does every few seconds. The answer must not move underneath a running test.
+    // A rival fixture shifts this app's index among the locale-sorted apps.
     await mkdir(path.join(workspaceRoot, "apps", "aaa-rival"), { recursive: true });
     await writeFile(path.join(workspaceRoot, "apps", "aaa-rival", "akan.config.ts"), "export default {};\n");
 
@@ -72,8 +57,7 @@ describe("dev stability harness port allocation", () => {
 
     const next = await new DevStabilityHarness({ workspaceRoot }).resolvePort();
 
-    // The next cursor step lands exactly on the occupied port, so a probe-less allocator would hand it
-    // out and the gateway would exit with "already in use" — it has no fallback for its http port.
+    // The next cursor step lands exactly on the occupied port.
     expect(next).not.toBe(taken);
     expect(await DevStabilityHarness.isPortFree(next)).toBe(true);
   });
@@ -84,7 +68,6 @@ describe("dev stability harness port allocation", () => {
   });
 
   test("reports a bound port as unavailable and a free one as available", async () => {
-    // Port 0 lets the OS pick a free one, so this cannot collide with anything on the machine.
     const port = Number(occupy(0).port);
     expect(await DevStabilityHarness.isPortFree(port)).toBe(false);
     for (const server of servers.splice(0)) server.stop(true);
@@ -103,10 +86,7 @@ describe("dev stability harness fixture sweep", () => {
     const swept = await DevStabilityHarness.sweepAbandonedFixtures(workspaceRoot);
 
     expect(swept).toEqual([abandoned]);
-    // `readdir`, not `Bun.file(dir).exists()` — that reports false for a directory, so it would have
-    // asserted nothing here.
-    // Never swept by name alone: a concurrent run's fixtures look identical apart from the pid they
-    // carry, and taking one out from under a live suite would break the run this is meant to protect.
+    // `readdir`, not `Bun.file(dir).exists()`, which is false for a directory.
     expect(await readdir(path.join(workspaceRoot, "apps"))).toEqual([live]);
   });