@akanjs/devkit 3.0.0-alpha.6 → 3.0.0-alpha.61

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (54) hide show
  1. package/CHANGELOG.md +15 -0
  2. package/README.ko.md +1 -1
  3. package/README.md +1 -1
  4. package/agentsIndex.test.ts +10 -0
  5. package/agentsIndex.ts +47 -1
  6. package/aiEditor.ts +1 -1
  7. package/akanConfig/akanConfig.test.ts +47 -10
  8. package/akanConfig/akanConfig.ts +23 -16
  9. package/akanContext.ts +53 -11
  10. package/applicationBuildRunner.test.ts +1 -1
  11. package/applicationBuildRunner.ts +0 -1
  12. package/artifact/implicitRootLayout.ts +2 -2
  13. package/biome.base.json +336 -0
  14. package/biomeBase.ts +9 -0
  15. package/executors.test.ts +87 -5
  16. package/executors.ts +26 -6
  17. package/formSetterScanner.test.ts +80 -0
  18. package/formSetterScanner.ts +92 -0
  19. package/frontendBuild/buildRouteClient.test.ts +28 -2
  20. package/frontendBuild/clientBuildTypes.ts +4 -0
  21. package/frontendBuild/clientEntriesBundler.ts +4 -1
  22. package/frontendBuild/cssCompiler.ts +122 -11
  23. package/frontendBuild/cssImportResolver.ts +8 -7
  24. package/frontendBuild/frontendBuild.test.ts +88 -1
  25. package/frontendBuild/hmrWatcher.ts +1 -1
  26. package/frontendBuild/routeClientBuilder.ts +12 -5
  27. package/frontendBuild/ssrBaseArtifactBuilder.ts +20 -4
  28. package/frontendBuild/styleGuard.test.ts +15 -0
  29. package/frontendBuild/styleGuard.ts +17 -0
  30. package/frontendBuild/vendorSpecifiers.ts +1 -0
  31. package/getCredentials.ts +1 -3
  32. package/incrementalBuilder/devWatchBatch.test.ts +18 -20
  33. package/incrementalBuilder/incrementalBuilder.host.ts +1 -1
  34. package/incrementalBuilder/incrementalBuilder.proc.ts +2 -2
  35. package/integration/devStabilityHarness.ts +1 -5
  36. package/lint/no-async-component-in-ui.grit +35 -0
  37. package/lint/no-daisyui-legacy-class.grit +26 -9
  38. package/lint/no-import-client-in-server.grit +48 -0
  39. package/lint/no-import-server-in-client.grit +45 -0
  40. package/lint/no-init-fetch-in-client.grit +47 -0
  41. package/lint/no-model-type-in-util-zone.grit +58 -0
  42. package/lint/no-return-in-store-action.grit +35 -0
  43. package/lint/no-unpublished-form-setter.grit +41 -0
  44. package/linter.ts +17 -12
  45. package/package.json +4 -4
  46. package/qualityScanner.test.ts +52 -0
  47. package/qualityScanner.ts +48 -37
  48. package/repoIdentity.ts +42 -0
  49. package/routeSourceValidator.test.ts +41 -0
  50. package/routeSourceValidator.ts +2 -44
  51. package/scanInfo.ts +21 -20
  52. package/transforms/externalizeFrameworkPlugin.ts +0 -1
  53. package/workspaceLayout.test.ts +56 -4
  54. package/workspaceLayout.ts +49 -4
@@ -0,0 +1,92 @@
1
+ import ts from "typescript";
2
+ import type { QualityWarning, SourceFileInfo } from "./qualityScanner";
3
+
4
+ /**
5
+ * The inventory of model fields a screen writes but does not publish.
6
+ *
7
+ * A control handed `onChange={st.do.setTitleOnTask}` **by reference** names the field it writes, so it emits
8
+ * `data-akan-action` and `useFieldTool` publishes the field to the in-page agent. Any wrapper around that setter is
9
+ * an anonymous closure carrying neither, and the field goes quiet — for the agent, for an E2E selector, and for the
10
+ * accessibility tree.
11
+ *
12
+ * `no-unpublished-form-setter.grit` is the per-line enforcement, and it fires only on a pure forwarding wrapper,
13
+ * because every other shape has a legitimate reading and a lint error would be wrong. This is the other half: the
14
+ * per-file count of fields that ended up unreachable whatever the reason, which is the number worth watching. A
15
+ * warning rather than an error for the same reason — the remedy depends on why the wrapper is there.
16
+ *
17
+ * Only a handler that takes a parameter is counted. A zero-parameter handler (`onClick={() => st.do.setStatusOnUser
18
+ * ("active")}`) is a button setting a constant, not a form control, and its remedy is an `st.tool` beside it.
19
+ */
20
+ export class FormSetterScanner {
21
+ static #fieldSetter = /^set[A-Za-z0-9_$]*On[A-Za-z0-9_$]*$/;
22
+
23
+ scan(sourceFiles: SourceFileInfo[]): QualityWarning[] {
24
+ return sourceFiles.filter((sourceFile) => sourceFile.file.endsWith(".tsx")).flatMap((f) => this.#scanFile(f));
25
+ }
26
+
27
+ #scanFile({ file, sourceFile }: SourceFileInfo): QualityWarning[] {
28
+ const wrapped: { setter: string; line: number }[] = [];
29
+ const visit = (node: ts.Node) => {
30
+ if (ts.isJsxAttribute(node)) {
31
+ const setter = FormSetterScanner.#wrappedSetterOf(node);
32
+ if (setter) wrapped.push({ setter, line: FormSetterScanner.#lineOf(sourceFile, node) });
33
+ }
34
+ ts.forEachChild(node, visit);
35
+ };
36
+ visit(sourceFile);
37
+ if (!wrapped.length) return [];
38
+ const setters = [...new Set(wrapped.map((entry) => entry.setter))].sort();
39
+ return [
40
+ {
41
+ rule: "akan.agent.unpublished-form-setter",
42
+ scope: "agent",
43
+ severity: "warning",
44
+ message:
45
+ setters.length === 1
46
+ ? `${setters[0]} is reached through a wrapper, so that field publishes no agent tool and carries no data-akan-action.`
47
+ : `${setters.length} field setters are reached through a wrapper, so those fields publish no agent tool and carry no data-akan-action: ${setters.join(", ")}.`,
48
+ file,
49
+ line: wrapped[0]?.line,
50
+ locations: wrapped.map(({ line }) => ({ file, line })),
51
+ },
52
+ ];
53
+ }
54
+
55
+ /** The setter a handler prop writes behind a wrapper, or null when it is passed by reference or absent. */
56
+ static #wrappedSetterOf(attribute: ts.JsxAttribute): string | null {
57
+ if (!ts.isIdentifier(attribute.name) || !/^on[A-Z]/.test(attribute.name.text)) return null;
58
+ const initializer = attribute.initializer;
59
+ if (!initializer || !ts.isJsxExpression(initializer) || !initializer.expression) return null;
60
+ const handler = initializer.expression;
61
+ if (!ts.isArrowFunction(handler) && !ts.isFunctionExpression(handler)) return null;
62
+ if (!handler.parameters.length) return null;
63
+ return FormSetterScanner.#setterCallIn(handler.body);
64
+ }
65
+
66
+ static #setterCallIn(node: ts.Node): string | null {
67
+ let found: string | null = null;
68
+ const visit = (current: ts.Node) => {
69
+ if (found) return;
70
+ if (ts.isCallExpression(current) && ts.isPropertyAccessExpression(current.expression)) {
71
+ const { expression, name } = current.expression;
72
+ if (
73
+ ts.isPropertyAccessExpression(expression) &&
74
+ ts.isIdentifier(expression.expression) &&
75
+ expression.expression.text === "st" &&
76
+ expression.name.text === "do" &&
77
+ FormSetterScanner.#fieldSetter.test(name.text)
78
+ ) {
79
+ found = name.text;
80
+ return;
81
+ }
82
+ }
83
+ ts.forEachChild(current, visit);
84
+ };
85
+ visit(node);
86
+ return found;
87
+ }
88
+
89
+ static #lineOf(sourceFile: ts.SourceFile, node: ts.Node) {
90
+ return sourceFile.getLineAndCharacterOfPosition(node.getStart(sourceFile)).line + 1;
91
+ }
92
+ }
@@ -82,16 +82,42 @@ describe("route client store bootstrap", () => {
82
82
  });
83
83
 
84
84
  test("bundles akan fetch into production SSR client chunks", () => {
85
- expect(RouteClientBuilder.resolveSsrClientExternalOptions("start")).toMatchObject({
85
+ expect(RouteClientBuilder.resolveSsrClientBundleOptions("start")).toMatchObject({
86
86
  external: expect.arrayContaining(["akanjs/fetch"]),
87
87
  externalSubpaths: ["akanjs/fetch"],
88
88
  });
89
89
 
90
- expect(RouteClientBuilder.resolveSsrClientExternalOptions("build")).toEqual({
90
+ expect(RouteClientBuilder.resolveSsrClientBundleOptions("build")).toEqual({
91
+ target: "bun",
91
92
  external: ["react", "react-dom", "react-dom/client", "react/jsx-runtime", "react/jsx-dev-runtime"],
92
93
  });
93
94
  });
94
95
 
96
+ test("targets the server so SSR client chunks never resolve a browser export condition", async () => {
97
+ const root = await makeTempRoot();
98
+ const pkgDir = path.join(root, "node_modules/dom-conditioned-pkg");
99
+ await write(
100
+ path.join(pkgDir, "package.json"),
101
+ JSON.stringify({
102
+ name: "dom-conditioned-pkg",
103
+ type: "module",
104
+ exports: { ".": { browser: "./index.dom.js", default: "./index.js" } },
105
+ }),
106
+ );
107
+ await write(path.join(pkgDir, "index.dom.js"), 'export const element = document.createElement("i");\n');
108
+ await write(path.join(pkgDir, "index.js"), "export const element = null;\n");
109
+ const entry = path.join(root, "entry.ts");
110
+ await write(entry, 'export { element } from "dom-conditioned-pkg";\n');
111
+
112
+ for (const command of ["start", "build"] as const) {
113
+ const { target } = RouteClientBuilder.resolveSsrClientBundleOptions(command);
114
+ const built = await Bun.build({ entrypoints: [entry], target, format: "esm" });
115
+
116
+ expect(built.success).toBe(true);
117
+ expect(await built.outputs[0].text()).not.toContain("document.createElement");
118
+ }
119
+ });
120
+
95
121
  test("rewrites SSR external imports to runtime aliases", () => {
96
122
  const source = [
97
123
  'import React, { useState } from "react";',
@@ -55,6 +55,8 @@ export interface BuildClientResult {
55
55
  rscClientUrl: string;
56
56
  }
57
57
 
58
+ export type ClientBundleTarget = "browser" | "bun";
59
+
58
60
  export const CLIENT_BUNDLE_NAMING = {
59
61
  entry: "[name]-[hash].[ext]",
60
62
  chunk: "chunks/[hash].[ext]",
@@ -79,6 +81,8 @@ export interface BundleClientEntriesOptions {
79
81
  }
80
82
 
81
83
  export interface BundleClientEntriesInternalOptions extends BundleClientEntriesOptions {
84
+ /** Module-resolution target. `"bun"` for the server-executed `client-ssr` bundle, `"browser"` otherwise. */
85
+ target?: ClientBundleTarget;
82
86
  external?: readonly string[];
83
87
  externalSubpaths?: readonly string[];
84
88
  externalAliases?: Partial<Record<string, string>>;
@@ -7,6 +7,7 @@ import {
7
7
  type BundleClientEntriesInternalOptions,
8
8
  type BundleClientEntriesResult,
9
9
  CLIENT_BUNDLE_NAMING,
10
+ type ClientBundleTarget,
10
11
  type ClientManifest,
11
12
  type MetafileOutput,
12
13
  type OpaqueEntryAliases,
@@ -25,6 +26,7 @@ export class ClientEntriesBundler {
25
26
  #externalSubpaths: readonly string[];
26
27
  #externalAliases: Partial<Record<string, string>>;
27
28
  #command: "build" | "start";
29
+ #target: ClientBundleTarget;
28
30
  #outputSubdir: string;
29
31
  #reactFastRefresh: boolean;
30
32
  #artifactDir: string;
@@ -47,6 +49,7 @@ export class ClientEntriesBundler {
47
49
  this.#externalSubpaths = options.externalSubpaths ?? [];
48
50
  this.#externalAliases = options.externalAliases ?? {};
49
51
  this.#command = options.command ?? "start";
52
+ this.#target = options.target ?? "browser";
50
53
  this.#outputSubdir = options.outputSubdir ?? "client";
51
54
  this.#reactFastRefresh = options.reactFastRefresh ?? false;
52
55
  this.#artifactDir = `${this.#command === "build" ? this.#app.dist.cwdPath : this.#app.cwdPath}/.akan/artifact`;
@@ -61,7 +64,7 @@ export class ClientEntriesBundler {
61
64
  entrypoints: this.#opaqueEntries.entries,
62
65
  outdir: this.#outdir,
63
66
  splitting: true,
64
- target: "browser",
67
+ target: this.#target,
65
68
  format: "esm",
66
69
  naming: CLIENT_BUNDLE_NAMING,
67
70
  metafile: true,
@@ -17,6 +17,12 @@ interface CssDiscovery {
17
17
  sourcePaths: string[];
18
18
  }
19
19
 
20
+ /** One `@import` target and the custom properties it declares, which is what proves it arrived downstream. */
21
+ export interface ImportedStylesheet {
22
+ cssPath: string;
23
+ declaredNames: string[];
24
+ }
25
+
20
26
  export class CssCompiler {
21
27
  #logger = new Logger("CssCompiler");
22
28
  #transpiler = new Bun.Transpiler({ loader: "tsx" });
@@ -46,6 +52,13 @@ export class CssCompiler {
46
52
  #fileExistsCache = new Map<string, Promise<boolean>>();
47
53
  #resolvedFileCache = new Map<string, Promise<string | null>>();
48
54
  #resolvedSpecifierCache = new Map<string, Promise<string | null>>();
55
+ /** Every stylesheet this compile reached, entry points and `@import` targets alike. */
56
+ #discoveredCssPaths = new Set<string>();
57
+ /**
58
+ * `@import` targets per base path, so whoever writes the asset can check the file it actually wrote — the
59
+ * compiled text and the written artifact are two different places a declaration can go missing.
60
+ */
61
+ importedStylesheetsByBasePath: Record<string, ImportedStylesheet[]> = {};
49
62
 
50
63
  #fileExists(absPath: string): Promise<boolean> {
51
64
  let cached = this.#fileExistsCache.get(absPath);
@@ -76,13 +89,20 @@ export class CssCompiler {
76
89
  }
77
90
  async getCss({ refresh }: { refresh?: boolean } = {}) {
78
91
  if (this.#cssText !== null && !refresh) return this.#cssText;
92
+ this.#discoveredCssPaths.clear();
93
+ this.importedStylesheetsByBasePath = {};
79
94
  const { cssPaths, sourcePaths } = await this.discoverCssAndSources({ refresh });
80
- this.#cssText = await this.compileCss(cssPaths, sourcePaths);
95
+ const { css, imported } = await this.#compileWithImports(cssPaths, sourcePaths);
96
+ this.#cssText = css;
97
+ this.importedStylesheetsByBasePath = { "": imported };
98
+ await this.#warnUnreachableStylesheets();
81
99
  return this.#cssText;
82
100
  }
83
101
 
84
102
  async getCssByBasePath({ refresh }: { refresh?: boolean } = {}): Promise<Record<string, string>> {
85
103
  if (this.#cssTextByBasePath !== null && !refresh) return this.#cssTextByBasePath;
104
+ this.#discoveredCssPaths.clear();
105
+ this.importedStylesheetsByBasePath = {};
86
106
  const akanConfig = await this.#app.getConfig({ refresh });
87
107
  const pageKeys = await this.#app.getPageKeys({ refresh });
88
108
  const basePaths = [...akanConfig.basePaths];
@@ -92,7 +112,8 @@ export class CssCompiler {
92
112
  if (rootPageKeys.length === 0) return ["", ""] as const;
93
113
  const started = Date.now();
94
114
  const { cssPaths, sourcePaths } = await this.discoverCssAndSources({ refresh, pageKeys: rootPageKeys });
95
- const css = await this.compileCss(cssPaths, sourcePaths);
115
+ const { css, imported } = await this.#compileWithImports(cssPaths, sourcePaths);
116
+ this.importedStylesheetsByBasePath[""] = imported;
96
117
  this.#logger.verbose(
97
118
  `css base=root paths=${cssPaths.length} sources=${sourcePaths.length} in ${Date.now() - started}ms`,
98
119
  );
@@ -103,7 +124,8 @@ export class CssCompiler {
103
124
  if (basePathPageKeys.length === 0) return [basePath, ""] as const;
104
125
  const started = Date.now();
105
126
  const { cssPaths, sourcePaths } = await this.discoverCssAndSources({ refresh, pageKeys: basePathPageKeys });
106
- const css = await this.compileCss(cssPaths, sourcePaths);
127
+ const { css, imported } = await this.#compileWithImports(cssPaths, sourcePaths);
128
+ this.importedStylesheetsByBasePath[basePath] = imported;
107
129
  this.#logger.verbose(
108
130
  `css base=${basePath} paths=${cssPaths.length} sources=${sourcePaths.length} in ${Date.now() - started}ms`,
109
131
  );
@@ -111,9 +133,26 @@ export class CssCompiler {
111
133
  }),
112
134
  ]);
113
135
  this.#cssTextByBasePath = Object.fromEntries(cssEntries);
136
+ await this.#warnUnreachableStylesheets();
114
137
  return this.#cssTextByBasePath;
115
138
  }
116
139
 
140
+ /**
141
+ * A stylesheet under `page/` reaches the build only by being imported from a route source. One that nothing
142
+ * imports compiles to nothing and reports success, which is indistinguishable from an empty theme — so say it
143
+ * out loud once per compile rather than leaving it to be noticed as unstyled elements in the browser.
144
+ */
145
+ async #warnUnreachableStylesheets() {
146
+ const pageDir = path.join(this.#app.cwdPath, "page");
147
+ const glob = new Bun.Glob("**/*.css");
148
+ for await (const cssPath of glob.scan({ cwd: pageDir, absolute: true })) {
149
+ // `(libs)` is a link farm: the same file is discovered under its real path in `libs/`, never this one.
150
+ if (cssPath.includes(`${path.sep}(libs)${path.sep}`)) continue;
151
+ if (this.#discoveredCssPaths.has(cssPath)) continue;
152
+ this.#logger.warn(`css ${path.relative(this.#app.cwdPath, cssPath)} is imported by no route and never compiled`);
153
+ }
154
+ }
155
+
117
156
  async discoverCss({ refresh }: { refresh?: boolean } = {}): Promise<string[]> {
118
157
  const { cssPaths } = await this.discoverCssAndSources({ refresh });
119
158
  return cssPaths;
@@ -180,22 +219,61 @@ export class CssCompiler {
180
219
  }
181
220
  }
182
221
 
183
- return { cssPaths: [...cssFiles], sourcePaths: [...sourceFiles] };
222
+ const tokenPaths = await this.#libTokenStylesheets(sourceFiles);
223
+ const cssPaths = [...new Set([...tokenPaths, ...cssFiles])];
224
+ for (const cssPath of cssPaths) this.#discoveredCssPaths.add(cssPath);
225
+ return { cssPaths, sourcePaths: [...sourceFiles] };
226
+ }
227
+
228
+ /**
229
+ * `libs/<lib>/ui/tokens.css` of every lib the page graph reached, so a lib can own the fixed colours its own
230
+ * components need instead of each consuming app re-declaring them. Ordered ahead of the app's stylesheets:
231
+ * the app is the last word on any variable both declare.
232
+ */
233
+ async #libTokenStylesheets(sourceFiles: Set<string>): Promise<string[]> {
234
+ const libsRoot = path.join(this.#app.workspace.workspaceRoot, "libs");
235
+ const libNames = new Set<string>();
236
+ for (const filePath of sourceFiles) {
237
+ const relPath = path.relative(libsRoot, filePath);
238
+ if (relPath.startsWith("..") || path.isAbsolute(relPath)) continue;
239
+ const [libName] = relPath.split(path.sep);
240
+ if (libName) libNames.add(libName);
241
+ }
242
+ const tokenPaths = await Promise.all(
243
+ [...libNames].sort().map(async (libName) => {
244
+ const tokensPath = path.join(libsRoot, libName, "ui/tokens.css");
245
+ return (await this.#fileExists(tokensPath)) ? tokensPath : null;
246
+ }),
247
+ );
248
+ return tokenPaths.filter((tokensPath): tokensPath is string => !!tokensPath);
184
249
  }
185
250
  async compileCss(cssPaths: string[], sourcePaths: string[]): Promise<string> {
186
- if (cssPaths.length === 0) return "";
251
+ const { css } = await this.#compileWithImports(cssPaths, sourcePaths);
252
+ return css;
253
+ }
254
+
255
+ /**
256
+ * The collector is per compile rather than per compiler instance: `getCssByBasePath` compiles every base path
257
+ * concurrently, so instance state would mix one base path's imports into another's check.
258
+ */
259
+ async #compileWithImports(
260
+ cssPaths: string[],
261
+ sourcePaths: string[],
262
+ ): Promise<{ css: string; imported: ImportedStylesheet[] }> {
263
+ if (cssPaths.length === 0) return { css: "", imported: [] };
187
264
 
188
265
  const compileStarted = Date.now();
189
266
  const compilers = await Promise.all(
190
267
  cssPaths.map(async (cssPath) => {
191
268
  const css = await Bun.file(cssPath).text();
192
269
  const base = path.dirname(cssPath);
270
+ const imported = new Map<string, string>();
193
271
  const compiler = await compile(css, {
194
272
  base,
195
- loadStylesheet: (id, fromBase) => this.#loadStylesheet(id, fromBase),
273
+ loadStylesheet: (id, fromBase) => this.#loadStylesheet(id, fromBase, imported),
196
274
  loadModule: (id, fromBase) => this.#loadModule(id, fromBase),
197
275
  });
198
- return { cssPath, compiler };
276
+ return { cssPath, compiler, imported };
199
277
  }),
200
278
  );
201
279
 
@@ -210,24 +288,46 @@ export class CssCompiler {
210
288
  `css candidates scanned count=${candidates.length} sources=${sourcePaths.length} dirs=${sourceDirs.size} in ${Date.now() - scanStarted}ms`,
211
289
  );
212
290
  const parts: string[] = [];
291
+ const imported: ImportedStylesheet[] = [];
213
292
  for (const entry of compilers) {
214
293
  if (!entry) continue;
215
- parts.push(entry.compiler.build(candidates));
294
+ const part = entry.compiler.build(candidates);
295
+ parts.push(part);
296
+ for (const [cssPath, content] of entry.imported) {
297
+ const declaredNames = declaredCustomProperties(content);
298
+ imported.push({ cssPath, declaredNames });
299
+ if (declaredNames.length === 0 || declaredNames.some((name) => part.includes(`${name}:`))) continue;
300
+ this.#logger.warn(
301
+ `css @import ${cssPath} was loaded by ${entry.cssPath} but none of its ${declaredNames.length} declaration(s) reached the compiled CSS`,
302
+ );
303
+ }
216
304
  }
217
305
  this.#logger.verbose(
218
306
  `css compiled paths=${cssPaths.length} candidates=${candidates.length} in ${Date.now() - compileStarted}ms`,
219
307
  );
220
- return parts.join("\n");
308
+ return { css: parts.join("\n"), imported };
221
309
  }
222
310
 
223
- async #loadStylesheet(id: string, fromBase: string) {
311
+ async #loadStylesheet(id: string, fromBase: string, imported?: Map<string, string>) {
224
312
  const p = await this.#resolveCssImport(id, fromBase);
313
+ this.#discoveredCssPaths.add(p);
225
314
  const content = await Bun.file(p).text();
315
+ imported?.set(p, content);
316
+ this.#logger.verbose(`css import "${id}" from ${fromBase} -> ${p} (${content.length} bytes)`);
226
317
  return { path: p, base: path.dirname(p), content };
227
318
  }
228
319
 
320
+ /**
321
+ * Every specifier is verified here, path-shaped ones included. An `@import` the pipeline cannot resolve is
322
+ * a build error and never a no-op: the vocabulary closure means a component whose token declaration failed
323
+ * to load renders unstyled, which nothing downstream can distinguish from a design choice.
324
+ */
229
325
  async #resolveCssImport(id: string, fromBase: string): Promise<string> {
230
- if (id.startsWith(".") || id.startsWith("/")) return path.resolve(fromBase, id);
326
+ if (id.startsWith(".") || id.startsWith("/")) {
327
+ const filePath = path.resolve(fromBase, id);
328
+ if (await this.#fileExists(filePath)) return filePath;
329
+ throw new Error(`[css] failed to resolve stylesheet import "${id}" from ${fromBase} (no file at ${filePath})`);
330
+ }
231
331
  const resolver = await this.#getCssImportResolver();
232
332
  const resolved = await resolver.resolve(id, fromBase);
233
333
  if (resolved) return resolved;
@@ -330,6 +430,17 @@ export function isIgnoredNodeModuleSource(filePath: string): boolean {
330
430
  return NODE_MODULES_RE.test(filePath) && !AKANJS_NODE_MODULE_RE.test(filePath);
331
431
  }
332
432
 
433
+ /**
434
+ * `@theme` blocks are stripped first: those variables are emitted only when a utility uses one, so their
435
+ * absence from a build says nothing about whether the stylesheet arrived.
436
+ */
437
+ export function declaredCustomProperties(css: string): string[] {
438
+ const withoutThemeBlocks = css.replace(/@theme[^{]*\{[^}]*\}/g, "");
439
+ return [...new Set([...withoutThemeBlocks.matchAll(/(?:^|[\s;{])(--[\w-]+)\s*:/g)].map(([, name]) => name))].filter(
440
+ (name): name is string => !!name,
441
+ );
442
+ }
443
+
333
444
  function getPageKeyBasePath(pageKey: string, basePaths: string[]): string | null {
334
445
  const normalized = pageKey.split(path.sep).join("/").replace(/^\.\//, "");
335
446
  const segments = normalized.split("/");
@@ -106,14 +106,15 @@ export class CssImportResolver {
106
106
  const pkg = await Bun.file(pkgPath).json();
107
107
  const subpath = id === pkgName ? "." : `.${id.slice(pkgName.length)}`;
108
108
  const exportValue = pkg.exports?.[subpath];
109
- const styleEntry =
110
- (typeof exportValue === "string"
109
+ const exportedEntry =
110
+ typeof exportValue === "string"
111
111
  ? exportValue
112
- : exportValue?.style || exportValue?.import || exportValue?.default) ||
113
- pkg.exports?.["."]?.style ||
114
- pkg.style ||
115
- "index.css";
116
- return await this.#firstExisting(path.resolve(pkgDir, styleEntry));
112
+ : exportValue?.style || exportValue?.import || exportValue?.default;
113
+ if (exportedEntry) return await this.#firstExisting(path.resolve(pkgDir, exportedEntry));
114
+ //* A subpath names a file inside the package, so it resolves literally. Falling back to the package's own
115
+ //* style entry here would load a different stylesheet than the author asked for and report success.
116
+ if (subpath !== ".") return await this.#firstExisting(path.resolve(pkgDir, subpath));
117
+ return await this.#firstExisting(path.resolve(pkgDir, pkg.exports?.["."]?.style || pkg.style || "index.css"));
117
118
  } catch {
118
119
  return null;
119
120
  }
@@ -5,7 +5,7 @@ import path from "node:path";
5
5
  import { fileURLToPath } from "node:url";
6
6
  import type { RoutesManifest } from "akanjs/server";
7
7
  import { CsrArtifactBuilder } from "./csrArtifactBuilder";
8
- import { CssCompiler, isIgnoredNodeModuleSource } from "./cssCompiler";
8
+ import { CssCompiler, declaredCustomProperties, isIgnoredNodeModuleSource } from "./cssCompiler";
9
9
  import { CssImportResolver } from "./cssImportResolver";
10
10
  import { DevChangePlanner } from "./devChangePlanner";
11
11
  import { DevGeneratedIndexSync } from "./devGeneratedIndexSync";
@@ -391,6 +391,20 @@ describe("CssImportResolver", () => {
391
391
  expect(await resolver.resolve("@libs/ui/missing", root)).toBeNull();
392
392
  });
393
393
 
394
+ test("never substitutes the package stylesheet for a subpath that does not exist", async () => {
395
+ const root = await makeTempRoot();
396
+ await write(
397
+ path.join(root, "node_modules/vendor/package.json"),
398
+ JSON.stringify({ name: "vendor", style: "index.css" }),
399
+ );
400
+ await write(path.join(root, "node_modules/vendor/index.css"), ".vendor {}\n");
401
+
402
+ const resolver = new CssImportResolver(root, {});
403
+
404
+ expect(await resolver.resolve("vendor", root)).toBe(path.join(root, "node_modules/vendor/index.css"));
405
+ expect(await resolver.resolve("vendor/ui/tokens.css", root)).toBeNull();
406
+ });
407
+
394
408
  test("resolves css from single-package Akan workspace subpaths", async () => {
395
409
  const root = await makeTempRoot();
396
410
  await write(path.join(root, "pkgs/akanjs/ui/styles.css"), "body {}\n");
@@ -428,4 +442,77 @@ describe("CssCompiler", () => {
428
442
 
429
443
  expect(css).toContain(".text-fuchsia-500");
430
444
  });
445
+
446
+ test("reads declarations that prove a stylesheet arrived, ignoring theme variables that may not", () => {
447
+ expect(declaredCustomProperties(":root { --kakao: #fee500; --naver: #1ec800; }")).toEqual(["--kakao", "--naver"]);
448
+ expect(declaredCustomProperties("@theme inline {\n --color-brand: var(--brand);\n}\n")).toEqual([]);
449
+ expect(declaredCustomProperties("@theme { --color-x: initial; }\n:root { --brand: #111; }")).toEqual(["--brand"]);
450
+ expect(declaredCustomProperties(".a { color: var(--kakao); }")).toEqual([]);
451
+ expect(declaredCustomProperties(":root{--a:#111}\n@media (min-width:1px){:root{--a:#222;--b:#333}}")).toEqual([
452
+ "--a",
453
+ "--b",
454
+ ]);
455
+ });
456
+
457
+ test("fails loudly on a stylesheet import that resolves to nothing", async () => {
458
+ const root = await makeTempRoot();
459
+ const cssPath = path.join(root, "apps/demo/page/styles.css");
460
+ await write(cssPath, '@import "../../../libs/shared/ui/tokens.css";\n');
461
+
462
+ const compiler = new CssCompiler({
463
+ workspace: { workspaceRoot: root },
464
+ cwdPath: path.join(root, "apps/demo"),
465
+ getTsConfig: async () => ({ compilerOptions: { paths: {} } }),
466
+ } as never);
467
+
468
+ await expect(compiler.compileCss([cssPath], [])).rejects.toThrow(
469
+ /failed to resolve stylesheet import "\.\.\/\.\.\/\.\.\/libs\/shared\/ui\/tokens\.css"/,
470
+ );
471
+ });
472
+
473
+ test("reports every @import per base path so the written asset can be checked against it", async () => {
474
+ const root = await makeTempRoot();
475
+ const appDir = path.join(root, "apps/demo");
476
+ await write(path.join(appDir, "page/_index.tsx"), 'import "./styles.css";\nexport default () => null;\n');
477
+ await write(path.join(appDir, "page/styles.css"), '@import "../../../libs/shared/ui/brand.css";\n');
478
+ await write(path.join(root, "libs/shared/ui/brand.css"), ":root { --kakao: #fee500; --naver: #1ec800; }\n");
479
+
480
+ const compiler = new CssCompiler({
481
+ workspace: { workspaceRoot: root },
482
+ cwdPath: appDir,
483
+ getPageKeys: async () => ["./_index.tsx"],
484
+ getConfig: async () => ({ barrelImports: [], basePaths: [] }),
485
+ getTsConfig: async () => ({ compilerOptions: { paths: {} } }),
486
+ } as never);
487
+ const cssByBasePath = await compiler.getCssByBasePath();
488
+
489
+ expect(cssByBasePath[""]).toContain("--kakao");
490
+ expect(compiler.importedStylesheetsByBasePath[""]).toEqual([
491
+ { cssPath: path.join(root, "libs/shared/ui/brand.css"), declaredNames: ["--kakao", "--naver"] },
492
+ ]);
493
+ });
494
+
495
+ test("compiles lib-owned tokens ahead of the app stylesheets that may override them", async () => {
496
+ const root = await makeTempRoot();
497
+ const appDir = path.join(root, "apps/demo");
498
+ await write(
499
+ path.join(appDir, "page/_index.tsx"),
500
+ 'import "./styles.css";\nimport { Card } from "@libs/shared/ui";\nexport default () => <Card />;\n',
501
+ );
502
+ await write(path.join(appDir, "page/styles.css"), ":root { --brand: #111111; }\n");
503
+ await write(path.join(root, "libs/shared/ui/index.ts"), "export const Card = () => null;\n");
504
+ await write(path.join(root, "libs/shared/ui/tokens.css"), ":root { --kakao: #fee500; }\n");
505
+ await write(path.join(root, "libs/unused/ui/tokens.css"), ":root { --unused: #000000; }\n");
506
+
507
+ const compiler = new CssCompiler({
508
+ workspace: { workspaceRoot: root },
509
+ cwdPath: appDir,
510
+ getPageKeys: async () => ["./_index.tsx"],
511
+ getConfig: async () => ({ barrelImports: [] }),
512
+ getTsConfig: async () => ({ compilerOptions: { paths: { "@libs/*": ["./libs/*"] } } }),
513
+ } as never);
514
+ const { cssPaths } = await compiler.discoverCssAndSources();
515
+
516
+ expect(cssPaths).toEqual([path.join(root, "libs/shared/ui/tokens.css"), path.join(appDir, "page/styles.css")]);
517
+ });
431
518
  });
@@ -209,7 +209,7 @@ export class HmrWatcher {
209
209
  // per-batch detail stays at verbose because a save-all trips this on every save.
210
210
  if (!this.#reportedCompensating) {
211
211
  this.#reportedCompensating = true;
212
- this.#logger.info(
212
+ this.#logger.verbose(
213
213
  `[hmr] recovered ${unreported} change(s) that fs.watch did not report; Bun coalesces concurrent saves and drops all but one, so changes are resolved by mtime`,
214
214
  );
215
215
  }
@@ -4,7 +4,7 @@ import type { BaseBuildArtifact, ClientManifest, SsrManifest } from "akanjs/serv
4
4
  import type { App } from "../commandDecorators";
5
5
  import { createBarrelImportsPlugin } from "../transforms/barrelImportsPlugin";
6
6
  import { toClientReferencePath } from "../transforms/rscUseClientTransform";
7
- import type { ClientEntryDiscovery } from "./clientBuildTypes";
7
+ import type { ClientBundleTarget, ClientEntryDiscovery } from "./clientBuildTypes";
8
8
  import { ClientEntriesBundler } from "./clientEntriesBundler";
9
9
  import { GraphClientEntryDiscovery } from "./clientEntryDiscovery";
10
10
  import { VENDOR_SPECIFIERS } from "./vendorSpecifiers";
@@ -163,12 +163,11 @@ export class RouteClientBuilder {
163
163
  }
164
164
 
165
165
  async #buildSsrBundle(bootstrapEntries: BootstrapEntries) {
166
- const externalOptions = RouteClientBuilder.resolveSsrClientExternalOptions(this.#command);
167
166
  return new ClientEntriesBundler({
168
167
  app: this.#app,
169
168
  entries: bootstrapEntries.buildEntries,
170
169
  plugins: [await createBarrelImportsPlugin(this.#app)],
171
- ...externalOptions,
170
+ ...RouteClientBuilder.resolveSsrClientBundleOptions(this.#command),
172
171
  outputSubdir: "client-ssr",
173
172
  command: this.#command,
174
173
  }).bundle();
@@ -239,20 +238,28 @@ export class RouteClientBuilder {
239
238
  return { [Bun.resolveSync("akanjs/fetch", serverEntry)]: "akanjs/fetch" };
240
239
  }
241
240
 
242
- static resolveSsrClientExternalOptions(command: "build" | "start"): {
241
+ /**
242
+ * `target: "bun"` is load-bearing: these chunks are `await import()`-ed by the SSR renderer, so a dependency
243
+ * resolved through its `browser` export condition can touch `document` at module scope and throw mid-render,
244
+ * degrading the whole document to client rendering. Bun's `conditions` only adds to the target's defaults —
245
+ * `browser` still wins — so the target itself has to say server.
246
+ */
247
+ static resolveSsrClientBundleOptions(command: "build" | "start"): {
248
+ target: ClientBundleTarget;
243
249
  external: readonly string[];
244
250
  externalSubpaths?: readonly string[];
245
251
  externalAliases?: Record<string, string>;
246
252
  } {
247
253
  if (command === "start") {
248
254
  return {
255
+ target: "bun",
249
256
  external: SSR_CLIENT_EXTERNALS,
250
257
  externalSubpaths: ["akanjs/fetch"],
251
258
  externalAliases: RouteClientBuilder.resolveSsrClientRuntimeAliases(),
252
259
  };
253
260
  }
254
261
 
255
- return { external: SSR_CLIENT_ALIAS_EXTERNALS };
262
+ return { target: "bun", external: SSR_CLIENT_ALIAS_EXTERNALS };
256
263
  }
257
264
 
258
265
  static resolveAkanServerEntry(): string {