@akanjs/devkit 2.4.1-rc.7 → 2.4.2-rc.0

package/transforms/barrelImportsPlugin.ts

@@ -64,18 +64,10 @@ export const createBarrelImportsPlugin = async (
           const hasMacroAttr = MACRO_ATTR_RE.test(source);
 
           if (!hasMacroAttr && barrels.length > 0) {
-            // Fast pre-check to avoid tokenizing every file in the workspace.
-            let maybe = false;
-            for (const b of barrels) {
-              if (source.includes(b)) {
-                maybe = true;
-                break;
-              }
-            }
-            if (maybe) {
-              const rewritten = await rewriteBarrelImports(source, barrels, analyzer);
-              if (rewritten !== null) source = rewritten;
-            }
+            // The pre-check that used to live here — "does this file mention a barrel at all" — now
+            // lives inside `rewriteBarrelImports`, so every caller gets it rather than just this one.
+            const rewritten = await rewriteBarrelImports(source, barrels, analyzer);
+            if (rewritten !== null) source = rewritten;
           }
 
           if (pipeAfter) {
@@ -309,6 +301,12 @@ export const rewriteBarrelImports = async (
   barrels: string[],
   analyzer: BarrelAnalyzer,
 ): Promise<string | null> => {
+  // Establish there is something to rewrite before the TypeScript parser is involved. This runs on
+  // every source file of every dev rebuild, and parsing was by far the most expensive thing in one:
+  // measured across 1189 files here, 299ms and 161MB of RSS, of which **63% of files import no barrel
+  // at all**. A static import cannot name a specifier without that specifier appearing literally in the
+  // text, so a substring test is a sound filter and costs 4ms for the whole corpus.
+  if (!barrels.some((barrel) => source.includes(barrel))) return null;
   const statements = findImportStatements(source);
   if (statements.length === 0) return null;
 
@@ -340,7 +338,16 @@ interface ImportStatement {
 
 const findImportStatements = (source: string): ImportStatement[] => {
   const statements: ImportStatement[] = [];
-  const sourceFile = ts.createSourceFile("barrel-imports.tsx", source, ts.ScriptTarget.Latest, true, ts.ScriptKind.TSX);
+  // `setParentNodes: false`: nothing below reads `node.parent`, and every position comes from
+  // `getStart(sourceFile)`, which takes the file explicitly. Building the parent links cost 132ms and
+  // 143MB of RSS across 1189 files for no reader.
+  const sourceFile = ts.createSourceFile(
+    "barrel-imports.tsx",
+    source,
+    ts.ScriptTarget.Latest,
+    false,
+    ts.ScriptKind.TSX,
+  );
   for (const statement of sourceFile.statements) {
     if (!ts.isImportDeclaration(statement)) continue;
     if (!ts.isStringLiteral(statement.moduleSpecifier)) continue;