@akanjs/devkit 2.3.11-rc.8 → 2.3.11-rc.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@akanjs/devkit",
-  "version": "2.3.11-rc.8",
+  "version": "2.3.11-rc.9",
   "sourceType": "module",
   "type": "module",
   "publishConfig": {
@@ -32,7 +32,7 @@
     "@langchain/openai": "^1.4.6",
     "@tailwindcss/node": "^4.3.0",
     "@trapezedev/project": "^7.1.4",
-    "akanjs": "2.3.11-rc.8",
+    "akanjs": "2.3.11-rc.9",
     "chalk": "^5.6.2",
     "commander": "^14.0.3",
     "daisyui": "5.5.23",

package/qualityScanner.ts

@@ -112,6 +112,7 @@ export class AkanQualityScanner {
     const warnings = [
       ...this.#scanGlobalQuality(sourceFiles),
       ...sourceFiles.flatMap((sourceFile) => this.#scanSingleFileQuality(sourceFile)),
+      ...sourceFiles.flatMap((sourceFile) => this.#scanComponentQuality(sourceFile)),
       ...sourceFiles.flatMap((sourceFile) => this.#scanConventionQuality(sourceFile)),
       ...sourceFiles.flatMap((sourceFile) => this.#scanLayoutQuality(sourceFile)),
     ];
@@ -256,6 +257,26 @@ export class AkanQualityScanner {
     return warnings;
   }
 
+  #scanComponentQuality(sourceFile: SourceFileInfo): QualityWarning[] {
+    if (!isComponentDeclarationFile(sourceFile.file)) return [];
+    const exportedNames = getExportedDeclarationNames(sourceFile.sourceFile);
+    const allowedInternalInterfaces = new Set([...exportedNames].map((name) => `${name}Props`));
+    const warnings: QualityWarning[] = [];
+    for (const declaration of getInternalTypeOrFunctionDeclarations(sourceFile.sourceFile)) {
+      if (exportedNames.has(declaration.name)) continue;
+      if (declaration.kind === "interface" && allowedInternalInterfaces.has(declaration.name)) continue;
+      warnings.push({
+        rule: "akan.file.component-internal-declaration",
+        scope: "file",
+        severity: "warning",
+        file: sourceFile.file,
+        line: declaration.line,
+        message: `Component file should not declare non-exported ${declaration.kind} "${declaration.name}". Only a "<Component>Props" interface may stay internal; move other types or helpers to a separate file in ui/, webkit/, or common/ by purpose.`,
+      });
+    }
+    return warnings;
+  }
+
   #scanConventionQuality(sourceFile: SourceFileInfo): QualityWarning[] {
     const suffix = CONVENTION_SUFFIXES.find((candidate) => sourceFile.file.endsWith(candidate));
     if (!suffix) return [];
@@ -347,7 +368,9 @@ function formatQualityLocation(file: string | undefined, line: number | undefine
 
 function getExportedFunctionLikes(sourceFile: SourceFileInfo): ExportedFunctionLike[] {
   const declarations: ExportedFunctionLike[] = [];
-  const pageExempt = isPageRouteFile(sourceFile.file);
+  // UI component names (e.g. Card, Button) naturally repeat across apps/libs, so exempt ui files from the
+  // duplicate-exported-name check. This only relaxes the name check; the shared-body check still applies.
+  const nameExempt = isPageRouteFile(sourceFile.file) || isUiComponentFile(sourceFile.file);
   for (const statement of sourceFile.sourceFile.statements) {
     if (ts.isFunctionDeclaration(statement) && statement.name && isExported(statement)) {
       declarations.push({
@@ -356,7 +379,7 @@ function getExportedFunctionLikes(sourceFile: SourceFileInfo): ExportedFunctionL
         file: sourceFile.file,
         line: getLine(sourceFile.sourceFile, statement),
         bodyFingerprint: getBodyFingerprint(sourceFile.sourceFile, statement.body),
-        duplicateNameExempt: pageExempt || isConventionDuplicateNameExempt(sourceFile.file, false),
+        duplicateNameExempt: nameExempt || isConventionDuplicateNameExempt(sourceFile.file, false),
       });
     }
     if (ts.isClassDeclaration(statement) && statement.name && isExported(statement)) {
@@ -367,7 +390,7 @@ function getExportedFunctionLikes(sourceFile: SourceFileInfo): ExportedFunctionL
         line: getLine(sourceFile.sourceFile, statement),
         bodyFingerprint: getBodyFingerprint(sourceFile.sourceFile, statement),
         duplicateNameExempt:
-          pageExempt ||
+          nameExempt ||
           isConventionDuplicateNameExempt(sourceFile.file, isEnumClassStatement(sourceFile.sourceFile, statement)),
       });
     }
@@ -380,7 +403,7 @@ function getExportedFunctionLikes(sourceFile: SourceFileInfo): ExportedFunctionL
           file: sourceFile.file,
           line: getLine(sourceFile.sourceFile, declaration),
           bodyFingerprint: getBodyFingerprint(sourceFile.sourceFile, declaration.initializer),
-          duplicateNameExempt: pageExempt || isConventionDuplicateNameExempt(sourceFile.file, false),
+          duplicateNameExempt: nameExempt || isConventionDuplicateNameExempt(sourceFile.file, false),
         });
       }
     }
@@ -393,6 +416,11 @@ function isPageRouteFile(file: string) {
   return (segments[0] === "apps" || segments[0] === "libs") && segments[2] === "page";
 }
 
+function isUiComponentFile(file: string) {
+  const segments = file.split("/");
+  return (segments[0] === "apps" || segments[0] === "libs") && segments[2] === "ui";
+}
+
 function isConventionDuplicateNameExempt(file: string, isEnumClass: boolean) {
   if (!isInLibModule(file)) return false;
   if (file.endsWith(".tsx")) return true;
@@ -427,6 +455,65 @@ function getExportedClassNames(sourceFile: ts.SourceFile) {
     .map((statement) => statement.name!.text);
 }
 
+function isComponentDeclarationFile(file: string) {
+  if (!file.endsWith(".tsx")) return false;
+  const segments = file.split("/");
+  const [root, , area] = segments;
+  if (root !== "apps" && root !== "libs") return false;
+  if (area === "lib" || area === "ui") return true;
+  return root === "apps" && area === "page";
+}
+
+function getExportedDeclarationNames(sourceFile: ts.SourceFile) {
+  const names = new Set<string>();
+  for (const statement of sourceFile.statements) {
+    if (ts.isExportDeclaration(statement) && statement.exportClause && ts.isNamedExports(statement.exportClause)) {
+      for (const element of statement.exportClause.elements) {
+        names.add(element.name.text);
+        if (element.propertyName) names.add(element.propertyName.text);
+      }
+      continue;
+    }
+    if (!isExported(statement)) continue;
+    for (const name of getStatementDeclarationNames(statement)) names.add(name);
+  }
+  return names;
+}
+
+function getStatementDeclarationNames(statement: ts.Statement): string[] {
+  if (ts.isFunctionDeclaration(statement) && statement.name) return [statement.name.text];
+  if (ts.isClassDeclaration(statement) && statement.name) return [statement.name.text];
+  if (ts.isInterfaceDeclaration(statement)) return [statement.name.text];
+  if (ts.isTypeAliasDeclaration(statement)) return [statement.name.text];
+  if (ts.isEnumDeclaration(statement)) return [statement.name.text];
+  if (ts.isVariableStatement(statement)) {
+    return statement.declarationList.declarations
+      .filter((declaration) => ts.isIdentifier(declaration.name))
+      .map((declaration) => (declaration.name as ts.Identifier).text);
+  }
+  return [];
+}
+
+function getInternalTypeOrFunctionDeclarations(sourceFile: ts.SourceFile) {
+  const declarations: Array<{ name: string; kind: "interface" | "type" | "function"; line: number }> = [];
+  for (const statement of sourceFile.statements) {
+    if (isExported(statement)) continue;
+    if (ts.isInterfaceDeclaration(statement)) {
+      declarations.push({ name: statement.name.text, kind: "interface", line: getLine(sourceFile, statement) });
+    } else if (ts.isTypeAliasDeclaration(statement)) {
+      declarations.push({ name: statement.name.text, kind: "type", line: getLine(sourceFile, statement) });
+    } else if (ts.isFunctionDeclaration(statement) && statement.name) {
+      declarations.push({ name: statement.name.text, kind: "function", line: getLine(sourceFile, statement) });
+    } else if (ts.isVariableStatement(statement)) {
+      for (const declaration of statement.declarationList.declarations) {
+        if (!ts.isIdentifier(declaration.name) || !isFunctionLikeInitializer(declaration.initializer)) continue;
+        declarations.push({ name: declaration.name.text, kind: "function", line: getLine(sourceFile, declaration) });
+      }
+    }
+  }
+  return declarations;
+}
+
 function getPlaceholderExportWarnings(sourceFile: SourceFileInfo): QualityWarning[] {
   if (!sourceFile.file.endsWith("/index.ts") && !sourceFile.file.endsWith("/index.tsx")) return [];
   return getTopLevelDeclarations(sourceFile)