@akagilnc/pi-workflow-roles 0.1.5918 → 0.1.5926

package/README.md

@@ -140,10 +140,10 @@ ak-role --model <provider/model[:thinking]> resume <runId> "<ruling>"
 
 ## Tests
 
-During the [ADR 0090](docs/adr/0090-tests-run-on-vitest-fixtures-and-helpers-from-the-platform.md) expand phase, `pnpm run test:vitest` runs the migrated examples from all three projects; CI runs it alongside the unchanged `test:all`. For a focused run:
+During the [ADR 0090](docs/adr/0090-tests-run-on-vitest-fixtures-and-helpers-from-the-platform.md) migration, `pnpm test` runs all unit/contract tests (including root-level tests) with Vitest. `test:vitest` also runs the migrated factory-board timer tests and the integration/package expand examples. `test:all` runs these first, then the remaining Node tests; CI retains both entries until migration closes. `test:integration` uses the same Vitest batch, including the package expand example, followed by the remaining integration tests. For a focused run:
 
 ```bash
-pnpm exec vitest run --project unit test/unit/package-home-seam.test.ts
+pnpm exec vitest run --project unit-contract
 pnpm exec vitest run --project integration test/integration/public-cli-bin-startup.test.ts
 pnpm exec vitest run --project package test/package/published-dist-import-closure.test.ts
 ```

package/dist/acp-host/production-host.js

@@ -22648,7 +22648,7 @@ async function executeActivationStage(role, stage, infrastructure) {
         role,
         stageId: stage.id,
         status: "failed",
-        timestamp: infrastructure.clock(),
+        timestamp: (/* @__PURE__ */ new Date()).toISOString(),
         cause: namedActivationCause(activationError)
       });
     } catch (traceError) {
@@ -23459,7 +23459,6 @@ function createRoleRuntimeExtension(dependencies, deliveryRequestLimit) {
         activeCollector = await collectorBusiness.activate(context);
       }
     };
-    const clock = dependencies.activationClock ?? (() => (/* @__PURE__ */ new Date()).toISOString());
     const writeTrace = dependencies.activationTraceWriter ?? writeActivationTraceRecord;
     roleHost.on("session_start", async (event, ctx) => {
       admitted = false;
@@ -23566,7 +23565,7 @@ function createRoleRuntimeExtension(dependencies, deliveryRequestLimit) {
           });
           navigatorAttendance.prepare();
         }
-        await executeActivationStage(entry.role, activationStage(entry.role, activateByRole), { clock, writeTrace });
+        await executeActivationStage(entry.role, activationStage(entry.role, activateByRole), { writeTrace });
         registerReportTicketTool(roleHost, hostActions);
         roleHost.setActiveTools([
           .../* @__PURE__ */ new Set([...roleHost.getActiveTools(), REPORT_TICKET_TOOL_NAME])

package/dist/factory-board.js

@@ -1360,13 +1360,6 @@ export async function writeFactoryBoardPage(input) {
     const outputPath = await writePageOutsideLedgers(gate.ledgerRoots, gate.outputAbsolute, html, BOARD_OUTPUT_REFUSAL);
     return { outputPath, html };
 }
-const defaultBoardScheduler = {
-    every(ms, tick) {
-        const timer = setInterval(tick, ms);
-        timer.unref?.();
-        return () => clearInterval(timer);
-    },
-};
 /**
  * Production board lifecycle: write immediately, then regenerate on the declared
  * refresh boundary so the same viewing surface observes new runs / generated-at.
@@ -1382,8 +1375,6 @@ export function startFactoryBoardPage(input) {
     if (input.view === undefined && input.loadView === undefined) {
         throw new Error("view or loadView is required");
     }
-    const clock = input.clock ?? (() => new Date());
-    const scheduler = input.scheduler ?? defaultBoardScheduler;
     let stopped = false;
     let cancel;
     let inFlight;
@@ -1424,7 +1415,7 @@ export function startFactoryBoardPage(input) {
         return writeFactoryBoardPage({
             books: input.books,
             view,
-            now: clock(),
+            now: new Date(),
             outputPath: input.outputPath,
             refreshBoundarySeconds,
         });
@@ -1448,9 +1439,9 @@ export function startFactoryBoardPage(input) {
         if (stopped || lastRejection !== undefined)
             return first;
         const intervalMs = Math.max(1, Math.round(refreshBoundarySeconds * 1000));
-        cancel = scheduler.every(intervalMs, () => {
-            queueWrite();
-        });
+        const timer = setInterval(queueWrite, intervalMs);
+        timer.unref?.();
+        cancel = () => clearInterval(timer);
         return first;
     })
         .catch((error) => {

package/dist/headless-host/production-host.js

@@ -22615,7 +22615,7 @@ async function executeActivationStage(role, stage, infrastructure) {
         role,
         stageId: stage.id,
         status: "failed",
-        timestamp: infrastructure.clock(),
+        timestamp: (/* @__PURE__ */ new Date()).toISOString(),
         cause: namedActivationCause(activationError)
       });
     } catch (traceError) {
@@ -23426,7 +23426,6 @@ function createRoleRuntimeExtension(dependencies, deliveryRequestLimit) {
         activeCollector = await collectorBusiness.activate(context);
       }
     };
-    const clock = dependencies.activationClock ?? (() => (/* @__PURE__ */ new Date()).toISOString());
     const writeTrace = dependencies.activationTraceWriter ?? writeActivationTraceRecord;
     roleHost.on("session_start", async (event, ctx) => {
       admitted = false;
@@ -23533,7 +23532,7 @@ function createRoleRuntimeExtension(dependencies, deliveryRequestLimit) {
           });
           navigatorAttendance.prepare();
         }
-        await executeActivationStage(entry.role, activationStage(entry.role, activateByRole), { clock, writeTrace });
+        await executeActivationStage(entry.role, activationStage(entry.role, activateByRole), { writeTrace });
         registerReportTicketTool(roleHost, hostActions);
         roleHost.setActiveTools([
           .../* @__PURE__ */ new Set([...roleHost.getActiveTools(), REPORT_TICKET_TOOL_NAME])

package/dist/oauth-keepalive.js

@@ -44,14 +44,6 @@ export function readOAuthKeepaliveProviders(path = oauthKeepaliveSettingPath())
         throw error;
     }
 }
-const defaultScheduler = {
-    every(ms, tick) {
-        const timer = setInterval(tick, ms);
-        // Allow the process to exit if a caller forgets stop (same discipline as trajectory).
-        timer.unref?.();
-        return () => clearInterval(timer);
-    },
-};
 function errorClassName(error) {
     if (error instanceof Error && error.name.trim() !== "")
         return error.name;
@@ -92,7 +84,6 @@ function emitWarning(ctx, providerId, error) {
 export function createOAuthKeepalive(options = {}) {
     const providers = Object.freeze((options.providers ?? DEFAULT_OAUTH_KEEPALIVE_PROVIDERS).map((id) => id));
     const intervalMs = options.intervalMs ?? OAUTH_KEEPALIVE_INTERVAL_MS;
-    const scheduler = options.scheduler ?? defaultScheduler;
     let cancel;
     let abortController;
     /** Bare single-flight gate; survives stop/start until the in-flight call settles. */
@@ -140,9 +131,9 @@ export function createOAuthKeepalive(options = {}) {
             // Reload / re-start: tear down any prior interval before hanging a new one.
             stop();
             abortController = new AbortController();
-            cancel = scheduler.every(intervalMs, () => {
-                void runTick(ctx);
-            });
+            const timer = setInterval(() => { void runTick(ctx); }, intervalMs);
+            timer.unref?.();
+            cancel = () => clearInterval(timer);
         },
         stop,
     };

package/dist/role-runtime.js

@@ -211,7 +211,7 @@ async function executeActivationStage(role, stage, infrastructure) {
                 role,
                 stageId: stage.id,
                 status: "failed",
-                timestamp: infrastructure.clock(),
+                timestamp: new Date().toISOString(),
                 cause: namedActivationCause(activationError),
             });
         }
@@ -1141,7 +1141,6 @@ deliveryRequestLimit) {
                 activeCollector = await collectorBusiness.activate(context);
             },
         };
-        const clock = dependencies.activationClock ?? (() => new Date().toISOString());
         const writeTrace = dependencies.activationTraceWriter ?? writeActivationTraceRecord;
         roleHost.on("session_start", async (event, ctx) => {
             admitted = false;
@@ -1267,7 +1266,7 @@ deliveryRequestLimit) {
                     // The lookup starts with the parent role (#1160 / #1192).
                     navigatorAttendance.prepare();
                 }
-                await executeActivationStage(entry.role, activationStage(entry.role, activateByRole), { clock, writeTrace });
+                await executeActivationStage(entry.role, activationStage(entry.role, activateByRole), { writeTrace });
                 // #1171: same registration mouth as submission tools; when-to-call is on the tool itself.
                 registerReportTicketTool(roleHost, hostActions);
                 roleHost.setActiveTools([

package/dist/ticket-trajectory.js

@@ -726,14 +726,6 @@ export async function writeTicketTrajectoryPage(input) {
     const outputPath = await writePageOutsideLedgers([gate.ledgerRoot], gate.outputAbsolute, html, TRAJECTORY_OUTPUT_REFUSAL);
     return { outputPath, html };
 }
-const defaultScheduler = {
-    every(ms, tick) {
-        const timer = setInterval(tick, ms);
-        // Allow the process to exit naturally if the caller forgets stop in scripts.
-        timer.unref?.();
-        return () => clearInterval(timer);
-    },
-};
 /**
  * Production page lifecycle: write immediately, then regenerate on the declared
  * refresh boundary so the same viewing surface observes new runs / generated-at.
@@ -745,8 +737,6 @@ export function startTicketTrajectoryPage(input) {
     if (!(refreshBoundarySeconds > 0) || !Number.isFinite(refreshBoundarySeconds)) {
         throw new Error("refreshBoundarySeconds must be a positive finite number");
     }
-    const clock = input.clock ?? (() => new Date());
-    const scheduler = input.scheduler ?? defaultScheduler;
     let stopped = false;
     let cancel;
     let inFlight;
@@ -787,7 +777,7 @@ export function startTicketTrajectoryPage(input) {
         return writeTicketTrajectoryPage({
             ledgerDir: input.ledgerDir,
             ticketSnapshot: input.ticketSnapshot,
-            now: clock(),
+            now: new Date(),
             outputPath: input.outputPath,
             refreshBoundarySeconds,
         });
@@ -811,9 +801,9 @@ export function startTicketTrajectoryPage(input) {
         if (stopped || lastRejection !== undefined)
             return first;
         const intervalMs = Math.max(1, Math.round(refreshBoundarySeconds * 1000));
-        cancel = scheduler.every(intervalMs, () => {
-            queueWrite();
-        });
+        const timer = setInterval(queueWrite, intervalMs);
+        timer.unref?.();
+        cancel = () => clearInterval(timer);
         return first;
     })
         .catch((error) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@akagilnc/pi-workflow-roles",
-  "version": "0.1.5918",
+  "version": "0.1.5926",
   "description": "Soul-bound workflow roles for Pi",
   "type": "module",
   "license": "Apache-2.0",
@@ -44,11 +44,11 @@
   "scripts": {
     "build": "node -e \"require('node:fs').rmSync('dist', { recursive: true, force: true })\" && tsc -p tsconfig.build.json && node scripts/build-package.mjs",
     "prepack": "npm run build",
-    "test": "node --import tsx --import ./scripts/test-process-env-preload.mjs --test-reporter=dot --test-reporter-destination=stdout --test-reporter=spec --test-reporter-destination=node-test-report.txt --test test/unit/**/*.test.ts test/contract/**/*.test.ts",
-    "test:fast": "node --import tsx --import ./scripts/test-process-env-preload.mjs --test-timeout=300000 --test-reporter=dot --test-reporter-destination=stdout --test-reporter=spec --test-reporter-destination=node-test-report.txt --test test/unit/**/*.test.ts test/contract/**/*.test.ts",
-    "test:integration": "node --import tsx --import ./scripts/test-process-env-preload.mjs --test-reporter=dot --test-reporter-destination=stdout --test-reporter=spec --test-reporter-destination=node-test-report.txt --test test/unit/**/*.test.ts test/contract/**/*.test.ts test/integration/**/*.test.ts",
-    "test:all": "node scripts/run-test-all.mjs",
-    "test:vitest": "vitest run test/unit/package-home-seam.test.ts test/integration/public-cli-bin-startup.test.ts test/package/published-dist-import-closure.test.ts",
+    "test": "vitest run --project unit-contract",
+    "test:fast": "pnpm test",
+    "test:integration": "pnpm run test:vitest && node scripts/run-test-all.mjs integration",
+    "test:all": "pnpm run test:vitest && node scripts/run-test-all.mjs",
+    "test:vitest": "vitest run test/unit/ test/contract/ test/primary-aware-cleanup.test.ts test/integration/factory-board.test.ts test/integration/public-cli-bin-startup.test.ts test/integration/test-user-profile-preload.test.ts test/package/published-dist-import-closure.test.ts",
     "test:adjudication": "node --import tsx --import ./scripts/test-process-env-preload.mjs --test-reporter=dot --test-reporter-destination=stdout --test-reporter=spec --test-reporter-destination=node-test-report.txt --test test/adjudication/**/*.test.ts",
     "typecheck": "tsc --noEmit",
     "migrate:book-topology": "node dist/migrate-book-topology.js"
@@ -80,6 +80,7 @@
     "@earendil-works/pi-coding-agent": "latest",
     "@types/node": "latest",
     "esbuild": "^0.28.1",
+    "execa": "^10.2.0",
     "tsx": "latest",
     "typescript": "latest",
     "vitest": "^5.0.5"

package/src/factory-board.ts

@@ -35,8 +35,6 @@ import {
   renderTicketTrajectoryStationHtml,
   type TicketTrajectoryBookIndex,
   type TicketTrajectoryRun,
-  type TrajectoryClock,
-  type TrajectoryScheduler,
   type UnboundTrajectoryRun,
 } from "./ticket-trajectory.ts";
 import type { BoardSnapshot, SnapshotTicket, TicketIssueState } from "./ticket-snapshot.ts";
@@ -50,10 +48,6 @@ export const UNACCEPTED_WATCH_MS = 15 * 60 * 1000;
 /** Same declared refresh bound as the S1 trajectory surface (seconds). */
 export { DEFAULT_REFRESH_BOUNDARY_SECONDS };
 
-/** Injected clock + scheduler for the production board lifecycle. */
-export type FactoryBoardClock = TrajectoryClock;
-export type FactoryBoardScheduler = TrajectoryScheduler;
-
 export type FactoryBoardPageHandle = {
   readonly outputPath: string;
   /** Settles when the first page write finishes (or rejects on first failure). */
@@ -1680,14 +1674,6 @@ export async function writeFactoryBoardPage(input: {
   return { outputPath, html };
 }
 
-const defaultBoardScheduler: FactoryBoardScheduler = {
-  every(ms, tick) {
-    const timer = setInterval(tick, ms);
-    timer.unref?.();
-    return () => clearInterval(timer);
-  },
-};
-
 /**
  * Production board lifecycle: write immediately, then regenerate on the declared
  * refresh boundary so the same viewing surface observes new runs / generated-at.
@@ -1706,8 +1692,6 @@ export function startFactoryBoardPage(input: {
   loadView?: () => Promise<FactoryBoardView>;
   outputPath: string;
   refreshBoundarySeconds?: number;
-  clock?: FactoryBoardClock;
-  scheduler?: FactoryBoardScheduler;
 }): FactoryBoardPageHandle {
   const refreshBoundarySeconds = input.refreshBoundarySeconds ?? DEFAULT_REFRESH_BOUNDARY_SECONDS;
   if (!(refreshBoundarySeconds > 0) || !Number.isFinite(refreshBoundarySeconds)) {
@@ -1716,8 +1700,6 @@ export function startFactoryBoardPage(input: {
   if (input.view === undefined && input.loadView === undefined) {
     throw new Error("view or loadView is required");
   }
-  const clock = input.clock ?? (() => new Date());
-  const scheduler = input.scheduler ?? defaultBoardScheduler;
 
   let stopped = false;
   let cancel: (() => void) | undefined;
@@ -1759,7 +1741,7 @@ export function startFactoryBoardPage(input: {
     return writeFactoryBoardPage({
       books: input.books,
       view,
-      now: clock(),
+      now: new Date(),
       outputPath: input.outputPath,
       refreshBoundarySeconds,
     });
@@ -1781,9 +1763,9 @@ export function startFactoryBoardPage(input: {
     .then((first) => {
       if (stopped || lastRejection !== undefined) return first;
       const intervalMs = Math.max(1, Math.round(refreshBoundarySeconds * 1000));
-      cancel = scheduler.every(intervalMs, () => {
-        queueWrite();
-      });
+      const timer = setInterval(queueWrite, intervalMs);
+      timer.unref?.();
+      cancel = () => clearInterval(timer);
       return first;
     })
     .catch((error) => {

package/src/oauth-keepalive.ts

@@ -59,19 +59,11 @@ export function readOAuthKeepaliveProviders(
   }
 }
 
-/** Injected interval scheduler (same shape as TrajectoryScheduler). */
-export type OAuthKeepaliveScheduler = {
-  /** Schedule `tick` every `ms` milliseconds; return a cancel function. */
-  every: (ms: number, tick: () => void) => () => void;
-};
-
 export type OAuthKeepaliveOptions = {
   /** Static provider id list; frozen at construction. Default: ["kimi-coding"]. */
   providers?: readonly string[];
   /** Interval between ticks in ms. Default: 60_000. First tick is after one interval. */
   intervalMs?: number;
-  /** Injectable scheduler for tests. Default: setInterval + unref. */
-  scheduler?: OAuthKeepaliveScheduler;
 };
 
 /** Minimal context surface used by keepalive (public extension facade only). */
@@ -97,15 +89,6 @@ export type OAuthKeepalive = {
   stop(): void;
 };
 
-const defaultScheduler: OAuthKeepaliveScheduler = {
-  every(ms, tick) {
-    const timer = setInterval(tick, ms);
-    // Allow the process to exit if a caller forgets stop (same discipline as trajectory).
-    timer.unref?.();
-    return () => clearInterval(timer);
-  },
-};
-
 function errorClassName(error: unknown): string {
   if (error instanceof Error && error.name.trim() !== "") return error.name;
   if (error !== null && typeof error === "object" && "name" in error) {
@@ -148,8 +131,6 @@ export function createOAuthKeepalive(options: OAuthKeepaliveOptions = {}): OAuth
     (options.providers ?? DEFAULT_OAUTH_KEEPALIVE_PROVIDERS).map((id) => id),
   ) as readonly string[];
   const intervalMs = options.intervalMs ?? OAUTH_KEEPALIVE_INTERVAL_MS;
-  const scheduler = options.scheduler ?? defaultScheduler;
-
   let cancel: (() => void) | undefined;
   let abortController: AbortController | undefined;
   /** Bare single-flight gate; survives stop/start until the in-flight call settles. */
@@ -194,9 +175,9 @@ export function createOAuthKeepalive(options: OAuthKeepaliveOptions = {}): OAuth
       // Reload / re-start: tear down any prior interval before hanging a new one.
       stop();
       abortController = new AbortController();
-      cancel = scheduler.every(intervalMs, () => {
-        void runTick(ctx);
-      });
+      const timer = setInterval(() => { void runTick(ctx); }, intervalMs);
+      timer.unref?.();
+      cancel = () => clearInterval(timer);
     },
     stop,
   };

package/src/role-runtime.ts

@@ -405,7 +405,7 @@ async function emitActivationTrace(
 async function executeActivationStage(
   role: string,
   stage: { id: string; run(): Promise<void> },
-  infrastructure: { clock(): string; writeTrace(record: ActivationTraceRecord): void | Promise<void> },
+  infrastructure: { writeTrace(record: ActivationTraceRecord): void | Promise<void> },
 ): Promise<void> {
   try {
     await stage.run();
@@ -415,7 +415,7 @@ async function executeActivationStage(
         role,
         stageId: stage.id,
         status: "failed",
-        timestamp: infrastructure.clock(),
+        timestamp: new Date().toISOString(),
         cause: namedActivationCause(activationError),
       });
     } catch (traceError) {
@@ -469,7 +469,6 @@ export type RoleRuntimeDependencies = {
   loadDoctorCase?(path: string): Promise<import("./doctor-contracts.ts").DoctorCase>;
   loadMergerInput?(path: string): Promise<unknown>;
   createNavigatorAttendance?(options: { context: HostContext; role: string; phase: NavigatorPhase; subjectKey: string; invocationId: string; onEvent: NavigatorAttendanceOptions["onEvent"] }): NavigatorAttendanceDependency | Promise<NavigatorAttendanceDependency>;
-  activationClock?(): string;
   activationTraceWriter?: (record: ActivationTraceRecord) => void | Promise<void>;
 };
 
@@ -1499,7 +1498,6 @@ export function createRoleRuntimeExtension(
       },
     };
 
-    const clock = dependencies.activationClock ?? (() => new Date().toISOString());
     const writeTrace = dependencies.activationTraceWriter ?? writeActivationTraceRecord;
 
     roleHost.on("session_start", async (event, ctx) => {
@@ -1631,7 +1629,7 @@ export function createRoleRuntimeExtension(
           navigatorAttendance.prepare();
         }
 
-        await executeActivationStage(entry.role, activationStage(entry.role, activateByRole), { clock, writeTrace });
+        await executeActivationStage(entry.role, activationStage(entry.role, activateByRole), { writeTrace });
         // #1171: same registration mouth as submission tools; when-to-call is on the tool itself.
         registerReportTicketTool(roleHost, hostActions);
         roleHost.setActiveTools([

package/src/ticket-trajectory.ts

@@ -66,13 +66,6 @@ export type TicketSnapshot = {
 
 export type StationSource = "tool" | "invocation" | "name" | "unknown";
 
-/** Injected clock + scheduler so tests drive the production lifecycle without wall sleep. */
-export type TrajectoryClock = () => Date;
-export type TrajectoryScheduler = {
-  /** Schedule `tick` every `ms` milliseconds; return a cancel function. */
-  every: (ms: number, tick: () => void) => () => void;
-};
-
 export type TicketTrajectoryPageHandle = {
   readonly outputPath: string;
   /** Settles when the first page write finishes (or rejects on first failure). */
@@ -937,15 +930,6 @@ export async function writeTicketTrajectoryPage(input: {
   return { outputPath, html };
 }
 
-const defaultScheduler: TrajectoryScheduler = {
-  every(ms, tick) {
-    const timer = setInterval(tick, ms);
-    // Allow the process to exit naturally if the caller forgets stop in scripts.
-    timer.unref?.();
-    return () => clearInterval(timer);
-  },
-};
-
 /**
  * Production page lifecycle: write immediately, then regenerate on the declared
  * refresh boundary so the same viewing surface observes new runs / generated-at.
@@ -957,15 +941,11 @@ export function startTicketTrajectoryPage(input: {
   ticketSnapshot: TicketSnapshot;
   outputPath: string;
   refreshBoundarySeconds?: number;
-  clock?: TrajectoryClock;
-  scheduler?: TrajectoryScheduler;
 }): TicketTrajectoryPageHandle {
   const refreshBoundarySeconds = input.refreshBoundarySeconds ?? DEFAULT_REFRESH_BOUNDARY_SECONDS;
   if (!(refreshBoundarySeconds > 0) || !Number.isFinite(refreshBoundarySeconds)) {
     throw new Error("refreshBoundarySeconds must be a positive finite number");
   }
-  const clock = input.clock ?? (() => new Date());
-  const scheduler = input.scheduler ?? defaultScheduler;
 
   let stopped = false;
   let cancel: (() => void) | undefined;
@@ -1007,7 +987,7 @@ export function startTicketTrajectoryPage(input: {
     return writeTicketTrajectoryPage({
       ledgerDir: input.ledgerDir,
       ticketSnapshot: input.ticketSnapshot,
-      now: clock(),
+      now: new Date(),
       outputPath: input.outputPath,
       refreshBoundarySeconds,
     });
@@ -1029,9 +1009,9 @@ export function startTicketTrajectoryPage(input: {
     .then((first) => {
       if (stopped || lastRejection !== undefined) return first;
       const intervalMs = Math.max(1, Math.round(refreshBoundarySeconds * 1000));
-      cancel = scheduler.every(intervalMs, () => {
-        queueWrite();
-      });
+      const timer = setInterval(queueWrite, intervalMs);
+      timer.unref?.();
+      cancel = () => clearInterval(timer);
       return first;
     })
     .catch((error) => {