@akagilnc/pi-workflow-roles 0.1.5357 → 0.1.5368

package/src/reviewer-role.ts

@@ -1,6 +1,6 @@
 import type { RoleHost, HostContext, HostToolResult } from "./host-contracts.ts";
 import { Type } from "typebox";
-import { openToolObjectFromUnion } from "./open-tool-schema.ts";
+import { openToolObject } from "./open-tool-schema.ts";
 import { withTerminatingOutputDeclarations } from "./package-contracts/terminating-infrastructure.ts";
 
 import { REVIEWER_OUTPUT_TOOL_NAME, type ReviewerIntent } from "./package-contracts/reviewer-output.ts";
@@ -17,43 +17,24 @@ export type ReviewerAdmittedInputs = Readonly<{
   ticketNumber?: number;
 }>;
 
-const reviewerAmendmentsSchema = Type.Object({
-  completeness: Type.Optional(Type.String({
-    description:
-      "completeness lens 完整报告：candidates、逐条处置与 verdict；非仅 verdict 一行。hard-stop／usage error 为 refused 时，若已产出报告仍照录于此",
-  })),
-  correctness: Type.Optional(Type.String({
-    description:
-      "correctness lens 完整报告：candidates、逐条处置与 verdict；非仅 verdict 一行。hard-stop／usage error 为 refused 时，若已产出报告仍照录于此",
-  })),
-}, {
-  additionalProperties: true,
-  description:
-    "已运行 lens 的 amendments 承载 candidates、逐条处置与 verdict 的完整报告（非仅 verdict 行）；显式单轴时另一轴可省略。hard-stop／usage error 为 refused 时，已产出报告仍照录对应 lens 字段。",
-});
-// #836 r16 class 1: diagnostic is LLM/human-read narrative content — no code
-// branches on its length (src/reviewer-role.ts consumer: reviewer content is
-// returned as submitted, ADR 0057).
-// #836 (ADR 0003 Amendment): status kept open like countersignStatus
-// (src/countersign-role.ts) — one shared description across both variants
-// so openToolObjectFromUnion's identical-declaration collapse drops none of it.
-// #917 §6: both normal lens verdicts → completed; hard-stop/usage error → refused
-// (report already produced still lands in selected-lens amendments).
+const REVIEWER_AMENDMENTS_DESCRIPTION =
+  "已运行 lens 的 amendments 承载 candidates、逐条处置与 verdict 的完整报告（非仅 verdict 行）；显式单轴时另一轴可省略（completeness / correctness）。hard-stop／usage error 为 refused 时，已产出报告仍照录对应 lens 字段。" as const;
+// #1134: `status` alone is the trajectory field (#917 §6 two normal lens verdicts →
+// completed; hard-stop / usage error → refused); its words ride the description.
+// amendments/diagnostic are LLM/human-read narrative content returned as
+// submitted — declaration keeps name + semantic description only, no nested
+// object shape, no string type, no required constraint.
 const REVIEWER_STATUS_DESCRIPTION =
   "completed | refused。两种正常 lens verdict（completeness / correctness）均 completed；hard-stop 与 usage error 为 refused（已产出报告仍照录进所选 lens amendments）。" as const;
-const reviewerOutputVariants = Type.Union([
-  Type.Object({
-    status: Type.Unknown({ description: REVIEWER_STATUS_DESCRIPTION }),
-    amendments: Type.Optional(reviewerAmendmentsSchema),
-  }, { additionalProperties: false }),
-  Type.Object({
-    status: Type.Unknown({ description: REVIEWER_STATUS_DESCRIPTION }),
-    diagnostic: Type.String({ description: "拒绝诊断说明；hard-stop／usage error 原因进此字段，已产出报告另照录 amendments" }),
-    amendments: Type.Optional(reviewerAmendmentsSchema),
-  }, { additionalProperties: false }),
-]);
+const reviewerOutputObject = Type.Object({
+  status: Type.Unknown({ description: REVIEWER_STATUS_DESCRIPTION }),
+  amendments: Type.Unknown({ description: REVIEWER_AMENDMENTS_DESCRIPTION }),
+  diagnostic: Type.Unknown({
+    description: "拒绝诊断说明；hard-stop／usage error 原因进此字段，已产出报告另照录 amendments",
+  }),
+});
 export const reviewerOutputSchema = withTerminatingOutputDeclarations(
-  openToolObjectFromUnion(reviewerOutputVariants),
+  openToolObject(reviewerOutputObject),
 );
 export type ReviewerRoleDependencies = {
   loadSoul(): Promise<string>;

package/src/role-run-placement.ts

@@ -107,6 +107,11 @@ export function roleRunArtifactsDirectory(runDirectory: string): string {
   return join(runDirectory, "artifacts");
 }
 
+/** Canonical unbound placement: a run directory under `<book>/unbound/runs/`. */
+export function isUnboundRunDirectory(runDirectory: string): boolean {
+  return runDirectory.replaceAll("\\", "/").includes("/unbound/runs/");
+}
+
 /** The placement seam owns creation for both new runs and resumed legacy runs. */
 export function ensureRoleRunDirectory(
   ledgerHome: string,

package/src/secretariat-role.ts

@@ -12,7 +12,17 @@ import { SECRETARIAT_OUTPUT_TOOL_NAME, type SecretariatVerdict } from "./secreta
 export { SECRETARIAT_OUTPUT_TOOL_NAME } from "./secretariat-contracts.ts";
 export type { SecretariatVerdict };
 
-/** 中书省终局回执形状。 */
+/**
+ * 中书省终局回执形状。
+ * #1134: `secretariatStatus` alone is the trajectory field
+ * (src/packaged-role-registry.ts:406 receiptStatusKey; the public settlement reads
+ * converged | escalate to route); its words ride the description. note/evidence/
+ * decisionGate are declared name + semantic description only — the string type, the
+ * number type, the nested question/options object shape and the required constraint
+ * are deleted, because the package declaration IS the host's pre-dispatch validator.
+ * (ticketNumber keeps its own declaration: it is the declared seat identity the
+ * activation flag and settlement read, not narrative content.)
+ */
 export const secretariatVerdictSchema = withTerminatingOutputDeclarations(
   Type.Object(
     {
@@ -20,19 +30,13 @@ export const secretariatVerdictSchema = withTerminatingOutputDeclarations(
         description: "converged | escalate",
       }),
       ticketNumber: Type.Optional(
-        Type.Number({ description: "本票号；署时指向最终正文所在票" }),
+        Type.Unknown({ description: "本票号；署时指向最终正文所在票" }),
       ),
-      note: Type.Optional(Type.String({ description: "附注" })),
+      note: Type.Unknown({ description: "附注" }),
       evidence: Type.Optional(Type.Unknown({ description: "留存证据" })),
-      decisionGate: Type.Optional(
-        Type.Object(
-          {
-            question: Type.Optional(Type.String()),
-            options: Type.Optional(Type.Array(Type.String())),
-          },
-          { additionalProperties: true, description: "需陛下处置的问题与选项" },
-        ),
-      ),
+      decisionGate: Type.Unknown({
+        description: "需陛下处置的问题与选项；可写 question 与 options，原样留存。",
+      }),
     },
     { additionalProperties: true },
   ),

package/src/worker-role.ts

@@ -1,6 +1,6 @@
 import type { RoleHost, HostContext, HostToolResult, HostGatekeeperActions } from "./host-contracts.ts";
 import { Type, type Static } from "typebox";
-import { openToolObjectFromUnion } from "./open-tool-schema.ts";
+import { openToolObject } from "./open-tool-schema.ts";
 import { withTerminatingOutputDeclarations } from "./package-contracts/terminating-infrastructure.ts";
 
 import {
@@ -36,37 +36,22 @@ export {
 };
 export type { WorkerOutput };
 
-// #836 r16 class 1: report/remainingScope are LLM/human-read narrative content —
-// no code branches on their length. `reason` alone keeps minLength: the worker
-// gate reads `reason.trim().length > 0` to pick typed-reminder-bounce vs accept
-// (src/worker-submission-gates.ts:159-163,297-302).
-// Worker status is not the review three-state field (#1055): schema stays open.
-// One shared description across every variant
-// so openToolObjectFromUnion's identical-declaration collapse drops none of it.
+// status 的合法词写在 description。WORKER_DONE_STATUSES 只让 completed /
+// partially_completed 进入提交闸。unfinished 且未见理由说明时，运行时同 run 催全
+// （ADR 0050）；理由在不在不按 JSON 类型判，也不在派发前用长度拒收。
+// report / remainingScope / reason 的声明只留字段名和语义。
 const CODER_STATUS_DESCRIPTION =
   `planned | completed | refused | partially_completed | unfinished。unfinished：缺前置或违宪约束致本局未完成。${PARTIALLY_COMPLETED_DEFINITION}` as const;
-const coderOutputVariants = Type.Union([
-  Type.Object({
-    status: Type.Unknown({ description: CODER_STATUS_DESCRIPTION }),
-    report: Type.String({ description: "如实结果报告" }),
-  }, { additionalProperties: false }),
-  Type.Object({
-    status: Type.Unknown({ description: CODER_STATUS_DESCRIPTION }),
-    report: Type.String({ description: "如实结果报告" }),
-  }, { additionalProperties: false }),
-  Type.Object({
-    status: Type.Unknown({ description: CODER_STATUS_DESCRIPTION }),
-    report: Type.String({ description: "如实结果报告" }),
-    remainingScope: Type.String({ description: "本局后剩余工作" }),
-    reason: Type.Optional(Type.String({
-      minLength: 1,
-      description:
-        "阻断原因：缺前置或违宪约束。缺待决 owner 决定或答复属缺前置。",
-    })),
-  }, { additionalProperties: false }),
-]);
+const coderOutputObject = Type.Object({
+  status: Type.Unknown({ description: CODER_STATUS_DESCRIPTION }),
+  report: Type.Unknown({ description: "如实结果报告" }),
+  remainingScope: Type.Unknown({ description: "本局后剩余工作" }),
+  reason: Type.Unknown({
+    description: "阻断原因：缺前置或违宪约束。缺待决 owner 决定或答复属缺前置。",
+  }),
+});
 export const coderOutputSchema = withTerminatingOutputDeclarations(
-  openToolObjectFromUnion(coderOutputVariants),
+  openToolObject(coderOutputObject),
 );
 export type { FixerOutput, CoderOutput };
 export const FIXER_FLAG_DEFINITIONS = {

package/src/worker-submission-gates.ts

@@ -156,10 +156,21 @@ function isRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 
+/** ADR 0050: a written explanation, including text carried by an object key. */
+function containsWrittenReason(value: unknown): boolean {
+  if (typeof value === "string") return value.trim().length > 0;
+  if (Array.isArray(value)) return value.some(containsWrittenReason);
+  if (typeof value === "object" && value !== null) {
+    return Object.entries(value).some(
+      ([key, item]) => containsWrittenReason(key) || containsWrittenReason(item),
+    );
+  }
+  return false;
+}
+
 function unfinishedReasonPresent(details?: unknown): boolean {
-  if (typeof details !== "object" || details === null) return false;
-  const reason = (details as { reason?: unknown }).reason;
-  return typeof reason === "string" && reason.trim().length > 0;
+  if (typeof details !== "object" || details === null || Array.isArray(details)) return false;
+  return containsWrittenReason((details as { reason?: unknown }).reason);
 }
 
 function readGateState(session: HostRecordSession): {