@akagilnc/pi-workflow-roles 0.1.5357 → 0.1.5365

package/src/worker-role.ts

@@ -1,6 +1,6 @@
 import type { RoleHost, HostContext, HostToolResult, HostGatekeeperActions } from "./host-contracts.ts";
 import { Type, type Static } from "typebox";
-import { openToolObjectFromUnion } from "./open-tool-schema.ts";
+import { openToolObject } from "./open-tool-schema.ts";
 import { withTerminatingOutputDeclarations } from "./package-contracts/terminating-infrastructure.ts";
 
 import {
@@ -36,37 +36,22 @@ export {
 };
 export type { WorkerOutput };
 
-// #836 r16 class 1: report/remainingScope are LLM/human-read narrative content —
-// no code branches on their length. `reason` alone keeps minLength: the worker
-// gate reads `reason.trim().length > 0` to pick typed-reminder-bounce vs accept
-// (src/worker-submission-gates.ts:159-163,297-302).
-// Worker status is not the review three-state field (#1055): schema stays open.
-// One shared description across every variant
-// so openToolObjectFromUnion's identical-declaration collapse drops none of it.
+// status 的合法词写在 description。WORKER_DONE_STATUSES 只让 completed /
+// partially_completed 进入提交闸。unfinished 且未见理由说明时，运行时同 run 催全
+// （ADR 0050）；理由在不在不按 JSON 类型判，也不在派发前用长度拒收。
+// report / remainingScope / reason 的声明只留字段名和语义。
 const CODER_STATUS_DESCRIPTION =
   `planned | completed | refused | partially_completed | unfinished。unfinished：缺前置或违宪约束致本局未完成。${PARTIALLY_COMPLETED_DEFINITION}` as const;
-const coderOutputVariants = Type.Union([
-  Type.Object({
-    status: Type.Unknown({ description: CODER_STATUS_DESCRIPTION }),
-    report: Type.String({ description: "如实结果报告" }),
-  }, { additionalProperties: false }),
-  Type.Object({
-    status: Type.Unknown({ description: CODER_STATUS_DESCRIPTION }),
-    report: Type.String({ description: "如实结果报告" }),
-  }, { additionalProperties: false }),
-  Type.Object({
-    status: Type.Unknown({ description: CODER_STATUS_DESCRIPTION }),
-    report: Type.String({ description: "如实结果报告" }),
-    remainingScope: Type.String({ description: "本局后剩余工作" }),
-    reason: Type.Optional(Type.String({
-      minLength: 1,
-      description:
-        "阻断原因：缺前置或违宪约束。缺待决 owner 决定或答复属缺前置。",
-    })),
-  }, { additionalProperties: false }),
-]);
+const coderOutputObject = Type.Object({
+  status: Type.Unknown({ description: CODER_STATUS_DESCRIPTION }),
+  report: Type.Unknown({ description: "如实结果报告" }),
+  remainingScope: Type.Unknown({ description: "本局后剩余工作" }),
+  reason: Type.Unknown({
+    description: "阻断原因：缺前置或违宪约束。缺待决 owner 决定或答复属缺前置。",
+  }),
+});
 export const coderOutputSchema = withTerminatingOutputDeclarations(
-  openToolObjectFromUnion(coderOutputVariants),
+  openToolObject(coderOutputObject),
 );
 export type { FixerOutput, CoderOutput };
 export const FIXER_FLAG_DEFINITIONS = {

package/src/worker-submission-gates.ts

@@ -156,10 +156,21 @@ function isRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 
+/** ADR 0050: a written explanation, including text carried by an object key. */
+function containsWrittenReason(value: unknown): boolean {
+  if (typeof value === "string") return value.trim().length > 0;
+  if (Array.isArray(value)) return value.some(containsWrittenReason);
+  if (typeof value === "object" && value !== null) {
+    return Object.entries(value).some(
+      ([key, item]) => containsWrittenReason(key) || containsWrittenReason(item),
+    );
+  }
+  return false;
+}
+
 function unfinishedReasonPresent(details?: unknown): boolean {
-  if (typeof details !== "object" || details === null) return false;
-  const reason = (details as { reason?: unknown }).reason;
-  return typeof reason === "string" && reason.trim().length > 0;
+  if (typeof details !== "object" || details === null || Array.isArray(details)) return false;
+  return containsWrittenReason((details as { reason?: unknown }).reason);
 }
 
 function readGateState(session: HostRecordSession): {