@akagilnc/pi-workflow-roles 0.1.5303 → 0.1.5307

package/src/analyst-metric-families/leg-wall-clock.ts

@@ -6,7 +6,7 @@
  * Registers by file drop under analyst-metric-families/ (A2 discovery).
  */
 import { medianNumber } from "../analyst-median.ts";
-import type { AnalystReadableRunFacts } from "../analyst-ledger.ts";
+import { compareAnalystLegs, sumAnalystRunWallMs, type AnalystReadableRunFacts } from "../analyst-ledger.ts";
 import type { AnalystMetricFamilyModule } from "../analyst-metric-family.ts";
 
 /** One readable leg's session-frame wall clock (first usable → last usable). */
@@ -31,19 +31,12 @@ export type AnalystLegWallClockSection = {
   readonly totalElapsedMs: number;
 };
 
-function frameSpanWallMs(span: {
-  readonly startedAt: string;
-  readonly endedAt: string;
-}): number {
-  return Date.parse(span.endedAt) - Date.parse(span.startedAt);
-}
-
 function projectEntry(facts: AnalystReadableRunFacts): AnalystLegWallClockEntry {
   return {
     runId: facts.runId,
     book: facts.book,
     role: facts.role,
-    wallMs: frameSpanWallMs(facts.frameSpan),
+    wallMs: facts.frameSpan.wallMs,
   };
 }
 
@@ -52,9 +45,7 @@ function compareRankingDesc(
   b: AnalystLegWallClockEntry,
 ): number {
   if (b.wallMs !== a.wallMs) return b.wallMs - a.wallMs;
-  if (a.book !== b.book) return a.book.localeCompare(b.book);
-  if (a.role !== b.role) return a.role.localeCompare(b.role);
-  return a.runId.localeCompare(b.runId);
+  return compareAnalystLegs(a, b);
 }
 
 /** Discovered by analyst-metric-families loader (default export). */
@@ -74,14 +65,11 @@ const legWallClockFamily: AnalystMetricFamilyModule = {
       return undefined;
     }
 
-    let totalElapsedMs = 0;
-    for (const wallMs of walls) totalElapsedMs += wallMs;
-
     const section: AnalystLegWallClockSection = {
       kind: "analyst-leg-wall-clock",
       ranking,
       medianWallMs,
-      totalElapsedMs,
+      totalElapsedMs: sumAnalystRunWallMs(input.runs),
     };
     return { legWallClock: section };
   },

package/src/analyst-metric-families/round-timeline.ts

@@ -70,10 +70,6 @@ function isRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 
-function wallMsFromSpan(startedAt: string, endedAt: string): number {
-  return Date.parse(endedAt) - Date.parse(startedAt);
-}
-
 function readClassCount(body: Record<string, unknown>): number | undefined {
   if (!isRecord(body.outcome)) return undefined;
   if (!isRecord(body.outcome.decisiveFacts)) return undefined;
@@ -113,7 +109,7 @@ function projectRunRow(facts: AnalystReadableRunFacts): AnalystRoundTimelineRunR
     role: facts.role,
     startedAt,
     endedAt,
-    wallMs: wallMsFromSpan(startedAt, endedAt),
+    wallMs: facts.frameSpan.wallMs,
     terminal: projectTerminal(facts),
   };
 }

package/src/analyst-model-groups.ts

@@ -11,7 +11,7 @@
 import { buildAcceptanceSuccessReworkSection } from "./analyst-metric-families/acceptance-success-rework.ts";
 import type { AnalystReadableRunFacts } from "./analyst-ledger.ts";
 import { medianNumber } from "./analyst-median.ts";
-import type { AnalystUnreadableRun } from "./analyst-page.ts";
+import { sortUnreadable, type AnalystUnreadableRun } from "./analyst-page.ts";
 
 /** One raw model group with rates over legs in that group. */
 export type AnalystModelGroupRow = {
@@ -74,15 +74,6 @@ function displayNameFor(
   return aliased === undefined ? rawGroupKey : aliased;
 }
 
-function sortUnreadable(
-  unreadable: readonly AnalystUnreadableRun[],
-): AnalystUnreadableRun[] {
-  return [...unreadable].sort((a, b) => {
-    if (a.book !== b.book) return a.book.localeCompare(b.book);
-    return a.runId.localeCompare(b.runId);
-  });
-}
-
 /**
  * Legs with no usable session model identity cannot join any model group.
  * Reuse the typed unreadable path (locatable missing-source) — not an empty-key group.

package/src/analyst-page.ts

@@ -15,7 +15,7 @@ import {
   ensureRealDirectoryTree,
   physicalPathIdentity,
 } from "./activation-ledger-topology.ts";
-import type { AnalystReadableRunFacts } from "./analyst-ledger.ts";
+import { compareAnalystLegs, sumAnalystRunWallMs, type AnalystReadableRunFacts } from "./analyst-ledger.ts";
 import { loadAnalystIssueMetricFamilies } from "./analyst-metric-families.ts";
 import { composeAnalystMetricFamilySections } from "./analyst-metric-family.ts";
 
@@ -187,14 +187,10 @@ export function analystIssuePageAddressFromPage(
 }
 
 function sortLegs(legs: readonly AnalystLegEntry[]): AnalystLegEntry[] {
-  return [...legs].sort((a, b) => {
-    if (a.book !== b.book) return a.book.localeCompare(b.book);
-    if (a.role !== b.role) return a.role.localeCompare(b.role);
-    return a.runId.localeCompare(b.runId);
-  });
+  return [...legs].sort(compareAnalystLegs);
 }
 
-function sortUnreadable(
+export function sortUnreadable(
   unreadable: readonly AnalystUnreadableRun[],
 ): AnalystUnreadableRun[] {
   return [...unreadable].sort((a, b) => {
@@ -260,13 +256,6 @@ export function computeAnalystMsPerKLines(
   };
 }
 
-function frameSpanWallMs(span: {
-  readonly startedAt: string;
-  readonly endedAt: string;
-}): number {
-  return Date.parse(span.endedAt) - Date.parse(span.startedAt);
-}
-
 /**
  * Σ readable wall clocks + max end-frame across ALL runs (C1 efficiency / index).
  * Unreadable runs never enter totalElapsedMs; their available lastFrameAt still
@@ -279,10 +268,9 @@ export function summarizeAnalystRunEfficiency(
   readonly totalElapsedMs: number;
   readonly lastActivityAt: AnalystOptionalTimestamp;
 } {
-  let totalElapsedMs = 0;
+  const totalElapsedMs = sumAnalystRunWallMs(runs);
   let latestEndedAt: string | undefined;
   for (const run of runs) {
-    totalElapsedMs += frameSpanWallMs(run.frameSpan);
     const endedAt = run.frameSpan.endedAt;
     if (latestEndedAt === undefined || endedAt > latestEndedAt) {
       latestEndedAt = endedAt;