@akagilnc/pi-workflow-roles 0.1.2383 → 0.1.2402

package/src/package-contracts/reviewer-output.ts

@@ -1,11 +1,5 @@
 /** Package-owned Reviewer intent and runtime-receipt leaves — no role registration surface. */
 
-import {
-  seatFallbackBaseStatus,
-  seatFallbackStatusHasLawfulEvidence,
-  type SeatFallbackTaintedStatus,
-  type WithEngineLaborFallback,
-} from "../engine-labor-fallback.ts";
 import type { ReviewerAcceptedEvidence, ReviewerFailureClassification, ReviewerWorkspaceDisposition } from "../reviewer-execution-ledger.ts";
 
 export const REVIEWER_OUTPUT_TOOL_NAME = "ak_reviewer_output";
@@ -36,7 +30,7 @@ export type RuntimeReviewerAcceptedBatch = Readonly<{
 }>;
 /** Honest Spec-child disposition on the receipt face. */
 export type RuntimeReviewerSpecDisposition = "launched" | "skipped-missing";
-type RuntimeReviewerReceiptV2Clean = Readonly<{
+export type RuntimeReviewerReceiptV2 = Readonly<{
   version: 2;
   status: "completed" | "refused";
   diagnostic?: string;
@@ -55,14 +49,6 @@ type RuntimeReviewerReceiptV2Clean = Readonly<{
     target?: ReviewerAcceptedEvidence["target"];
   }>;
 }>;
-/** Clean runtime receipt or seat-fallback tainted accepted receipt (ADR 0071). */
-export type RuntimeReviewerReceiptV2 =
-  | RuntimeReviewerReceiptV2Clean
-  | WithEngineLaborFallback<
-      Omit<RuntimeReviewerReceiptV2Clean, "status"> & {
-        status: SeatFallbackTaintedStatus<"completed" | "refused">;
-      }
-    >;
 
 function isRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === "object" && value !== null && !Array.isArray(value);
@@ -102,10 +88,6 @@ export function validateReviewerIntent(output: unknown): ReviewerIntent {
 /** Validate runtime-owned facts at their real identity seams (target pins + plain text). */
 export function validateRuntimeReviewerReceipt(output: unknown): RuntimeReviewerReceiptV2 {
   const status = read(output, "status");
-  // ADR 0071: tainted top-level status requires latch-shaped engineLaborFallback evidence.
-  if (typeof status === "string" && !seatFallbackStatusHasLawfulEvidence(status, output)) {
-    throw new Error("Reviewer receipt has no recognized execution discriminator");
-  }
   const acceptedBatch = read(output, "acceptedBatch");
   const identities = read(output, "identities");
   const construction = read(identities, "construction");
@@ -173,8 +155,7 @@ export function projectReviewerIntentToReceipt(intentValue: unknown, receiptValu
   const intent = validateReviewerIntent(intentValue);
   const receipt = validateRuntimeReviewerReceipt(receiptValue);
   const receiptStatus = String(receipt.status);
-  const receiptBase = seatFallbackBaseStatus(receiptStatus);
-  if (receiptBase !== intent.status || (intent.status === "completed" ? receipt.diagnostic !== undefined : receipt.diagnostic !== intent.diagnostic)) {
+  if (receiptStatus !== intent.status || (intent.status === "completed" ? receipt.diagnostic !== undefined : receipt.diagnostic !== intent.diagnostic)) {
     throw new Error("Reviewer intent and runtime receipt disagree");
   }
   return receipt;

package/src/package-contracts/terminating-tools.ts

@@ -25,10 +25,6 @@ import {
   type RuntimeReviewerReceiptV2,
 } from "./reviewer-output.ts";
 import { isAuditEscalationResult } from "../audit-escalation.ts";
-import {
-  seatFallbackBaseStatus,
-  seatFallbackStatusHasLawfulEvidence,
-} from "../engine-labor-fallback.ts";
 import { DOCTOR_OUTPUT_TOOL_NAME, validateDoctorSubmissionShape, validateRecordedDoctorOutput, type DoctorOutput, type DoctorSubmission } from "../doctor-contracts.ts";
 import { MERGER_ACCEPTED_TEXT, MERGER_OUTPUT_TOOL_NAME, validateMergerOutput, type MergerOutput } from "../merger-contracts.ts";
 import { NOTARY_ACCEPTED_TEXT, NOTARY_OUTPUT_TOOL_NAME, validateRecordedNotaryOutput, type NotaryOutput } from "../notary-contracts.ts";
@@ -168,19 +164,14 @@ export function validateAcceptedDetails(
     [COLLECTOR_OUTPUT_TOOL]: [],
     [DOCTOR_OUTPUT_TOOL_NAME]: ["completed", "refused"],
     [MERGER_OUTPUT_TOOL_NAME]: ["completed", "escalate"],
-    [NOTARY_OUTPUT_TOOL_NAME]: ["pass", "bounce", "incomplete"],
+    [NOTARY_OUTPUT_TOOL_NAME]: ["pass", "bounce"],
   };
   const collectorDiscriminator = toolName === COLLECTOR_OUTPUT_TOOL && Array.isArray(candidate?.groups);
-  const baseDiscriminator = typeof discriminator === "string" ? seatFallbackBaseStatus(discriminator) : discriminator;
-  // ADR 0071: `-by-fallback` is not independently lawful — require latch-shaped evidence.
-  const taintedWithoutEvidence =
-    typeof discriminator === "string" &&
-    !seatFallbackStatusHasLawfulEvidence(discriminator, details);
+  const baseDiscriminator = discriminator;
   const runtimeBindingMissing =
     (toolName === DOCTOR_OUTPUT_TOOL_NAME && baseDiscriminator === "completed" && !(candidate?.cost !== null && typeof candidate?.cost === "object")) ||
     (toolName === REVIEWER_OUTPUT_TOOL_NAME && candidate?.version !== 2);
   if (
-    taintedWithoutEvidence ||
     runtimeBindingMissing ||
     (!collectorDiscriminator && (typeof discriminator !== "string" || !lawfulStatuses[toolName].includes(baseDiscriminator as string)))
   ) {
@@ -219,12 +210,12 @@ export function validateAcceptedLifecycle(
   const details = validateAcceptedDetails(toolName, detailsValue);
   if (toolName === DOCTOR_OUTPUT_TOOL_NAME) {
     const testimony = validateDoctorSubmissionShape(argumentsValue);
-    if (seatFallbackBaseStatus(String(testimony.status)) === "refused") {
+    if ((String(testimony.status)) === "refused") {
       if (!deepEqual(testimony, details)) throw new Error("accepted tool lifecycle details mismatch");
       return details;
     }
     const receipt = details as DoctorOutput & { cost?: unknown };
-    if (seatFallbackBaseStatus(String(receipt.status)) !== "completed") {
+    if ((String(receipt.status)) !== "completed") {
       throw new Error("accepted tool lifecycle details mismatch");
     }
     const { cost: _runtimeCost, ...projected } = receipt;
@@ -253,7 +244,7 @@ export function acceptedFacts(toolName: TerminatingToolName, details: AcceptedDe
     case MERGER_OUTPUT_TOOL_NAME: {
       const output = details as unknown as Record<string, unknown>;
       const status = output.status as string;
-      return { status, ...(seatFallbackBaseStatus(status) === "completed" && typeof output.mergeCommitId === "string" ? { commit: output.mergeCommitId } : {}) };
+      return { status, ...(status === "completed" && typeof output.mergeCommitId === "string" ? { commit: output.mergeCommitId } : {}) };
     }
     case COLLECTOR_OUTPUT_TOOL:
       return { status: "collected" };

package/src/package-contracts/worker-output.ts

@@ -15,24 +15,16 @@ export type {
 } from "./fixer-output.ts";
 export { fixerPrerequisiteSchema, fixerPrerequisitesSchema, parseFixerPrerequisites, validateFixerPrerequisites } from "./fixer-packet.ts";
 export type { FixerInvocationInput, FixerPrerequisite } from "./fixer-packet.ts";
-import type { WithEngineLaborFallback } from "../engine-labor-fallback.ts";
 import { validateFixerOutput, type FixerOutput } from "./fixer-output.ts";
 
 export const CODER_OUTPUT_TOOL_NAME = "ak_coder_output";
 export const CODER_ACCEPTED_TEXT = "Coder report accepted";
 export type WorkerRoleLabel = "Coder" | "Fixer";
-type CoderOutputClean =
+export type CoderOutput =
   | { status: "planned"; report: string }
   | { status: "completed" | "refused"; report: string }
   | { status: "unfinished"; report: string; remainingScope: string; reason?: string };
-/** Clean submission shape or seat-fallback tainted accepted receipt (ADR 0071). */
-export type CoderOutput =
-  | CoderOutputClean
-  | WithEngineLaborFallback<CoderOutputClean>;
-export type WorkerOutput =
-  | CoderOutput
-  | FixerOutput
-  | WithEngineLaborFallback<FixerOutput>;
+export type WorkerOutput = CoderOutput | FixerOutput;
 
 export function validateAcceptedCoderDetails(output: unknown): CoderOutput {
   return output as CoderOutput;

package/src/public-cli/doctor-run.ts

@@ -21,7 +21,6 @@ import {
 } from "./one-shot-dispatch.ts";
 import {
   presentStructuralRejection,
-  trySettleComplianceAuditIncompleteTerminalResult,
   trySettleDoctorTerminalResult,
 } from "./settlement.ts";
 import type { CliIo } from "./cli-io.ts";
@@ -122,7 +121,6 @@ export async function runPublicDoctor(
       trySettle: trySettleDoctorTerminalResult,
       shouldPresentSettled: (terminal) =>
         isLawfulTypedTerminalOutcome(terminal.roleOutcome),
-      trySettleSecondary: trySettleComplianceAuditIncompleteTerminalResult,
     },
     ...(env.engine === undefined ? {} : { effectiveEngine: env.engine }),
   });

package/src/public-cli/fixer-run.ts

@@ -70,7 +70,6 @@ import {
   explicitInternalKnownFailureClassificationInput,
   settleFailureTerminalResult,
   trySettleFixerTerminalResult,
-  trySettleComplianceAuditIncompleteTerminalResult,
 } from "./settlement.ts";
 import type { CliIo } from "./cli-io.ts";
 import type {
@@ -390,20 +389,6 @@ async function dispatchAdmittedFixer(input: {
       };
     }
 
-    const auditIncomplete = await trySettleComplianceAuditIncompleteTerminalResult(admitted);
-    if (auditIncomplete !== undefined) {
-      await markRunTerminal(admitted.runDirectory).catch(() => undefined);
-      if (auditIncomplete.roleOutcome.kind === "failure") {
-        presentFailureTerminal(auditIncomplete, io);
-      } else {
-        io.stdout(formatTerminalResult(auditIncomplete));
-      }
-      return {
-        exitCode: exitCodeForTerminalOutcome(auditIncomplete.roleOutcome),
-        admitted,
-        terminal: auditIncomplete,
-      };
-    }
 
     const credentialFailure = postRunMissingCredentialFailure(
       result,

package/src/public-cli/judge-run.ts

@@ -64,7 +64,6 @@ import {
   readEngineDetourInfrastructureFailure,
   settleJudgeFailureTerminalResult,
   trySettleJudgeTerminalResult,
-  trySettleComplianceAuditIncompleteTerminalResult,
 } from "./settlement.ts";
 import type { CliIo } from "./cli-io.ts";
 import type {
@@ -370,21 +369,6 @@ async function dispatchAdmittedJudge(input: {
       };
     }
 
-    const auditIncomplete = await trySettleComplianceAuditIncompleteTerminalResult(admitted);
-    if (auditIncomplete !== undefined) {
-      await markRunTerminal(admitted.runDirectory).catch(() => undefined);
-      if (auditIncomplete.roleOutcome.kind === "failure") {
-        presentFailureTerminal(auditIncomplete, io);
-      } else {
-        io.stdout(formatTerminalResult(auditIncomplete));
-      }
-      return {
-        exitCode: exitCodeForTerminalOutcome(auditIncomplete.roleOutcome),
-        admitted,
-        terminal: auditIncomplete,
-      };
-    }
-
     // Prefer engine-detour infrastructure failure already on the session principal
     // over a later secondary provider-stop after abort (#357 T2 / collector-isomorphic).
     const infrastructureFailure = await readEngineDetourInfrastructureFailure(

package/src/public-cli/notary-run.ts

@@ -109,7 +109,7 @@ export async function runPublicNotary(
     extraArgs,
     adapters: {
       trySettle: trySettleNotaryTerminalResult,
-      // Accepted receipts and residual incomplete share one present path.
+      // Accepted receipts and failure terminals both present via shared path.
       shouldPresentSettled: () => true,
     },
     ...(env.engine === undefined ? {} : { effectiveEngine: env.engine }),

package/src/public-cli/one-shot-dispatch.ts

@@ -59,7 +59,7 @@ export type OneShotRunEnv = {
 /**
  * Role-specific settlement hooks. Lifecycle coordination stays in this module.
  * - Doctor: present only lawful typed outcomes; optional compliance-audit secondary.
- * - Notary: present any settled terminal (accepted + residual incomplete).
+ * - Notary: present any settled terminal (accepted or failure).
  */
 export type OneShotSettlementAdapters<A extends AdmittedRoleInvocation> = {
   trySettle: (admitted: A) => Promise<TerminalResult | undefined>;

package/src/public-cli/reviewer-run.ts

@@ -72,7 +72,6 @@ import {
   readEngineDetourInfrastructureFailure,
   settleFailureTerminalResult,
   trySettleReviewerTerminalResult,
-  trySettleComplianceAuditIncompleteTerminalResult,
 } from "./settlement.ts";
 import type { CliIo } from "./cli-io.ts";
 import type {
@@ -398,20 +397,6 @@ async function dispatchAdmittedReviewer(input: {
       };
     }
 
-    const auditIncomplete = await trySettleComplianceAuditIncompleteTerminalResult(admitted);
-    if (auditIncomplete !== undefined) {
-      await markRunTerminal(admitted.runDirectory).catch(() => undefined);
-      if (auditIncomplete.roleOutcome.kind === "failure") {
-        presentFailureTerminal(auditIncomplete, io);
-      } else {
-        io.stdout(formatTerminalResult(auditIncomplete));
-      }
-      return {
-        exitCode: exitCodeForTerminalOutcome(auditIncomplete.roleOutcome),
-        admitted,
-        terminal: auditIncomplete,
-      };
-    }
 
     // Prefer engine-detour infrastructure failure already on the session principal
     // over a later secondary knownFailure / provider-stop after abort (#357 T2 / #378).