@akagilnc/pi-workflow-roles 0.1.2383 → 0.1.2397

package/src/public-cli/terminal.ts

@@ -6,7 +6,6 @@
  * extra rows or shift column boundaries (note / fix.summary / decision question / reason).
  */
 import { renderPublicAkRoleCommand } from "./command-renderer.ts";
-import type { ComplianceAuditIncomplete } from "../compliance-transport.ts";
 import type { NavigatorPhase } from "../navigator-attendance.ts";
 import type { NoReceiptLifecycleFacts } from "../receipt-delivery-policy.ts";
 
@@ -41,9 +40,10 @@ export type TerminalRoleName =
   | "merger"
   | "notary";
 
+/** Merger/Collector residual only — Notary/audit residual abolished (#475). */
 export type ResidualIncompleteTerminalOutcome = {
   kind: "incomplete";
-  role: "merger" | "collector" | "notary";
+  role: "merger" | "collector";
   status: "incomplete";
   decision: "no-usable-result";
   candidate: unknown;
@@ -52,35 +52,6 @@ export type ResidualIncompleteTerminalOutcome = {
   decisiveFacts: Readonly<Record<string, unknown>>;
 };
 
-export type AuditIncompleteTerminalOutcome = {
-  kind: "audit_incomplete";
-  role: TerminalRoleName;
-  status: "audit-incomplete";
-  decision: "no-usable-decision";
-  /** The original role submission arguments, retained independently. */
-  roleCandidate: unknown;
-  /** The malformed auditor candidate and observation retained by compliance transport. */
-  audit: ComplianceAuditIncomplete;
-  acceptedReceipt: false;
-  decisiveFacts: Readonly<Record<string, unknown>>;
-};
-
-/** JSON-safe public stand-in for an omitted tool-call `arguments` member. */
-export const JSON_SAFE_UNDEFINED_ARGUMENT = Object.freeze({
-  kind: "json-safe-sentinel",
-  type: "undefined",
-} as const);
-
-export type AuditIncompleteResidual = {
-  readonly roleCandidate: unknown;
-  readonly audit: ComplianceAuditIncomplete;
-  readonly acceptedReceipt: false;
-};
-
-export function jsonSafeComplianceCandidate(value: unknown): unknown {
-  return value === undefined ? JSON_SAFE_UNDEFINED_ARGUMENT : value;
-}
-
 export type NoReceiptTerminalOutcome = NoReceiptLifecycleFacts & {
   kind: "no_receipt";
   role: TerminalRoleName;
@@ -102,7 +73,6 @@ export type TerminalRoleOutcome =
       status: "audit_escalation";
       decisiveFacts: Readonly<Record<string, unknown>>;
     }
-  | AuditIncompleteTerminalOutcome
   | ResidualIncompleteTerminalOutcome
   | NoReceiptTerminalOutcome
   | {
@@ -113,8 +83,6 @@ export type TerminalRoleOutcome =
       /** Original diagnostic identity retained for the caller. */
       diagnostic: string;
       decisiveFacts: Readonly<Record<string, unknown>>;
-      /** Retained audit residual when publication itself failed. */
-      auditResidual?: AuditIncompleteResidual;
     };
 
 /** Lawful typed terminal results exit zero (including audit_escalation). */
@@ -131,7 +99,7 @@ export function exitCodeForTerminalOutcome(
 }
 
 export function buildResidualIncompleteTerminalOutcome(input: {
-  role: "merger" | "collector" | "notary";
+  role: "merger" | "collector";
   candidate: unknown;
   diagnostic: string;
 }): ResidualIncompleteTerminalOutcome {
@@ -152,42 +120,6 @@ export function buildResidualIncompleteTerminalOutcome(input: {
   };
 }
 
-export function buildAuditIncompleteTerminalOutcome(input: {
-  role: TerminalRoleName;
-  roleCandidate: unknown;
-  audit: ComplianceAuditIncomplete;
-}): AuditIncompleteTerminalOutcome {
-  const roleCandidate = jsonSafeComplianceCandidate(input.roleCandidate);
-  const audit = {
-    ...input.audit,
-    candidate: jsonSafeComplianceCandidate(input.audit.candidate),
-  };
-  return {
-    kind: "audit_incomplete",
-    role: input.role,
-    status: "audit-incomplete",
-    decision: "no-usable-decision",
-    roleCandidate,
-    audit,
-    acceptedReceipt: false,
-    decisiveFacts: {
-      decision: "no-usable-decision",
-      roleCandidate,
-      auditCandidate: audit.candidate,
-      auditObservation: audit.observation,
-      observationKind: audit.observation.kind,
-      observationType: audit.observation.kind === "non-object-arguments"
-        ? audit.observation.type
-        : audit.observation.kind === "object-status-unreadable"
-          ? audit.observation.status
-          : audit.observation.kind === "missing-subject"
-            ? audit.observation.subject
-            : audit.observation.kind,
-      acceptedReceipt: false,
-    },
-  };
-}
-
 export type TerminalNavigatorFact =
   | {
       disposition: "recommendation";

package/src/reviewer-auditor.ts

@@ -10,8 +10,8 @@ import {
 } from "./compliance-transport.ts";
 import {
   readReviewerAuditSubjects,
+  requireAuditMaterials,
   resolveAuditDossier,
-  toAuditIncomplete,
 } from "./dossier-resolution.ts";
 
 export const REVIEWER_AUDIT_TOOL_NAME = "ak_reviewer_audit_decision";
@@ -35,9 +35,9 @@ export function createPiReviewerAuditor(
 ): (options: ReviewerAuditOptions) => Promise<ComplianceDecision> {
   return async (options) => {
     const dossier = resolveAuditDossier();
-    if (dossier.status === "incomplete") return toAuditIncomplete(dossier.observation);
+    requireAuditMaterials(dossier);
     const subjects = readReviewerAuditSubjects(options.context);
-    if (subjects.status === "incomplete") return toAuditIncomplete(subjects.observation);
+    requireAuditMaterials(subjects);
 
     return runComplianceAudit({
       tool: reviewerDecisionTool,

package/src/reviewer-role.ts

@@ -210,7 +210,6 @@ export function createReviewerRoleRuntime(
                   try { await dependencies.shutdownAgent?.(); } catch (error) { hostActions.failInfrastructure(ledger.recordInfrastructureFailure(error), toolCtx, id); }
                   return result;
                 },
-                auditIncomplete: (result) => result,
               },
               candidate,
             );

package/src/role-runtime.ts

@@ -50,6 +50,7 @@ import { decorateSettlementWithNavigation, formatNavigatorReport, NAVIGATOR_EVEN
 import {
   buildNavigatorInfrastructureFailureFact,
   classifyPackagedRoleTerminalResult,
+  NAVIGATOR_INFRASTRUCTURE_FAILURE_EVIDENCE_KEYS,
   NAVIGATOR_INVOCATION_ENTRY,
   resolveLifecycleInvocationPrincipal,
 } from "./navigator-invocation-identity.ts";
@@ -220,9 +221,11 @@ import { createMergerRoleRuntime, type MergerRoleDependencies } from "./merger-r
 export {
   buildNavigatorInfrastructureFailureFact,
   classifyPackagedRoleTerminalResult,
+  hasNavigatorInfrastructureFailureBase,
   isAcceptedPackagedRoleTerminalResult,
   isDurablePackagedRoleTerminalResult,
   isNavigatorInfrastructureFailureFact,
+  NAVIGATOR_INFRASTRUCTURE_FAILURE_EVIDENCE_KEYS,
   NAVIGATOR_INFRASTRUCTURE_FAILURE_KIND,
   type NavigatorInfrastructureFailureFact,
   type PackagedRoleTerminalClassification,
@@ -550,6 +553,35 @@ function failInfrastructure(error: unknown, ctx: ExtensionContext): never {
   throw error;
 }
 
+/**
+ * Envelope-owned pending infrastructure failure: closed fact + original Error evidence.
+ * tool_result projects once from this record; settlement consumes durable details as-is.
+ */
+type PendingInfrastructureFailure = {
+  readonly details: Record<string, unknown>;
+};
+
+function extractInfrastructureFailureEvidence(error: unknown): Record<string, unknown> {
+  if (typeof error !== "object" || error === null) return {};
+  const record = error as Record<string, unknown>;
+  const evidence: Record<string, unknown> = {};
+  for (const key of NAVIGATOR_INFRASTRUCTURE_FAILURE_EVIDENCE_KEYS) {
+    if (!Object.hasOwn(record, key)) continue;
+    // undefined → null so JSON durable details retain the empty-candidate key.
+    evidence[key] = record[key] === undefined ? null : record[key];
+  }
+  return evidence;
+}
+
+function buildPendingInfrastructureFailure(error: unknown): PendingInfrastructureFailure {
+  return {
+    details: {
+      ...buildNavigatorInfrastructureFailureFact(),
+      ...extractInfrastructureFailureEvidence(error),
+    },
+  };
+}
+
 function navigatorPhase(pi: ExtensionAPI, role: string): NavigatorPhase {
   const metadata = packagedRoleMetadata(role);
   if (metadata === undefined || metadata.phases[0] === null) return null;
@@ -616,7 +648,8 @@ export function createRoleRuntimeExtension(
     let pendingNavigatorPresentation: { event: import("./navigator-attendance.ts").NavigatorEvent; report: import("./navigator-attendance.ts").NavigatorReport } | undefined;
     let pendingNavigatorSettlement: Promise<void> | undefined;
     let navigatorWorkContext: NavigatorWorkContext | undefined;
-    const pendingInfrastructureToolCallIds = new Set<string>();
+    /** toolCallId → fact+evidence; one-shot projected onto durable tool_result (#475). */
+    const pendingInfrastructureFailures = new Map<string, PendingInfrastructureFailure>();
     // Envelope-owned execute→tool_result bridge for Gatekeeper non-pass (ADR 0018).
     const pendingGatekeeperNonPassByToolCallId = new Map<string, GatekeeperNonPassResult>();
     // #357 T2 / #378 / #380 / #391: engine detour once-latch + seat-fallback latch (any role+engine).
@@ -705,11 +738,11 @@ export function createRoleRuntimeExtension(
     pi.on("tool_result", async (event) => {
       const role = selectedRole;
       if (role === undefined) return;
-      const isRoleInfrastructureFailure = pendingInfrastructureToolCallIds.delete(event.toolCallId);
-      // Overlay typed infra fact so live settlement and durable session entry agree.
-      const infrastructureDetails = isRoleInfrastructureFailure
-        ? buildNavigatorInfrastructureFailureFact()
-        : undefined;
+      const pendingInfra = pendingInfrastructureFailures.get(event.toolCallId);
+      const isRoleInfrastructureFailure = pendingInfra !== undefined;
+      if (pendingInfra !== undefined) pendingInfrastructureFailures.delete(event.toolCallId);
+      // One-shot project fact + typed evidence so live settlement and durable session agree.
+      const infrastructureDetails = pendingInfra?.details;
       const classified = infrastructureDetails === undefined
         ? event
         : { ...event, details: infrastructureDetails };
@@ -878,7 +911,7 @@ export function createRoleRuntimeExtension(
       navigatorAttendance?.dispose();
       navigatorAttendance = undefined;
       pendingNavigatorSettlement = undefined;
-      pendingInfrastructureToolCallIds.clear();
+      pendingInfrastructureFailures.clear();
       pendingGatekeeperNonPassByToolCallId.clear();
       observationFace.reset();
     });
@@ -886,7 +919,7 @@ export function createRoleRuntimeExtension(
     const hostActions = {
       failInfrastructure(error: unknown, ctx: ExtensionContext, toolCallId?: string): never {
         if (toolCallId !== undefined) {
-          pendingInfrastructureToolCallIds.add(toolCallId);
+          pendingInfrastructureFailures.set(toolCallId, buildPendingInfrastructureFailure(error));
         }
         failInfrastructure(error, ctx);
       },
@@ -1105,7 +1138,7 @@ export function createRoleRuntimeExtension(
       observationFace.reset();
       pendingNavigatorPresentation = undefined;
       pendingNavigatorSettlement = undefined;
-      pendingInfrastructureToolCallIds.clear();
+      pendingInfrastructureFailures.clear();
       pendingGatekeeperNonPassByToolCallId.clear();
       engineLaborFallbackLatch = createEngineLaborFallbackLatch();
       // #380 resume: restore sole-built fallback from durable same-session detour results.