@akagilnc/pi-workflow-roles 0.1.2096 → 0.1.2101

package/dist/public-cli/main.js

@@ -14449,7 +14449,7 @@ function setPersistentSeatEngine(config, seat, engine) {
   const previous = config.seats[seat];
   if (previous === void 0) {
     throw new Error(
-      `config seat ${seat} has no persistent model; set provider/model:thinking before engine`
+      `config seat ${seat} has no persistent model; set provider/model[:thinking] before engine`
     );
   }
   if (engine === void 0) {
@@ -14518,19 +14518,6 @@ function parseModelSpec(spec, fallbackThinking) {
   const model = modelPart.slice(slash + 1);
   return thinking === void 0 ? { provider, model } : { provider, model, thinking };
 }
-function parsePersistentModelSpec(spec) {
-  const parsed = parseModelSpec(spec);
-  if (parsed.thinking === void 0) {
-    throw new Error(
-      `model specification requires a thinking level (provider/model:thinking), got ${spec}`
-    );
-  }
-  return {
-    provider: parsed.provider,
-    model: parsed.model,
-    thinking: parsed.thinking
-  };
-}
 function formatModelSpec(selection) {
   const base = `${selection.provider}/${selection.model}`;
   return selection.thinking === void 0 ? base : `${base}:${selection.thinking}`;
@@ -14578,13 +14565,15 @@ function parseSeatModelConfig(value, seat) {
   if (typeof raw.model !== "string" || raw.model.trim() === "") {
     throw new Error(`config seat ${seat} requires model`);
   }
-  if (typeof raw.thinking !== "string" || !THINKING_LEVELS.has(raw.thinking)) {
-    throw new Error(`config seat ${seat} requires a valid thinking level`);
+  if (raw.thinking !== void 0) {
+    if (typeof raw.thinking !== "string" || !THINKING_LEVELS.has(raw.thinking)) {
+      throw new Error(`config seat ${seat} requires a valid thinking level`);
+    }
   }
   const parsed = {
     provider: raw.provider,
     model: raw.model,
-    thinking: raw.thinking
+    ...raw.thinking === void 0 ? {} : { thinking: raw.thinking }
   };
   if (raw.engine !== void 0) {
     if (typeof raw.engine !== "string") {
@@ -27117,7 +27106,7 @@ function renderHelp() {
   lines.push(
     "",
     "Role options: ak-role help <command>",
-    "Persistent config: ak-role config set <seat> <provider/model:thinking>",
+    "Persistent config: ak-role config set <seat> <provider/model[:thinking]>",
     "Persistent engine (judge|reviewer): ak-role config set-engine <seat> <name> | unset-engine <seat>",
     "Effective seats: ak-role roles"
   );
@@ -27198,7 +27187,7 @@ async function runConfigCommand(args, home, packageRoot2, io) {
   if (args[0] === "set") {
     if (args.length < 3) {
       throw new CliUsageError(
-        "usage: ak-role config set <seat> <provider/model:thinking>"
+        "usage: ak-role config set <seat> <provider/model[:thinking]>"
       );
     }
     const pairs = args.slice(1);
@@ -27214,7 +27203,7 @@ async function runConfigCommand(args, home, packageRoot2, io) {
       if (!isPublicConfigurableSeat(seat)) {
         throw new CliUsageError(`unknown configurable seat: ${seat}`);
       }
-      config = setPersistentSeatConfig(config, seat, parsePersistentModelSpec(spec));
+      config = setPersistentSeatConfig(config, seat, parseModelSpec(spec));
     }
     await savePublicCliConfig(config, home);
     io.stdout(renderConfig(config));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@akagilnc/pi-workflow-roles",
-  "version": "0.1.2096",
+  "version": "0.1.2101",
   "description": "Soul-bound workflow roles for Pi",
   "type": "module",
   "license": "Apache-2.0",

package/src/public-cli/cli.ts

@@ -13,7 +13,7 @@ import {
   formatModelSpec,
   loadCredentialProviders,
   loadPublicCliConfig,
-  parsePersistentModelSpec,
+  parseModelSpec,
   resolveEffectiveSeat,
   savePublicCliConfig,
   isEngineAxisSeat,
@@ -418,7 +418,7 @@ function renderHelp(): string {
   lines.push(
     "",
     "Role options: ak-role help <command>",
-    "Persistent config: ak-role config set <seat> <provider/model:thinking>",
+    "Persistent config: ak-role config set <seat> <provider/model[:thinking]>",
     "Persistent engine (judge|reviewer): ak-role config set-engine <seat> <name> | unset-engine <seat>",
     "Effective seats: ak-role roles",
   );
@@ -507,7 +507,7 @@ async function runConfigCommand(
   if (args[0] === "set") {
     if (args.length < 3) {
       throw new CliUsageError(
-        "usage: ak-role config set <seat> <provider/model:thinking>",
+        "usage: ak-role config set <seat> <provider/model[:thinking]>",
       );
     }
     // Bulk: repeated seat spec pairs after `set`
@@ -524,7 +524,9 @@ async function runConfigCommand(
       if (!isPublicConfigurableSeat(seat)) {
         throw new CliUsageError(`unknown configurable seat: ${seat}`);
       }
-      config = setPersistentSeatConfig(config, seat, parsePersistentModelSpec(spec));
+      // #384: persistent seat config shares the invocation model grammar.
+      // Bare provider/model stores as-is; :thinking suffix still required only when colon present.
+      config = setPersistentSeatConfig(config, seat, parseModelSpec(spec));
     }
     await savePublicCliConfig(config, home);
     io.stdout(renderConfig(config));

package/src/public-cli/config.ts

@@ -23,7 +23,7 @@ export type CredentialProviders = {
 
 export type SeatModelConfig = ModelRef;
 
-/** Persistent seat row: required model triple + optional engine axis (#356). */
+/** Persistent seat row: provider/model[:thinking] + optional engine axis (#356/#384). */
 export type PersistentSeatConfig = SeatModelConfig & {
   engine?: string;
 };
@@ -123,7 +123,7 @@ export function isEngineAxisSeat(seat: string): seat is "judge" | "reviewer" {
 
 /**
  * Set or clear persistent engine on Judge or Reviewer (#356 / #378).
- * Engine-only seats are rejected — model triple remains required.
+ * Engine-only seats are rejected — provider/model[:thinking] remains required first.
  */
 export function setPersistentSeatEngine(
   config: PublicCliConfig,
@@ -136,7 +136,7 @@ export function setPersistentSeatEngine(
   const previous = config.seats[seat];
   if (previous === undefined) {
     throw new Error(
-      `config seat ${seat} has no persistent model; set provider/model:thinking before engine`,
+      `config seat ${seat} has no persistent model; set provider/model[:thinking] before engine`,
     );
   }
   if (engine === undefined) {
@@ -226,30 +226,12 @@ export function parseModelSpec(
   }
   const provider = modelPart.slice(0, slash);
   const model = modelPart.slice(slash + 1);
-  // #346: bare provider/model is legal on invocation — do not invent thinking.
-  // Persistent config set still requires thinking via parsePersistentModelSpec.
+  // #346/#384: bare provider/model is legal — do not invent thinking.
   return thinking === undefined
     ? { provider, model }
     : { provider, model, thinking };
 }
 
-/** Persistent seat config keeps the three-part provider/model:thinking grammar. */
-export function parsePersistentModelSpec(spec: string): SeatModelConfig & {
-  thinking: PublicThinkingLevel;
-} {
-  const parsed = parseModelSpec(spec);
-  if (parsed.thinking === undefined) {
-    throw new Error(
-      `model specification requires a thinking level (provider/model:thinking), got ${spec}`,
-    );
-  }
-  return {
-    provider: parsed.provider,
-    model: parsed.model,
-    thinking: parsed.thinking,
-  };
-}
-
 export function formatModelSpec(selection: SeatModelConfig): string {
   const base = `${selection.provider}/${selection.model}`;
   return selection.thinking === undefined ? base : `${base}:${selection.thinking}`;
@@ -308,16 +290,21 @@ function parseSeatModelConfig(value: unknown, seat: string): PersistentSeatConfi
   if (typeof raw.model !== "string" || raw.model.trim() === "") {
     throw new Error(`config seat ${seat} requires model`);
   }
-  if (
-    typeof raw.thinking !== "string" ||
-    !THINKING_LEVELS.has(raw.thinking as PublicThinkingLevel)
-  ) {
-    throw new Error(`config seat ${seat} requires a valid thinking level`);
+  // #384: thinking is optional on persistent seats; when present it must be typed.
+  if (raw.thinking !== undefined) {
+    if (
+      typeof raw.thinking !== "string" ||
+      !THINKING_LEVELS.has(raw.thinking as PublicThinkingLevel)
+    ) {
+      throw new Error(`config seat ${seat} requires a valid thinking level`);
+    }
   }
   const parsed: PersistentSeatConfig = {
     provider: raw.provider,
     model: raw.model,
-    thinking: raw.thinking as PublicThinkingLevel,
+    ...(raw.thinking === undefined
+      ? {}
+      : { thinking: raw.thinking as PublicThinkingLevel }),
   };
   if (raw.engine !== undefined) {
     // Shape only: engine must be a string field. Path-safety syntax is deferred to