@akagilnc/pi-workflow-roles 0.1.2004 → 0.1.2014

package/src/reviewer-role.ts

@@ -9,7 +9,7 @@ import type { ComplianceDecision } from "./compliance-transport.ts";
 import { appendActiveSessionCustomEntry } from "./compliance-transport.ts";
 import { REVIEWER_CANDIDATE_ENTRY_TYPE } from "./dossier-resolution.ts";
 import { type ReviewerSpecDisposition } from "./reviewer-construction.ts";
-import { createReviewerDispatcher, type AcceptedReviewerDispatch, type AcceptedReviewerExecution, type ReviewerPinnedGitReader } from "./reviewer-dispatch.ts";
+import { createReviewerDispatcher, type AcceptedReviewerDispatch, type AcceptedReviewerExecution, type ReviewerIssueFetcher, type ReviewerPinnedGitReader } from "./reviewer-dispatch.ts";
 import { ReviewerDispatchExecutionError, type ReviewerDispatchRunResult } from "./reviewer-agent.ts";
 import { createReviewerExecutionLedger, projectAcceptedDispatch, projectReviewerDispatchOutcome, type ReviewerExecutionRecord } from "./reviewer-execution-ledger.ts";
 import { assembleRuntimeReviewerReceipt } from "./reviewer-settlement.ts";
@@ -24,6 +24,8 @@ export type ReviewerAdmittedInputs = Readonly<{
   baseRevision: string;
   reviewScopeKeys?: readonly string[];
   authorityRefs?: readonly string[];
+  /** Typed #176 ticketNumber from admitted invocation (Spec self-fetch primary). */
+  ticketNumber?: number;
 }>;
 
 const reviewerOutputVariants = Type.Union([
@@ -35,6 +37,8 @@ export type ReviewerRoleDependencies = {
   loadSoul(): Promise<string>;
   loadCanonicalSkillBinding(name: "code-review"): Promise<AnyCanonicalSkillBinding>;
   createPinnedGitReader(): Promise<ReviewerPinnedGitReader>;
+  /** Injected issue-fetch capability; shared seam owns gh lifecycle. */
+  fetchIssue?: ReviewerIssueFetcher;
   runDispatch(execution: AcceptedReviewerExecution, options: { context: ExtensionContext; signal?: AbortSignal }): Promise<ReviewerDispatchRunResult>;
   shutdownAgent?(): Promise<void>;
   auditCompliance(options: { context: ExtensionContext; signal?: AbortSignal }): Promise<ComplianceDecision>;
@@ -86,6 +90,7 @@ export function createReviewerRoleRuntime(
       fixedBaseRevision = admitted.baseRevision;
       const reviewScopeKeys = admitted.reviewScopeKeys;
       const authorityRefs = admitted.authorityRefs;
+      const ticketNumber = admitted.ticketNumber;
       const loaded = await dependencies.loadCanonicalSkillBinding("code-review");
       if (loaded.name !== "code-review") throw new Error("Canonical Skill binding loader returned tdd for code-review");
       binding = loaded;
@@ -115,6 +120,8 @@ export function createReviewerRoleRuntime(
         reader,
         ...(reviewScopeKeys === undefined ? {} : { reviewScopeKeys }),
         ...(authorityRefs === undefined ? {} : { authorityRefs }),
+        ...(ticketNumber === undefined ? {} : { ticketNumber }),
+        ...(dependencies.fetchIssue === undefined ? {} : { fetchIssue: dependencies.fetchIssue }),
         decisionEvidence(decision) {
           try {
             if (decision.disposition === "accepted") {

package/src/reviewer-settlement.ts

@@ -56,6 +56,10 @@ export function assembleRuntimeReviewerReceipt(input: {
       ...(accepted.specDisposition === undefined
         ? {}
         : { specDisposition: accepted.specDisposition }),
+      // Self-fetch bytes + source annotation retained for audit (#343 fetch-then-store).
+      ...(accepted.specFetchedMaterial === undefined
+        ? {}
+        : { specFetchedMaterial: accepted.specFetchedMaterial }),
     }),
     reports,
     outcomes,

package/src/role-runtime.ts

@@ -61,7 +61,7 @@ import {
   type ReviewerActivation,
   type ReviewerAdmittedInputs,
 } from "./reviewer-role.ts";
-import type { AcceptedReviewerExecution, ReviewerPinnedGitReader } from "./reviewer-dispatch.ts";
+import type { AcceptedReviewerExecution, ReviewerIssueFetcher, ReviewerPinnedGitReader } from "./reviewer-dispatch.ts";
 import type { ReviewerDispatchRunResult } from "./reviewer-agent.ts";
 import {
   REVIEWER_VERIFICATION_BOUNDARY,
@@ -94,6 +94,13 @@ const REVIEWER_TRANSPORT_FLAGS = Object.freeze([
       type: "string" as const,
     }),
   }),
+  Object.freeze({
+    name: "ak-review-ticket-number",
+    definition: Object.freeze({
+      description: "Typed ticketNumber for Spec self-fetch primary path",
+      type: "string" as const,
+    }),
+  }),
 ] as const);
 
 /**
@@ -134,6 +141,13 @@ function decodeReviewerAdmittedInputs(getFlag: (name: string) => unknown): Revie
     authorityRefs = Object.freeze(parsed as string[]);
   }
 
+  let ticketNumber: number | undefined;
+  const rawTicketNumber = getFlag("ak-review-ticket-number");
+  // Shape-invalid flag values do not abort: omit typed candidate; branch→commit→degrade continues.
+  if (typeof rawTicketNumber === "string" && /^[1-9]\d*$/.test(rawTicketNumber)) {
+    ticketNumber = Number(rawTicketNumber);
+  }
+
   const baseRevision = getFlag("ak-review-base");
   if (typeof baseRevision !== "string" || !baseRevision.trim()) {
     throw new Error("Reviewer role requires --ak-review-base");
@@ -142,6 +156,7 @@ function decodeReviewerAdmittedInputs(getFlag: (name: string) => unknown): Revie
     baseRevision,
     ...(reviewScopeKeys === undefined ? {} : { reviewScopeKeys }),
     ...(authorityRefs === undefined ? {} : { authorityRefs }),
+    ...(ticketNumber === undefined ? {} : { ticketNumber }),
   });
 }
 
@@ -454,6 +469,8 @@ export type RoleRuntimeDependencies = {
   loadCoderTask?(path: string): Promise<string>;
   loadReviewerSoul?(): Promise<string>;
   createReviewerPinnedGitReader?(): Promise<ReviewerPinnedGitReader>;
+  /** Shared-seam issue-fetch capability for Reviewer Spec self-fetch (#343). */
+  createReviewerIssueFetcher?(): ReviewerIssueFetcher;
   loadCollectorSoul?(): Promise<string>;
   createCollectorTransport?(): CollectorGitHubTransport;
   loadDoctorSoul?(): Promise<string>;
@@ -892,6 +909,9 @@ export function createRoleRuntimeExtension(
           }
           return dependencies.loadCanonicalSkillBinding(name);
         },
+        ...(dependencies.createReviewerIssueFetcher === undefined
+          ? {}
+          : { fetchIssue: dependencies.createReviewerIssueFetcher() }),
         async runDispatch(dispatch, options) {
           if (dependencies.runReviewerDispatch === undefined) throw new Error("Reviewer runtime dependencies are not configured");
           return dependencies.runReviewerDispatch(dispatch, options);