@akagilnc/pi-workflow-roles 0.1.1883 → 0.1.1918

package/src/public-cli/judge-run.ts

@@ -36,8 +36,8 @@ import {
   markRunResumable,
   markRunRunning,
   markRunTerminal,
-  readTypedHttp429Observation,
   renderResumeCommand,
+  type TypedProviderHttpObservation,
   RESUME_TRANSPORT_ENVELOPE,
   RunWriterLeaseHeldError,
   type RunWriterLease,
@@ -52,7 +52,9 @@ import {
   isLawfulTypedTerminalOutcome,
   presentFailureTerminal,
   presentStructuralRejection,
-  resolveAuditedRunnerKnownFailure,
+  resolveAuditedRunnerFailureResolution,
+  resolveControlledFailureResumeObservation,
+  controlledFailureInputFromResolution,
   explicitInternalKnownFailureClassificationInput,
   settleJudgeFailureTerminalResult,
   trySettleJudgeTerminalResult,
@@ -171,6 +173,9 @@ async function presentControlledFailure(
     stderr: string;
     thrown?: unknown;
     knownFailure?: ExplicitInternalKnownFailure;
+    /** Pre-resolved typed-HTTP outcome — no second sidecar read when settled. */
+    typedHttpObservationSettled?: true;
+    typedHttpObservation?: TypedProviderHttpObservation;
   },
   io: CliIo,
 ): Promise<{
@@ -180,10 +185,25 @@ async function presentControlledFailure(
 }> {
   // Own-key presence, not value: `throw undefined` must not look like "no throw".
   const hasThrown = Object.hasOwn(failureInput, "thrown");
+  // v1 resume observation: reuse audited resolution when present; otherwise one
+  // controlled read. Non-absence failures fold into knownFailure — never escape.
+  const resumeObservation = await resolveControlledFailureResumeObservation({
+    runDirectory: admitted.runDirectory,
+    ...(failureInput.typedHttpObservationSettled === true
+      ? {
+        typedHttpObservationSettled: true as const,
+        ...(failureInput.typedHttpObservation === undefined
+          ? {}
+          : { typedHttpObservation: failureInput.typedHttpObservation }),
+      }
+      : {}),
+  });
+  const knownFailure =
+    failureInput.knownFailure ?? resumeObservation.observationReadFailure;
   const session =
     !hasThrown &&
     !failureInput.timedOut &&
-    failureInput.knownFailure === undefined
+    knownFailure === undefined
       ? await inspectJudgeSession(admitted.sessionFile)
       : undefined;
   const failure = classifyPostAdmissionFailure({
@@ -191,7 +211,7 @@ async function presentControlledFailure(
     code: failureInput.code,
     stderr: failureInput.stderr,
     ...(hasThrown ? { thrown: failureInput.thrown } : {}),
-    ...explicitInternalKnownFailureClassificationInput(failureInput.knownFailure),
+    ...explicitInternalKnownFailureClassificationInput(knownFailure),
     ...(session === undefined ? {} : { session }),
   });
 
@@ -199,7 +219,7 @@ async function presentControlledFailure(
   // absence of a lawful Judge result, and a durable exact Pi session principal.
   // Lawful presence is session-owned and must not depend on artifact publication.
   const hasLawfulTerminalResult = await hasLawfulJudgeTerminalResult(admitted);
-  const typedHttp429 = await readTypedHttp429Observation(admitted.runDirectory);
+  const typedHttp429 = resumeObservation.typedHttp429;
   const sessionPrincipalAvailable = await isSessionPrincipalAvailable(
     admitted.sessionFile,
   );
@@ -269,8 +289,9 @@ async function dispatchAdmittedJudge(input: {
       // and role-runtime can record typed provider HTTP observations.
       AK_ROLE_RUN_DIR: admitted.runDirectory,
     };
-    if (env.correlationId !== undefined && env.correlationId.trim() !== "") {
-      childEnv.AK_CORRELATION_ID = env.correlationId;
+    const correlationId = admitted.correlationId ?? env.correlationId;
+    if (correlationId !== undefined && correlationId.trim() !== "") {
+      childEnv.AK_CORRELATION_ID = correlationId;
     }
 
     let result: ExplicitInternalPiResult;
@@ -355,10 +376,11 @@ async function dispatchAdmittedJudge(input: {
       env.model,
       env.credentials,
     );
-    const knownFailure = await resolveAuditedRunnerKnownFailure({
+    const resolution = await resolveAuditedRunnerFailureResolution({
       runner: result.knownFailure,
       sessionFile: admitted.sessionFile,
       credential: credentialFailure,
+      runDirectory: admitted.runDirectory,
     });
     return await presentControlledFailure(
       admitted,
@@ -366,7 +388,7 @@ async function dispatchAdmittedJudge(input: {
         timedOut: result.timedOut,
         code: result.code,
         stderr: result.stderr,
-        ...(knownFailure === undefined ? {} : { knownFailure }),
+        ...controlledFailureInputFromResolution(resolution),
       },
       io,
     );
@@ -429,7 +451,10 @@ export async function runPublicJudge(
 
   return await dispatchAdmittedJudge({
     admitted,
-    env,
+    env: {
+      ...env,
+      ...(admitted.correlationId === undefined ? {} : { correlationId: admitted.correlationId }),
+    },
     io,
     extraArgs,
     lease,
@@ -499,7 +524,10 @@ export async function runPublicResume(
 
   return await dispatchAdmittedJudge({
     admitted,
-    env,
+    env: {
+      ...env,
+      ...(admitted.correlationId === undefined ? {} : { correlationId: admitted.correlationId }),
+    },
     io,
     extraArgs,
     lease,

package/src/public-cli/merger-run.ts

@@ -50,7 +50,7 @@ import {
   RESUME_TRANSPORT_ENVELOPE,
   RunWriterLeaseHeldError,
   type RunWriterLease,
-  readTypedHttp429Observation,
+  type TypedProviderHttpObservation,
 } from "./run-lifecycle.ts";
 import {
   classifyPostAdmissionFailure,
@@ -62,7 +62,9 @@ import {
   presentFailureTerminal,
   presentStructuralRejection,
   explicitInternalKnownFailureClassificationInput,
-  resolveAuditedRunnerKnownFailure,
+  resolveAuditedRunnerFailureResolution,
+  resolveControlledFailureResumeObservation,
+  controlledFailureInputFromResolution,
   settleFailureTerminalResult,
   trySettleMergerTerminalResult,
 } from "./settlement.ts";
@@ -192,6 +194,8 @@ async function presentControlledFailure(
       readonly code?: string | number;
     };
     knownDiagnostic?: string;
+    typedHttpObservationSettled?: true;
+    typedHttpObservation?: TypedProviderHttpObservation;
   },
   io: CliIo,
 ): Promise<{
@@ -200,10 +204,23 @@ async function presentControlledFailure(
   terminal: TerminalResult;
 }> {
   const hasThrown = Object.hasOwn(failureInput, "thrown");
+  const resumeObservation = await resolveControlledFailureResumeObservation({
+    runDirectory: admitted.runDirectory,
+    ...(failureInput.typedHttpObservationSettled === true
+      ? {
+        typedHttpObservationSettled: true as const,
+        ...(failureInput.typedHttpObservation === undefined
+          ? {}
+          : { typedHttpObservation: failureInput.typedHttpObservation }),
+      }
+      : {}),
+  });
+  const knownFailure =
+    failureInput.knownFailure ?? resumeObservation.observationReadFailure;
   const session =
     !hasThrown &&
     !failureInput.timedOut &&
-    failureInput.knownFailure === undefined &&
+    knownFailure === undefined &&
     failureInput.knownCause === undefined
       ? await inspectJudgeSession(admitted.sessionFile)
       : undefined;
@@ -212,7 +229,7 @@ async function presentControlledFailure(
     code: failureInput.code,
     stderr: failureInput.stderr,
     ...(hasThrown ? { thrown: failureInput.thrown } : {}),
-    ...explicitInternalKnownFailureClassificationInput(failureInput.knownFailure),
+    ...explicitInternalKnownFailureClassificationInput(knownFailure),
     ...(failureInput.knownCause === undefined
       ? {}
       : { knownCause: failureInput.knownCause }),
@@ -226,7 +243,7 @@ async function presentControlledFailure(
   });
 
   const hasLawfulTerminalResult = await hasLawfulMergerTerminalResult(admitted);
-  const typedHttp429 = await readTypedHttp429Observation(admitted.runDirectory);
+  const typedHttp429 = resumeObservation.typedHttp429;
   const sessionPrincipalAvailable = await isSessionPrincipalAvailable(
     admitted.sessionFile,
   );
@@ -291,8 +308,9 @@ async function dispatchAdmittedMerger(input: {
       PI_CODING_AGENT_DIR: env.agentDir,
       AK_ROLE_RUN_DIR: admitted.runDirectory,
     };
-    if (env.correlationId !== undefined && env.correlationId.trim() !== "") {
-      childEnv.AK_CORRELATION_ID = env.correlationId;
+    const correlationId = admitted.correlationId ?? env.correlationId;
+    if (correlationId !== undefined && correlationId.trim() !== "") {
+      childEnv.AK_CORRELATION_ID = correlationId;
     }
 
     let result: ExplicitInternalPiResult;
@@ -367,10 +385,11 @@ async function dispatchAdmittedMerger(input: {
       env.model,
       env.credentials,
     );
-    const knownFailure = await resolveAuditedRunnerKnownFailure({
+    const resolution = await resolveAuditedRunnerFailureResolution({
       runner: result.knownFailure,
       sessionFile: admitted.sessionFile,
       credential: credentialFailure,
+      runDirectory: admitted.runDirectory,
     });
     return await presentControlledFailure(
       admitted,
@@ -378,7 +397,7 @@ async function dispatchAdmittedMerger(input: {
         timedOut: result.timedOut,
         code: result.code,
         stderr: result.stderr,
-        ...(knownFailure === undefined ? {} : { knownFailure }),
+        ...controlledFailureInputFromResolution(resolution),
       },
       io,
     );
@@ -571,7 +590,10 @@ export async function runPublicMerger(
 
   return await dispatchAdmittedMerger({
     admitted,
-    env,
+    env: {
+      ...env,
+      ...(admitted.correlationId === undefined ? {} : { correlationId: admitted.correlationId }),
+    },
     io,
     extraArgs,
     lease,
@@ -658,7 +680,10 @@ export async function runPublicMergerResume(
 
   return await dispatchAdmittedMerger({
     admitted,
-    env,
+    env: {
+      ...env,
+      ...(admitted.correlationId === undefined ? {} : { correlationId: admitted.correlationId }),
+    },
     io,
     extraArgs,
     lease,

package/src/public-cli/reviewer-run.ts

@@ -44,11 +44,11 @@ import {
   markRunResumable,
   markRunRunning,
   markRunTerminal,
-  readTypedHttp429Observation,
   renderResumeCommand,
   RESUME_TRANSPORT_ENVELOPE,
   RunWriterLeaseHeldError,
   type RunWriterLease,
+  type TypedProviderHttpObservation,
 } from "./run-lifecycle.ts";
 import {
   classifyPostAdmissionFailure,
@@ -60,7 +60,9 @@ import {
   isLawfulTypedTerminalOutcome,
   presentFailureTerminal,
   presentStructuralRejection,
-  resolveAuditedRunnerKnownFailure,
+  resolveAuditedRunnerFailureResolution,
+  resolveControlledFailureResumeObservation,
+  controlledFailureInputFromResolution,
   explicitInternalKnownFailureClassificationInput,
   settleFailureTerminalResult,
   trySettleReviewerTerminalResult,
@@ -186,6 +188,8 @@ async function presentControlledFailure(
     stderr: string;
     thrown?: unknown;
     knownFailure?: ExplicitInternalKnownFailure;
+    typedHttpObservationSettled?: true;
+    typedHttpObservation?: TypedProviderHttpObservation;
   },
   io: CliIo,
 ): Promise<{
@@ -194,10 +198,23 @@ async function presentControlledFailure(
   terminal: TerminalResult;
 }> {
   const hasThrown = Object.hasOwn(failureInput, "thrown");
+  const resumeObservation = await resolveControlledFailureResumeObservation({
+    runDirectory: admitted.runDirectory,
+    ...(failureInput.typedHttpObservationSettled === true
+      ? {
+        typedHttpObservationSettled: true as const,
+        ...(failureInput.typedHttpObservation === undefined
+          ? {}
+          : { typedHttpObservation: failureInput.typedHttpObservation }),
+      }
+      : {}),
+  });
+  const knownFailure =
+    failureInput.knownFailure ?? resumeObservation.observationReadFailure;
   const session =
     !hasThrown &&
     !failureInput.timedOut &&
-    failureInput.knownFailure === undefined
+    knownFailure === undefined
       ? await inspectJudgeSession(admitted.sessionFile)
       : undefined;
   const failure = classifyPostAdmissionFailure({
@@ -205,12 +222,12 @@ async function presentControlledFailure(
     code: failureInput.code,
     stderr: failureInput.stderr,
     ...(hasThrown ? { thrown: failureInput.thrown } : {}),
-    ...explicitInternalKnownFailureClassificationInput(failureInput.knownFailure),
+    ...explicitInternalKnownFailureClassificationInput(knownFailure),
     ...(session === undefined ? {} : { session }),
   });
 
   const hasLawfulTerminalResult = await hasLawfulReviewerTerminalResult(admitted);
-  const typedHttp429 = await readTypedHttp429Observation(admitted.runDirectory);
+  const typedHttp429 = resumeObservation.typedHttp429;
   const sessionPrincipalAvailable = await isSessionPrincipalAvailable(
     admitted.sessionFile,
   );
@@ -276,8 +293,9 @@ async function dispatchAdmittedReviewer(input: {
       PI_CODING_AGENT_DIR: env.agentDir,
       AK_ROLE_RUN_DIR: admitted.runDirectory,
     };
-    if (env.correlationId !== undefined && env.correlationId.trim() !== "") {
-      childEnv.AK_CORRELATION_ID = env.correlationId;
+    const correlationId = admitted.correlationId ?? env.correlationId;
+    if (correlationId !== undefined && correlationId.trim() !== "") {
+      childEnv.AK_CORRELATION_ID = correlationId;
     }
 
     let result: ExplicitInternalPiResult;
@@ -367,7 +385,7 @@ async function dispatchAdmittedReviewer(input: {
       env.model,
       env.credentials,
     );
-    const knownFailure = await resolveAuditedRunnerKnownFailure({
+    const resolution = await resolveAuditedRunnerFailureResolution({
       runner: result.knownFailure,
       sessionFile: admitted.sessionFile,
       credential: credentialFailure,
@@ -379,7 +397,7 @@ async function dispatchAdmittedReviewer(input: {
         timedOut: result.timedOut,
         code: result.code,
         stderr: result.stderr,
-        ...(knownFailure === undefined ? {} : { knownFailure }),
+        ...controlledFailureInputFromResolution(resolution),
       },
       io,
     );
@@ -467,7 +485,10 @@ export async function runPublicReviewer(
 
   return await dispatchAdmittedReviewer({
     admitted,
-    env,
+    env: {
+      ...env,
+      ...(admitted.correlationId === undefined ? {} : { correlationId: admitted.correlationId }),
+    },
     io,
     extraArgs,
     lease,
@@ -553,7 +574,10 @@ export async function runPublicReviewerResume(
 
   return await dispatchAdmittedReviewer({
     admitted,
-    env,
+    env: {
+      ...env,
+      ...(admitted.correlationId === undefined ? {} : { correlationId: admitted.correlationId }),
+    },
     io,
     extraArgs,
     lease,

package/src/public-cli/run-lifecycle.ts

@@ -12,6 +12,15 @@ import {
   resolveActivationLedgerHome,
 } from "../activation-ledger-topology.ts";
 import { CliUsageError } from "./cli-errors.ts";
+import {
+  readLatestTypedProviderHttpObservation,
+} from "../typed-provider-http.ts";
+export {
+  clearTypedProviderHttpObservation,
+  recordTypedProviderHttpStatus,
+  readLatestTypedProviderHttpObservation,
+  type TypedProviderHttpObservation,
+} from "../typed-provider-http.ts";
 import type { FixerPhase } from "../package-contracts/fixer-output.ts";
 import type { FixerPrerequisite } from "../package-contracts/fixer-packet.ts";
 import {
@@ -65,7 +74,6 @@ export type RoleRunRecord = {
 export const RESUME_TRANSPORT_ENVELOPE = "[ak-role:resume-continue]" as const;
 
 const RUN_STATE_FILE = "run-state.json";
-const TYPED_HTTP_FILE = "typed-provider-http.json";
 const WRITER_LOCK_FILE = "writer.lock";
 
 export function isV1ResumableProvider(
@@ -74,84 +82,14 @@ export function isV1ResumableProvider(
   return (V1_RESUMABLE_PROVIDERS as readonly string[]).includes(provider);
 }
 
-function typedProviderHttpPath(runDirectory: string): string {
-  return join(runDirectory, TYPED_HTTP_FILE);
-}
-
-/**
- * Clear any prior attempt's typed provider HTTP observation.
- * Each initial/resume dispatch must start without inherited 429 evidence so
- * only the current attempt can qualify v1 resume.
- */
-export async function clearTypedProviderHttpObservation(
-  runDirectory: string,
-): Promise<void> {
-  try {
-    await unlink(typedProviderHttpPath(runDirectory));
-  } catch (error) {
-    if (
-      error instanceof Error &&
-      "code" in error &&
-      (error as { code?: unknown }).code === "ENOENT"
-    ) {
-      return;
-    }
-    throw error;
-  }
-}
-
-/**
- * Record a typed provider HTTP status observation for the admitted run.
- * The latest observation is authoritative: only a current HTTP 429 from
- * Codex/xAI is retained for v1 resume; any other status or provider clears
- * prior within-attempt 429 evidence. Never inspects diagnostic prose.
- */
-export async function recordTypedProviderHttpStatus(
-  runDirectory: string,
-  observation: { readonly httpStatus: number; readonly provider: string },
-): Promise<void> {
-  if (
-    observation.httpStatus === 429 &&
-    isV1ResumableProvider(observation.provider)
-  ) {
-    const body: TypedHttp429Observation = {
-      httpStatus: 429,
-      provider: observation.provider,
-    };
-    await writeFile(
-      typedProviderHttpPath(runDirectory),
-      `${JSON.stringify(body)}\n`,
-      "utf8",
-    );
-    return;
-  }
-  // Non-qualifying latest response supersedes any earlier 429 in this attempt.
-  await clearTypedProviderHttpObservation(runDirectory);
-}
-
-/**
- * Read a durable typed HTTP 429 observation. Returns undefined unless both
- * httpStatus === 429 and provider is a v1-resumable provider are present as
- * typed fields (never inferred from prose).
- */
 export async function readTypedHttp429Observation(
   runDirectory: string,
 ): Promise<TypedHttp429Observation | undefined> {
-  try {
-    const raw: unknown = JSON.parse(
-      await readFile(typedProviderHttpPath(runDirectory), "utf8"),
-    );
-    if (raw === null || typeof raw !== "object" || Array.isArray(raw)) {
-      return undefined;
-    }
-    const record = raw as Record<string, unknown>;
-    if (record.httpStatus !== 429) return undefined;
-    if (typeof record.provider !== "string") return undefined;
-    if (!isV1ResumableProvider(record.provider)) return undefined;
-    return { httpStatus: 429, provider: record.provider };
-  } catch {
-    return undefined;
-  }
+  const observation = await readLatestTypedProviderHttpObservation(runDirectory);
+  if (observation === undefined) return undefined;
+  if (observation.httpStatus !== 429) return undefined;
+  if (!isV1ResumableProvider(observation.provider)) return undefined;
+  return { httpStatus: 429, provider: observation.provider };
 }
 
 /**
@@ -453,8 +391,40 @@ type LoadedAdmittedRequestFields = {
   readonly baseRevision?: string;
   readonly mergerInputPath?: string;
   readonly derived?: DerivedMergerEnvelope;
+  readonly correlationId?: string;
+  readonly ticketNumber?: number;
 };
 
+/** Restore optional correlation + typed ticketNumber from a durable admitted page. */
+function parsePersistedTicketIdentity(
+  record: Record<string, unknown>,
+): { correlationId?: string; ticketNumber?: number } {
+  const correlationId =
+    typeof record.correlationId === "string" && record.correlationId.trim() !== ""
+      ? record.correlationId
+      : undefined;
+  const ticketNumber =
+    typeof record.ticketNumber === "number" &&
+    Number.isInteger(record.ticketNumber) &&
+    record.ticketNumber >= 1
+      ? record.ticketNumber
+      : undefined;
+  return {
+    ...(correlationId === undefined ? {} : { correlationId }),
+    ...(ticketNumber === undefined ? {} : { ticketNumber }),
+  };
+}
+
+function restoredTicketFields(fields: LoadedAdmittedRequestFields): {
+  correlationId?: string;
+  ticketNumber?: number;
+} {
+  return {
+    ...(fields.correlationId === undefined ? {} : { correlationId: fields.correlationId }),
+    ...(fields.ticketNumber === undefined ? {} : { ticketNumber: fields.ticketNumber }),
+  };
+}
+
 async function loadResumableRunRecord(
   home: string,
   runId: string,
@@ -495,6 +465,8 @@ async function loadResumableRunRecord(
   let baseRevision: string | undefined;
   let mergerInputPath: string | undefined;
   let derived: DerivedMergerEnvelope | undefined;
+  let correlationId: string | undefined;
+  let ticketNumber: number | undefined;
   try {
     const raw: unknown = JSON.parse(
       await readFile(run.admittedRequestPath, "utf8"),
@@ -564,12 +536,46 @@ async function loadResumableRunRecord(
           };
         }
       }
+      const fromAdmitted = parsePersistedTicketIdentity(record);
+      correlationId = fromAdmitted.correlationId;
+      ticketNumber = fromAdmitted.ticketNumber;
     }
   } catch {
     throw new CliUsageError(
       `role run admitted request is unreadable: ${runId}`,
     );
   }
+  if (correlationId === undefined || ticketNumber === undefined) {
+    try {
+      const invocationRaw: unknown = JSON.parse(
+        await readFile(join(run.runDirectory, "invocation.json"), "utf8"),
+      );
+      if (
+        invocationRaw !== null &&
+        typeof invocationRaw === "object" &&
+        !Array.isArray(invocationRaw)
+      ) {
+        const fromInvocation = parsePersistedTicketIdentity(
+          invocationRaw as Record<string, unknown>,
+        );
+        if (correlationId === undefined) correlationId = fromInvocation.correlationId;
+        if (ticketNumber === undefined) ticketNumber = fromInvocation.ticketNumber;
+      }
+    } catch (error) {
+      if (
+        !(
+          error instanceof Error &&
+          "code" in error &&
+          (error as { code?: unknown }).code === "ENOENT"
+        )
+      ) {
+        throw new CliUsageError(
+          `role run invocation identity is unreadable: ${runId}`,
+          { cause: error },
+        );
+      }
+    }
+  }
   return {
     run,
     observation: run.resumable,
@@ -585,6 +591,8 @@ async function loadResumableRunRecord(
       ...(baseRevision === undefined ? {} : { baseRevision }),
       ...(mergerInputPath === undefined ? {} : { mergerInputPath }),
       ...(derived === undefined ? {} : { derived }),
+      ...(correlationId === undefined ? {} : { correlationId }),
+      ...(ticketNumber === undefined ? {} : { ticketNumber }),
     },
   };
 }
@@ -639,6 +647,7 @@ export async function loadResumableJudgeRun(
     sessionDirectory: loaded.run.sessionDirectory,
     sessionFile: loaded.run.sessionFile,
     admittedRequestPath: loaded.run.admittedRequestPath,
+    ...restoredTicketFields(loaded.admittedFields),
   };
   return {
     admitted,
@@ -692,6 +701,7 @@ export async function loadResumableCoderRun(
     sessionFile: loaded.run.sessionFile,
     admittedRequestPath: loaded.run.admittedRequestPath,
     taskPath,
+    ...restoredTicketFields(loaded.admittedFields),
   };
   return {
     admitted,
@@ -750,6 +760,7 @@ export async function loadResumableFixerRun(
       ? {}
       : { prerequisitesPath: loaded.admittedFields.prerequisitesPath }),
     prerequisites,
+    ...restoredTicketFields(loaded.admittedFields),
   };
   return {
     admitted,
@@ -795,6 +806,7 @@ export async function loadResumableReviewerRun(
     sessionFile: loaded.run.sessionFile,
     admittedRequestPath: loaded.run.admittedRequestPath,
     baseRevision,
+    ...restoredTicketFields(loaded.admittedFields),
   };
   return {
     admitted,
@@ -854,6 +866,7 @@ export async function loadResumableMergerRun(
     admittedRequestPath: loaded.run.admittedRequestPath,
     mergerInputPath,
     derived,
+    ...restoredTicketFields(loaded.admittedFields),
   };
   return {
     admitted,