@aitne/daemon 0.1.7 → 0.1.9

package/dist/api/routes/mcp.js

@@ -8,6 +8,7 @@ import { z } from "zod";
 import { BACKEND_IDS } from "@aitne/shared";
 import { createLogger, toSafeErrorMessage } from "../../logging.js";
 import { readJsonBody } from "../json-body.js";
+import { composeIssue, respondWithAgentError } from "../helpers/agent-errors.js";
 import { deleteAllMcpSecrets, deleteMcpServer, disableAllMcpServers, DuplicateMcpServerError, getMcpServer, insertMcpServer, InvalidMcpServerError, listMcpServers, McpServerNotFoundError, resolveMcpSecrets, saveMcpProbeResult, setMcpServerEnabled, setMcpSecret, updateMcpServer, } from "../../services/mcp/registry.js";
 import { McpServerIdSchema, MCP_RISK_TIERS, MCP_TRANSPORTS, } from "../../services/mcp/types.js";
 import { probeMcpServer } from "../../services/mcp/probe.js";
@@ -86,8 +87,11 @@ export function createMcpRoutes(deps) {
     app.get("/mcp/servers/:id", async (c) => {
         const id = c.req.param("id");
         const server = getMcpServer(db, id);
-        if (!server)
-            return c.json({ error: "not_found" }, 404);
+        if (!server) {
+            return respondWithAgentError(c, 404, [
+                composeIssue("mcp.not_found", { field: "id", received: id }),
+            ]);
+        }
         return c.json({ server: await withSecretPresence(server) });
     });
     // ── POST /mcp/servers ──
@@ -97,7 +101,7 @@ export function createMcpRoutes(deps) {
             return parsed.response;
         const validated = CreateInputSchema.safeParse(parsed.body);
         if (!validated.success) {
-            return c.json({ error: "invalid_input", issues: validated.error.issues }, 400);
+            return respondWithAgentError(c, 400, [composeIssue("mcp.invalid_input", { field: "body", received: parsed.body })], { legacyFields: { issues: validated.error.issues } });
         }
         return withWriteLock(async () => {
             try {
@@ -106,13 +110,24 @@ export function createMcpRoutes(deps) {
             }
             catch (err) {
                 if (err instanceof DuplicateMcpServerError) {
-                    return c.json({ error: "duplicate", message: err.message }, 409);
+                    return respondWithAgentError(c, 409, [composeIssue("mcp.duplicate", { field: "id", received: validated.data.id })], { legacyFields: { message: err.message } });
                 }
                 if (err instanceof InvalidMcpServerError) {
-                    return c.json({ error: "invalid_input", message: err.message }, 400);
+                    return respondWithAgentError(c, 400, [
+                        composeIssue("mcp.invalid_input", {
+                            field: "body",
+                            received: err.message,
+                            expected: err.message,
+                        }),
+                    ], { legacyFields: { message: err.message } });
                 }
                 logger.error({ err }, "insertMcpServer failed");
-                return c.json({ error: "internal_error" }, 500);
+                return respondWithAgentError(c, 500, [
+                    composeIssue("mcp.internal_error", {
+                        field: "insert",
+                        received: toSafeErrorMessage(err),
+                    }),
+                ]);
             }
         });
     });
@@ -124,13 +139,16 @@ export function createMcpRoutes(deps) {
             return parsed.response;
         const validated = PatchInputSchema.safeParse(parsed.body);
         if (!validated.success) {
-            return c.json({ error: "invalid_input", issues: validated.error.issues }, 400);
+            return respondWithAgentError(c, 400, [composeIssue("mcp.invalid_input", { field: "body", received: parsed.body })], { legacyFields: { issues: validated.error.issues } });
         }
         return withWriteLock(async () => {
             try {
                 const before = getMcpServer(db, id);
-                if (!before)
-                    return c.json({ error: "not_found" }, 404);
+                if (!before) {
+                    return respondWithAgentError(c, 404, [
+                        composeIssue("mcp.not_found", { field: "id", received: id }),
+                    ]);
+                }
                 const updated = updateMcpServer(db, id, validated.data);
                 // Prune secret blobs for keys that were removed from env_keys/header_keys.
                 const beforeKeys = new Set([...before.envKeys, ...before.headerKeys]);
@@ -148,14 +166,27 @@ export function createMcpRoutes(deps) {
                    one Hono handler, so the branch exists for future schema-level
                    triggers that might delete the row async. */
                 if (err instanceof McpServerNotFoundError) {
-                    return c.json({ error: "not_found" }, 404);
+                    return respondWithAgentError(c, 404, [
+                        composeIssue("mcp.not_found", { field: "id", received: id }),
+                    ]);
                 }
                 /* c8 ignore stop */
                 if (err instanceof InvalidMcpServerError) {
-                    return c.json({ error: "invalid_input", message: err.message }, 400);
+                    return respondWithAgentError(c, 400, [
+                        composeIssue("mcp.invalid_input", {
+                            field: "body",
+                            received: err.message,
+                            expected: err.message,
+                        }),
+                    ], { legacyFields: { message: err.message } });
                 }
                 logger.error({ err, id }, "updateMcpServer failed");
-                return c.json({ error: "internal_error" }, 500);
+                return respondWithAgentError(c, 500, [
+                    composeIssue("mcp.internal_error", {
+                        field: "update",
+                        received: toSafeErrorMessage(err),
+                    }),
+                ]);
             }
         });
     });
@@ -164,15 +195,21 @@ export function createMcpRoutes(deps) {
         const id = c.req.param("id");
         return withWriteLock(async () => {
             const before = getMcpServer(db, id);
-            if (!before)
-                return c.json({ error: "not_found" }, 404);
+            if (!before) {
+                return respondWithAgentError(c, 404, [
+                    composeIssue("mcp.not_found", { field: "id", received: id }),
+                ]);
+            }
             const keys = [...before.envKeys, ...before.headerKeys];
             const deleted = deleteMcpServer(db, id);
             /* c8 ignore start — TOCTOU race: row removed between the SELECT above
                and the DELETE statement. Cannot happen under a single better-sqlite3
                writer, so the branch is unreachable in tests but kept as defense. */
-            if (!deleted)
-                return c.json({ error: "not_found" }, 404);
+            if (!deleted) {
+                return respondWithAgentError(c, 404, [
+                    composeIssue("mcp.not_found", { field: "id", received: id }),
+                ]);
+            }
             /* c8 ignore stop */
             if (keys.length > 0) {
                 await deleteAllMcpSecrets(blobStore, id, keys);
@@ -184,13 +221,20 @@ export function createMcpRoutes(deps) {
     app.post("/mcp/servers/:id/probe", async (c) => {
         const id = c.req.param("id");
         const server = getMcpServer(db, id);
-        if (!server)
-            return c.json({ error: "not_found" }, 404);
+        if (!server) {
+            return respondWithAgentError(c, 404, [
+                composeIssue("mcp.not_found", { field: "id", received: id }),
+            ]);
+        }
         if (!server.enabled) {
-            return c.json({
-                error: "server_disabled",
-                message: "Enable the MCP server before probing it.",
-            }, 409);
+            return respondWithAgentError(c, 409, [
+                composeIssue("mcp.server_disabled", {
+                    field: "enabled",
+                    received: false,
+                }),
+            ], {
+                legacyFields: { message: "Enable the MCP server before probing it." },
+            });
         }
         const rawSecrets = await resolveMcpSecrets(blobStore, server);
         const secrets = {};
@@ -205,7 +249,8 @@ export function createMcpRoutes(deps) {
         }
         catch (err) {
             logger.error({ err, id }, "probeMcpServer threw unexpectedly");
-            return c.json({ error: "probe_failed", message: toSafeErrorMessage(err) }, 500);
+            const message = toSafeErrorMessage(err);
+            return respondWithAgentError(c, 500, [composeIssue("mcp.probe_failed", { field: "probe", received: message })], { legacyFields: { message } });
         }
     });
     // ── POST /mcp/servers/:id/enable | /disable ──
@@ -218,7 +263,9 @@ export function createMcpRoutes(deps) {
             }
             catch (err) {
                 if (err instanceof McpServerNotFoundError) {
-                    return c.json({ error: "not_found" }, 404);
+                    return respondWithAgentError(c, 404, [
+                        composeIssue("mcp.not_found", { field: "id", received: id }),
+                    ]);
                 }
                 throw err;
             }
@@ -254,7 +301,9 @@ export function createMcpRoutes(deps) {
             }
             catch (err) {
                 if (err instanceof McpServerNotFoundError) {
-                    return c.json({ error: "not_found" }, 404);
+                    return respondWithAgentError(c, 404, [
+                        composeIssue("mcp.not_found", { field: "id", received: id }),
+                    ]);
                 }
                 throw err;
             }
@@ -279,8 +328,11 @@ export function createMcpRoutes(deps) {
     app.get("/mcp/servers/:id/activity", (c) => {
         const id = c.req.param("id");
         const server = getMcpServer(db, id);
-        if (!server)
-            return c.json({ error: "not_found" }, 404);
+        if (!server) {
+            return respondWithAgentError(c, 404, [
+                composeIssue("mcp.not_found", { field: "id", received: id }),
+            ]);
+        }
         const limitParam = Number(c.req.query("limit") ?? "20");
         const limit = Number.isFinite(limitParam) ? Math.min(Math.max(1, limitParam), 100) : 20;
         const calls = listMcpToolCalls(db, id, limit);
@@ -292,21 +344,31 @@ export function createMcpRoutes(deps) {
         const id = c.req.param("id");
         const keyName = c.req.param("keyName");
         const server = getMcpServer(db, id);
-        if (!server)
-            return c.json({ error: "not_found" }, 404);
+        if (!server) {
+            return respondWithAgentError(c, 404, [
+                composeIssue("mcp.not_found", { field: "id", received: id }),
+            ]);
+        }
         const keys = new Set([...server.envKeys, ...server.headerKeys]);
         if (!keys.has(keyName)) {
-            return c.json({
-                error: "unknown_key",
-                message: `keyName must be declared in envKeys/headerKeys: ${keyName}`,
-            }, 400);
+            return respondWithAgentError(c, 400, [
+                composeIssue("mcp.unknown_key", {
+                    field: "keyName",
+                    received: keyName,
+                    expected: `one of ${[...keys].join(", ")}`,
+                }),
+            ], {
+                legacyFields: {
+                    message: `keyName must be declared in envKeys/headerKeys: ${keyName}`,
+                },
+            });
         }
         const parsed = await readJsonBody(c);
         if (!parsed.ok)
             return parsed.response;
         const validated = SecretInputSchema.safeParse(parsed.body);
         if (!validated.success) {
-            return c.json({ error: "invalid_input", issues: validated.error.issues }, 400);
+            return respondWithAgentError(c, 400, [composeIssue("mcp.invalid_input", { field: "body", received: parsed.body })], { legacyFields: { issues: validated.error.issues } });
         }
         await setMcpSecret(blobStore, id, keyName, validated.data.value);
         return c.json({ status: "saved" });
@@ -316,8 +378,11 @@ export function createMcpRoutes(deps) {
         const id = c.req.param("id");
         const keyName = c.req.param("keyName");
         const server = getMcpServer(db, id);
-        if (!server)
-            return c.json({ error: "not_found" }, 404);
+        if (!server) {
+            return respondWithAgentError(c, 404, [
+                composeIssue("mcp.not_found", { field: "id", received: id }),
+            ]);
+        }
         await deleteAllMcpSecrets(blobStore, id, [keyName]);
         return c.json({ status: "deleted" });
     });
@@ -352,7 +417,7 @@ export function createMcpRoutes(deps) {
             .object({ kind: z.enum(["google-workspace", "notion"]) })
             .safeParse(parsed.body);
         if (!validated.success) {
-            return c.json({ error: "invalid_input", issues: validated.error.issues }, 400);
+            return respondWithAgentError(c, 400, [composeIssue("mcp.invalid_input", { field: "body", received: parsed.body })], { legacyFields: { issues: validated.error.issues } });
         }
         const { kind } = validated.data;
         const args = GEMINI_INSTALL_COMMANDS[kind];
@@ -389,16 +454,19 @@ export function createMcpRoutes(deps) {
             // dashboard can show OAuth-required / version-mismatch hints.
             const e = err;
             logger.warn({ kind, args, code: e.code, message }, "gemini install command failed");
-            return c.json({
-                ok: false,
-                kind,
-                command: ["gemini", ...args].join(" "),
-                error: e.code === "ENOENT" ? "gemini_cli_not_found" : "install_failed",
-                message,
-                stdout: e.stdout ?? "",
-                stderr: e.stderr ?? "",
-                exitCode: typeof e.code === "number" ? e.code : null,
-            }, e.code === "ENOENT" ? 503 : 502);
+            const code = e.code === "ENOENT" ? "mcp.gemini_cli_not_found" : "mcp.install_failed";
+            const status = e.code === "ENOENT" ? 503 : 502;
+            return respondWithAgentError(c, status, [composeIssue(code, { field: "gemini", received: message })], {
+                legacyFields: {
+                    ok: false,
+                    kind,
+                    command: ["gemini", ...args].join(" "),
+                    message,
+                    stdout: e.stdout ?? "",
+                    stderr: e.stderr ?? "",
+                    exitCode: typeof e.code === "number" ? e.code : null,
+                },
+            });
         }
     });
     return app;
@@ -467,4 +535,3 @@ const GEMINI_INSTALL_COMMANDS = {
         "https://mcp.notion.com/mcp",
     ],
 };
-//# sourceMappingURL=mcp.js.map

package/dist/api/routes/metrics.d.ts

@@ -8,7 +8,6 @@ import type { ApiDependencies } from "../server.js";
  * GET /metrics/auth               — auth telemetry counters (Phase 8 dashboard)
  * GET /metrics/delegated-task     — DELEGATED-TASK-MODE-DESIGN.md §11.2
  * GET /metrics/managed-tasks      — docs/design/21 §14.3 (Phase 8)
- * GET /metrics/pre-pass           — PRE_PASS_FAN_OUT_DESIGN.md §7.3
+ * GET /metrics/pre-pass           — docs/design/appendices/pre-pass-fan-out.md §7.3
  */
 export declare function createMetricsRoutes(deps: ApiDependencies): Hono;
-//# sourceMappingURL=metrics.d.ts.map

package/dist/api/routes/metrics.js

@@ -9,7 +9,7 @@ import { MetricsCollector } from "../../core/metrics.js";
  * GET /metrics/auth               — auth telemetry counters (Phase 8 dashboard)
  * GET /metrics/delegated-task     — DELEGATED-TASK-MODE-DESIGN.md §11.2
  * GET /metrics/managed-tasks      — docs/design/21 §14.3 (Phase 8)
- * GET /metrics/pre-pass           — PRE_PASS_FAN_OUT_DESIGN.md §7.3
+ * GET /metrics/pre-pass           — docs/design/appendices/pre-pass-fan-out.md §7.3
  */
 export function createMetricsRoutes(deps) {
     const app = new Hono();
@@ -114,7 +114,7 @@ export function createMetricsRoutes(deps) {
         }));
     });
     /**
-     * GET /metrics/pre-pass — PRE_PASS_FAN_OUT_DESIGN.md §7.3.
+     * GET /metrics/pre-pass — docs/design/appendices/pre-pass-fan-out.md §7.3.
      *
      * Aggregates `routine.fetch_window` audit rows (one per attempt per
      * integration per parent routine) into the four §7.3 metric families:
@@ -138,4 +138,3 @@ export function createMetricsRoutes(deps) {
     });
     return app;
 }
-//# sourceMappingURL=metrics.js.map

package/dist/api/routes/notion.d.ts

@@ -32,4 +32,3 @@ export interface NotionRouteDependencies {
  * | DELETE | /notion/pages/:id                   | Autonomous | Archive (move to trash, 30-day recovery)   |
  */
 export declare function createNotionRoutes(deps: NotionRouteDependencies): Hono;
-//# sourceMappingURL=notion.d.ts.map