@aisdlc/core 1.2.0 → 1.3.0

package/dist/index.cjs

@@ -148,17 +148,31 @@ function calculateLocAndHalstead(fullText, cyclomatic) {
   const normalizedMI = Math.max(0, Math.min(100, rawMI * 100 / 171));
   return { loc, mi: Math.round(normalizedMI * 10) / 10 };
 }
-function detectAstCodeSmells(node, loc, nodeText) {
+var TEST_FILE_PATTERN = /(?:^|\/)(?:tests|__tests__|fixtures)\/|\.(?:spec|test)\.[cm]?[jt]sx?$/i;
+var EMPTY_UI_HANDLER_PATTERN = /\bon[A-Z]\w*\s*=\s*\{\s*(?:\([^)]*\)\s*=>\s*\{\s*\}|function\s*\([^)]*\)\s*\{\s*\})\s*\}/;
+var FAKE_WIRING_STUB_PATTERN = /(?:\/\/\s*T[O]DO:\s*(?:connect|wire|integrate)\b|\b(?:m[o]ckData|F[A]KE_DATA)\b)/i;
+function isProductionFile(filePath) {
+  return !TEST_FILE_PATTERN.test(filePath.replace(/\\/g, "/"));
+}
+function detectAstCodeSmells(node, loc, fullText, filePath) {
   const smells = [];
   if (node.getDescendantsOfKind(tsMorph.SyntaxKind.AnyKeyword).length > 0) {
     smells.push('Uso prohibido de "any"');
   }
-  if (/\/\/\s*@ts-ignore|\/\/\s*eslint-disable/.test(nodeText)) {
+  if (/\/\/\s*@ts-ignore|\/\/\s*eslint-disable/.test(fullText)) {
     smells.push("Supresi\xF3n no autorizada de linter");
   }
   if (loc > 40) {
     smells.push(`Funci\xF3n extensa (${loc} l\xEDneas > l\xEDmite 40)`);
   }
+  if (isProductionFile(filePath)) {
+    if (EMPTY_UI_HANDLER_PATTERN.test(fullText)) {
+      smells.push("Handler de UI vac\xEDo (fake-wiring detectado)");
+    }
+    if (FAKE_WIRING_STUB_PATTERN.test(fullText)) {
+      smells.push("Datos simulados o conexi\xF3n pendiente en producci\xF3n (fake-wiring)");
+    }
+  }
   return smells;
 }
 function isDeclarationFunction(node) {
@@ -182,9 +196,8 @@ function buildNodeMetrics(node, filePath) {
   const cyclomatic = computeCyclomaticFromAst(node);
   const cognitive = computeCognitiveFromAst(node);
   const fullText = node.getFullText();
-  const nodeText = node.getText();
   const { loc, mi } = calculateLocAndHalstead(fullText, cyclomatic);
-  const codeSmells = detectAstCodeSmells(node, loc, nodeText);
+  const codeSmells = detectAstCodeSmells(node, loc, fullText, filePath);
   return { functionName, filePath, loc, cyclomatic, cognitive, maintainability: mi, codeSmells };
 }
 function buildModuleFallback(content, filePath) {
@@ -9313,6 +9326,7 @@ var SPECIALIZED_AGENT_TEMPLATES = [
 
 ## Operational Directives & Guardrails
 - Decompose the system into building blocks \`CMP-*\` ensuring each component declares which use cases \`UC-*\` it implements and which requirements (\`FR-*\`, \`QR-*\`, \`SEC-REQ-*\`) it fulfills under \`satisfies-requirements\`.
+- **Contract-First Full-Stack Integration**: Whenever a feature or change spans Frontend (UI) and Backend (API/services), define an explicit shared typed contract (Zod schemas, shared TypeScript DTOs, or OpenAPI specification) in \`design.md\` before implementation so both layers compile against a single source of truth.
 - Generate interaction and sequence diagrams in native Mermaid syntax.
 - Document critical technological decisions using immutable \`ADR-*\` records conforming to \`schemas/architecture/adr.schema.json\`.
 - Validate that architectural choices comply with legal constraints in \`license-policy.yaml\`.
@@ -9335,6 +9349,7 @@ var SPECIALIZED_AGENT_TEMPLATES = [
   2. **Boundary Cases** (\`Scenario Outline\` + \`Examples\` table): values at the extremes of the accepted range.
   3. **Out-of-Range / Invalid Cases** (\`Scenario Outline\` + \`Examples\` table): null, empty, wrong types, values exceeding bounds.
 - Apply conditional categories when applicable: Security (\`@security @mitigation\`), Performance (\`@performance\`), Idempotency (\`@idempotence\`), Postconditions, and Interface Contracts.
+- **Zero-Mock Integration Rule**: When an \`FR-*\` spans UI and Backend, unit tests mocking \`fetch\`/HTTP in isolation are insufficient; include integration/contract or E2E test scenarios verifying real request/response wiring and UI state transitions (\`Loading\`, \`Empty\`, \`Error\`, \`Nominal\`).
 - Tag all scenarios with \`@<FR-ID> @automated @regression\`.
 - **STRICTLY FORBIDDEN**: Including production code, suggesting implementation, or anticipating technical solutions.
 - Run \`pnpm run verify:testing\` before emitting handoff.
@@ -9353,6 +9368,9 @@ var SPECIALIZED_AGENT_TEMPLATES = [
 - Respect the autonomy mode assigned to each task in \`tasks.md\` (\`AUTONOMOUS\`, \`HUMAN_REVIEW_PLAN\`, \`AMBIGUOUS\`, \`HIGH_RISK_MANUAL\`).
 - Apply Test-Driven Development (TDD): make failing tests delivered by \`agent-qa-engineer\` pass green without altering tests to accommodate buggy code.
 - Cite implemented \`FR-*\` or \`SEC-REQ-*\` IDs in test header comments to maintain 360\xB0 reverse traceability.
+- **Zero Fake-Wiring Guardrail**: Strictly forbidden from marking a task \`COMPLETED\` with hardcoded \`mockData\` arrays in production views, \`setTimeout\` simulating network calls, or empty UI event handlers (\`onClick={() => {}}\`, \`onSubmit={() => {}}\`). Frontend components must wire directly to the shared contract and real Backend endpoints.
+- **Mandatory 4 UI States Matrix**: Every data-driven UI component or screen must explicitly implement all 4 usability states: \`Loading\` (spinner/skeleton + disabled submit), \`Empty\` (clear message + CTA), \`Error\` (visible error recovery banner, never silent failure), and \`Nominal/Success\` (accessible semantic DOM + keyboard navigation).
+- **Live Runtime Smoke Verification**: For tasks touching UI or UI-to-Backend integration, unit tests alone are insufficient. Before emitting handoff, boot the real Backend and Frontend servers and verify (via Playwright E2E or Chrome DevTools MCP) that browser \`console.error\` and \`pageerror\` counts are \`0\` and API calls return real \`2xx\` responses without CORS or schema mismatches.
 - Before adding any external dependency, verify its SPDX license is permitted in \`license-policy.yaml\`.
 - Respect non-negotiable \`quality-policy.yaml\` thresholds: Cyclomatic Complexity $\\le 10$, Cognitive Complexity $\\le 15$, Maintainability Index $\\ge 50$, Function Length $\\le 40$ lines.
 - Run unified pre-flight with auto-fix (\`pnpm run check:fix\`) and full verification (\`pnpm run verify:all\`).
@@ -9401,9 +9419,9 @@ var SPECIALIZED_AGENT_TEMPLATES = [
 ## Operational Directives & Guardrails
 - Operate under bimodal discipline depending on the lifecycle phase:
   1. **Design Mode (Upstream)**: Adopt the primary actor persona under real-world field conditions (stress, latency, constrained viewports). Separate strict Minimum Viable Product (MVP) core from future roadmap ideas using \`templates/product/user-design-feedback.template.md\`.
-  2. **Functional Validation Mode (Downstream / Pre-PR / Post-Development Functional Validation)**: Inspect \`agent-developer\` deliverables once unit tests pass green. Contrast actual UI, CLI, and API behavior against approved \`UC-*\` and \`FR-*\` criteria.
+  2. **Functional Validation Mode (Downstream / Pre-PR / Post-Development Functional Validation)**: Inspect \`agent-developer\` deliverables once unit tests pass green by executing the real application (via Playwright or Chrome DevTools MCP when UI is present). Contrast actual UI, CLI, and API behavior against approved \`UC-*\` and \`FR-*\` criteria, verifying real Backend connectivity, the 4 UI usability states (\`Loading\`, \`Empty\`, \`Error\`, \`Nominal\`), keyboard/ARIA accessibility, and \`0\` browser \`console.error\` / network failures.
 - Formulate decisive questions under \`open-questions\` for the human Product Owner.
-- Emit handoff block suggesting the Pre-Merge Audit Triad (\`agent-code-reviewer\`, \`agent-security-auditor\`, \`agent-compliance-checker\`) if compliant, or return to \`agent-developer\` on functional drift.`
+- Emit handoff block suggesting the Pre-Merge Audit Triad (\`agent-code-reviewer\`, \`agent-security-auditor\`, \`agent-compliance-checker\`) if compliant, or return to \`agent-developer\` on functional drift or fake-wiring.`
   },
   {
     id: "agent-code-reviewer",
@@ -9418,6 +9436,7 @@ var SPECIALIZED_AGENT_TEMPLATES = [
 - Analyze code diffs against \`quality-policy.yaml\` standards: Cyclomatic Complexity $\\le 10$, Cognitive Complexity $\\le 15$, Maintainability Index $\\ge 50$, Lines per Function $\\le 40$.
 - Detect improper coupling, code smells, magic numbers, ambiguous identifiers, and encapsulation breaches.
 - Flag premature abstractions and speculative code violating YAGNI.
+- **Block Fake-Wiring & Disconnected UI**: Flag as \`[BLOCKING]\` any production UI component containing hardcoded mock data (\`mockData\`), empty event handlers (\`onClick={() => {}}\`), missing error/loading state handling, or API calls bypassing shared contracts.
 - Coordinate Pre-Merge Audit Triad with \`agent-security-auditor\` and \`agent-compliance-checker\`.
 - Categorize findings into: \`[BLOCKING]\` (quality violation or broken pattern), \`[CLEAN_CODE_SUGGESTION]\` (non-blocking improvement), and \`[COMPLIANT]\`.
 - If autonomy is $\\ge$ \`HUMAN_REVIEW_PLAN\`, conclude by emitting the Workflow Handoff block (\`templates/workflow/agent-handoff.template.md\`) to the human Tech Lead for final approval and merge, opening the Human Action Window. In \`AUTONOMOUS\` mode, omit interactive handoff.`