@aiready/consistency 0.6.6 → 0.6.8

package/dist/cli.js

@@ -29,10 +29,6 @@ var import_commander = require("commander");
 // src/analyzer.ts
 var import_core3 = require("@aiready/core");
 
-// src/analyzers/naming-ast.ts
-var import_core = require("@aiready/core");
-var import_path = require("path");
-
 // src/utils/ast-parser.ts
 var import_typescript_estree = require("@typescript-eslint/typescript-estree");
 var import_fs = require("fs");
@@ -457,6 +453,10 @@ function isAcceptableInContext(name, context, options) {
   return false;
 }
 
+// src/utils/config-loader.ts
+var import_core = require("@aiready/core");
+var import_path = require("path");
+
 // src/analyzers/naming-constants.ts
 var COMMON_SHORT_WORDS = /* @__PURE__ */ new Set([
   // Full English words (1-3 letters)
@@ -841,9 +841,8 @@ var ACCEPTABLE_ABBREVIATIONS = /* @__PURE__ */ new Set([
   "msg"
 ]);
 
-// src/analyzers/naming-ast.ts
-async function analyzeNamingAST(files) {
-  const issues = [];
+// src/utils/config-loader.ts
+async function loadNamingConfig(files) {
   const rootDir = files.length > 0 ? (0, import_path.dirname)(files[0]) : process.cwd();
   const config = await (0, import_core.loadConfig)(rootDir);
   const consistencyConfig = config?.tools?.["consistency"];
@@ -852,6 +851,19 @@ async function analyzeNamingAST(files) {
   const disabledChecks = new Set(consistencyConfig?.disableChecks || []);
   const allAbbreviations = /* @__PURE__ */ new Set([...ACCEPTABLE_ABBREVIATIONS, ...customAbbreviations]);
   const allShortWords = /* @__PURE__ */ new Set([...COMMON_SHORT_WORDS, ...customShortWords]);
+  return {
+    customAbbreviations,
+    customShortWords,
+    disabledChecks,
+    allAbbreviations,
+    allShortWords
+  };
+}
+
+// src/analyzers/naming-ast.ts
+async function analyzeNamingAST(files) {
+  const issues = [];
+  const { allAbbreviations, allShortWords, disabledChecks } = await loadNamingConfig(files);
   for (const file of files) {
     try {
       const ast = parseFile(file);
@@ -1177,7 +1189,7 @@ async function analyzeImportStyles(files) {
   for (const file of files) {
     const content = await (0, import_core2.readFileContent)(file);
     const hasESM = content.match(/^import\s+/m);
-    const hasCJS = content.match(/require\s*\(/);
+    const hasCJS = hasActualRequireCalls(content);
     if (hasESM && hasCJS) {
       patterns.mixed.push(file);
     } else if (hasESM) {
@@ -1213,6 +1225,15 @@ async function analyzeImportStyles(files) {
   }
   return issues;
 }
+function hasActualRequireCalls(content) {
+  let cleaned = content.replace(/\/\/.*$/gm, "");
+  cleaned = cleaned.replace(/\/\*[\s\S]*?\*\//g, "");
+  cleaned = cleaned.replace(/"[^"\n]*"/g, '""');
+  cleaned = cleaned.replace(/'[^'\n]*'/g, "''");
+  cleaned = cleaned.replace(/`[^`]*`/g, "``");
+  cleaned = cleaned.replace(/\/[^/\n]*require[^/\n]*\/[gimsuvy]*/g, "");
+  return /require\s*\(/.test(cleaned);
+}
 
 // src/analyzer.ts
 async function analyzeConsistency(options) {

package/dist/cli.mjs

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 import {
   analyzeConsistency
-} from "./chunk-WTBDNCEN.mjs";
+} from "./chunk-HPG7P6PD.mjs";
 
 // src/cli.ts
 import { Command } from "commander";

package/dist/index.js

@@ -31,10 +31,6 @@ module.exports = __toCommonJS(index_exports);
 // src/analyzer.ts
 var import_core3 = require("@aiready/core");
 
-// src/analyzers/naming-ast.ts
-var import_core = require("@aiready/core");
-var import_path = require("path");
-
 // src/utils/ast-parser.ts
 var import_typescript_estree = require("@typescript-eslint/typescript-estree");
 var import_fs = require("fs");
@@ -459,6 +455,10 @@ function isAcceptableInContext(name, context, options) {
   return false;
 }
 
+// src/utils/config-loader.ts
+var import_core = require("@aiready/core");
+var import_path = require("path");
+
 // src/analyzers/naming-constants.ts
 var COMMON_SHORT_WORDS = /* @__PURE__ */ new Set([
   // Full English words (1-3 letters)
@@ -854,9 +854,8 @@ function detectNamingConventions(files, allIssues) {
   return { dominantConvention: "camelCase", conventionScore: 0.9 };
 }
 
-// src/analyzers/naming-ast.ts
-async function analyzeNamingAST(files) {
-  const issues = [];
+// src/utils/config-loader.ts
+async function loadNamingConfig(files) {
   const rootDir = files.length > 0 ? (0, import_path.dirname)(files[0]) : process.cwd();
   const config = await (0, import_core.loadConfig)(rootDir);
   const consistencyConfig = config?.tools?.["consistency"];
@@ -865,6 +864,19 @@ async function analyzeNamingAST(files) {
   const disabledChecks = new Set(consistencyConfig?.disableChecks || []);
   const allAbbreviations = /* @__PURE__ */ new Set([...ACCEPTABLE_ABBREVIATIONS, ...customAbbreviations]);
   const allShortWords = /* @__PURE__ */ new Set([...COMMON_SHORT_WORDS, ...customShortWords]);
+  return {
+    customAbbreviations,
+    customShortWords,
+    disabledChecks,
+    allAbbreviations,
+    allShortWords
+  };
+}
+
+// src/analyzers/naming-ast.ts
+async function analyzeNamingAST(files) {
+  const issues = [];
+  const { allAbbreviations, allShortWords, disabledChecks } = await loadNamingConfig(files);
   for (const file of files) {
     try {
       const ast = parseFile(file);
@@ -1190,7 +1202,7 @@ async function analyzeImportStyles(files) {
   for (const file of files) {
     const content = await (0, import_core2.readFileContent)(file);
     const hasESM = content.match(/^import\s+/m);
-    const hasCJS = content.match(/require\s*\(/);
+    const hasCJS = hasActualRequireCalls(content);
     if (hasESM && hasCJS) {
       patterns.mixed.push(file);
     } else if (hasESM) {
@@ -1226,6 +1238,15 @@ async function analyzeImportStyles(files) {
   }
   return issues;
 }
+function hasActualRequireCalls(content) {
+  let cleaned = content.replace(/\/\/.*$/gm, "");
+  cleaned = cleaned.replace(/\/\*[\s\S]*?\*\//g, "");
+  cleaned = cleaned.replace(/"[^"\n]*"/g, '""');
+  cleaned = cleaned.replace(/'[^'\n]*'/g, "''");
+  cleaned = cleaned.replace(/`[^`]*`/g, "``");
+  cleaned = cleaned.replace(/\/[^/\n]*require[^/\n]*\/[gimsuvy]*/g, "");
+  return /require\s*\(/.test(cleaned);
+}
 
 // src/analyzer.ts
 async function analyzeConsistency(options) {
@@ -1375,15 +1396,9 @@ function generateRecommendations(namingIssues, patternIssues) {
 
 // src/analyzers/naming.ts
 var import_core4 = require("@aiready/core");
-var import_path2 = require("path");
 async function analyzeNaming(files) {
   const issues = [];
-  const rootDir = files.length > 0 ? (0, import_path2.dirname)(files[0]) : process.cwd();
-  const config = await (0, import_core4.loadConfig)(rootDir);
-  const consistencyConfig = config?.tools?.["consistency"];
-  const customAbbreviations = new Set(consistencyConfig?.acceptedAbbreviations || []);
-  const customShortWords = new Set(consistencyConfig?.shortWords || []);
-  const disabledChecks = new Set(consistencyConfig?.disableChecks || []);
+  const { customAbbreviations, customShortWords, disabledChecks } = await loadNamingConfig(files);
   for (const file of files) {
     const content = await (0, import_core4.readFileContent)(file);
     const fileIssues = analyzeFileNaming(file, content, customAbbreviations, customShortWords, disabledChecks);

package/dist/index.mjs

@@ -5,20 +5,15 @@ import {
   analyzeNamingAST,
   analyzePatterns,
   detectNamingConventions,
+  loadNamingConfig,
   snakeCaseToCamelCase
-} from "./chunk-WTBDNCEN.mjs";
+} from "./chunk-HPG7P6PD.mjs";
 
 // src/analyzers/naming.ts
-import { readFileContent, loadConfig } from "@aiready/core";
-import { dirname } from "path";
+import { readFileContent } from "@aiready/core";
 async function analyzeNaming(files) {
   const issues = [];
-  const rootDir = files.length > 0 ? dirname(files[0]) : process.cwd();
-  const config = await loadConfig(rootDir);
-  const consistencyConfig = config?.tools?.["consistency"];
-  const customAbbreviations = new Set(consistencyConfig?.acceptedAbbreviations || []);
-  const customShortWords = new Set(consistencyConfig?.shortWords || []);
-  const disabledChecks = new Set(consistencyConfig?.disableChecks || []);
+  const { customAbbreviations, customShortWords, disabledChecks } = await loadNamingConfig(files);
   for (const file of files) {
     const content = await readFileContent(file);
     const fileIssues = analyzeFileNaming(file, content, customAbbreviations, customShortWords, disabledChecks);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aiready/consistency",
-  "version": "0.6.6",
+  "version": "0.6.8",
   "description": "Detects consistency issues in naming, patterns, and architecture that confuse AI models",
   "main": "./dist/index.js",
   "module": "./dist/index.mjs",
@@ -43,7 +43,7 @@
     "@typescript-eslint/typescript-estree": "^8.53.0",
     "chalk": "^5.3.0",
     "commander": "^12.1.0",
-    "@aiready/core": "0.7.4"
+    "@aiready/core": "0.7.5"
   },
   "devDependencies": {
     "@types/node": "^22.10.5",

package/src/analyzers/naming-ast.ts

@@ -1,6 +1,4 @@
 import { TSESTree } from '@typescript-eslint/typescript-estree';
-import { loadConfig } from '@aiready/core';
-import { dirname } from 'path';
 import type { NamingIssue } from '../types';
 import {
   parseFile,
@@ -18,10 +16,7 @@ import {
   isAcceptableInContext,
   calculateComplexity,
 } from '../utils/context-detector';
-import {
-  COMMON_SHORT_WORDS,
-  ACCEPTABLE_ABBREVIATIONS,
-} from './naming-constants';
+import { loadNamingConfig } from '../utils/config-loader';
 
 /**
  * AST-based naming analyzer
@@ -29,18 +24,8 @@ import {
 export async function analyzeNamingAST(files: string[]): Promise<NamingIssue[]> {
   const issues: NamingIssue[] = [];
 
-  // Load config
-  const rootDir = files.length > 0 ? dirname(files[0]) : process.cwd();
-  const config = await loadConfig(rootDir);
-  const consistencyConfig = config?.tools?.['consistency'];
-
-  // Merge custom configuration
-  const customAbbreviations = new Set(consistencyConfig?.acceptedAbbreviations || []);
-  const customShortWords = new Set(consistencyConfig?.shortWords || []);
-  const disabledChecks = new Set(consistencyConfig?.disableChecks || []);
-
-  const allAbbreviations = new Set([...ACCEPTABLE_ABBREVIATIONS, ...customAbbreviations]);
-  const allShortWords = new Set([...COMMON_SHORT_WORDS, ...customShortWords]);
+  // Load and merge configuration
+  const { allAbbreviations, allShortWords, disabledChecks } = await loadNamingConfig(files);
 
   for (const file of files) {
     try {

package/src/analyzers/naming.ts

@@ -1,11 +1,11 @@
-import { readFileContent, loadConfig } from '@aiready/core';
+import { readFileContent } from '@aiready/core';
 import type { NamingIssue } from '../types';
-import { dirname } from 'path';
 import {
   COMMON_SHORT_WORDS,
   ACCEPTABLE_ABBREVIATIONS,
   snakeCaseToCamelCase,
 } from './naming-constants';
+import { loadNamingConfig } from '../utils/config-loader';
 
 /**
  * Analyzes naming conventions and quality
@@ -13,15 +13,8 @@ import {
 export async function analyzeNaming(files: string[]): Promise<NamingIssue[]> {
   const issues: NamingIssue[] = [];
 
-  // Load config from the first file's directory (or project root)
-  const rootDir = files.length > 0 ? dirname(files[0]) : process.cwd();
-  const config = await loadConfig(rootDir);
-  const consistencyConfig = config?.tools?.['consistency'];
-
-  // Merge custom abbreviations and short words with defaults
-  const customAbbreviations = new Set(consistencyConfig?.acceptedAbbreviations || []);
-  const customShortWords = new Set(consistencyConfig?.shortWords || []);
-  const disabledChecks = new Set(consistencyConfig?.disableChecks || []);
+  // Load and merge configuration
+  const { customAbbreviations, customShortWords, disabledChecks } = await loadNamingConfig(files);
 
   for (const file of files) {
     const content = await readFileContent(file);

package/src/analyzers/patterns.ts

@@ -135,7 +135,12 @@ async function analyzeImportStyles(files: string[]): Promise<PatternIssue[]> {
   for (const file of files) {
     const content = await readFileContent(file);
     const hasESM = content.match(/^import\s+/m);
-    const hasCJS = content.match(/require\s*\(/);
+    
+    // Check for actual CommonJS require() calls, excluding:
+    // - String literals: "require('...') or 'require('...')
+    // - Regex patterns: /require\(/
+    // - Comments: // require( or /* require( */
+    const hasCJS = hasActualRequireCalls(content);
     
     if (hasESM && hasCJS) {
       patterns.mixed.push(file);
@@ -179,6 +184,36 @@ async function analyzeImportStyles(files: string[]): Promise<PatternIssue[]> {
   return issues;
 }
 
+/**
+ * Detects actual require() calls, excluding false positives
+ * Filters out require() in:
+ * - String literals (single/double/template quotes)
+ * - Regex patterns
+ * - Single-line comments (//)
+ * - Multi-line comments
+ */
+function hasActualRequireCalls(content: string): boolean {
+  // Simple heuristic: remove obvious false positives
+  // 1. Remove single-line comments
+  let cleaned = content.replace(/\/\/.*$/gm, '');
+  
+  // 2. Remove multi-line comments (non-greedy)
+  cleaned = cleaned.replace(/\/\*[\s\S]*?\*\//g, '');
+  
+  // 3. Remove string literals - use simpler regex to avoid backtracking
+  // Match strings but don't try to be perfect, just remove obvious ones
+  cleaned = cleaned.replace(/"[^"\n]*"/g, '""');
+  cleaned = cleaned.replace(/'[^'\n]*'/g, "''");
+  cleaned = cleaned.replace(/`[^`]*`/g, '``');
+  
+  // 4. Simple regex detection: if we see /require in the line, likely a regex pattern
+  // Remove lines that look like regex patterns with require
+  cleaned = cleaned.replace(/\/[^/\n]*require[^/\n]*\/[gimsuvy]*/g, '');
+  
+  // Now check for require( in the cleaned content
+  return /require\s*\(/.test(cleaned);
+}
+
 /**
  * Analyzes API design consistency
  */

package/src/utils/config-loader.ts

@@ -0,0 +1,48 @@
+import { loadConfig } from '@aiready/core';
+import { dirname } from 'path';
+import {
+  COMMON_SHORT_WORDS,
+  ACCEPTABLE_ABBREVIATIONS,
+} from '../analyzers/naming-constants';
+
+/**
+ * Configuration for naming analyzers
+ */
+export interface NamingConfig {
+  customAbbreviations: Set<string>;
+  customShortWords: Set<string>;
+  disabledChecks: Set<string>;
+  allAbbreviations: Set<string>;
+  allShortWords: Set<string>;
+}
+
+/**
+ * Loads and merges naming configuration for consistency analyzers
+ * Extracts common config loading logic used by both naming.ts and naming-ast.ts
+ * 
+ * @param files - Array of files being analyzed (used to determine project root)
+ * @returns Merged configuration with custom and default abbreviations/short words
+ */
+export async function loadNamingConfig(files: string[]): Promise<NamingConfig> {
+  // Load config from the first file's directory (or project root)
+  const rootDir = files.length > 0 ? dirname(files[0]) : process.cwd();
+  const config = await loadConfig(rootDir);
+  const consistencyConfig = config?.tools?.['consistency'];
+
+  // Extract custom configuration
+  const customAbbreviations = new Set(consistencyConfig?.acceptedAbbreviations || []);
+  const customShortWords = new Set(consistencyConfig?.shortWords || []);
+  const disabledChecks = new Set(consistencyConfig?.disableChecks || []);
+
+  // Merge with defaults
+  const allAbbreviations = new Set([...ACCEPTABLE_ABBREVIATIONS, ...customAbbreviations]);
+  const allShortWords = new Set([...COMMON_SHORT_WORDS, ...customShortWords]);
+
+  return {
+    customAbbreviations,
+    customShortWords,
+    disabledChecks,
+    allAbbreviations,
+    allShortWords,
+  };
+}