@aiready/cli 0.10.3 → 0.10.6

package/src/commands/scan.ts

@@ -22,6 +22,9 @@ import {
   getRatingDisplay,
   parseWeightString,
   getRepoMetadata,
+  Severity,
+  IssueType,
+  ToolName,
   type ToolScoringOutput,
 } from '@aiready/core';
 import { analyzeUnified, scoreUnified, type ScoringResult } from '../index';
@@ -364,7 +367,7 @@ export async function scanAction(directory: string, options: ScanOptions) {
               // Count severities
               const counts = issues.reduce(
                 (acc: any, it: any) => {
-                  const s = (it.severity || 'info').toLowerCase();
+                  const s = (it.severity || Severity.Info).toLowerCase();
                   acc[s] = (acc[s] || 0) + 1;
                   return acc;
                 },
@@ -374,12 +377,13 @@ export async function scanAction(directory: string, options: ScanOptions) {
               const sample =
                 issues.find(
                   (it: any) =>
-                    it.severity === 'critical' || it.severity === 'major'
+                    it.severity === Severity.Critical ||
+                    it.severity === Severity.Major
                 ) || issues[0];
               const sampleMsg = sample ? ` — ${sample.message}` : '';
 
               console.log(
-                `   ${idx + 1}. ${file} — ${issues.length} issue(s) (critical:${counts.critical || 0} major:${counts.major || 0} minor:${counts.minor || 0} info:${counts.info || 0})${sampleMsg}`
+                `   ${idx + 1}. ${file} — ${issues.length} issue(s) (critical:${counts[Severity.Critical] || 0} major:${counts[Severity.Major] || 0} minor:${counts[Severity.Minor] || 0} info:${counts[Severity.Info] || 0})${sampleMsg}`
               );
             });
 
@@ -462,30 +466,29 @@ export async function scanAction(directory: string, options: ScanOptions) {
       (finalOptions.tools || ['patterns', 'context', 'consistency']).join(', ')
     );
 
-    // Results summary
     console.log(chalk.cyan('\nResults summary:'));
     console.log(
       `  Total issues (all tools): ${chalk.bold(String(results.summary.totalIssues || 0))}`
     );
-    if (results.patternDetect) {
+    if (results[ToolName.PatternDetect]) {
       console.log(
-        `  Duplicate patterns found: ${chalk.bold(String(results.patternDetect.duplicates?.length || 0))}`
+        `  Duplicate patterns found: ${chalk.bold(String(results[ToolName.PatternDetect].duplicates?.length || 0))}`
       );
       console.log(
-        `  Pattern files with issues: ${chalk.bold(String(results.patternDetect.results.length || 0))}`
+        `  Pattern files with issues: ${chalk.bold(String(results[ToolName.PatternDetect].results.length || 0))}`
       );
     }
-    if (results.contextAnalyzer)
+    if (results[ToolName.ContextAnalyzer])
       console.log(
-        `  Context issues: ${chalk.bold(String(results.contextAnalyzer.results.length || 0))}`
+        `  Context issues: ${chalk.bold(String(results[ToolName.ContextAnalyzer].results.length || 0))}`
       );
-    if (results.consistency)
+    if (results[ToolName.NamingConsistency])
       console.log(
-        `  Consistency issues: ${chalk.bold(String(results.consistency.summary?.totalIssues || 0))}`
+        `  Consistency issues: ${chalk.bold(String(results[ToolName.NamingConsistency].summary?.totalIssues || 0))}`
       );
-    if (results.changeAmplification)
+    if (results[ToolName.ChangeAmplification])
       console.log(
-        `  Change amplification: ${chalk.bold(String(results.changeAmplification.summary?.score || 0))}/100`
+        `  Change amplification: ${chalk.bold(String(results[ToolName.ChangeAmplification].summary?.score || 0))}/100`
       );
     console.log(chalk.cyan('===========================\n'));
 
@@ -653,6 +656,114 @@ export async function scanAction(directory: string, options: ScanOptions) {
       }
     }
 
+    // Helper to map CLI results to UnifiedReport schema
+    const mapToUnifiedReport = (
+      res: any,
+      scoring: ScoringResult | undefined
+    ) => {
+      const allResults: any[] = [];
+      let totalFilesSet = new Set<string>();
+      let criticalCount = 0;
+      let majorCount = 0;
+
+      // Collect from all spokes and normalize to AnalysisResult
+      const collect = (
+        spokeRes: any,
+        defaultType: IssueType = IssueType.AiSignalClarity
+      ) => {
+        if (!spokeRes || !spokeRes.results) return;
+        spokeRes.results.forEach((r: any) => {
+          const fileName = r.fileName || r.file || 'unknown';
+          totalFilesSet.add(fileName);
+
+          // Enforce strict AnalysisResult schema
+          const normalizedResult = {
+            fileName,
+            issues: [] as any[],
+            metrics: r.metrics || { tokenCost: r.tokenCost || 0 },
+          };
+
+          if (r.issues && Array.isArray(r.issues)) {
+            r.issues.forEach((i: any) => {
+              const normalizedIssue =
+                typeof i === 'string'
+                  ? {
+                      type: defaultType,
+                      severity: (r.severity || Severity.Info) as Severity,
+                      message: i,
+                      location: { file: fileName, line: 1 },
+                    }
+                  : {
+                      type: i.type || defaultType,
+                      severity: (i.severity ||
+                        r.severity ||
+                        Severity.Info) as Severity,
+                      message: i.message || String(i),
+                      location: i.location || { file: fileName, line: 1 },
+                      suggestion: i.suggestion,
+                    };
+
+              if (
+                normalizedIssue.severity === Severity.Critical ||
+                normalizedIssue.severity === 'critical'
+              )
+                criticalCount++;
+              if (
+                normalizedIssue.severity === Severity.Major ||
+                normalizedIssue.severity === 'major'
+              )
+                majorCount++;
+
+              normalizedResult.issues.push(normalizedIssue);
+            });
+          } else if (r.severity) {
+            // handle context-analyzer style if issues missing but severity present
+            const normalizedIssue = {
+              type: defaultType,
+              severity: r.severity as Severity,
+              message: r.message || 'General issue',
+              location: { file: fileName, line: 1 },
+            };
+            if (
+              normalizedIssue.severity === Severity.Critical ||
+              normalizedIssue.severity === 'critical'
+            )
+              criticalCount++;
+            if (
+              normalizedIssue.severity === Severity.Major ||
+              normalizedIssue.severity === 'major'
+            )
+              majorCount++;
+            normalizedResult.issues.push(normalizedIssue);
+          }
+
+          allResults.push(normalizedResult);
+        });
+      };
+
+      collect(res[ToolName.PatternDetect], IssueType.DuplicatePattern);
+      collect(res[ToolName.ContextAnalyzer], IssueType.ContextFragmentation);
+      collect(res[ToolName.NamingConsistency], IssueType.NamingInconsistency);
+      collect(res[ToolName.DocDrift], IssueType.DocDrift);
+      collect(res[ToolName.DependencyHealth], IssueType.DependencyHealth);
+      collect(res[ToolName.AiSignalClarity], IssueType.AiSignalClarity);
+      collect(res[ToolName.AgentGrounding], IssueType.AgentNavigationFailure);
+      collect(res[ToolName.TestabilityIndex], IssueType.LowTestability);
+      collect(res[ToolName.ChangeAmplification], IssueType.ChangeAmplification);
+
+      return {
+        ...res,
+        results: allResults,
+        summary: {
+          ...res.summary,
+          totalFiles: totalFilesSet.size,
+          criticalIssues: criticalCount,
+          majorIssues: majorCount,
+        },
+        scoring: scoring,
+      };
+    };
+
     // Persist JSON summary when output format is json
     const outputFormat =
       options.output || finalOptions.output?.format || 'console';
@@ -666,8 +777,7 @@ export async function scanAction(directory: string, options: ScanOptions) {
         resolvedDir
       );
       const outputData = {
-        ...results,
-        scoring: scoringResult,
+        ...mapToUnifiedReport(results, scoringResult),
         repository: repoMetadata,
       };
       handleJSONOutput(
@@ -697,8 +807,7 @@ export async function scanAction(directory: string, options: ScanOptions) {
         resolvedDir
       );
       const outputData = {
-        ...results,
-        scoring: scoringResult,
+        ...mapToUnifiedReport(results, scoringResult),
         repository: repoMetadata,
       };
 
@@ -755,10 +864,13 @@ export async function scanAction(directory: string, options: ScanOptions) {
         }
 
         // Output annotations for critical issues
-        if (results.patternDetect) {
-          const criticalPatterns = results.patternDetect.results.flatMap(
-            (p: any) => p.issues.filter((i: any) => i.severity === 'critical')
+        if (results[ToolName.PatternDetect]) {
+          const criticalPatterns = results[
+            ToolName.PatternDetect
+          ].results.flatMap((p: any) =>
+            p.issues.filter((i: any) => i.severity === Severity.Critical)
           );
+
           criticalPatterns.slice(0, 10).forEach((issue: any) => {
             console.log(
               `::warning file=${issue.location?.file || 'unknown'},line=${issue.location?.line || 1}::${issue.message}`
@@ -786,25 +898,25 @@ export async function scanAction(directory: string, options: ScanOptions) {
         let criticalCount = 0;
         let majorCount = 0;
 
-        if (results.patternDetect) {
-          results.patternDetect.results.forEach((p: any) => {
+        if (results[ToolName.PatternDetect]) {
+          results[ToolName.PatternDetect].results.forEach((p: any) => {
             p.issues.forEach((i: any) => {
-              if (i.severity === 'critical') criticalCount++;
-              if (i.severity === 'major') majorCount++;
+              if (i.severity === Severity.Critical) criticalCount++;
+              if (i.severity === Severity.Major) majorCount++;
             });
           });
         }
-        if (results.contextAnalyzer) {
-          results.contextAnalyzer.results.forEach((c: any) => {
-            if (c.severity === 'critical') criticalCount++;
-            if (c.severity === 'major') majorCount++;
+        if (results[ToolName.ContextAnalyzer]) {
+          results[ToolName.ContextAnalyzer].results.forEach((c: any) => {
+            if (c.severity === Severity.Critical) criticalCount++;
+            if (c.severity === Severity.Major) majorCount++;
           });
         }
-        if (results.consistency) {
-          results.consistency.results.forEach((r: any) => {
+        if (results[ToolName.NamingConsistency]) {
+          results[ToolName.NamingConsistency].results.forEach((r: any) => {
             r.issues?.forEach((i: any) => {
-              if (i.severity === 'critical') criticalCount++;
-              if (i.severity === 'major') majorCount++;
+              if (i.severity === Severity.Critical) criticalCount++;
+              if (i.severity === Severity.Major) majorCount++;
             });
           });
         }