@aiqa/sdk 1.5.0-develop.3 → 1.5.0-develop.4

package/dist/browser/browser.d.ts

@@ -257,7 +257,7 @@ declare abstract class IAiqaSdk {
     abstract connect(): void;
     abstract disconnect(): void;
     abstract on(eventName: string, callback: (...args: any[]) => any): void;
-    abstract off(eventName: string): void;
+    abstract off(eventName: string, callback?: (...args: any[]) => any): void;
     abstract getApplication(): Promise<Application>;
     abstract addFact(fact: ApplicationFactInput): Promise<AddFactResult>;
     abstract flagFact(factId: string): Promise<FlagFactResult>;
@@ -274,6 +274,7 @@ declare class AiQaSdk implements IAiqaSdk {
     cachedApplication?: Application;
     internalListeners: Map<SdkEvent, Set<(...args: any[]) => void>>;
     internalEvents: Set<SdkEvent>;
+    private wrappersByEvent;
     constructor(applicationId: string, applicationSecret: string, url?: string);
     on(name: SdkEvent, callback: (...args: any[]) => any): void;
     off(name: SdkEvent, callback?: (...args: any[]) => any): void;

package/dist/browser/browser.js

@@ -3396,7 +3396,7 @@ var compareVersions = (left, right) => {
 // package.json
 var package_default = {
   name: "@aiqa/sdk",
-  version: "1.5.0-develop.2",
+  version: "1.5.0-develop.3",
   main: "dist/node/node.js",
   module: "dist/node/node.js",
   types: "dist/node/node.d.ts",
@@ -3480,9 +3480,41 @@ var DEFAULT_URL = "ws://localhost:3025/ws";
 var DEFAULT_TIMEOUT_MS = 6e4;
 var RUNTIME = typeof window !== "undefined" && typeof window.document !== "undefined" ? "browser" : "node";
 var USER_AGENT = RUNTIME === "browser" ? typeof navigator !== "undefined" ? navigator.userAgent : "browser/unknown" : typeof process !== "undefined" ? `node ${process.version} ${process.platform}` : "node/unknown";
+function isThenable(value2) {
+  return value2 !== null && typeof value2 === "object" && typeof value2.then === "function";
+}
+function wrapAckHandler(callback) {
+  return (...args) => {
+    const last = args[args.length - 1];
+    const hasAck = typeof last === "function";
+    const payload = hasAck ? args.slice(0, -1) : args;
+    try {
+      const handlerResult = callback(...payload);
+      if (isThenable(handlerResult)) {
+        handlerResult.then(void 0, (err) => {
+          console.error("[AiQaSdk] async event handler rejected:", err);
+        });
+      }
+    } catch (err) {
+      console.error("[AiQaSdk] event handler threw:", err);
+    } finally {
+      if (hasAck) {
+        try {
+          last();
+        } catch {
+        }
+      }
+    }
+  };
+}
 var AiQaSdk = class {
   constructor(applicationId, applicationSecret, url2) {
     this.socket = null;
+    // event → originalCallback → Set<wrappedCallback> registered on
+    // socket.io. A Set per (event, callback) so that subscribing the
+    // same fn twice registers two wrappers and two off() calls clear
+    // both.
+    this.wrappersByEvent = /* @__PURE__ */ new Map();
     this.url = url2 ?? DEFAULT_URL;
     this.internalListeners = /* @__PURE__ */ new Map();
     this.internalEvents = /* @__PURE__ */ new Set(["authenticated"]);
@@ -3507,7 +3539,19 @@ var AiQaSdk = class {
     if (this.isManagerEvent(name)) {
       this.socket.io.on(name, callback);
     } else {
-      this.socket.on(name, callback);
+      const wrapped = wrapAckHandler(callback);
+      let wrappersByCallback = this.wrappersByEvent.get(name);
+      if (!wrappersByCallback) {
+        wrappersByCallback = /* @__PURE__ */ new Map();
+        this.wrappersByEvent.set(name, wrappersByCallback);
+      }
+      let wrappers = wrappersByCallback.get(callback);
+      if (!wrappers) {
+        wrappers = /* @__PURE__ */ new Set();
+        wrappersByCallback.set(callback, wrappers);
+      }
+      wrappers.add(wrapped);
+      this.socket.on(name, wrapped);
     }
   }
   off(name, callback) {
@@ -3530,6 +3574,25 @@ var AiQaSdk = class {
     }
     if (this.isManagerEvent(name)) {
       this.socket.io.off(name, callback);
+      return;
+    }
+    if (!callback) {
+      this.socket.off(name);
+      this.wrappersByEvent.delete(name);
+      return;
+    }
+    const wrappersByCallback = this.wrappersByEvent.get(name);
+    const wrappers = wrappersByCallback?.get(callback);
+    if (wrappers && wrappers.size > 0) {
+      const wrapped = wrappers.values().next().value;
+      wrappers.delete(wrapped);
+      this.socket.off(name, wrapped);
+      if (wrappers.size === 0) {
+        wrappersByCallback.delete(callback);
+        if (wrappersByCallback.size === 0) {
+          this.wrappersByEvent.delete(name);
+        }
+      }
     } else {
       this.socket.off(name, callback);
     }
@@ -3547,34 +3610,38 @@ var AiQaSdk = class {
     this.socket.on("connect", () => {
       this.authenticate();
     });
-    this.socket.on("app_version", (payload) => {
-      let versionRange = payload;
-      if (typeof payload === "string") {
-        try {
-          versionRange = JSON.parse(payload);
-        } catch (error) {
-          versionRange = payload;
+    this.socket.on(
+      "app_version",
+      wrapAckHandler((payload) => {
+        let versionRange = payload;
+        if (typeof payload === "string") {
+          try {
+            versionRange = JSON.parse(payload);
+          } catch (error) {
+            versionRange = payload;
+          }
         }
-      }
-      const minVersion = versionRange?.min;
-      const maxVersion = versionRange?.max;
-      if (minVersion || maxVersion) {
-        const tooLow = minVersion ? compareVersions(SDK_VERSION, minVersion) < 0 : false;
-        const tooHigh = maxVersion ? compareVersions(SDK_VERSION, maxVersion) > 0 : false;
-        if (tooLow || tooHigh) {
-          const error = new Error(
-            `SDK version ${SDK_VERSION} is not supported. Supported range: ${minVersion || "-"} to ${maxVersion || "-"}.`
-          );
-          this.socket.disconnect();
-          this.socket.emit("error", error);
+        const minVersion = versionRange?.min;
+        const maxVersion = versionRange?.max;
+        if (minVersion || maxVersion) {
+          const tooLow = minVersion ? compareVersions(SDK_VERSION, minVersion) < 0 : false;
+          const tooHigh = maxVersion ? compareVersions(SDK_VERSION, maxVersion) > 0 : false;
+          if (tooLow || tooHigh) {
+            const error = new Error(
+              `SDK version ${SDK_VERSION} is not supported. Supported range: ${minVersion || "-"} to ${maxVersion || "-"}.`
+            );
+            this.socket.disconnect();
+            this.socket.emit("error", error);
+          }
         }
-      }
-    });
+      })
+    );
   }
   disconnect() {
     if (this.socket) {
       this.socket.disconnect();
     }
+    this.wrappersByEvent.clear();
   }
   sendMessage(method, data) {
     return new Promise((resolve, reject) => {