@aion0/forge 0.9.7 → 0.9.10

package/RELEASE_NOTES.md

@@ -1,12 +1,12 @@
-# Forge v0.9.7
+# Forge v0.9.10
 
 Released: 2026-05-26
 
-## Changes since v0.9.6
+## Changes since v0.9.9
 
 ### Other
-- fix(server): rebuild stale .next on every restart after upgrade
-- marketplace: drop 'Recipes' option from Templates filter
+- docs(pipelines): >→| switch audit checklist + v0.7.x case study
+- fix(pipeline): for_each retry rewinds currentIndex past finalize
 
 
-**Full Changelog**: https://github.com/aiwatching/forge/compare/v0.9.6...v0.9.7
+**Full Changelog**: https://github.com/aiwatching/forge/compare/v0.9.9...v0.9.10

package/app/api/connectors/route.ts

@@ -74,6 +74,7 @@ function toConnectorPayload(def: ConnectorDefinition, config: Record<string, any
     ...(hostMatch ? { host_match: hostMatch } : {}),
     ...(loginRedirect ? { login_redirect: loginRedirect } : {}),
     runner,
+    ...(def.tab_strategy ? { tab_strategy: def.tab_strategy } : {}),
     /** Hint for the marketplace UI: a Test button is wired for this connector. */
     has_test: !!def.test,
     /** Optional human description of what the test does (no request shape exposed). */

package/components/PipelineView.tsx

@@ -360,7 +360,7 @@ function DagNodeCard({ nodeId, node, nodeDef, onViewTask, onRetry }: {
           </button>
         )}
         {node.iterations > 1 && <span className="text-[9px] text-yellow-400">iter {node.iterations}</span>}
-        {node.status === 'failed' && onRetry && (
+        {(node.status === 'failed' || node.status === 'cancelled') && onRetry && (
           <button
             onClick={async () => { setRetryBusy(true); try { await onRetry(nodeId); } finally { setRetryBusy(false); } }}
             disabled={retryBusy}

package/lib/connectors/types.ts

@@ -211,6 +211,18 @@ export interface ConnectorDefinition {
    */
   runner?: ConnectorRunner;
 
+  /**
+   * How the runner acquires a tab to execute scripts in:
+   *   - 'reuse' (default): query existing tabs matching host_match;
+   *     navigate the first match. Saves tab churn but hijacks whatever
+   *     page the user was viewing.
+   *   - 'ephemeral': always open a fresh background tab; close it after
+   *     the tool returns. User's own tabs are untouched. Slightly slower
+   *     (5–10s per call on cold load) but invisible to the user. Use for
+   *     connectors hit frequently by background pipelines (Mantis, etc.).
+   */
+  tab_strategy?: 'reuse' | 'ephemeral';
+
   // ─── 1:1 connector — top-level fields ──────────────────
   /** Most connectors expose tools directly here. */
   tools?: Record<string, ConnectorTool>;

package/lib/help-docs/05-pipelines.md

@@ -108,6 +108,35 @@ relies on the discipline of blank lines between every statement. But for
 any **new** node or **substantial rewrite**, use `|`. Don't sprinkle
 shell into existing `>` nodes without re-checking blank-line spacing.
 
+**Switching an existing node from `>` to `|` is NOT a 1-line change.**
+Code originally written for `>` may have *deliberately* split a single
+bash command across two yaml lines, relying on `>` to re-fold them into
+one bash command line. Common shape:
+
+```yaml
+prompt: >                                      # folded
+  RESULT=$(python3 - "$ARG1" "$ARG2"           # ← these two yaml
+  "$ARG3" "$ARG4" <<'PY'                       #   lines become ONE bash command
+```
+
+Under `>`: `RESULT=$(python3 - "$ARG1" "$ARG2" "$ARG3" "$ARG4" <<'PY'` (good).
+Under `|`: two separate bash statements, the second starting with
+`"$ARG3"` — bash will try to expand and exec the variable as a command,
+giving `command not found: <ARG3's value>`. Real-world failure mode from
+fortinet-mantis-bug-fix v0.7.1 → v0.7.2.
+
+Audit checklist when switching `>` → `|`:
+
+1. Grep for `\$\(` followed by content that wraps across multiple yaml
+   lines without a `\` continuation. Collapse those to a single yaml line,
+   OR add explicit `\` continuations.
+2. Grep for any non-blank yaml line whose previous non-blank line doesn't
+   end in `;`, `&&`, `||`, `|`, `\`, `{`, `(`, `then`, `else`, `do`,
+   `fi`, `done` — that's a candidate for "two yaml lines being folded
+   into one bash command under `>`".
+3. Run `node -e "console.log(YAML.parse(fs.readFileSync('foo.yaml','utf8')).nodes['NODE'].prompt)" | head -200` and visually scan for any
+   `RESULT=$(cmd arg1\n"arg2"...)` shapes that won't survive the switch.
+
 ### Rule 2 — Don't use `eval $(echo "$X" | sed 's/^/export /')` to import env vars
 
 This idiom looks innocent but breaks the moment any value contains a space,

package/lib/pipeline.ts

@@ -1562,12 +1562,13 @@ export async function retryNode(pipelineId: string, nodeId: string): Promise<{ o
 
   const nodeState = pipeline.nodes[nodeId];
   if (!nodeState) return { ok: false, error: `node '${nodeId}' is not in this pipeline` };
-  // Allow retry on 'failed' OR 'running'. Running covers the
-  // forge-restart-orphaned case: the node thinks it's executing but
-  // the underlying task is dead. Anything else (pending/done/skipped)
-  // is a misclick.
-  if (nodeState.status !== 'failed' && nodeState.status !== 'running') {
-    return { ok: false, error: `node is in status '${nodeState.status}' — only failed or running nodes can be retried` };
+  // Allow retry on 'failed' OR 'running' OR 'cancelled'. Running covers
+  // the forge-restart-orphaned case (node thinks it's executing but the
+  // underlying task is dead); cancelled covers user-cancelled pipelines
+  // where the user later wants to resume from the cancelled node.
+  // pending/done/skipped are still misclicks.
+  if (nodeState.status !== 'failed' && nodeState.status !== 'running' && nodeState.status !== 'cancelled') {
+    return { ok: false, error: `node is in status '${nodeState.status}' — only failed, running, or cancelled nodes can be retried` };
   }
 
   // If the node is "running", best-effort terminate the underlying task
@@ -1620,11 +1621,34 @@ export async function retryNode(pipelineId: string, nodeId: string): Promise<{ o
     // Don't reset s.iterations — keep monotonic so retries show up in history.
   }
 
-  if (pipeline.status === 'failed' || pipeline.status === 'done') {
+  if (pipeline.status === 'failed' || pipeline.status === 'done' || pipeline.status === 'cancelled') {
     pipeline.status = 'running';
     pipeline.completedAt = undefined;
   }
 
+  // for_each: when retry fires after the pipeline finalized, currentIndex
+  // has already been ++'d past the last iter, so items[currentIndex] would
+  // be undefined and the re-run would see {{<as>}} as empty. Rewind to the
+  // last iter and pop its snapshot — checkPipelineCompletion will re-add it
+  // when the retried nodes settle.
+  //
+  // Only handles the typical case (retry a node from the LAST iter).
+  // Retrying an earlier failed iter when later iters already succeeded is
+  // not supported here — the main DAG only reflects the last iter's state
+  // anyway, so the user can't actually click on an earlier iter's node.
+  if (
+    pipeline.forEach &&
+    pipeline.forEach.itemsResolved &&
+    pipeline.forEach.total > 0 &&
+    pipeline.forEach.currentIndex >= pipeline.forEach.total
+  ) {
+    pipeline.forEach.currentIndex = pipeline.forEach.total - 1;
+    const lastSnap = pipeline.forEach.iterations[pipeline.forEach.iterations.length - 1];
+    if (lastSnap && lastSnap.index === pipeline.forEach.currentIndex) {
+      pipeline.forEach.iterations.pop();
+    }
+  }
+
   savePipeline(pipeline);
   await scheduleReadyNodes(pipeline, workflow);
   return { ok: true };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aion0/forge",
-  "version": "0.9.7",
+  "version": "0.9.10",
   "description": "Unified AI workflow platform — multi-model task orchestration, persistent sessions, web terminal, remote access",
   "type": "module",
   "scripts": {