@aion0/forge 0.9.11 → 0.9.12

package/RELEASE_NOTES.md

@@ -1,8 +1,13 @@
-# Forge v0.9.11
+# Forge v0.9.12
 
-Released: 2026-05-26
+Released: 2026-05-27
 
-## Changes since v0.9.10
+## Changes since v0.9.11
 
+### Other
+- fix(settings): id-collision guards on agent + profile add
+- fix(settings): functional setSettings in profile add — preserves new agent
+- fix(settings): adding an Agent no longer creates a CLI Profile
 
-**Full Changelog**: https://github.com/aiwatching/forge/compare/v0.9.10...v0.9.11
+
+**Full Changelog**: https://github.com/aiwatching/forge/compare/v0.9.11...v0.9.12

package/components/SettingsModal.tsx

@@ -1379,8 +1379,16 @@ function AgentsSection({ settings, setSettings }: { settings: any; setSettings:
       const agentsCfg: Record<string, any> = { ...(prev.agents || {}) };
       for (const a of updated) {
         const existing = agentsCfg[a.id] || {};
+        // NOTE: do NOT write `cliType` from the entry here. cliType is the
+        // load-time discriminator between agents and CLI profiles (see the
+        // filter ~line 1349 — `if (cfg.cliType || cfg.base) continue`).
+        // The Agents-add form seeds newAgent.cliType for cliDefaults lookup
+        // (taskFlags / resumeFlag presets), but persisting it would make
+        // the new agent show up as a profile on reload. `...existing`
+        // carries forward cliType for detected agents whose inline selector
+        // wrote it via setSettings directly (line ~1540).
         agentsCfg[a.id] = {
-          ...existing, // preserve profile-specific fields
+          ...existing, // preserve profile-specific fields + any prior cliType
           name: a.name,
           path: a.path,
           enabled: a.enabled,
@@ -1391,7 +1399,6 @@ function AgentsSection({ settings, setSettings }: { settings: any; setSettings:
           models: a.models,
           skipPermissionsFlag: a.skipPermissionsFlag,
           requiresTTY: a.requiresTTY,
-          cliType: (a as any).cliType || existing.cliType,
         };
       }
       const claude = updated.find(a => a.id === 'claude');
@@ -1437,6 +1444,15 @@ function AgentsSection({ settings, setSettings }: { settings: any; setSettings:
 
   const addAgent = () => {
     if (!newAgent.id || !newAgent.path) return;
+    // settings.agents is one map keyed by id — agents + CLI profiles + API
+    // profiles all coexist. A duplicate id silently overwrites whichever
+    // entry was there first. Block the add and tell the user why.
+    if (agents.some(a => a.id === newAgent.id) || settings.agents?.[newAgent.id]) {
+      const existing = settings.agents?.[newAgent.id] as any;
+      const kind = existing?.type === 'api' ? 'API profile' : existing?.cliType || existing?.base ? 'CLI profile' : 'agent';
+      alert(`id "${newAgent.id}" is already in use by a ${kind}. Pick a different id.`);
+      return;
+    }
     const entry: AgentEntry = {
       ...newAgent,
       enabled: true,
@@ -1743,11 +1759,34 @@ function AgentsSection({ settings, setSettings }: { settings: any; setSettings:
         ))}
 
         <div className="flex gap-2 mt-1">
+          {/* Functional setSettings — non-functional form captures a stale
+              `settings` snapshot, which clobbers any agent that was saved
+              between this component's last render and the Add click
+              (debouncedSave for the Agents section fires 1s later, so the
+              window is real). Also: settings.agents is a single map keyed
+              by id — agents + CLI profiles + API profiles share it — so
+              reusing an id silently overwrites. Block dups with an alert. */}
           <AddProfileForm type="cli" baseAgents={agents.filter(a => !a.isProfile && a.detected)} onAdd={(id, cfg) => {
-            setSettings({ ...settings, agents: { ...settings.agents, [id]: cfg } });
+            setSettings((prev: any) => {
+              if (prev.agents?.[id]) {
+                const existing = prev.agents[id] as any;
+                const kind = existing.type === 'api' ? 'API profile' : existing.cliType || existing.base ? 'CLI profile' : 'agent';
+                alert(`id "${id}" is already in use by a ${kind}. Pick a different id.`);
+                return prev;
+              }
+              return { ...prev, agents: { ...(prev.agents || {}), [id]: cfg } };
+            });
           }} />
           <AddProfileForm type="api" baseAgents={[]} onAdd={(id, cfg) => {
-            setSettings({ ...settings, agents: { ...settings.agents, [id]: cfg } });
+            setSettings((prev: any) => {
+              if (prev.agents?.[id]) {
+                const existing = prev.agents[id] as any;
+                const kind = existing.type === 'api' ? 'API profile' : existing.cliType || existing.base ? 'CLI profile' : 'agent';
+                alert(`id "${id}" is already in use by a ${kind}. Pick a different id.`);
+                return prev;
+              }
+              return { ...prev, agents: { ...(prev.agents || {}), [id]: cfg } };
+            });
           }} />
         </div>
       </div>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aion0/forge",
-  "version": "0.9.11",
+  "version": "0.9.12",
   "description": "Unified AI workflow platform — multi-model task orchestration, persistent sessions, web terminal, remote access",
   "type": "module",
   "scripts": {