@aion0/forge 0.5.12 → 0.5.14

package/RELEASE_NOTES.md

@@ -1,13 +1,14 @@
-# Forge v0.5.12
+# Forge v0.5.14
 
 Released: 2026-03-31
 
-## Changes since v0.5.11
+## Changes since v0.5.13
 
 ### Bug Fixes
-- fix: correct bin paths in package.json
-- fix: merge pending upstream_complete — auto-complete older ones before sending new
-- fix: upstream_complete notification tells agent to ignore if busy or duplicate
+- fix: dedup forge failed notifications by sender→target pair
+- fix: TerminalLaunchDialog also uses daemon to create session
+- fix: FloatingTerminal only attaches, daemon creates all sessions
+- fix: write launch script to file to avoid tmux send-keys truncation
 
 
-**Full Changelog**: https://github.com/aiwatching/forge/compare/v0.5.11...v0.5.12
+**Full Changelog**: https://github.com/aiwatching/forge/compare/v0.5.13...v0.5.14

package/components/WorkspaceView.tsx

@@ -2517,43 +2517,20 @@ function WorkspaceViewInner({ projectPath, projectName, onClose }: {
                 },
               };
 
-              // If tmux session exists → attach (primary or non-primary)
-              if (existingTmux) {
-                wsApi(workspaceId, 'open_terminal', { agentId: agent.id });
-                setFloatingTerminals(prev => [...prev, {
-                  agentId: agent.id, label: agent.label, icon: agent.icon,
-                  cliId: agent.agentId || 'claude', ...launchInfo, workDir,
-                  tmuxSession: existingTmux, sessionName: sessName,
-                  isPrimary: agent.primary, skipPermissions: agent.skipPermissions !== false, persistentSession: agent.persistentSession, boundSessionId: agent.boundSessionId, initialPos,
-                }]);
-                return;
-              }
-
-              // Primary without session → open directly (no dialog)
-              if (agent.primary) {
-                const res = await wsApi(workspaceId, 'open_terminal', { agentId: agent.id }).catch(() => ({})) as any;
-                setFloatingTerminals(prev => [...prev, {
-                  agentId: agent.id, label: agent.label, icon: agent.icon,
-                  cliId: agent.agentId || 'claude', ...launchInfo, workDir,
-                  tmuxSession: res?.tmuxSession || sessName, sessionName: sessName,
-                  isPrimary: true, skipPermissions: agent.skipPermissions !== false, persistentSession: agent.persistentSession, boundSessionId: agent.boundSessionId, initialPos,
-                }]);
-                return;
-              }
-
-              // Non-primary: has boundSessionId → use it directly; no bound → show dialog
-              if (agent.boundSessionId) {
+              // All paths: let daemon create/ensure session, then attach
+              if (existingTmux || agent.primary || agent.persistentSession || agent.boundSessionId) {
+                // Daemon creates session via ensurePersistentSession (launch script, no truncation)
                 const res = await wsApi(workspaceId, 'open_terminal', { agentId: agent.id }).catch(() => ({})) as any;
+                const tmux = existingTmux || res?.tmuxSession || sessName;
                 setFloatingTerminals(prev => [...prev, {
                   agentId: agent.id, label: agent.label, icon: agent.icon,
-                  cliId: agent.agentId || 'claude', ...launchInfo, workDir,
-                  tmuxSession: res?.tmuxSession || sessName, sessionName: sessName,
-                  resumeSessionId: agent.boundSessionId,
-                  isPrimary: false, skipPermissions: agent.skipPermissions !== false, persistentSession: agent.persistentSession, boundSessionId: agent.boundSessionId, initialPos,
+                  cliId: agent.agentId || 'claude', workDir,
+                  tmuxSession: tmux, sessionName: sessName,
+                  isPrimary: agent.primary, skipPermissions: agent.skipPermissions !== false, persistentSession: agent.persistentSession, boundSessionId: agent.boundSessionId, initialPos,
                 }]);
                 return;
               }
-              // No bound session → show launch dialog (New / Resume / Select)
+              // No persistent session, no bound session → show launch dialog
               setTermLaunchDialog({ agent, sessName, workDir, sessions: [], supportsSession: resolveRes?.supportsSession ?? true, initialPos });
             },
             onSwitchSession: async () => {
@@ -2934,28 +2911,19 @@ function WorkspaceViewInner({ projectPath, projectName, onClose }: {
           onLaunch={async (resumeMode, sessionId) => {
             const { agent, sessName, workDir } = termLaunchDialog;
             setTermLaunchDialog(null);
-            const res = await wsApi(workspaceId, 'open_terminal', { agentId: agent.id });
-            if (res.ok) {
-              // Save selected session as boundSessionId if user chose a specific one
-              if (sessionId) {
-                wsApi(workspaceId, 'update', { agentId: agent.id, config: { ...agent, boundSessionId: sessionId } }).catch(() => {});
-              }
-              setFloatingTerminals(prev => [...prev, {
-                agentId: agent.id, label: agent.label, icon: agent.icon,
-                cliId: agent.agentId || 'claude',
-                cliCmd: res.cliCmd || 'claude',
-                cliType: res.cliType || 'claude-code',
-                workDir,
-                sessionName: sessName, resumeMode, resumeSessionId: sessionId, isPrimary: false, skipPermissions: agent.skipPermissions !== false, persistentSession: agent.persistentSession, boundSessionId: sessionId || agent.boundSessionId, initialPos: termLaunchDialog.initialPos,
-                profileEnv: {
-                  ...(res.env || {}),
-                  ...(res.model ? { CLAUDE_MODEL: res.model } : {}),
-                  FORGE_AGENT_ID: agent.id,
-                  FORGE_WORKSPACE_ID: workspaceId,
-                  FORGE_PORT: String(window.location.port || 8403),
-                },
-              }]);
+            // Save selected session as boundSessionId
+            if (sessionId) {
+              await wsApi(workspaceId, 'update', { agentId: agent.id, config: { ...agent, boundSessionId: sessionId } }).catch(() => {});
             }
+            // Daemon creates session (launch script), then attach
+            const res = await wsApi(workspaceId, 'open_terminal', { agentId: agent.id }).catch(() => ({})) as any;
+            const tmux = res?.tmuxSession || sessName;
+            setFloatingTerminals(prev => [...prev, {
+              agentId: agent.id, label: agent.label, icon: agent.icon,
+              cliId: agent.agentId || 'claude', workDir,
+              tmuxSession: tmux, sessionName: sessName,
+              isPrimary: false, skipPermissions: agent.skipPermissions !== false, persistentSession: agent.persistentSession, boundSessionId: sessionId || agent.boundSessionId, initialPos: termLaunchDialog.initialPos,
+            }]);
           }}
           onCancel={() => setTermLaunchDialog(null)}
         />

package/lib/workspace/orchestrator.ts

@@ -1353,16 +1353,20 @@ export class WorkspaceOrchestrator extends EventEmitter {
         }
       }
 
-      // Case 4: Failed → notify sender so they know
-      if (msg.status === 'failed' && !this.forgeActedMessages.has(`failed-${msg.id}`)) {
-        const senderEntry = this.agents.get(msg.from);
-        const targetLabel = this.agents.get(msg.to)?.config.label || msg.to;
-        if (senderEntry && msg.from !== '_forge' && msg.from !== '_system') {
-          this.bus.send('_forge', msg.from, 'notify', {
-            action: 'update_notify',
-            content: `Your message to ${targetLabel} has failed. You may want to retry or take a different approach.`,
-          });
-          console.log(`[forge-agent] Notified ${senderEntry.config.label} that message to ${targetLabel} failed`);
+      // Case 4: Failed → notify sender (once per sender→target pair)
+      if (msg.status === 'failed') {
+        const failKey = `failed-${msg.from}->${msg.to}`;
+        if (!this.forgeActedMessages.has(failKey)) {
+          const senderEntry = this.agents.get(msg.from);
+          const targetLabel = this.agents.get(msg.to)?.config.label || msg.to;
+          if (senderEntry && msg.from !== '_forge' && msg.from !== '_system') {
+            this.bus.send('_forge', msg.from, 'notify', {
+              action: 'update_notify',
+              content: `Your message to ${targetLabel} has failed. You may want to retry or take a different approach.`,
+            });
+            console.log(`[forge-agent] Notified ${senderEntry.config.label} that message to ${targetLabel} failed (once)`);
+          }
+          this.forgeActedMessages.add(failKey);
         }
         this.forgeActedMessages.add(`failed-${msg.id}`);
       }
@@ -2023,27 +2027,24 @@ export class WorkspaceOrchestrator extends EventEmitter {
 
         execSync(`tmux new-session -d -s "${sessionName}" -c "${workDir}"`, { timeout: 5000 });
 
-        // Reset profile env vars (unset any leftover from previous agent) then set new ones
-        const profileVarsToReset = ['ANTHROPIC_AUTH_TOKEN', 'ANTHROPIC_BASE_URL', 'ANTHROPIC_SMALL_FAST_MODEL', 'CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC', 'DISABLE_TELEMETRY', 'DISABLE_ERROR_REPORTING', 'DISABLE_AUTOUPDATER', 'DISABLE_NON_ESSENTIAL_MODEL_CALLS', 'CLAUDE_MODEL'];
-        const unsetCmd = profileVarsToReset.map(v => `unset ${v}`).join(' && ');
-        execSync(`tmux send-keys -t "${sessionName}" '${unsetCmd}' Enter`, { timeout: 5000 });
+        // Build launch script to avoid tmux send-keys truncation
+        const scriptLines: string[] = ['#!/bin/bash', `cd "${workDir}"`];
+
+        // Unset old profile vars
+        scriptLines.push('unset ANTHROPIC_AUTH_TOKEN ANTHROPIC_BASE_URL ANTHROPIC_SMALL_FAST_MODEL CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC DISABLE_TELEMETRY DISABLE_ERROR_REPORTING DISABLE_AUTOUPDATER DISABLE_NON_ESSENTIAL_MODEL_CALLS CLAUDE_MODEL');
 
-        // Set FORGE env vars (short, separate command)
-        execSync(`tmux send-keys -t "${sessionName}" 'export FORGE_WORKSPACE_ID="${this.workspaceId}" FORGE_AGENT_ID="${config.id}" FORGE_PORT="${Number(process.env.PORT) || 8403}"' Enter`, { timeout: 5000 });
+        // Set FORGE env vars
+        scriptLines.push(`export FORGE_WORKSPACE_ID="${this.workspaceId}" FORGE_AGENT_ID="${config.id}" FORGE_PORT="${Number(process.env.PORT) || 8403}"`);
 
-        // Set profile env vars if any (separate command to avoid truncation)
+        // Set profile env vars
         if (envExports) {
-          execSync(`tmux send-keys -t "${sessionName}" '${envExports.replace(/ && $/, '')}' Enter`, { timeout: 5000 });
+          scriptLines.push(envExports.replace(/ && /g, '\n').replace(/\n$/, ''));
         }
 
-        // Build CLI start command
-        const parts: string[] = [];
+        // Build CLI command
         let cmd = cliCmd;
-
-        // Session resume: use bound session ID (primary from project-sessions, others from config)
         if (supportsSession) {
           let sessionId: string | undefined;
-
           if (config.primary) {
             try {
               const { getFixedSession } = await import('../project-sessions') as any;
@@ -2052,7 +2053,6 @@ export class WorkspaceOrchestrator extends EventEmitter {
           } else {
             sessionId = config.boundSessionId;
           }
-
           if (sessionId) {
             const sessionFile = join(this.getCliSessionDir(config.workDir), `${sessionId}.jsonl`);
             if (existsSync(sessionFile)) {
@@ -2061,15 +2061,16 @@ export class WorkspaceOrchestrator extends EventEmitter {
               console.log(`[daemon] ${config.label}: bound session ${sessionId} missing, starting fresh`);
             }
           }
-          // No bound session → start fresh (no -c, avoids "No conversation found")
         }
         if (modelFlag) cmd += modelFlag;
         if (config.skipPermissions !== false && skipPermissionsFlag) cmd += ` ${skipPermissionsFlag}`;
         if (mcpConfigFlag) cmd += mcpConfigFlag;
-        parts.push(cmd);
+        scriptLines.push(`exec ${cmd}`);
 
-        const startCmd = parts.join(' && ');
-        execSync(`tmux send-keys -t "${sessionName}" '${startCmd}' Enter`, { timeout: 5000 });
+        // Write script and execute in tmux
+        const scriptPath = `/tmp/forge-launch-${config.id.replace(/[^a-z0-9-]/g, '')}.sh`;
+        writeFileSync(scriptPath, scriptLines.join('\n'), { mode: 0o755 });
+        execSync(`tmux send-keys -t "${sessionName}" 'bash ${scriptPath}' Enter`, { timeout: 5000 });
 
         console.log(`[daemon] ${config.label}: persistent session created (${sessionName}) [${cliType}: ${cliCmd}]`);
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aion0/forge",
-  "version": "0.5.12",
+  "version": "0.5.14",
   "description": "Unified AI workflow platform — multi-model task orchestration, persistent sessions, web terminal, remote access",
   "type": "module",
   "scripts": {