@ainova-systems/intelligence 0.18.1 → 0.19.0

package/engine/adapters/codex.sh

@@ -9,7 +9,9 @@
 # Skills: copy skill directories in full to .agents/skills/{name}/ (Codex
 #   reads from $REPO_ROOT/.agents/skills exclusively per official docs)
 # Agents: -> .codex/agents/{name}.toml (name, description, model,
-#   model_reasoning_effort, sandbox_mode, developer_instructions)
+#   model_reasoning_effort, sandbox_mode, developer_instructions).
+#   model_reasoning_effort comes from `effort:` alone — never from the tier —
+#   and is omitted without one, so Codex's own setting applies.
 #
 # Every per-file loop batches its work into one awk process (see the batched
 # helpers in lib/common.sh): process spawns dominate sync time on Windows.
@@ -97,18 +99,12 @@ sync_codex_agents() {
     if [ "${#files[@]}" -gt 0 ]; then
         load_model_tiers "$config_file" "codex"
 
-        local path tier access description name effort sandbox spec="" report="" LS=$'\x1e'
-        while IFS=$'\x1f' read -r path tier access description; do
+        local path tier access description effort name sandbox spec="" report="" LS=$'\x1e'
+        while IFS=$'\x1f' read -r path tier access description effort; do
             [ -n "$path" ] || continue
             name="${path##*/}"; name="${name%.md}"
             resolve_model_var "$tier"
-            case "$tier" in
-                frontier) effort="xhigh" ;;
-                heavy|"") effort="high" ;;
-                standard) effort="medium" ;;
-                light)    effort="low" ;;
-                *)        effort="medium" ;;
-            esac
+            map_effort_var codex "$effort"
             case "$access" in
                 readonly) sandbox="read-only" ;;
                 *)        sandbox="workspace-write" ;;
@@ -121,7 +117,7 @@ sync_codex_agents() {
             header="${LS}name = \"$name_escaped\""
             header+="${LS}description = \"$description_escaped\""
             header+="${LS}model = \"$IS_MODEL\""
-            header+="${LS}model_reasoning_effort = \"$effort\""
+            [ -z "$IS_EFFORT" ] || header+="${LS}model_reasoning_effort = \"$IS_EFFORT\""
             header+="${LS}sandbox_mode = \"$sandbox\""
             header+="${LS}"
             header+="${LS}developer_instructions = \"\"\""
@@ -129,7 +125,7 @@ sync_codex_agents() {
             spec+="$path"$'\x1f'"$output_dir/$name.toml"$'\x1f'"fence"$'\x1f'"1"$'\x1f'"toml"$'\x1f'"$header"$'\x1f'"${LS}\"\"\""$'\n'
             report+="  agent: $name.toml"$'\n'
             count=$((count + 1))
-        done < <(frontmatter_index "tier,access,description" "${files[@]}")
+        done < <(frontmatter_index "tier,access,description,effort" "${files[@]}")
 
         emit_wrapped_bodies "$spec"
         printf '%s' "$report"

package/engine/adapters/copilot.sh

@@ -12,13 +12,20 @@
 # Skills: copy skill directories in full to .github/skills/{name}/
 # Agents: -> .github/agents/{name}.agent.md (description, tools, model)
 #
+# Git policy (decision 0020): generated output is ignored by default, as it is
+# for Cursor and Claude Code — Copilot in the editor reads it from disk after
+# sync. GitHub's cloud Copilot (code review, the coding agent) reads the
+# repository instead, so `targets.copilot.commit_output: true` keeps the output
+# tracked. Only the generated subdirectories are named, never `.github/`
+# itself: workflows, templates and hand-written files there stay tracked.
+#
 # Every per-file loop batches its work into one awk process (see the batched
 # helpers in lib/common.sh): process spawns dominate sync time on Windows.
 
 source "$(dirname "${BASH_SOURCE[0]}")/../lib/common.sh"
 
 adapter_contract_copilot() {
-    local output="${1%/}"
+    local output="${1%/}" record=adapter_contract_ignore sub
     adapter_contract_version 1
     adapter_contract_requires agents
     adapter_contract_owned "$output/instructions"
@@ -26,6 +33,37 @@ adapter_contract_copilot() {
     adapter_contract_owned "$output/agents"
     adapter_contract_owned "$output/skills"
     adapter_contract_legacy "$output/copilot-instructions.md"
+    # A malformed value declares the default here; sync refuses it with the
+    # reason, so the policy never rests on a guess.
+    if copilot_commit_output_var "${2:-}" && [ "$IS_COPILOT_COMMIT_OUTPUT" = 1 ]; then
+        record=adapter_contract_unignore
+    fi
+    # The same four paths the contract owns: every sync rewrites them, so the
+    # ignore covers generated output only.
+    for sub in instructions prompts agents skills; do
+        "$record" "$output/$sub/"
+    done
+    # The root instructions file onboarding quarantines, like CLAUDE.md and
+    # .cursorrules: its content migrates into project rules, and a copy left
+    # behind makes Copilot ignore AGENTS.md (copilot-cli#489).
+    "$record" "$output/copilot-instructions.md"
+}
+
+# copilot_commit_output_var <manifest> — the one reader of
+# targets.copilot.commit_output. Sets IS_COPILOT_COMMIT_OUTPUT to 1 when the
+# project commits generated output and 0 for the default; returns 1 for any
+# value other than true or false. No manifest — a caller reading ownership
+# only — is the default.
+copilot_commit_output_var() {
+    local manifest="$1" setting
+    IS_COPILOT_COMMIT_OUTPUT=0
+    [ -n "$manifest" ] && [ -f "$manifest" ] || return 0
+    setting="$(get_target_field "$manifest" "copilot" "commit_output")"
+    case "$setting" in
+        ''|false) ;;
+        true) IS_COPILOT_COMMIT_OUTPUT=1 ;;
+        *) return 1 ;;
+    esac
 }
 
 # copilot_paths_rows <file>... — batch form of the old per-file `paths:`
@@ -143,7 +181,8 @@ sync_copilot_skills() {
 
     local count=0
     if [ "${#skill_dirs[@]}" -gt 0 ]; then
-        copy_skill_bundle_dirs "$output_dir/skills" "${skill_dirs[@]}"
+        # Copilot has no effort field: the copy carries no `effort:`.
+        copy_skill_bundle_dirs_for copilot "$output_dir/skills" "${skill_dirs[@]}"
         for d in "${skill_dirs[@]}"; do
             skill_name="${d%/}"
             count=$((count + 1))
@@ -221,6 +260,11 @@ sync_to_copilot() {
 
     echo "=== GitHub Copilot ==="
 
+    copilot_commit_output_var "$config_file" || {
+        echo "ERROR: targets.copilot.commit_output must be true or false: true keeps generated Copilot output tracked, false or omission ignores it." >&2
+        return 1
+    }
+
     # Clean generated content (preserve workflows, etc.)
     rm -rf "$output_dir/instructions" "$output_dir/prompts"
     if [ -d "$output_dir/skills" ]; then

package/engine/adapters/cursor.sh

@@ -10,6 +10,8 @@
 #     same rules would cause double-loading and burn the context window.
 # Skills: copy skill directories in full (SKILL.md + bundled resources)
 # Agents: strip tier/access/tools/disallowedTools, add model + readonly:true
+# Cursor has no per-agent or per-skill effort field (its effort is part of a
+# model ID), so `effort:` is stripped from both.
 #
 # Every per-file loop batches its work into one awk process (see the batched
 # helpers in lib/common.sh): process spawns dominate sync time on Windows.
@@ -113,7 +115,7 @@ sync_cursor_skills() {
         done
     done <<< "$list"
     [ "${#skill_dirs[@]}" -gt 0 ] || return 0
-    copy_skill_bundle_dirs "$output_dir/skills" "${skill_dirs[@]}"
+    copy_skill_bundle_dirs_for cursor "$output_dir/skills" "${skill_dirs[@]}"
     for d in "${skill_dirs[@]}"; do
         skill_name="${d%/}"
         echo "  skill: ${skill_name##*/}"
@@ -170,13 +172,16 @@ sync_cursor_agents() {
             if (out != "") close(out)
             out = dst "/" base_name(FILENAME)
             count = 0
+            fm = 0
         }
         /^tier:/  { next }
         /^access:/ { next }
         /^tools:/ { next }
         /^disallowedTools:/ { next }
         { sub(/\r$/, "") }
+        FNR == 1 && $0 == "---" { fm = 1 }
         /^---$/ { count++ }
+        fm && count == 1 && substr($0, 1, 7) == "effort:" { next }
         count == 2 && /^---$/ {
             print fin_line("model: " MODEL[FILENAME]) > out
             if (RO[FILENAME] != "") print fin_line(RO[FILENAME]) > out

package/engine/lib/adapter-contract.sh

@@ -1,10 +1,17 @@
 #!/bin/bash
 # Declarative adapter ownership contract shared by the engine and CLI.
 #
-# Every adapter exposes adapter_contract_<name> <configured-output>. The
-# function emits tab-separated records through the helpers below. Keeping the
+# Every adapter exposes adapter_contract_<name> <configured-output> [manifest].
+# The function emits tab-separated records through the helpers below. Keeping the
 # declaration beside sync_to_<name>() makes backup, rollback, git policy and
 # lifecycle checks consume the same ownership model as the writer itself.
+#
+# The manifest argument exists for Git policy alone: a target field may choose
+# whether generated output is ignored (targets.copilot.commit_output). Ownership
+# never depends on it, so the engine and the sync cache, which read ownership
+# only, pass none and spare every sync the extra read; a contract given none
+# declares its default policy. Every caller that applies or checks Git policy
+# passes the manifest.
 
 adapter_contract_version()  { printf 'version\t%s\n' "$1"; }
 adapter_contract_requires() { printf 'requires\t%s\n' "$1"; }
@@ -14,6 +21,10 @@ adapter_contract_legacy()   { printf 'legacy\t%s\n' "$1"; }
 adapter_contract_preserve() { printf 'preserve\t%s\n' "$1"; }
 adapter_contract_ignore()   { printf 'ignore\t%s\n' "$1"; }
 adapter_contract_include()  { printf 'include\t%s\n' "$1"; }
+# An ignore line the policy must not hold: the writer takes it back out of the
+# region it manages. It is how a configuration that keeps output tracked undoes
+# the default ignore an earlier alignment already wrote.
+adapter_contract_unignore() { printf 'unignore\t%s\n' "$1"; }
 
 # --- cross-adapter ownership -------------------------------------------------
 #
@@ -106,12 +117,12 @@ adapter_contract_safe_concrete_path() {
     esac
 }
 
-# adapter_contract_records <adapter-name> <adapter-file> <configured-output>
+# adapter_contract_records <adapter-name> <adapter-file> <configured-output> [manifest]
 # Source and query in a subshell so a project adapter cannot leak shell state
 # into the caller. Project adapters are trusted executable code during sync;
 # the isolation here is for correctness, not a security boundary.
 adapter_contract_records() (
-    local name="$1" file="$2" output="$3" fn line kind value saw_version=0
+    local name="$1" file="$2" output="$3" manifest="${4:-}" fn line kind value saw_version=0
     # shellcheck source=/dev/null
     source "$file"
     printf -v fn 'adapter_contract_%s' "$name"
@@ -149,7 +160,7 @@ adapter_contract_records() (
                     return 1
                 }
                 ;;
-            ignore|include)
+            ignore|include|unignore)
                 adapter_contract_safe_path "$value" || {
                     echo "ERROR: adapter '$name' declares unsafe $kind path '$value'" >&2
                     return 1
@@ -161,7 +172,7 @@ adapter_contract_records() (
                 ;;
         esac
         printf '%s\n' "$line"
-    done < <("$fn" "$output")
+    done < <("$fn" "$output" "$manifest")
     [ "$saw_version" -eq 1 ] || {
         echo "ERROR: adapter '$name' contract did not declare version 1" >&2
         return 1