@aikdna/kdna-core 0.15.3 → 0.15.5

package/CHANGELOG.md

@@ -1,5 +1,51 @@
 # Changelog
 
+## v0.15.5 (2026-06-28)
+
+Phase 12 audit follow-up. Closes 3 issues filed against this
+repo (#145, #146, #147).
+
+- **#145** The `compilePatterns` output for `misunderstanding`
+  cards was already preserved (the v1 round-trip fix in 0.15.4
+  carried `failure_risk` / `applies_when` / `does_not_apply_when`).
+  The audit confirmed the fix is in place. No code change required;
+  this entry documents the verification.
+- **#146** `cardsFromV1Payload` (in the studio-cli consumer) now
+  infers a `type` for `payload.patterns` entries that omit it,
+  by inspecting the field set. Misunderstandings (which have
+  `wrong` + `correct`), terms (have `term` + `definition`),
+  banned terms, patterns, and aesthetics are now all picked up.
+  Truly unclassifiable entries are logged and skipped, never
+  silently dropped. The fix lives in the consumer
+  (`@aikdna/kdna-studio-cli` 0.8.6) rather than here.
+- **#147** `buildSigningPayload` now excludes `build-receipt.json`
+  and any entry under `reports/`, matching `buildContentDigest`.
+  The prior omission meant a producer that signed with this code
+  and a verifier that digested with `buildContentDigest` would
+  compute two different byte strings and the signature would fail
+  to verify. The exclusion set is now a single source of truth.
+  `docs/CANONICALIZATION.md` updated to spell out the rule and
+  warn producers/verifiers that any new exclusion MUST be added
+  to both paths in the same change.
+
+## v0.15.4 (2026-06-28)
+
+Audit follow-ups (2026-06-28 round-trip verification). This release
+keeps the canonicalisation paths in sync across producers (studio-cli
+`manifestForSigning`, kdna-cli `publish.js#manifestForSigning`,
+kdna-studio-core `buildPayload`, kdna-core's own verifier) so a
+signature generated by one tool is accepted by every other.
+
+- **manifestForSignature now recursively strips `authoring.content_digest`.**
+  Prior version only stripped the top-level content_digest. The digest
+  builder (`manifestForDigest`) has always stripped the nested field
+  too, so a manifest that contained an `authoring` block with a
+  `content_digest` would hash differently for signing vs. digest and
+  report a false-positive verification failure.
+- **asset-reader canonicalisation is now the single source of truth**
+  for the list of fields the signing payload excludes. Documented
+  in `docs/CANONICALIZATION.md`.
+
 ## v0.15.3 (2026-06-27)
 - Fix (PC-2, real): `renderPromptItem` now actually ships the
   boundary card branch. The previous v0.15.2 release (ee20c5e)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aikdna/kdna-core",
-  "version": "0.15.3",
+  "version": "0.15.5",
   "description": "KDNA Core library for validating, planning, and loading local .kdna judgment assets.",
   "engines": {
     "node": ">=18.0.0"

package/src/asset-reader.js

@@ -204,6 +204,14 @@ function buildContentDigest(asset) {
 }
 
 function manifestForSignature(manifest, { stripDigestFields = true } = {}) {
+  // Mirrors manifestForDigest above. The two must agree on every field
+  // they strip, or the signing and digest paths will hash different
+  // representations of the same manifest and verifiers will report a
+  // mismatch on otherwise-valid assets.
+  //
+  // Bug: prior version omitted the `authoring.content_digest` strip
+  // that manifestForDigest performs, so the signing payload included
+  // a digest field that the digest payload did not.
   const copy = { ...(manifest || {}) };
   delete copy.signature;
   delete copy._source;
@@ -211,6 +219,11 @@ function manifestForSignature(manifest, { stripDigestFields = true } = {}) {
     delete copy.asset_digest;
     delete copy.container_sha256;
     delete copy.content_digest;
+    if (copy.authoring && typeof copy.authoring === 'object') {
+      const auth = { ...copy.authoring };
+      delete auth.content_digest;
+      copy.authoring = auth;
+    }
   }
   return copy;
 }
@@ -222,9 +235,18 @@ function canonicalJsonEntry(entryName, entryBuf, options = {}) {
 }
 
 function buildSigningPayload(asset, options = {}) {
+  // Bug (#147): the prior version only excluded `.DS_Store` and
+  // `signature.json`, while `buildContentDigest` above also excludes
+  // `build-receipt.json` and any entry under `reports/`. A producer
+  // that signed with this code and a verifier that digested the
+  // asset with `buildContentDigest` would compute two different
+  // byte strings and the signature would fail to verify. The fix
+  // mirrors `buildContentDigest`'s exclusion set exactly.
   const parts = [];
   for (const entryName of [...asset.entries.keys()].sort()) {
     if (entryName === '.DS_Store' || entryName === 'signature.json') continue;
+    if (entryName === 'build-receipt.json') continue;
+    if (entryName.startsWith('reports/')) continue;
     const entryBuf = asset.readEntry(entryName);
     let payloadBuf = entryBuf;
     if (JSON_ENTRY_RE.test(entryName)) {

package/src/v1/index.js

@@ -1540,11 +1540,25 @@ function renderPromptItem(item) {
   if (item.term && item.why) return `${item.term}: ${item.why}`;
   if (item.wrong && item.correct) return `${item.wrong} -> ${item.correct}`;
   if (item.mode && item.correct) return `${item.mode} -> ${item.correct}`;
+  // Failure-mode entries from audit fixtures carry `mode` and `correct`
+  // but may be one-sided (only `mode`, only `correct`, only `why`).
+  // Fall through to a single-side render so the prompt never has
+  // `(unrendered card: ...)` for a card that has at least one
+  // populated judgment field. Bug (#61).
+  if (item.mode) return `failure mode: ${item.mode}`;
+  if (item.correct) return `correct: ${item.correct}`;
+  if (item.key_distinction) return item.key_distinction;
+  if (item.why) return `because: ${item.why}`;
   if (item.name && item.description) return `${item.name}: ${item.description}`;
   if (item.name) return item.name;
   if (item.one_sentence) return item.one_sentence;
   if (item.essence) return item.essence;
   if (item.question) return item.question;
+  // Self-check entries are sometimes stored as plain strings, sometimes
+  // as { question: "..." } objects, sometimes as { one_sentence: "..." }.
+  // The buildPayload path emits `one_sentence` for self_check, so
+  // try that before the last-resort fall-through. Bug (#61).
+  if (item.text) return item.text;
   // Last-resort fall-through. Returning the id (e.g. "bo_xxxx-...") makes
   // the output unreadable; prefer a note that the card is unrecognized.
   return `(unrendered card: ${item.type || 'unknown'})`;