@aigne/doc-smith 0.8.12-beta.3 → 0.8.12-beta.5

package/tests/agents/update/check-document.test.mjs

@@ -3,7 +3,6 @@ import * as fsPromises from "node:fs/promises";
 import * as aigneCore from "@aigne/core";
 import checkDocument from "../../../agents/update/check-document.mjs";
 import * as checkDetailResultModule from "../../../agents/utils/check-detail-result.mjs";
-import * as utils from "../../../utils/utils.mjs";
 
 describe("check-document", () => {
   let mockOptions;
@@ -12,7 +11,6 @@ describe("check-document", () => {
   let teamAgentFromSpy;
 
   // Spies for internal utils and fs operations
-  let hasSourceFilesChangedSpy;
   let checkDetailResultSpy;
   let consoleSpy;
   let accessSpy;
@@ -32,7 +30,6 @@ describe("check-document", () => {
     };
 
     // Set up spies for internal utils
-    hasSourceFilesChangedSpy = spyOn(utils, "hasSourceFilesChanged").mockReturnValue(false);
     checkDetailResultSpy = spyOn(checkDetailResultModule, "default").mockResolvedValue({
       isApproved: true,
       detailFeedback: "",
@@ -50,7 +47,6 @@ describe("check-document", () => {
   afterEach(() => {
     // Restore all spies
     teamAgentFromSpy?.mockRestore();
-    hasSourceFilesChangedSpy?.mockRestore();
     checkDetailResultSpy?.mockRestore();
     consoleSpy?.mockRestore();
     accessSpy?.mockRestore();
@@ -197,68 +193,8 @@ describe("check-document", () => {
     expect(mockOptions.context.invoke).not.toHaveBeenCalled();
   });
 
-  // SOURCE FILES CHANGE TESTS
-  test("should regenerate when source files have changed", async () => {
-    accessSpy.mockResolvedValue();
-    checkDetailResultSpy.mockResolvedValue({ isApproved: true });
-    hasSourceFilesChangedSpy.mockReturnValue(true);
-
-    await checkDocument(
-      {
-        path: "/getting-started",
-        docsDir: "./docs",
-        sourceIds: ["file1.js"],
-        originalDocumentStructure: [{ path: "/getting-started", sourceIds: ["file1.js"] }],
-        documentStructure: [{ path: "/getting-started" }],
-        modifiedFiles: ["file1.js"],
-      },
-      mockOptions,
-    );
-
-    expect(hasSourceFilesChangedSpy).toHaveBeenCalledWith(["file1.js"], ["file1.js"]);
-    expect(consoleSpy).toHaveBeenCalledWith(
-      "Source files changed for /getting-started, will regenerate",
-    );
-    expect(mockOptions.context.invoke).toHaveBeenCalled();
-  });
-
-  test("should not check source files when no sourceIds provided", async () => {
-    accessSpy.mockResolvedValue();
-    checkDetailResultSpy.mockResolvedValue({ isApproved: true });
-
-    const result = await checkDocument(
-      {
-        path: "/getting-started",
-        docsDir: "./docs",
-        sourceIds: [],
-        documentStructure: [{ path: "/getting-started" }],
-        modifiedFiles: ["file1.js"],
-      },
-      mockOptions,
-    );
-
-    expect(hasSourceFilesChangedSpy).not.toHaveBeenCalled();
-    expect(result.detailGenerated).toBe(true);
-  });
-
-  test("should not check source files when no modifiedFiles provided", async () => {
-    accessSpy.mockResolvedValue();
-    checkDetailResultSpy.mockResolvedValue({ isApproved: true });
-
-    const result = await checkDocument(
-      {
-        path: "/getting-started",
-        docsDir: "./docs",
-        sourceIds: ["file1.js"],
-        documentStructure: [{ path: "/getting-started" }],
-        modifiedFiles: null,
-      },
-      mockOptions,
-    );
-
-    expect(hasSourceFilesChangedSpy).not.toHaveBeenCalled();
-    expect(result.detailGenerated).toBe(true);
-  });
+  // SOURCE FILES CHANGE TESTS - These tests are now obsolete as modifiedFiles checking has been removed
+  // The check-document function now only checks for sourceIds changes and content validation
 
   // CONTENT VALIDATION TESTS
   test("should regenerate when content validation fails", async () => {
@@ -420,12 +356,16 @@ describe("check-document", () => {
       {
         path: "/api/users/create",
         docsDir: "./docs",
+        locale: "en",
       },
       mockOptions,
     );
 
     // "/api/users/create" -> flatName "api-users-create" -> fileFullName "api-users-create.md"
-    expect(accessSpy).toHaveBeenCalledWith(expect.stringMatching(/api-users-create\.md$/));
+    // The access function is called with a full path that includes docsDir
+    expect(accessSpy).toHaveBeenCalled();
+    const callArg = accessSpy.mock.calls[0][0];
+    expect(callArg).toMatch(/api-users-create\.md$/);
   });
 
   // RESULT STRUCTURE TESTS

package/tests/agents/utils/load-sources.test.mjs

@@ -156,11 +156,11 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
-    expect(result.datasourcesList.length).toBeGreaterThan(0);
+    expect(result.files).toBeDefined();
+    expect(result.files.length).toBeGreaterThan(0);
 
     // Should include package.json, README.md, src files
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
     expect(filePaths.some((element) => element.includes("package.json"))).toBe(true);
     expect(filePaths.some((element) => element.includes("README.md"))).toBe(true);
     expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(true);
@@ -182,10 +182,10 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
-    expect(result.datasourcesList.length).toBeGreaterThan(0);
+    expect(result.files).toBeDefined();
+    expect(result.files.length).toBeGreaterThan(0);
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
     expect(filePaths.some((element) => element.includes("package.json"))).toBe(true);
     expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(true);
     expect(filePaths.some((element) => element.includes("src/utils.js"))).toBe(true);
@@ -204,9 +204,9 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
+    expect(result.files).toBeDefined();
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
 
     // Should exclude files listed in .gitignore
     expect(filePaths.some((element) => element.includes("node_modules"))).toBe(false);
@@ -224,9 +224,9 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
+    expect(result.files).toBeDefined();
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
     expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(true);
     expect(filePaths.some((element) => element.includes("src/utils.js"))).toBe(true);
 
@@ -243,10 +243,10 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
-    expect(result.datasourcesList.length).toBeGreaterThan(0);
+    expect(result.files).toBeDefined();
+    expect(result.files.length).toBeGreaterThan(0);
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
     expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(true);
     expect(filePaths.some((element) => element.includes("src/utils.js"))).toBe(true);
   });
@@ -259,8 +259,8 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
-    expect(result.datasourcesList.length).toBe(0);
+    expect(result.files).toBeDefined();
+    expect(result.files.length).toBe(0);
   });
 
   test("should merge user patterns with default patterns", async () => {
@@ -273,9 +273,9 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
+    expect(result.files).toBeDefined();
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
 
     // Should include default patterns (package.json, README.md, etc.)
     expect(filePaths.some((element) => element.includes("package.json"))).toBe(true);
@@ -295,10 +295,10 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
-    expect(result.datasourcesList.length).toBeGreaterThan(0);
+    expect(result.files).toBeDefined();
+    expect(result.files.length).toBeGreaterThan(0);
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
 
     // Should include files from all levels
     expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(true);
@@ -333,9 +333,9 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
+    expect(result.files).toBeDefined();
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
 
     // Should include files from specified subdirectories
     expect(filePaths.some((element) => element.includes("src/components/Button.js"))).toBe(true);
@@ -363,9 +363,9 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
+    expect(result.files).toBeDefined();
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
 
     // Should include JS files from all levels
     expect(filePaths.some((element) => element.includes("src/components/Button.js"))).toBe(true);
@@ -390,9 +390,9 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
+    expect(result.files).toBeDefined();
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
 
     // For now, let's verify that regular files are still included
     expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(true);
@@ -413,10 +413,10 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
-    expect(result.datasourcesList.length).toBeGreaterThan(0);
+    expect(result.files).toBeDefined();
+    expect(result.files.length).toBeGreaterThan(0);
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
 
     // Should include JS files from src directory and subdirectories
     expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(true);
@@ -439,10 +439,10 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
-    expect(result.datasourcesList.length).toBeGreaterThan(0);
+    expect(result.files).toBeDefined();
+    expect(result.files.length).toBeGreaterThan(0);
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
 
     // Should include JS files from src directory
     expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(true);
@@ -466,9 +466,9 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
+    expect(result.files).toBeDefined();
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
 
     // Should include JS files
     expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(true);
@@ -492,8 +492,8 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
-    expect(result.datasourcesList.length).toBe(0);
+    expect(result.files).toBeDefined();
+    expect(result.files.length).toBe(0);
   });
 
   test("should handle mixed regular paths and glob patterns", async () => {
@@ -505,10 +505,10 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
-    expect(result.datasourcesList.length).toBeGreaterThan(0);
+    expect(result.files).toBeDefined();
+    expect(result.files.length).toBeGreaterThan(0);
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
 
     // Should include markdown files from directory scan
     expect(filePaths.some((element) => element.includes("README.md"))).toBe(true);
@@ -526,9 +526,9 @@ describe("load-sources", () => {
       docsDir: path.join(testDir, "docs"),
     });
 
-    expect(result.datasourcesList).toBeDefined();
+    expect(result.files).toBeDefined();
 
-    const filePaths = result.datasourcesList.map((f) => f.sourceId);
+    const filePaths = result.files;
 
     // Should match Button.js with character class
     expect(filePaths.some((element) => element.includes("src/components/Button.js"))).toBe(true);
@@ -552,10 +552,10 @@ describe("load-sources", () => {
 
       const result = await loadSources(yamlConfigInput);
 
-      expect(result.datasourcesList).toBeDefined();
-      expect(result.datasourcesList.length).toBeGreaterThan(0);
+      expect(result.files).toBeDefined();
+      expect(result.files.length).toBeGreaterThan(0);
 
-      const filePaths = result.datasourcesList.map((f) => f.sourceId);
+      const filePaths = result.files;
       expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(true);
     });
 
@@ -568,8 +568,8 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
-      expect(result.datasourcesList.length).toBe(0);
+      expect(result.files).toBeDefined();
+      expect(result.files.length).toBe(0);
       expect(result.files.length).toBe(0);
 
       // Empty arrays are handled gracefully - this is correct behavior
@@ -588,7 +588,7 @@ describe("load-sources", () => {
       });
 
       // Should successfully process valid paths and ignore invalid ones
-      expect(result.datasourcesList).toBeDefined();
+      expect(result.files).toBeDefined();
       // This test will FAIL because the function crashes instead of filtering
     });
 
@@ -601,9 +601,9 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
-      expect(Array.isArray(result.datasourcesList)).toBe(true);
-      expect(result.datasourcesList.length).toBe(0);
+      expect(result.files).toBeDefined();
+      expect(Array.isArray(result.files)).toBe(true);
+      expect(result.files.length).toBe(0);
 
       // undefined is handled gracefully by skipping sourcesPath processing
     });
@@ -627,9 +627,9 @@ describe("load-sources", () => {
             outputDir: tempDir,
             docsDir: path.join(testDir, "docs"),
           });
-          expect(result.datasourcesList).toBeDefined();
-          expect(Array.isArray(result.datasourcesList)).toBe(true);
-          expect(result.datasourcesList.length).toBe(0);
+          expect(result.files).toBeDefined();
+          expect(Array.isArray(result.files)).toBe(true);
+          expect(result.files.length).toBe(0);
         }
       }
 
@@ -651,7 +651,7 @@ describe("load-sources", () => {
           docsDir: path.join(testDir, "docs"),
         });
 
-        expect(result.datasourcesList).toBeDefined();
+        expect(result.files).toBeDefined();
         // Some of these tests will FAIL, exposing input validation issues
       }
     });
@@ -673,8 +673,8 @@ describe("load-sources", () => {
           docsDir: path.join(testDir, "docs"),
         });
 
-        expect(result.datasourcesList).toBeDefined();
-        const filePaths = result.datasourcesList.map((f) => f.sourceId);
+        expect(result.files).toBeDefined();
+        const filePaths = result.files;
         expect(filePaths.some((element) => element.includes("index.js"))).toBe(true);
       } catch {
         // Skip test on systems that don't support symlinks
@@ -699,8 +699,8 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
-      const filePaths = result.datasourcesList.map((f) => f.sourceId);
+      expect(result.files).toBeDefined();
+      const filePaths = result.files;
       expect(filePaths.some((element) => element.includes("a/b/c/d/e/f/g/h/deep.js"))).toBe(true);
     });
 
@@ -724,8 +724,8 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
-      const filePaths = result.datasourcesList.map((f) => f.sourceId);
+      expect(result.files).toBeDefined();
+      const filePaths = result.files;
 
       expect(filePaths.some((element) => element.includes("file with spaces.js"))).toBe(true);
       expect(filePaths.some((element) => element.includes("file-with-dashes.js"))).toBe(true);
@@ -745,8 +745,8 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
-      expect(result.datasourcesList.length).toBe(0);
+      expect(result.files).toBeDefined();
+      expect(result.files.length).toBe(0);
     });
   });
 
@@ -761,8 +761,8 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
-      const filePaths = result.datasourcesList.map((f) => f.sourceId);
+      expect(result.files).toBeDefined();
+      const filePaths = result.files;
 
       // Should still exclude test files by default gitignore/patterns
       expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(true);
@@ -779,8 +779,8 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
-      const filePaths = result.datasourcesList.map((f) => f.sourceId);
+      expect(result.files).toBeDefined();
+      const filePaths = result.files;
 
       // Exclude should win over include
       expect(filePaths.some((element) => element.includes("src/index.js"))).toBe(false);
@@ -801,8 +801,8 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
-      const filePaths = result.datasourcesList.map((f) => f.sourceId);
+      expect(result.files).toBeDefined();
+      const filePaths = result.files;
 
       expect(filePaths.some((element) => element.includes("CamelCase.js"))).toBe(true);
       expect(filePaths.some((element) => element.includes("lowercase.js"))).toBe(true);
@@ -821,9 +821,9 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
+      expect(result.files).toBeDefined();
       // Just verify it doesn't crash and returns some results
-      expect(Array.isArray(result.datasourcesList)).toBe(true);
+      expect(Array.isArray(result.files)).toBe(true);
     });
   });
 
@@ -843,7 +843,7 @@ describe("load-sources", () => {
       });
       const endTime = Date.now();
 
-      expect(result.datasourcesList).toBeDefined();
+      expect(result.files).toBeDefined();
       expect(endTime - startTime).toBeLessThan(5000); // Should complete within 5 seconds
     });
 
@@ -861,8 +861,8 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
-      const filePaths = result.datasourcesList.map((f) => f.sourceId);
+      expect(result.files).toBeDefined();
+      const filePaths = result.files;
       expect(filePaths.some((element) => element.includes(longDirName))).toBe(true);
     });
   });
@@ -881,7 +881,7 @@ describe("load-sources", () => {
           docsDir: path.join(testDir, "docs"),
         });
 
-        expect(result.datasourcesList).toBeDefined();
+        expect(result.files).toBeDefined();
         // Should handle gracefully without crashing
       } catch {
         // Skip on systems where permission tests don't work
@@ -897,9 +897,9 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
+      expect(result.files).toBeDefined();
       // Should not crash, even with malformed patterns
-      expect(Array.isArray(result.datasourcesList)).toBe(true);
+      expect(Array.isArray(result.files)).toBe(true);
     });
 
     test("should handle circular symbolic links", async () => {
@@ -920,7 +920,7 @@ describe("load-sources", () => {
           docsDir: path.join(testDir, "docs"),
         });
 
-        expect(result.datasourcesList).toBeDefined();
+        expect(result.files).toBeDefined();
         // Should handle circular links without infinite loop
 
         // Clean up circular links immediately to prevent interference with other tests
@@ -958,8 +958,8 @@ describe("load-sources", () => {
           docsDir: path.join(testDir, "docs"),
         });
 
-        expect(result.datasourcesList).toBeDefined();
-        expect(Array.isArray(result.datasourcesList)).toBe(true);
+        expect(result.files).toBeDefined();
+        expect(Array.isArray(result.files)).toBe(true);
         // Should not crash with any typical config
       }
     });
@@ -978,9 +978,9 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
-      expect(result.datasourcesList.length).toBe(1);
-      expect(result.datasourcesList[0].sourceId).toContain("single-file.js");
+      expect(result.files).toBeDefined();
+      expect(result.files.length).toBe(1);
+      expect(result.files[0]).toContain("single-file.js");
     });
 
     test("should process media files correctly", async () => {
@@ -1024,8 +1024,8 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList).toBeDefined();
-      expect(Array.isArray(result.datasourcesList)).toBe(true);
+      expect(result.files).toBeDefined();
+      expect(Array.isArray(result.files)).toBe(true);
       // Should handle gracefully without crashing
     });
   });
@@ -1246,8 +1246,8 @@ describe("load-sources", () => {
     });
   });
 
-  describe("Word and line counting", () => {
-    test("should count words and lines in source content", async () => {
+  describe("Token and line counting", () => {
+    test("should count tokens and lines in source content", async () => {
       // Create files with known content for counting
       await writeFile(
         path.join(testDir, "count-test.js"),
@@ -1262,9 +1262,9 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.totalWords).toBeGreaterThan(0);
+      expect(result.totalTokens).toBeGreaterThan(0);
       expect(result.totalLines).toBeGreaterThan(0);
-      expect(typeof result.totalWords).toBe("number");
+      expect(typeof result.totalTokens).toBe("number");
       expect(typeof result.totalLines).toBe("number");
     });
   });
@@ -1394,11 +1394,11 @@ describe("load-sources", () => {
         docsDir: path.join(testDir, "docs"),
       });
 
-      expect(result.datasourcesList.length).toBeGreaterThan(0);
+      expect(result.files.length).toBeGreaterThan(0);
       expect(result.assetsContent).toContain("mixed-image.png");
 
       // Verify both source files and media files are processed
-      const sourceFiles = result.datasourcesList.map((f) => f.sourceId);
+      const sourceFiles = result.files;
       expect(sourceFiles.some((f) => f.includes("mixed-test.js"))).toBe(true);
       expect(sourceFiles.some((f) => f.includes("mixed-doc.md"))).toBe(true);
     });