@ai-setting/roy-agent-core 1.0.0

package/src/env/workflow/nodes/workflow-node.test.ts

@@ -0,0 +1,315 @@
+import { describe, it, expect, beforeEach, jest } from 'vitest';
+import { WorkflowNode, WorkflowRunner, WorkflowRunResult } from './workflow-node';
+import type { NodeDefinition, NodeExecutionContext } from '../types';
+
+// Mock EventBus
+const mockEventBus = {
+  emit: jest.fn(),
+  on: jest.fn(),
+  off: jest.fn(),
+} as any;
+
+// Mock WorkflowRunner
+const createMockRunner = () => ({
+  run: jest.fn<(workflowName: string, input?: any) => Promise<WorkflowRunResult>>(),
+  getRun: jest.fn<(runId: string) => Promise<WorkflowRunResult | null>>(),
+});
+
+describe('WorkflowNode', () => {
+  let nodeDefinition: NodeDefinition;
+  let executionContext: NodeExecutionContext;
+  let mockRunner: ReturnType<typeof createMockRunner>;
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+    
+    nodeDefinition = {
+      id: 'workflow-node-1',
+      type: 'workflow',
+      name: 'Nested Workflow Node',
+      config: {
+        workflow_name: 'sub-workflow',
+        input: { message: 'hello from parent' },
+        wait_complete: true,
+      },
+    };
+
+    executionContext = {
+      sessionId: 'session-1',
+      nodeOutputs: {},
+      input: {},
+      metadata: {},
+    };
+
+    mockRunner = createMockRunner();
+  });
+
+  describe('constructor', () => {
+    it('should create a WorkflowNode with correct type', () => {
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      expect(workflowNode.type).toBe('workflow');
+      expect(workflowNode.id).toBe('workflow-node-1');
+    });
+
+    it('should create WorkflowNode with minimal config', () => {
+      const minimalDef: NodeDefinition = {
+        id: 'minimal-node',
+        type: 'workflow',
+        config: {
+          workflow_name: 'simple-workflow',
+        },
+      };
+      
+      const workflowNode = new WorkflowNode(minimalDef, mockRunner);
+      expect(workflowNode.type).toBe('workflow');
+      expect(workflowNode.id).toBe('minimal-node');
+    });
+  });
+
+  describe('execute', () => {
+    it('should run sub-workflow successfully', async () => {
+      const completedResult: WorkflowRunResult = {
+        runId: 'run_123',
+        status: 'completed',
+        output: { result: 'nested workflow done' },
+      };
+      
+      mockRunner.run.mockResolvedValue(completedResult);
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      const result = await workflowNode.execute(executionContext);
+      
+      expect(result.success).toBe(true);
+      expect(result.output).toEqual({ result: 'nested workflow done' });
+      expect(result.error).toBeUndefined();
+      expect(mockRunner.run).toHaveBeenCalledWith('sub-workflow', {
+        message: 'hello from parent',
+      });
+    });
+
+    it('should pass input to sub-workflow', async () => {
+      const customInput = { param1: 'value1', param2: 123, nested: { data: 'test' } };
+      nodeDefinition.config.input = customInput;
+      
+      mockRunner.run.mockResolvedValue({
+        runId: 'run_456',
+        status: 'completed',
+        output: { processed: true },
+      });
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      await workflowNode.execute(executionContext);
+      
+      expect(mockRunner.run).toHaveBeenCalledWith('sub-workflow', customInput);
+    });
+
+    it('should wait for completion when wait_complete=true', async () => {
+      nodeDefinition.config.wait_complete = true;
+      
+      mockRunner.run.mockResolvedValue({
+        runId: 'run_wait',
+        status: 'completed',
+        output: { waited: true },
+      });
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      const result = await workflowNode.execute(executionContext);
+      
+      expect(result.success).toBe(true);
+      expect(result.output).toEqual({ waited: true });
+      // When wait_complete=true, run should return completed status
+      expect(mockRunner.run).toHaveBeenCalled();
+    });
+
+    it('should not wait for completion when wait_complete=false', async () => {
+      nodeDefinition.config.wait_complete = false;
+      
+      mockRunner.run.mockResolvedValue({
+        runId: 'run_fire',
+        status: 'completed', // Fire-and-forget returns immediately
+        output: { runId: 'run_fire' },
+      });
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      const result = await workflowNode.execute(executionContext);
+      
+      expect(result.success).toBe(true);
+      expect(result.output).toBeDefined();
+      // Should have called run
+      expect(mockRunner.run).toHaveBeenCalled();
+    });
+
+    it('should handle sub-workflow failure', async () => {
+      mockRunner.run.mockResolvedValue({
+        runId: 'run_fail',
+        status: 'failed',
+        error: 'Sub-workflow execution failed',
+      });
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      const result = await workflowNode.execute(executionContext);
+      
+      expect(result.success).toBe(false);
+      expect(result.error).toBeDefined();
+      expect(result.error).toContain('Sub-workflow execution failed');
+    });
+
+    it('should handle sub-workflow not found', async () => {
+      mockRunner.run.mockRejectedValue(new Error('Workflow not found: non-existent-workflow'));
+      
+      nodeDefinition.config.workflow_name = 'non-existent-workflow';
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      const result = await workflowNode.execute(executionContext);
+      
+      expect(result.success).toBe(false);
+      expect(result.error).toBeDefined();
+      expect(result.error.message).toContain('Workflow not found');
+    });
+
+    it('should record execution duration', async () => {
+      mockRunner.run.mockImplementation(async () => {
+        await new Promise(resolve => setTimeout(resolve, 10));
+        return {
+          runId: 'run_duration',
+          status: 'completed',
+          output: { done: true },
+        };
+      });
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      const result = await workflowNode.execute(executionContext);
+      
+      expect(result.duration).toBeGreaterThanOrEqual(0);
+    });
+
+    it('should resolve template references from previous outputs', async () => {
+      // Set up previous outputs from other nodes
+      // Note: The Map format stores raw outputs directly, so path is {{nodeId.property}}
+      executionContext.previousOutputs = new Map([
+        ['node-0', { value: 'from-node-0' }]
+      ]);
+      
+      // Create node with template reference input
+      const templateNodeDef: NodeDefinition = {
+        id: 'workflow-node-1',
+        type: 'workflow',
+        name: 'Nested Workflow Node',
+        config: {
+          workflow_name: 'sub-workflow',
+          input: {
+            message: '{{node-0.value}}',
+          },
+        },
+      };
+      
+      mockRunner.run.mockResolvedValue({
+        runId: 'run_template',
+        status: 'completed',
+        output: { received: 'from-node-0' },
+      });
+      
+      const workflowNode = new WorkflowNode(templateNodeDef, mockRunner);
+      await workflowNode.execute(executionContext);
+      
+      // The input should have template references resolved
+      expect(mockRunner.run).toHaveBeenCalledWith('sub-workflow', {
+        message: 'from-node-0',
+      });
+    });
+
+    it('should handle unresolved template references gracefully', async () => {
+      nodeDefinition.config.input = {
+        message: '{{non-existent.value}}',
+      };
+      
+      mockRunner.run.mockResolvedValue({
+        runId: 'run_unresolved',
+        status: 'completed',
+        output: {},
+      });
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      await workflowNode.execute(executionContext);
+      
+      // Should pass through unresolved template as-is
+      expect(mockRunner.run).toHaveBeenCalledWith('sub-workflow', {
+        message: '{{non-existent.value}}',
+      });
+    });
+
+    it('should throw error when workflow_name is missing', async () => {
+      nodeDefinition.config = {}; // No workflow_name specified
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      const result = await workflowNode.execute(executionContext);
+      
+      expect(result.success).toBe(false);
+      expect(result.error).toBeDefined();
+      expect(result.error.message).toContain('workflow_name');
+    });
+
+    it('should pass metadata to sub-workflow', async () => {
+      executionContext.metadata = {
+        parentRunId: 'parent-123',
+        correlationId: 'corr-456',
+      };
+      
+      mockRunner.run.mockResolvedValue({
+        runId: 'run_meta',
+        status: 'completed',
+        output: {},
+      });
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      await workflowNode.execute(executionContext);
+      
+      expect(mockRunner.run).toHaveBeenCalledWith('sub-workflow', {
+        message: 'hello from parent',
+      });
+    });
+
+    it('should handle stopped sub-workflow', async () => {
+      mockRunner.run.mockResolvedValue({
+        runId: 'run_stopped',
+        status: 'stopped',
+        error: 'Workflow was stopped',
+      });
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      const result = await workflowNode.execute(executionContext);
+      
+      expect(result.success).toBe(false);
+      expect(result.error).toBeDefined();
+    });
+  });
+
+  describe('WorkflowRunner interface', () => {
+    it('should use run method to start workflows', async () => {
+      mockRunner.run.mockResolvedValue({
+        runId: 'run_interface',
+        status: 'completed',
+        output: { test: true },
+      });
+      
+      const workflowNode = new WorkflowNode(nodeDefinition, mockRunner);
+      await workflowNode.execute(executionContext);
+      
+      expect(mockRunner.run).toHaveBeenCalledTimes(1);
+    });
+
+    it('should use getRun method for status checking', async () => {
+      // This test verifies the interface contract
+      mockRunner.getRun.mockResolvedValue({
+        runId: 'run_status',
+        status: 'completed',
+        output: {},
+      });
+      
+      // The interface supports getRun for status checking
+      const status = await mockRunner.getRun('run_status');
+      expect(status).toBeDefined();
+      expect(status?.runId).toBe('run_status');
+    });
+  });
+});

package/src/env/workflow/nodes/workflow-node.ts

@@ -0,0 +1,311 @@
+import type { Node, NodeDefinition, NodeExecutionContext, NodeExecutionResult } from '../types';
+
+/**
+ * WorkflowRunner interface for running sub-workflows
+ */
+export interface WorkflowRunner {
+  /**
+   * Run a workflow by name
+   * @param workflowName - Name of the workflow to run
+   * @param input - Optional input to pass to the workflow
+   * @returns Promise resolving to the workflow run result
+   */
+  run(workflowName: string, input?: any): Promise<WorkflowRunResult>;
+  
+  /**
+   * Get the status of a workflow run
+   * @param runId - The run ID to check
+   * @returns Promise resolving to the run result or null if not found
+   */
+  getRun(runId: string): Promise<WorkflowRunResult | null>;
+}
+
+/**
+ * Result from a workflow run
+ */
+export interface WorkflowRunResult {
+  /** Unique run ID */
+  runId: string;
+  /** Final status of the run */
+  status: 'completed' | 'failed' | 'stopped';
+  /** Output from the workflow (if completed) */
+  output?: any;
+  /** Error message (if failed or stopped) */
+  error?: string;
+}
+
+/**
+ * WorkflowNode configuration
+ */
+export interface WorkflowNodeConfig {
+  /** Name of the workflow to invoke */
+  workflow_name: string;
+  /** Input to pass to the sub-workflow (supports template strings) */
+  input?: Record<string, unknown>;
+  /** Whether to wait for completion (default: true) */
+  wait_complete?: boolean;
+}
+
+/**
+ * WorkflowNode executes a nested workflow as a node.
+ * 
+ * This allows one workflow to invoke another workflow as a single node,
+ * enabling workflow composition and reusability.
+ * 
+ * Features:
+ * - Pass input to sub-workflow (with template resolution)
+ * - Wait for completion or fire-and-forget
+ * - Handle sub-workflow errors
+ * - Track execution duration
+ */
+export class WorkflowNode implements Node {
+  readonly type = 'workflow';
+  readonly id: string;
+  
+  private readonly config: WorkflowNodeConfig;
+  
+  constructor(
+    definition: NodeDefinition,
+    private workflowRunner: WorkflowRunner
+  ) {
+    this.id = definition.id;
+    this.config = (definition.config ?? {}) as any as WorkflowNodeConfig;
+  }
+  
+  async execute(context: NodeExecutionContext): Promise<NodeExecutionResult> {
+    const startTime = Date.now();
+    
+    try {
+      // 1. Get workflow name from config
+      const workflowName = this.config.workflow_name;
+      
+      if (!workflowName) {
+        throw new Error('workflow_name is required in config. Please specify config.workflow_name in the node definition.');
+      }
+      
+      // 2. Resolve input template (may reference previous outputs)
+      // Support both Map (previousOutputs) and Record (nodeOutputs) formats
+      const previousOutputs = context.previousOutputs ?? this.convertToMap((context.nodeOutputs ?? {}) as any);
+      const resolvedInput = this.resolveInput(
+        this.config.input ?? {},
+        previousOutputs
+      );
+      
+      // 3. Run sub-workflow via workflowRunner
+      const result = await this.workflowRunner.run(workflowName, resolvedInput);
+      
+      // 4. Determine success based on status
+      const success = result.status === 'completed';
+      
+      // 5. Return result
+      return {
+        success,
+        output: result.output,
+        error: success ? undefined : result.error,
+        duration: Date.now() - startTime,
+      };
+    } catch (error) {
+      return {
+        success: false,
+        output: undefined,
+        error: error instanceof Error ? error : new Error(String(error)),
+        duration: Date.now() - startTime,
+      };
+    }
+  }
+  
+  /**
+   * Convert Record<string, NodeExecutionResult> to Map<string, any>
+   * for compatibility with resolvePath that expects Map format.
+   * 
+   * In the Record format, the value is NodeExecutionResult (with output field).
+   * In the Map format, the value is the raw output directly.
+   */
+  private convertToMap(nodeOutputs: Record<string, NodeExecutionResult>): Map<string, any> {
+    const map = new Map<string, any>();
+    for (const [nodeId, result] of Object.entries(nodeOutputs)) {
+      // Store the entire result for access to both output and success
+      map.set(nodeId, result.output);
+    }
+    return map;
+  }
+  
+  /**
+   * Resolve input template references.
+   * Templates are in the format {{nodeId.output.path}}
+   * 
+   * @param input - The input object that may contain template strings
+   * @param previousOutputs - Map of previous node outputs (value is raw output)
+   * @returns The input with template references resolved
+   */
+  private resolveInput(
+    input: Record<string, unknown>,
+    previousOutputs: Map<string, any>
+  ): Record<string, unknown> {
+    const resolved: Record<string, unknown> = {};
+    
+    for (const [key, value] of Object.entries(input)) {
+      resolved[key] = this.resolveValue(value, previousOutputs);
+    }
+    
+    return resolved;
+  }
+  
+  /**
+   * Resolve a value that may contain template references.
+   */
+  private resolveValue(value: unknown, previousOutputs: Map<string, any>): unknown {
+    if (typeof value === 'string') {
+      return this.resolveStringTemplate(value, previousOutputs);
+    }
+    
+    if (Array.isArray(value)) {
+      return value.map(item => this.resolveValue(item, previousOutputs));
+    }
+    
+    if (value !== null && typeof value === 'object') {
+      const resolved: Record<string, unknown> = {};
+      for (const [k, v] of Object.entries(value as Record<string, unknown>)) {
+        resolved[k] = this.resolveValue(v, previousOutputs);
+      }
+      return resolved;
+    }
+    
+    // Return primitive values as-is
+    return value;
+  }
+  
+  /**
+   * Resolve template references in a single string.
+   * Supports format: {{nodeId.output.path}}
+   */
+  private resolveStringTemplate(
+    template: string,
+    previousOutputs: Map<string, any>
+  ): string {
+    // Match template patterns like {{nodeId}} or {{nodeId.output.value}}
+    const templatePattern = /\{\{([^}]+)\}\}/g;
+    
+    return template.replace(templatePattern, (match, path) => {
+      const trimmedPath = path.trim();
+      
+      // Try to resolve the path from previous outputs
+      const value = this.resolvePath(trimmedPath, previousOutputs);
+      
+      if (value !== undefined) {
+        return this.stringifyValue(value, match);
+      }
+      
+      // If not found, return the original template string
+      return match;
+    });
+  }
+  
+  /**
+   * Resolve a dot-notation path from previous outputs.
+   * First segment is the node ID, rest is the path within that node's output.
+   */
+  private resolvePath(
+    path: string,
+    previousOutputs: Map<string, any>
+  ): unknown {
+    const segments = path.split('.');
+    
+    if (segments.length === 0) {
+      return undefined;
+    }
+    
+    const nodeId = segments[0];
+    let nodeOutput = previousOutputs.get(nodeId);
+    
+    if (nodeOutput === undefined) {
+      return undefined;
+    }
+    
+    // Extract from wrapper formats (DecoratorNode: {success, output} and AgentNode: {result, metadata})
+    nodeOutput = this.extractFromWrapper(nodeOutput);
+    
+    // If no path beyond node ID, return the extracted value
+    if (segments.length === 1) {
+      return nodeOutput;
+    }
+    
+    // Navigate the path within the node's output
+    // Skip first segment if it's a wrapper property since extractFromWrapper already extracted it
+    let current: any = nodeOutput;
+    let startIndex = 1;
+    if (segments.length > 1 && 
+        (segments[1] === 'output' || segments[1] === 'result' || segments[1] === 'metadata')) {
+      startIndex = 2;
+    }
+    
+    for (let i = startIndex; i < segments.length; i++) {
+      if (current === null || current === undefined) {
+        return undefined;
+      }
+      current = current[segments[i]];
+    }
+    
+    return current;
+  }
+
+  /**
+   * Extract the actual output value from wrapper formats.
+   * 
+   * Handles:
+   * - AgentNode format: { result, metadata } -> returns result
+   * - DecoratorNode format: { success, output, ... } -> returns output
+   * - Other formats: returns value as-is
+   * 
+   * @param value - The value to extract from
+   * @returns The extracted value
+   */
+  private extractFromWrapper(value: unknown): unknown {
+    if (value === null || value === undefined) {
+      return value;
+    }
+    
+    if (typeof value !== 'object') {
+      return value;
+    }
+    
+    // Check for AgentNode wrapper: { result, metadata }
+    // This is the signature of AgentNode output
+    if ('result' in value && 'metadata' in value) {
+      return (value as { result: unknown }).result;
+    }
+    
+    // Check for DecoratorNode wrapper: { success, output, ... }
+    // This has 'output' but NOT 'result' (that's AgentNode's signature)
+    if ('output' in value) {
+      return (value as { output: unknown }).output;
+    }
+    
+    return value;
+  }
+
+  /**
+   * Convert a value to string for template replacement.
+   * - If value is undefined, return the original template
+   * - If value is a string, return it directly
+   * - If value is null, return 'null'
+   * - If value is an object or array, serialize to JSON
+   * 
+   * @param value - The value to stringify
+   * @param originalTemplate - The original template string (returned if value is undefined)
+   * @returns String representation of the value
+   */
+  private stringifyValue(value: unknown, originalTemplate: string): string {
+    if (value === undefined) {
+      return originalTemplate;
+    }
+    if (value === null) {
+      return 'null';
+    }
+    if (typeof value === 'string') {
+      return value;
+    }
+    // For objects and arrays, serialize to JSON
+    return JSON.stringify(value);
+  }
+}

package/src/env/workflow/service/index.ts

@@ -0,0 +1,27 @@
+/**
+ * Service Index - Session-based Workflow Service
+ * 
+ * After refactoring, RunRepository is removed. Workflow runs are managed via SessionComponent.
+ */
+
+export { WorkflowService } from './workflow-service';
+export type {
+  WorkflowRepository,
+  WorkflowEngine,
+  CreateOptions,
+  ListOptions,
+  WorkflowUpdates,
+  WorkflowEngineFactory,
+  SessionInfo,
+  WorkflowSessionMetadata,
+  AgentSessionRef,
+} from './workflow-service';
+
+export {
+  WorkflowServiceRegistry,
+  getWorkflowService,
+  registerWorkflowService,
+} from './registry';
+
+// Re-export WorkflowDefinition from types
+export type { WorkflowDefinition } from '../types/workflow';