@ai-matrx/records-ui 0.83.0 → 0.84.0

package/CHANGELOG.md

@@ -1,5 +1,66 @@
 # Changelog — @ai-matrx/records-ui
 
+## 0.84.0
+
+**A refusal is said once, with the doors that fit it, and a change a person made is kept or
+said — never dropped.** (lane RECORDS-UI-FIX, VERIFIER-15 H2, H3, M3, M4, M6, M7.)
+
+* **The grid's cell refusal is the one notice.** A rule refusal (`-3` in a column "at least
+  0") used to draw a small red line with *Try again* (which re-sent the refused value) and
+  *Keep theirs* (conflict wording when nobody else wrote). It is now `RefusalNotice` with
+  **Keep editing** — the cell reopens holding `-3`, the reason still beside it — and
+  **Discard**. *Try again* / *Keep theirs* appear only on a real version conflict, beside
+  the other person's value. A tick box's refusal carries Discard.
+* **The record form says a refusal once, with Keep editing / Discard, and before Save.** The
+  mirror's per-column notice is the store's rule, so the store's copy under the form is no
+  longer drawn beside it; the mirror speaks the moment a changed column would be refused.
+  What was typed survives the (slower) version read landing late. An edit sends only the
+  columns the person changed, and a Save with nothing changed writes nothing.
+* **A board's layout or grouping change is kept, or said.** Every view save carried a version
+  read from the view's history, which can stop short of the record, so every Kanban / Group
+  by press was refused `stale_write` and dropped in silence. New `saveViewPatch` (the one
+  view-save door) writes on the version the refusal names; a save still refused is said
+  through `RefusalNotice` with Try again / Discard.
+* **"Someone else wrote first" only when somebody did.** The store's `contested_fields`
+  carries each patched column's current value; when every one is still what the screen
+  started from, the write goes once more on the winning version (the grid cell session, the
+  record form and saved views apply the same rule — internal `updateOnTheWinningVersion`).
+* **The next digest summary is never in the past.** New export `nextSummaryAt(subscription,
+  now)` carries a passed due time forward by whole periods to the first slot after now,
+  keeping the store's alignment (tested at a fixed clock).
+* **Table Settings never cuts a field name to two letters** — the name wraps with a readable
+  minimum and the row wraps its controls first.
+* **On a phone the table's rail is a sheet over the table** — below the design system's
+  breakpoint (`useIsMobile`, 768px) it renders through the canonical `BottomSheet`, the way
+  `Dialog` and `CommandDialog` already do; dragging it down closes the rail.
+* Tests (each shown failing on the prior bytes): `src/a-refused-cell-keeps-what-you-typed`,
+  `src/a-form-refusal-is-said-once-with-its-doors`, `src/a-board-layout-change-is-kept`,
+  `src/the-next-summary-is-never-in-the-past`, `src/a-rail-on-a-phone-is-a-sheet`, and a
+  new clause in `src/TableSettings.hooks.test`.
+
+**Store-side, reported to the chair (not in this package):** `custom.record_update` of an
+unchanged value moves `version` and writes no history row (reproduced on the dev clone), and
+the digest runner computes the next slot from the last summary SENT, so an empty window
+freezes it.
+
+**Consumer action (matrx-frontend):** none required — install picks it up. A host that
+shows a digest's next time outside `SubscriptionsPanel` should use `nextSummaryAt`.
+
+## 0.83.1
+
+**A table shared by link is in the World lane, not Community.** (lane HUB-FIX, chair ruling
+2026-09-23.)
+
+* `visibilityLaneFor` maps `link` → `world` (was `community`). A link anyone can open without
+  signing in reaches the world; Community is for things any SIGNED-IN account can reach, and
+  the store has no signed-in-only link yet, so no stored visibility lands in Community today.
+  `VISIBILITY_LANES` still carries all four — the chip stays.
+* Test: `src/visibility-lanes.test.tsx` updated (link → world) plus a case pinning that no
+  stored visibility maps to Community yet — 5 cases.
+
+**Consumer action:** none. The hub reads `visibilityLaneFor`, so link-shared tables move from
+the Community chip to the World chip on install.
+
 ## 0.83.0
 
 **Four visibility lanes a filter can read, and the store's own choice lists stop sitting

package/dist/index.cjs

@@ -256,6 +256,7 @@ __export(src_exports, {
   mayNotRestoreLine: () => mayNotRestoreLine,
   memberName: () => memberName,
   nextInWords: () => nextInWords,
+  nextSummaryAt: () => nextSummaryAt,
   openingRail: () => openingRail,
   openingView: () => openingView,
   pageViewFromParam: () => pageViewFromParam,
@@ -2388,7 +2389,7 @@ function useGridEditing({ tableId, fields, rows, reload, canWrite, mayWriteRow }
     startedFrom.current = null;
   }, []);
   const writeCellNow = (0, import_react15.useCallback)(
-    async (rowId, key, value, resent = false) => {
+    async (rowId, key, value, base, resent = false) => {
       const id = cellKey(rowId, key);
       setOptimistic((held) => ({ ...held, [id]: value }));
       setSaving((held) => ({ ...held, [id]: true }));
@@ -2435,8 +2436,8 @@ function useGridEditing({ tableId, fields, rows, reload, canWrite, mayWriteRow }
       if (written.error.code === "stale_write") {
         if (conflict) rememberVersion(versions.current, rowId, conflict.current_version);
         else versions.current.delete(rowId);
-        if (conflict && !resent && !Object.prototype.hasOwnProperty.call(conflict.contested_fields, key)) {
-          await writeCellNow(rowId, key, value, true);
+        if (conflict && !resent && sameValue(conflict.contested_fields[key], base)) {
+          await writeCellNow(rowId, key, value, base, true);
           return;
         }
       }
@@ -2453,9 +2454,9 @@ function useGridEditing({ tableId, fields, rows, reload, canWrite, mayWriteRow }
     [client, reload]
   );
   const writeCell = (0, import_react15.useCallback)(
-    (rowId, key, value) => {
+    (rowId, key, value, base) => {
       const behind = queues.current.get(rowId) ?? Promise.resolve();
-      const next = behind.then(() => writeCellNow(rowId, key, value));
+      const next = behind.then(() => writeCellNow(rowId, key, value, base));
       queues.current.set(
         rowId,
         next.then(
@@ -2473,7 +2474,7 @@ function useGridEditing({ tableId, fields, rows, reload, canWrite, mayWriteRow }
       const open = editing;
       if (!open) return;
       const value = typed.current;
-      if (!sameValue(startedFrom.current, value)) void writeCell(open.rowId, open.key, value);
+      if (!sameValue(startedFrom.current, value)) void writeCell(open.rowId, open.key, value, startedFrom.current);
       if (!move) {
         setEditing(null);
         setDraft(null);
@@ -2502,7 +2503,7 @@ function useGridEditing({ tableId, fields, rows, reload, canWrite, mayWriteRow }
     (rowId, key) => {
       const held = refusals[cellKey(rowId, key)];
       if (!held) return;
-      void writeCell(rowId, key, held.attempted);
+      void writeCell(rowId, key, held.attempted, held.conflict?.contested_fields[key]);
     },
     [refusals, writeCell]
   );
@@ -2598,7 +2599,7 @@ function useGridEditing({ tableId, fields, rows, reload, canWrite, mayWriteRow }
     commit,
     setCell: (rowId, key, value) => {
       if (!writable(rowId)) return;
-      void writeCell(rowId, key, value);
+      void writeCell(rowId, key, value, shownValue(rowId, key));
     },
     retry,
     keepTheirs,
@@ -2683,7 +2684,7 @@ function GridCell({
             RefusalNotice,
             {
               error: refusal2.error,
-              className: "py-1.5",
+              className: "py-1.5 text-left",
               onDiscard: () => editing.discard(row.id, field.key)
             }
           ) : null
@@ -2797,7 +2798,7 @@ function CellRefusalNotice({
       RefusalNotice,
       {
         error: refusal2.error,
-        className: "py-1.5",
+        className: "py-1.5 text-left",
         actions: /* @__PURE__ */ (0, import_jsx_runtime10.jsxs)("span", { className: "flex flex-col gap-1", "data-refusal-conflict": "", children: [
           /* @__PURE__ */ (0, import_jsx_runtime10.jsxs)("span", { className: "text-[11px]", children: [
             "Theirs: ",
@@ -2815,7 +2816,7 @@ function CellRefusalNotice({
     RefusalNotice,
     {
       error: refusal2.error,
-      className: "py-1.5",
+      className: "py-1.5 text-left",
       ...typed ? { onKeepEditing: () => editing?.keepEditing(row.id, field.key) } : {},
       onDiscard: () => editing?.discard(row.id, field.key)
     }
@@ -7131,7 +7132,39 @@ var import_design_system22 = require("@ai-matrx/design-system");
 // src/RecordForm.tsx
 var import_react41 = require("react");
 var import_react42 = require("@ai-matrx/records/react");
+var import_core7 = require("@ai-matrx/records/core");
+
+// src/writeOnTheWinningVersion.ts
 var import_core6 = require("@ai-matrx/records/core");
+function sameStoredValue(left, right) {
+  if (left === right) return true;
+  const empty = (v) => v === null || v === void 0 || v === "";
+  if (empty(left) || empty(right)) return empty(left) && empty(right);
+  if (typeof left === "object" || typeof right === "object") {
+    try {
+      return JSON.stringify(left) === JSON.stringify(right);
+    } catch {
+      return false;
+    }
+  }
+  return false;
+}
+async function updateOnTheWinningVersion(client, recordId, patch, expectedVersion, base) {
+  const send = (expected) => client.recordUpdate({
+    record_id: recordId,
+    patch,
+    ...expected === null ? {} : { expectedVersion: expected }
+  });
+  const first = await send(expectedVersion);
+  if (first.ok) return first;
+  const conflict = (0, import_core6.asWriteConflict)(first.error, recordId);
+  if (!conflict) return first;
+  const untouched = base === "always" || Object.keys(patch).every((key) => sameStoredValue(conflict.contested_fields[key], base[key]));
+  if (!untouched) return first;
+  return send(conflict.current_version);
+}
+
+// src/RecordForm.tsx
 var import_design_system20 = require("@ai-matrx/design-system");
 
 // src/systemTable.ts
@@ -7319,15 +7352,38 @@ function RecordForm({
   const fields = (0, import_react42.useFields)(tableId, recordType);
   const existing = (0, import_react42.useRecord)(recordId ?? null);
   const mutation = (0, import_react42.useRecordMutation)();
+  const client = (0, import_react42.useRecordsClient)();
+  const [edit, setEdit] = (0, import_react41.useState)({
+    saving: false,
+    error: null,
+    conflict: null
+  });
+  const said = {
+    saving: mutation.saving || edit.saving,
+    error: recordId ? edit.error : mutation.error,
+    conflict: recordId ? edit.conflict : mutation.conflict,
+    clearConflict: () => {
+      mutation.clearConflict();
+      setEdit((e) => ({ ...e, conflict: null }));
+    }
+  };
   const [draft, setDraft] = (0, import_react41.useState)({});
   const [touched, setTouched] = (0, import_react41.useState)(false);
   const [changed, setChanged] = (0, import_react41.useState)({});
   const [answered, setAnswered] = (0, import_react41.useState)(null);
   const loaded = useRecordVersion(recordId ?? null);
   const loadedVersion = loaded.version;
+  const changedRef = (0, import_react41.useRef)({});
+  changedRef.current = changed;
   (0, import_react41.useEffect)(() => {
     const document3 = existing.data?.document;
-    if (document3) setDraft({ ...document3 });
+    if (!document3) return;
+    const mine = changedRef.current;
+    setDraft((held) => {
+      const next = { ...document3 };
+      for (const key of Object.keys(mine)) next[key] = held[key];
+      return next;
+    });
   }, [existing.data?.record_id, loadedVersion]);
   const document2 = (0, import_react41.useMemo)(() => {
     const out = {};
@@ -7338,15 +7394,15 @@ function RecordForm({
     return out;
   }, [draft]);
   const predicted = (0, import_react41.useMemo)(
-    () => fields.data ? (0, import_core6.predictWriteRefusals)({ fields: fields.data, document: document2, ...recordType ? { recordType } : {} }) : [],
+    () => fields.data ? (0, import_core7.predictWriteRefusals)({ fields: fields.data, document: document2, ...recordType ? { recordType } : {} }) : [],
     [fields.data, document2, recordType]
   );
   if (fields.error) return /* @__PURE__ */ (0, import_jsx_runtime23.jsx)(RefusalNotice, { error: fields.error, className });
   if (existing.error) return /* @__PURE__ */ (0, import_jsx_runtime23.jsx)(RefusalNotice, { error: existing.error, className });
-  const storeSaid = mutation.error && mutation.error !== answered ? mutation.error : null;
+  const storeSaid = said.error && said.error !== answered ? said.error : null;
   const fieldProblems = predicted.filter((p) => p.field_key);
   const problemsShown = (key) => touched || changed[key] ? fieldProblems.filter((p) => p.field_key === key) : [];
-  const storeRefusalIsOnAField = storeSaid !== null && !mutation.conflict && storeSaid.code === "refused_by_rule" && (fields.data ?? []).some((f) => problemsShown(f.key).length > 0);
+  const storeRefusalIsOnAField = storeSaid !== null && !said.conflict && storeSaid.code === "refused_by_rule" && (fields.data ?? []).some((f) => problemsShown(f.key).length > 0);
   const stored = existing.data?.document;
   const focusField = (field) => {
     if (!field) return;
@@ -7377,13 +7433,22 @@ function RecordForm({
     setAnswered(null);
     if (recordId) {
       const version = loadedVersion;
-      const moved = await mutation.update({
-        record_id: recordId,
-        patch: document2,
-        ...version === null ? {} : { expectedVersion: version }
+      if (Object.keys(changed).length === 0) {
+        onSaved?.(recordId);
+        return;
+      }
+      const patch = Object.fromEntries(Object.entries(document2).filter(([key]) => changed[key]));
+      setEdit({ saving: true, error: null, conflict: null });
+      const answered2 = await updateOnTheWinningVersion(client, recordId, patch, version, stored ?? {});
+      setEdit({
+        saving: false,
+        error: answered2.ok ? null : answered2.error,
+        conflict: answered2.ok ? null : (0, import_core7.asWriteConflict)(answered2.error, recordId)
       });
+      const moved = answered2.ok ? answered2.data : null;
       if (moved !== null) {
         loaded.note(moved);
+        setChanged({});
         host.notify?.success("Saved");
         existing.reload();
         onSaved?.(recordId);
@@ -7432,9 +7497,9 @@ function RecordForm({
           RefusalNotice,
           {
             error: storeSaid,
-            ...mutation.conflict ? {
+            ...said.conflict ? {
               actions: /* @__PURE__ */ (0, import_jsx_runtime23.jsxs)("div", { className: "mt-1 space-y-1", children: [
-                Object.entries(mutation.conflict.contested_fields).map(([key, theirs]) => {
+                Object.entries(said.conflict.contested_fields).map(([key, theirs]) => {
                   const column = (fields.data ?? []).find((f) => f.key === key);
                   return /* @__PURE__ */ (0, import_jsx_runtime23.jsxs)("p", { className: "text-[11px]", children: [
                     column ? fieldName(column) : humanize(key),
@@ -7452,9 +7517,9 @@ function RecordForm({
                     size: "sm",
                     variant: "outline",
                     onClick: () => {
-                      if (mutation.conflict) loaded.note(mutation.conflict.current_version);
+                      if (said.conflict) loaded.note(said.conflict.current_version);
                       existing.reload();
-                      mutation.clearConflict();
+                      said.clearConflict();
                       setAnswered(storeSaid);
                     },
                     children: "Take theirs and start again"
@@ -7466,7 +7531,7 @@ function RecordForm({
         ) : null,
         /* @__PURE__ */ (0, import_jsx_runtime23.jsx)(import_design_system20.Separator, {}),
         /* @__PURE__ */ (0, import_jsx_runtime23.jsxs)("div", { className: "flex items-center gap-2", children: [
-          /* @__PURE__ */ (0, import_jsx_runtime23.jsx)(import_design_system20.Button, { type: "submit", size: "sm", disabled: mutation.saving, children: mutation.saving ? "Saving\u2026" : recordId ? "Save" : "Create" }),
+          /* @__PURE__ */ (0, import_jsx_runtime23.jsx)(import_design_system20.Button, { type: "submit", size: "sm", disabled: said.saving, children: said.saving ? "Saving\u2026" : recordId ? "Save" : "Create" }),
           onCancel ? /* @__PURE__ */ (0, import_jsx_runtime23.jsx)(import_design_system20.Button, { type: "button", size: "sm", variant: "ghost", onClick: onCancel, children: "Cancel" }) : null
         ] })
       ]
@@ -7661,7 +7726,6 @@ function computedInPlainWords(row, field) {
 }
 
 // src/views.ts
-var import_core7 = require("@ai-matrx/records/core");
 var VIEW_LAYOUTS = ["grid", "kanban", "calendar", "gallery"];
 var LAYOUT_LABEL = {
   grid: "Grid",
@@ -7786,16 +7850,7 @@ function viewFromRecord(row) {
   };
 }
 async function saveViewPatch(client, viewId, document2, expectedVersion) {
-  const send = (expected) => client.recordUpdate({
-    record_id: viewId,
-    patch: document2,
-    ...expected === null ? {} : { expectedVersion: expected }
-  });
-  const first = await send(expectedVersion);
-  if (first.ok) return first;
-  const conflict = (0, import_core7.asWriteConflict)(first.error, viewId);
-  if (!conflict) return first;
-  return send(conflict.current_version);
+  return updateOnTheWinningVersion(client, viewId, document2, expectedVersion, "always");
 }
 function viewPatchDocument(patch) {
   const out = {};
@@ -16505,8 +16560,7 @@ function visibilityLaneFor(table) {
   if (table.is_kernel) return null;
   if ((table.slug ?? "").startsWith(APP_TABLE_PREFIX) || keptByTheApp(table)) return null;
   if (table.visibility === "personal") return "mine";
-  if (table.visibility === "link") return "community";
-  if (table.visibility === "public") return "world";
+  if (table.visibility === "link" || table.visibility === "public") return "world";
   return "organization";
 }
 function TablesHome({ onOpenTable, className }) {